session-load: default to most-recently-used snapshot
[ardour.git] / gtk2_ardour / video_timeline.cc
index 743bc3216c3fa289936d8d7cefa7977c7c398923..a1dd4bcfbbc89edaa03078c2886e3c7798703ed9 100644 (file)
 #include "ardour/tempo.h"
 
 #include "pbd/file_utils.h"
+#include "pbd/convert.h"
 #include "ardour/session_directory.h"
 
 #include "ardour_ui.h"
 #include "public_editor.h"
 #include "gui_thread.h"
-#include "utils.h"
-#include "canvas_impl.h"
-#include "simpleline.h"
 #include "utils_videotl.h"
 #include "rgb_macros.h"
 #include "video_timeline.h"
+#include "video_tool_paths.h"
 
 #include <gtkmm2ext/utils.h>
 #include <pthread.h>
@@ -44,10 +43,11 @@ using namespace std;
 using namespace ARDOUR;
 using namespace PBD;
 using namespace Timecode;
+using namespace VideoUtils;
 
-VideoTimeLine::VideoTimeLine (PublicEditor *ed, ArdourCanvas::Group *vbg, int initial_height)
+VideoTimeLine::VideoTimeLine (PublicEditor *ed, ArdourCanvas::Container *vbg, int initial_height)
        : editor (ed)
-               , videotl_bar_group(vbg)
+               , videotl_group(vbg)
                , bar_height(initial_height)
 {
        video_start_offset = 0L;
@@ -85,7 +85,7 @@ VideoTimeLine::save_session ()
                return;
        }
 
-       LocaleGuard lg (X_("POSIX"));
+       LocaleGuard lg (X_("C"));
 
        XMLNode* node = new XMLNode(X_("Videomonitor"));
        if (!node) return;
@@ -123,6 +123,7 @@ VideoTimeLine::close_session ()
        video_filename = "";
        video_duration = 0;
        GuiUpdate("set-xjadeo-sensitive-off");
+       GuiUpdate("video-unavailable");
 }
 
 void
@@ -141,8 +142,8 @@ VideoTimeLine::set_session (ARDOUR::Session *s)
        SessionHandlePtr::set_session (s);
        if (!_session) { return ; }
 
-       _session->SaveSession.connect_same_thread (sessionsave, boost::bind (&VideoTimeLine::save_session, this));
-       LocaleGuard lg (X_("POSIX"));
+       _session->SessionSaveUnderway.connect_same_thread (sessionsave, boost::bind (&VideoTimeLine::save_session, this));
+       LocaleGuard lg (X_("C"));
 
        XMLNode* node = _session->extra_xml (X_("Videotimeline"));
 
@@ -150,44 +151,41 @@ VideoTimeLine::set_session (ARDOUR::Session *s)
                return;
        }
 
-       if (node) {
-               ARDOUR_UI::instance()->start_video_server((Gtk::Window*)0, false);
+       ARDOUR_UI::instance()->start_video_server((Gtk::Window*)0, false);
 
-               set_id(*node);
+       set_id(*node);
 
-               const XMLProperty* proph = node->property (X_("Height"));
-               if (proph) {
-                       editor->set_video_timeline_height(atoi(proph->value().c_str()));
-               }
+       const XMLProperty* proph = node->property (X_("Height"));
+       if (proph) {
+               editor->set_video_timeline_height(atoi(proph->value()));
+       }
 #if 0 /* TODO THINK: set FPS first time only ?! */
-               const XMLProperty* propasfps = node->property (X_("AutoFPS"));
-               if (propasfps) {
-                       auto_set_session_fps = atoi(propasfps->value().c_str())?true:false;
-               }
+       const XMLProperty* propasfps = node->property (X_("AutoFPS"));
+       if (propasfps) {
+               auto_set_session_fps = atoi(propasfps->value())?true:false;
+       }
 #endif
 
-               const XMLProperty* propoffset = node->property (X_("VideoOffset"));
-               if (propoffset) {
-                       video_offset = atoll(propoffset->value().c_str());
-                       video_offset_p = video_offset;
-               }
-
-               const XMLProperty* proplock = node->property (X_("VideoOffsetLock"));
-               if (proplock) {
-                       video_offset_lock = atoi(proplock->value().c_str())?true:false;
-               }
+       const XMLProperty* propoffset = node->property (X_("VideoOffset"));
+       if (propoffset) {
+               video_offset = atoll(propoffset->value());
+               video_offset_p = video_offset;
+       }
 
-               const XMLProperty* localfile = node->property (X_("LocalFile"));
-               if (localfile) {
-                       local_file = atoi(localfile->value().c_str())?true:false;
-               }
+       const XMLProperty* proplock = node->property (X_("VideoOffsetLock"));
+       if (proplock) {
+               video_offset_lock = atoi(proplock->value())?true:false;
+       }
 
-               const XMLProperty* propf = node->property (X_("Filename"));
-               video_file_info(propf->value(), local_file);
+       const XMLProperty* localfile = node->property (X_("LocalFile"));
+       if (localfile) {
+               local_file = atoi(localfile->value())?true:false;
        }
 
-       node = _session->extra_xml (X_("Videomonitor"));
-       if (node) {
+       const XMLProperty* propf = node->property (X_("Filename"));
+       video_file_info(propf->value(), local_file);
+
+       if ((node = _session->extra_xml (X_("Videomonitor")))) {
                const XMLProperty* prop = node->property (X_("active"));
                if (prop && prop->value() == "yes" && found_xjadeo() && !video_filename.empty() && local_file) {
                        open_video_monitor();
@@ -226,10 +224,10 @@ VideoTimeLine::save_undo ()
 int
 VideoTimeLine::set_state (const XMLNode& node, int /*version*/)
 {
-       LocaleGuard lg (X_("POSIX"));
+       LocaleGuard lg (X_("C"));
        const XMLProperty* propoffset = node.property (X_("VideoOffset"));
        if (propoffset) {
-               video_offset = atoll(propoffset->value().c_str());
+               video_offset = atoll(propoffset->value());
        }
        ARDOUR_UI::instance()->flush_videotimeline_cache(true);
        return 0;
@@ -239,7 +237,7 @@ XMLNode&
 VideoTimeLine::get_state ()
 {
        XMLNode* node = new XMLNode (X_("Videotimeline"));
-       LocaleGuard lg (X_("POSIX"));
+       LocaleGuard lg (X_("C"));
        node->add_property (X_("VideoOffset"), video_offset_p);
        return *node;
 }
@@ -271,7 +269,7 @@ float
 VideoTimeLine::get_apv()
 {
        // XXX: dup code - TODO use this fn in update_video_timeline()
-       float apv = -1; /* audio frames per video frame; */
+       float apv = -1; /* audio samples per video frame; */
        if (!_session) return apv;
 
        if (_session->config.get_use_video_file_fps()) {
@@ -304,8 +302,8 @@ VideoTimeLine::update_video_timeline()
                if (_session->timecode_frames_per_second() == 0 ) return;
        }
 
-       double frames_per_unit = editor->unit_to_frame(1.0);
-       framepos_t leftmost_frame =  editor->leftmost_position();
+       const double samples_per_pixel = editor->get_current_zoom();
+       const framepos_t leftmost_sample =  editor->leftmost_sample();
 
        /* Outline:
         * 1) calculate how many frames there should be in current zoom (plus 1 page on each side)
@@ -317,12 +315,12 @@ VideoTimeLine::update_video_timeline()
 
        /* video-file and session properties */
        double display_vframe_width; /* unit: pixels ; width of one thumbnail in the timeline */
-       float apv; /* audio frames per video frame; */
+       float apv; /* audio samples per video frame; */
        framepos_t leftmost_video_frame; /* unit: video-frame number ; temporary var -> vtl_start */
 
        /* variables needed to render videotimeline -- what needs to computed first */
-       framepos_t vtl_start; /* unit: audio-frames ; first displayed video-frame */
-       framepos_t vtl_dist;  /* unit: audio-frames ; distance between displayed video-frames */
+       framepos_t vtl_start; /* unit: audio-samples ; first displayed video-frame */
+       framepos_t vtl_dist;  /* unit: audio-samples ; distance between displayed video-frames */
        unsigned int visible_video_frames; /* number of frames that fit on current canvas */
 
        if (_session->config.get_videotimeline_pullup()) {
@@ -338,39 +336,41 @@ VideoTimeLine::update_video_timeline()
 
        display_vframe_width = bar_height * video_aspect_ratio;
 
-       if (apv > frames_per_unit * display_vframe_width) {
+       if (apv > samples_per_pixel * display_vframe_width) {
                /* high-zoom: need space between successive video-frames */
                vtl_dist = rint(apv);
        } else {
                /* continous timeline: skip video-frames */
-               vtl_dist = ceil(display_vframe_width * frames_per_unit / apv) * apv;
+               vtl_dist = ceil(display_vframe_width * samples_per_pixel / apv) * apv;
        }
 
        assert (vtl_dist > 0);
        assert (apv > 0);
 
-#define GOFFSET (video_offset)
+       leftmost_video_frame = floor (floor((long double)(leftmost_sample - video_start_offset - video_offset ) / vtl_dist) * vtl_dist / apv);
 
-       leftmost_video_frame = floor (floor((leftmost_frame - video_start_offset - GOFFSET ) / vtl_dist) * vtl_dist / apv);
-
-       vtl_start = rint (GOFFSET + video_start_offset + leftmost_video_frame * apv);
-       visible_video_frames = 2 + ceil(editor->current_page_frames() / vtl_dist); /* +2 left+right partial frames */
+       vtl_start = rint (video_offset + video_start_offset + leftmost_video_frame * apv);
+       visible_video_frames = 2 + ceil((double)editor->current_page_samples() / vtl_dist); /* +2 left+right partial frames */
 
        /* expand timeline (cache next/prev page images) */
        vtl_start -= visible_video_frames * vtl_dist;
        visible_video_frames *=3;
 
-       if (vtl_start < GOFFSET ) {
-               visible_video_frames += ceil(vtl_start/vtl_dist);
-               vtl_start = GOFFSET;
+       /* don't request frames that are too far to the right */
+       if (vtl_start < video_offset) {
+               visible_video_frames = std::max((double)0.0, (double)visible_video_frames + ceil((double)(vtl_start - video_offset)/vtl_dist));
+               vtl_start = video_offset;
        }
 
-       /* apply video-file constraints */
-       if (vtl_start > video_start_offset + video_duration + GOFFSET ) {
+       /* apply video-file constraints
+        * (first frame in video is at video_start_offset) */
+       if (vtl_start > video_start_offset + video_duration + video_offset ) {
                visible_video_frames = 0;
        }
-       /* TODO optimize: compute rather than iterate */
-       while (visible_video_frames > 0 && vtl_start + (visible_video_frames-1) * vtl_dist >= video_start_offset + video_duration + GOFFSET) {
+       /* trim end.
+        * end = position on timeline (video-offset)  minus  video-file's first frame position
+        * TODO optimize: compute rather than iterate */
+       while (visible_video_frames > 0 && vtl_start + (visible_video_frames-1) * vtl_dist >= video_start_offset + video_duration + video_offset) {
                --visible_video_frames;
        }
 
@@ -381,7 +381,7 @@ VideoTimeLine::update_video_timeline()
 
        while (video_frames.size() < visible_video_frames) {
                VideoImageFrame *frame;
-               frame = new VideoImageFrame(*editor, *videotl_bar_group, display_vframe_width, bar_height, video_server_url, translated_filename());
+               frame = new VideoImageFrame(*editor, *videotl_group, display_vframe_width, bar_height, video_server_url, translated_filename());
                frame->ImgChanged.connect (*this, invalidator (*this), boost::bind (&PublicEditor::queue_visual_videotimeline_update, editor), gui_context());
                video_frames.push_back(frame);
        }
@@ -404,17 +404,17 @@ VideoTimeLine::update_video_timeline()
 
        for (unsigned int vfcount=0; vfcount < visible_video_frames; ++vfcount){
                framepos_t vfpos = vtl_start + vfcount * vtl_dist; /* unit: audio-frames */
-               framepos_t vframeno = rint ( (vfpos - GOFFSET) / apv); /* unit: video-frames */
-               vfpos = (vframeno * apv ) + GOFFSET; /* audio-frame  corresponding to /rounded/ video-frame */
+               framepos_t vframeno = rint ( (vfpos - video_offset) / apv); /* unit: video-frames */
+               vfpos = (vframeno * apv ) + video_offset; /* audio-frame  corresponding to /rounded/ video-frame */
 
                int rightend = -1; /* unit: pixels */
-               if (vfpos + vtl_dist > video_start_offset + video_duration + GOFFSET) {
-                       rightend = display_vframe_width * (video_start_offset + video_duration + GOFFSET - vfpos) / vtl_dist;
+               if (vfpos + vtl_dist > video_start_offset + video_duration + video_offset) {
+                       rightend = display_vframe_width * (video_start_offset + video_duration + video_offset - vfpos) / vtl_dist;
                        //printf("lf(e): %lu\n", vframeno); // XXX
                }
                VideoImageFrame * frame = get_video_frame(vframeno, cut, rightend);
                if (frame) {
-                 frame->set_position(vfpos-leftmost_frame);
+                 frame->set_position(vfpos);
                        outdated_video_frames.remove(frame);
                } else {
                        remaining.push_back(vfcount);
@@ -424,18 +424,18 @@ VideoTimeLine::update_video_timeline()
        for (VideoFrames::iterator i = outdated_video_frames.begin(); i != outdated_video_frames.end(); ++i ) {
                VideoImageFrame *frame = (*i);
                if (remaining.empty()) {
-                 frame->set_position(-2 * vtl_dist); /* move off screen */
+                 frame->set_position(-2 * vtl_dist + leftmost_sample); /* move off screen */
                } else {
                        int vfcount=remaining.front();
                        remaining.pop_front();
                        framepos_t vfpos = vtl_start + vfcount * vtl_dist; /* unit: audio-frames */
-                       framepos_t vframeno = rint ((vfpos - GOFFSET) / apv);  /* unit: video-frames */
+                       framepos_t vframeno = rint ((vfpos - video_offset) / apv);  /* unit: video-frames */
                        int rightend = -1; /* unit: pixels */
-                       if (vfpos + vtl_dist > video_start_offset + video_duration + GOFFSET) {
-                               rightend = display_vframe_width * (video_start_offset + video_duration + GOFFSET - vfpos) / vtl_dist;
+                       if (vfpos + vtl_dist > video_start_offset + video_duration + video_offset) {
+                               rightend = display_vframe_width * (video_start_offset + video_duration + video_offset - vfpos) / vtl_dist;
                                //printf("lf(n): %lu\n", vframeno); // XXX
                        }
-                       frame->set_position(vfpos-leftmost_frame);
+                       frame->set_position(vfpos);
                        frame->set_videoframe(vframeno, rightend);
                }
        }
@@ -456,7 +456,8 @@ VideoTimeLine::video_file_info (std::string filename, bool local)
 {
 
        local_file = local;
-       if (filename.at(0) == G_DIR_SEPARATOR || !local_file) {
+       if (Glib::path_is_absolute(filename) || !local_file)
+       {
                video_filename = filename;
        }  else {
                video_filename = Glib::build_filename (_session->session_directory().video_path(), filename);
@@ -469,6 +470,9 @@ VideoTimeLine::video_file_info (std::string filename, bool local)
                        video_server_url, translated_filename(),
                        video_file_fps, _duration, _start_offset, video_aspect_ratio)) {
                warning << _("Parsing video file info failed. Is the Video Server running? Is the file readable by the Video Server? Does the docroot match? Is it a video file?") << endmsg;
+               video_duration = 0;
+               GuiUpdate("set-xjadeo-sensitive-off");
+               GuiUpdate("video-unavailable");
                return false;
        }
        video_duration = _duration * _session->nominal_frame_rate() / video_file_fps;
@@ -502,14 +506,18 @@ VideoTimeLine::video_file_info (std::string filename, bool local)
                                _session->config.set_timecode_format(timecode_60);
                                break;
                        default:
-                               warning << _("Failed to set session-framerate: ") << video_file_fps << _(" does not have a corresponding option setting in Ardour.") << endmsg; /* TODO: gettext arg */
+                               warning << string_compose (
+                                               _("Failed to set session-framerate: '%1' does not have a corresponding option setting in %2."),
+                                               video_file_fps, PROGRAM_NAME ) << endmsg;
                                break;
                }
                _session->config.set_video_pullup(0); /* TODO only set if set_timecode_format() was successful ?!*/
        }
        if (floor(video_file_fps*100) != floor(_session->timecode_frames_per_second()*100)) {
-               warning << _("Video file's framerate is not equal to Ardour session timecode's framerate: ")
-                       << video_file_fps << _(" vs ") << _session->timecode_frames_per_second() << endmsg;
+               warning << string_compose(
+                               _("Video file's framerate is not equal to %1 session timecode's framerate: '%2' vs '%3'"),
+                                       PROGRAM_NAME, video_file_fps, _session->timecode_frames_per_second())
+                               << endmsg;
        }
        flush_local_cache ();
 
@@ -535,6 +543,7 @@ VideoTimeLine::video_file_info (std::string filename, bool local)
 #endif
        }
        VtlUpdate();
+       GuiUpdate("video-available");
        return true;
 }
 
@@ -547,7 +556,7 @@ VideoTimeLine::check_server ()
                        , video_server_url.c_str()
                        , (video_server_url.length()>0 && video_server_url.at(video_server_url.length()-1) == '/')?"":"/"
                        );
-       char *res=curl_http_get(url, NULL);
+       char *res=a3_curl_http_get(url, NULL);
        if (res) {
                if (strstr(res, "status: ok, online.")) { ok = true; }
                free(res);
@@ -555,6 +564,39 @@ VideoTimeLine::check_server ()
        return ok;
 }
 
+bool
+VideoTimeLine::check_server_docroot ()
+{
+       bool ok = true;
+       char url[1024];
+       std::vector<std::vector<std::string> > lines;
+
+       if (video_server_url.find("/localhost:") == string::npos) {
+               return true;
+       }
+       snprintf(url, sizeof(url), "%s%src?format=csv"
+                       , video_server_url.c_str()
+                       , (video_server_url.length()>0 && video_server_url.at(video_server_url.length()-1) == '/')?"":"/"
+                       );
+       char *res=a3_curl_http_get(url, NULL);
+       if (!res) {
+               return false;
+       }
+
+       ParseCSV(std::string(res), lines);
+       if (   lines.empty()
+                       || lines.at(0).empty()
+                       || lines.at(0).at(0) != video_get_docroot(Config)) {
+               warning << string_compose(
+                               _("Video-server docroot mismatch. %1: '%2', video-server: '%3'. This usually means that the video server was not started by %1 and uses a different document-root."),
+                               PROGRAM_NAME, video_get_docroot(Config), lines.at(0).at(0))
+               << endmsg;
+               ok = false; // TODO allow to override
+       }
+       free(res);
+       return ok;
+}
+
 void
 VideoTimeLine::gui_update(std::string const & t) {
        /* this is to be called via GuiUpdate() only. */
@@ -595,6 +637,10 @@ VideoTimeLine::gui_update(std::string const & t) {
                editor->toggle_xjadeo_viewoption(6, 1);
        } else if (t == "xjadeo-window-letterbox-off") {
                editor->toggle_xjadeo_viewoption(6, 0);
+       } else if (t == "video-available") {
+               editor->set_close_video_sensitive(true);
+       } else if (t == "video-unavailable") {
+               editor->set_close_video_sensitive(false);
        }
 }
 
@@ -610,7 +656,7 @@ VideoTimeLine::set_height (int height) {
 void
 VideoTimeLine::vmon_update () {
        if (vmonitor && vmonitor->is_started()) {
-               vmonitor->set_offset( GOFFSET); // TODO proper re-init xjadeo w/o restart not just offset.
+               vmonitor->set_offset(video_offset); // TODO proper re-init xjadeo w/o restart not just offset.
        }
 }
 
@@ -628,7 +674,7 @@ VideoTimeLine::flush_cache () {
                        , video_server_url.c_str()
                        , (video_server_url.length()>0 && video_server_url.at(video_server_url.length()-1) == '/')?"":"/"
                        );
-       char *res=curl_http_get(url, NULL);
+       char *res=a3_curl_http_get(url, NULL);
        if (res) {
                free (res);
        }
@@ -671,31 +717,61 @@ VideoTimeLine::set_video_server_docroot(std::string vsr) {
 }
 
 /* video-monitor for this timeline */
+void
+VideoTimeLine::xjadeo_readversion (std::string d, size_t /* s */) {
+       xjadeo_version += d;
+}
+
 void
 VideoTimeLine::find_xjadeo () {
-       std::string xjadeo_file_path;
-       if (getenv("XJREMOTE")) {
-               _xjadeo_bin = strdup(getenv("XJREMOTE")); // XXX TODO: free it?!
-       } else if (find_file_in_search_path (SearchPath(Glib::getenv("PATH")), X_("xjremote"), xjadeo_file_path)) {
-               _xjadeo_bin = xjadeo_file_path;
-       }
-       else if (Glib::file_test(X_("/Applications/Jadeo.app/Contents/MacOS/xjremote"), Glib::FILE_TEST_EXISTS|Glib::FILE_TEST_IS_EXECUTABLE)) {
-               _xjadeo_bin = X_("/Applications/Jadeo.app/Contents/MacOS/xjremote");
-       }
-       /* TODO: win32: allow to configure PATH to xjremote */
-       else if (Glib::file_test(X_("C:\\Program Files\\xjadeo\\xjremote.exe"), Glib::FILE_TEST_EXISTS)) {
-               _xjadeo_bin = X_("C:\\Program Files\\xjadeo\\xjremote.exe");
-       }
-       else if (Glib::file_test(X_("C:\\Program Files\\xjadeo\\xjremote.bat"), Glib::FILE_TEST_EXISTS)) {
-               _xjadeo_bin = X_("C:\\Program Files\\xjadeo\\xjremote.bat");
-       }
-       else  {
-               _xjadeo_bin = X_("");
+       if (!ArdourVideoToolPaths::xjadeo_exe(_xjadeo_bin)) {
                warning << _("Video-monitor 'xjadeo' was not found. Please install http://xjadeo.sf.net/ "
                                "(a custom path to xjadeo can be specified by setting the XJREMOTE environment variable. "
-                               "It should point to an application compatible with xjadeo's remote-control interface 'xjremote').")
+                               "It should point to an application compatible with xjadeo's remote-control interface 'xjremote').\n"
+                               "\n"
+                               "see also http://manual.ardour.org/video-timeline/setup/")
                        << endmsg;
        }
+
+       if (found_xjadeo ()) {
+               ARDOUR::SystemExec version_check(_xjadeo_bin, X_("--version"));
+               xjadeo_version = "";
+               version_check.ReadStdout.connect_same_thread (*this, boost::bind (&VideoTimeLine::xjadeo_readversion, this, _1 ,_2));
+               version_check.Terminated.connect_same_thread (*this, boost::bind (&VideoTimeLine::xjadeo_readversion, this, "\n" ,1));
+               if (version_check.start(2)) {
+                       warning << _(
+                                       "Video-monitor 'xjadeo' cannot be launched."
+                                       ) << endmsg;
+                       _xjadeo_bin = X_("");
+                       return;
+               }
+
+               version_check.wait ();
+               int timeout = 300;
+               while (xjadeo_version.empty() && --timeout) {
+                       Glib::usleep(10000);
+               }
+
+               bool v_ok = false;
+               size_t vo = xjadeo_version.find(" version ");
+               if (vo != string::npos) {
+                       int v_major, v_minor, v_micro;
+                       if(sscanf(xjadeo_version.substr(vo + 9, string::npos).c_str(),"%d.%d.%d",
+                                               &v_major, &v_minor, &v_micro) == 3)
+                       {
+                               if (v_major >= 1) v_ok = true;
+                               else if (v_major == 0 && v_minor >= 8) v_ok = true;
+                               else if (v_major == 0 && v_minor >= 7 && v_micro >= 7) v_ok = true;
+                       }
+               }
+               if (!v_ok) {
+                       _xjadeo_bin = X_("");
+                       warning << _(
+                                       "Video-monitor 'xjadeo' is too old. "
+                                       "Please install xjadeo version 0.7.7 or later. http://xjadeo.sf.net/"
+                                       ) << endmsg;
+               }
+       }
 }
 
 void
@@ -704,12 +780,20 @@ VideoTimeLine::open_video_monitor() {
        if (!vmonitor) {
                vmonitor = new VideoMonitor(editor, _xjadeo_bin);
                vmonitor->set_session(_session);
+               vmonitor->set_offset(video_offset);
                vmonitor->Terminated.connect (sigc::mem_fun (*this, &VideoTimeLine::terminated_video_monitor));
                vmonitor->UiState.connect (*this, invalidator (*this), boost::bind (&VideoTimeLine::gui_update, this, _1), gui_context());
        } else if (vmonitor->is_started()) {
                return;
        }
 
+#if 0
+       /* unused for now.
+        * the idea is to selective ignore certain monitor window
+        * states if xjadeo is not running on the same host as ardour.
+        * However with the removal of the video-monitor-startup-dialogue
+        * (git rev 5a4d0fff0) these settings are currently not accessible.
+        */
        int xj_settings_mask = vmonitor->restore_settings_mask();
        if (_session) {
                /* load mask from Session */
@@ -717,12 +801,13 @@ VideoTimeLine::open_video_monitor() {
                if (node) {
                        const XMLProperty* prop = node->property (X_("mask"));
                        if (prop) {
-                               xj_settings_mask = atoi(prop->value().c_str());
+                               xj_settings_mask = atoi(prop->value());
                        }
                }
        }
 
        vmonitor->restore_settings_mask(xj_settings_mask);
+#endif
 
        if (!vmonitor->start()) {
                warning << "launching xjadeo failed.." << endmsg;
@@ -764,10 +849,11 @@ VideoTimeLine::control_video_monitor(int what, int param) {
 void
 VideoTimeLine::terminated_video_monitor () {
        if (vmonitor) {
+               vmonitor->save_session();
                delete vmonitor;
        }
-       GuiUpdate("set-xjadeo-active-off");
        vmonitor=0;
+       GuiUpdate("set-xjadeo-active-off");
        if (reopen_vmonitor) {
                reopen_vmonitor=false;
                open_video_monitor();
@@ -778,26 +864,11 @@ VideoTimeLine::terminated_video_monitor () {
        }
 }
 
-/*
-void
-VideoTimeLine::clear_video_monitor_session_state ()
-{
-       if (vmonitor) {
-               vmonitor->clear_session_state();
-       } else {
-         if (!_session) { return; }
-               XMLNode* node = new XMLNode(X_("XJSettings"));
-               _session->add_extra_xml (*node);
-               _session->set_dirty ();
-       }
-}
-*/
-
 void
 VideoTimeLine::manual_seek_video_monitor (framepos_t pos)
 {
        if (!vmonitor) { return; }
        if (!vmonitor->is_started()) { return; }
        if (!vmonitor->synced_by_manual_seeks()) { return; }
-       vmonitor->manual_seek(pos, false, GOFFSET); // XXX -> set offset in xjadeo
+       vmonitor->manual_seek(pos, false, video_offset); // XXX -> set offset in xjadeo
 }