Fix crash on save of MIDI data.
[ardour.git] / libs / ardour / midi_ring_buffer.cc
index 6486889f44c9d35ba98f7f032382b162392c90e9..f886eb84439dc9de3bb7c8581c7e9ef439525d36 100644 (file)
@@ -24,36 +24,34 @@ using namespace std;
 
 namespace ARDOUR {
 
-/** Read a block of MIDI events from buffer.
+/** Read a block of MIDI events from buffer into a MidiBuffer.
  *
  * Timestamps of events returned are relative to start (i.e. event with stamp 0
  * occurred at start), with offset added.
  */
+template<typename T>
 size_t
-MidiRingBuffer::read(MidiBuffer& dst, nframes_t start, nframes_t end, nframes_t offset)
+MidiRingBuffer<T>::read(MidiBuffer& dst, nframes_t start, nframes_t end, nframes_t offset)
 {
-       if (read_space() == 0) {
-               //cerr << "MRB: NO READ SPACE" << endl;
+       if (this->read_space() == 0) {
                return 0;
        }
 
-       Evoral::EventTime ev_time;
+       T                 ev_time;
        Evoral::EventType ev_type;
        uint32_t          ev_size;
 
        size_t count = 0;
 
-       //cerr << "MRB read " << start << " .. " << end << " + " << offset << endl;
+       while (this->read_space() >= sizeof(T) + sizeof(Evoral::EventType) + sizeof(uint32_t)) {
 
-       while (read_space() >= sizeof(Evoral::EventTime) + sizeof(Evoral::EventType) + sizeof(uint32_t)) {
-
-               full_peek(sizeof(Evoral::EventTime), (uint8_t*)&ev_time);
+               this->full_peek(sizeof(T), (uint8_t*)&ev_time);
 
                if (ev_time > end) {
-                       //cerr << "MRB: PAST END (" << ev_time << " : " << end << ")" << endl;
+                       // cerr << "MRB event @ " << ev_time << " past end @ " << end << endl;
                        break;
                } else if (ev_time < start) {
-                       //cerr << "MRB (start " << start << ") - Skipping event at (too early) time " << ev_time << endl;
+                       // cerr << "MRB event @ " << ev_time << " before start @ " << start << endl;
                        break;
                }
 
@@ -63,65 +61,145 @@ MidiRingBuffer::read(MidiBuffer& dst, nframes_t start, nframes_t end, nframes_t
                        continue;
                }
 
-               // This event marks a loop happening. this means that
-               // the next events timestamp will be non-monotonic.
+               // This event marks a loop end (i.e. the next event's timestamp will be non-monotonic)
                if (ev_type == LoopEventType) {
-                       ev_time -= start;
-                       ev_time += offset;
-                       Evoral::MIDIEvent loopevent(LoopEventType, ev_time); 
-                       dst.push_back(loopevent);
-                       
-                       // We can safely return, without reading the data, because
-                       // a LoopEvent does not have data.
+                       /*ev_time -= start;
+                         ev_time += offset;*/
+                       // cerr << "MRB loop boundary @ " << ev_time << endl;
+
+                       // Return without reading data or writing to buffer (loop events have no data)
+                       // FIXME: This is not correct, loses events after the loop this cycle
                        return count + 1;
                }
 
                uint8_t status;
-               success = full_peek(sizeof(uint8_t), &status);
+               success = this->full_peek(sizeof(uint8_t), &status);
                assert(success); // If this failed, buffer is corrupt, all hope is lost
 
                // Ignore event if it doesn't match channel filter
                if (is_channel_event(status) && get_channel_mode() == FilterChannels) {
                        const uint8_t channel = status & 0x0F;
-                       if ( !(get_channel_mask() & (1L << channel)) ) {
-                               //cerr << "MRB skipping event due to channel mask" << endl;
-                               skip(ev_size); // Advance read pointer to next event
+                       if (!(get_channel_mask() & (1L << channel))) {
+                               // cerr << "MRB skipping event due to channel mask" << endl;
+                               this->skip(ev_size); // Advance read pointer to next event
                                continue;
                        }
                }
 
-               //cerr << "MRB " << this << " - Reading event, time = "
-               //      << ev_time << " - " << start << " => " << ev_time - start
-               //      << ", size = " << ev_size << endl;
-
                assert(ev_time >= start);
                ev_time -= start;
                ev_time += offset;
 
+               // write the timestamp to address (write_loc - 1)
                uint8_t* write_loc = dst.reserve(ev_time, ev_size);
                if (write_loc == NULL) {
-                       //cerr << "MRB: Unable to reserve space in buffer, event skipped";
+                       // cerr << "MRB: Unable to reserve space in buffer, event skipped";
                        continue;
                }
 
-               success = Evoral::EventRingBuffer::full_read(ev_size, write_loc);
+               // write MIDI buffer contents
+               success = Evoral::EventRingBuffer<T>::full_read(ev_size, write_loc);
+
+#if 0
+               cerr << "wrote MidiEvent to Buffer: " << hex;
+               for (size_t i=0; i < ev_size; ++i) {
+                       cerr << (int) write_loc[i] << ' ';
+               }
+               cerr << dec << endl;
+#endif
 
                if (success) {
                        if (is_channel_event(status) && get_channel_mode() == ForceChannel) {
                                write_loc[0] = (write_loc[0] & 0xF0) | (get_channel_mask() & 0x0F);
                        }
                        ++count;
-                       //cerr << "MRB - read event at time " << ev_time << endl;
                } else {
-                       //cerr << "WARNING: error reading event contents from MIDI ring" << endl;
+                       cerr << "WARNING: error reading event contents from MIDI ring" << endl;
                }
        }
-       
-       //cerr << "MTB read space: " << read_space() << endl;
 
        return count;
 }
+template<typename T>
+void
+MidiRingBuffer<T>::dump(ostream& str)
+{
+       size_t rspace;
+
+       if ((rspace = this->read_space()) == 0) {
+               str << "MRB::dump: empty\n";
+               return;
+       }
+
+       T                 ev_time;
+       Evoral::EventType ev_type;
+       uint32_t          ev_size;
+       size_t read_ptr = g_atomic_int_get (&this->_read_ptr);
+
+       str << "Dump @ " << read_ptr << endl;
+
+       while (1) {
+               uint8_t* wp;
+               uint8_t* data;
+               size_t write_ptr;
+
+#define space(r,w) ((w > r) ? (w - r) : ((w - r + this->_size) % this->_size))
+
+               write_ptr  = g_atomic_int_get (&this->_write_ptr);
+               if (space (read_ptr, write_ptr) < sizeof (T)) {
+                       break;
+               }
+
+               wp = &this->_buf[read_ptr];
+               memcpy (&ev_time, wp, sizeof (T));
+               read_ptr = (read_ptr + sizeof (T)) % this->_size;
+               str << "time " << ev_time;
+
+               write_ptr  = g_atomic_int_get (&this->_write_ptr);
+               if (space (read_ptr, write_ptr) < sizeof (ev_type)) {
+                       break;
+               }
+
+               wp = &this->_buf[read_ptr];
+               memcpy (&ev_type, wp, sizeof (ev_type));
+               read_ptr = (read_ptr + sizeof (ev_type)) % this->_size;
+               str << " type " << ev_type;
+
+               write_ptr  = g_atomic_int_get (&this->_write_ptr);
+               if (space (read_ptr, write_ptr) < sizeof (ev_size)) {
+                       str << "!OUT!\n";
+                       break;
+               }
+
+               wp = &this->_buf[read_ptr];
+               memcpy (&ev_size, wp, sizeof (ev_size));
+               read_ptr = (read_ptr + sizeof (ev_size)) % this->_size;
+               str << " size " << ev_size;
+
+               write_ptr  = g_atomic_int_get (&this->_write_ptr);
+               if (space (read_ptr, write_ptr) < ev_size) {
+                       str << "!OUT!\n";
+                       break;
+               }
+
+               data = new uint8_t[ev_size];
+
+               wp = &this->_buf[read_ptr];
+               memcpy (data, wp, ev_size);
+               read_ptr = (read_ptr + ev_size) % this->_size;
+
+               for (uint32_t i = 0; i != ev_size; ++i) {
+                       str << ' ' << hex << (int) data[i] << dec;
+               }
+
+               str << endl;
+
+               delete [] data;
+       }
+}
+
 
+template class MidiRingBuffer<nframes_t>;
 
 } // namespace ARDOUR