Fix a potential memory-corruption

[ardour.git] / libs / ardour / phase_control.cc

diff --git a/libs/ardour/phase_control.cc b/libs/ardour/phase_control.cc
index 96d0d375b6b7aca65854affa2fa1c2a661c56139..a42888f103412c8150e84b779586efec1171ad08 100644 (file)
--- a/libs/ardour/phase_control.cc
+++ b/libs/ardour/phase_control.cc
@@ -32,12 +32,12 @@ PhaseControl::PhaseControl (Session& session, std::string const & name)
 {
 }
 
-bool
+void
 PhaseControl::actually_set_value (double val, Controllable::GroupControlDisposition gcd)
 {
        _phase_invert = boost::dynamic_bitset<> (std::numeric_limits<double>::digits, (unsigned long) val);
 
-       return AutomationControl::actually_set_value (val, gcd);
+       AutomationControl::actually_set_value (val, gcd);
 }
 
 /** @param c Audio channel index.
@@ -48,8 +48,7 @@ PhaseControl::set_phase_invert (uint32_t c, bool yn)
 {
        if (_phase_invert[c] != yn) {
                _phase_invert[c] = yn;
-               (void) AutomationControl::actually_set_value (_phase_invert.to_ulong(), Controllable::NoGroup);
-               _session.set_dirty ();
+               AutomationControl::actually_set_value (_phase_invert.to_ulong(), Controllable::NoGroup);
        }
 }
 
@@ -58,9 +57,7 @@ PhaseControl::set_phase_invert (boost::dynamic_bitset<> p)
 {
        if (_phase_invert != p) {
                _phase_invert = p;
-               (void) AutomationControl::actually_set_value (_phase_invert.to_ulong(), Controllable::NoGroup);
-               Changed (true, Controllable::NoGroup); /* EMIT SIGNAL */
-               _session.set_dirty ();
+               AutomationControl::actually_set_value (_phase_invert.to_ulong(), Controllable::NoGroup);
        }
 }
 
@@ -77,7 +74,7 @@ PhaseControl::get_state ()
 
        string p;
        boost::to_string (_phase_invert, p);
-       node.add_property("phase-invert", p);
+       node.set_property ("phase-invert", p);
 
        return node;
 }
@@ -87,10 +84,9 @@ PhaseControl::set_state (XMLNode const & node, int version)
 {
        AutomationControl::set_state (node, version);
 
-       const XMLProperty* prop;
-
-       if ((prop = node.property (X_("phase-invert"))) != 0) {
-               set_phase_invert (boost::dynamic_bitset<> (prop->value ()));
+       std::string str;
+       if (node.get_property (X_("phase-invert"), str)) {
+               set_phase_invert (boost::dynamic_bitset<> (str));
        }
 
        return 0;