forward port automation handling changes from 2.x, upto and including about rev 6981...
[ardour.git] / libs / evoral / src / ControlList.cpp
index b54e2373f89298317f965f5c5ebd3aeb98bee682..b49b294288e5e8473dd0024ecb86e09f1c409d7c 100644 (file)
@@ -1,16 +1,16 @@
 /* This file is part of Evoral.
  * Copyright (C) 2008 Dave Robillard <http://drobilla.net>
  * Copyright (C) 2000-2008 Paul Davis
- * 
+ *
  * Evoral is free software; you can redistribute it and/or modify it under the
  * terms of the GNU General Public License as published by the Free Software
  * Foundation; either version 2 of the License, or (at your option) any later
  * version.
- * 
+ *
  * Evoral is distributed in the hope that it will be useful, but WITHOUT ANY
  * WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
  * FOR A PARTICULAR PURPOSE.  See the GNU General Public License for details.
- * 
+ *
  * You should have received a copy of the GNU General Public License along
  * with this program; if not, write to the Free Software Foundation, Inc.,
  * 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
@@ -21,6 +21,7 @@
 #include <utility>
 #include <iostream>
 #include "evoral/ControlList.hpp"
+#include "evoral/Curve.hpp"
 
 using namespace std;
 
@@ -36,25 +37,25 @@ inline bool event_time_less_than (ControlEvent* a, ControlEvent* b)
 ControlList::ControlList (const Parameter& id)
        : _parameter(id)
        , _interpolation(Linear)
-       , _curve(new Curve(*this))
-{      
+       , _curve(0)
+{
        _frozen = 0;
        _changed_when_thawed = false;
        _min_yval = id.min();
        _max_yval = id.max();
-       _max_xval = 0; // means "no limit" 
-       _rt_insertion_point = _events.end();
+       _max_xval = 0; // means "no limit"
+       _default_value = 0;
        _lookup_cache.left = -1;
        _lookup_cache.range.first = _events.end();
        _search_cache.left = -1;
-       _search_cache.range.first = _events.end();
+       _search_cache.first = _events.end();
        _sort_pending = false;
 }
 
 ControlList::ControlList (const ControlList& other)
        : _parameter(other._parameter)
        , _interpolation(Linear)
-       , _curve(new Curve(*this))
+       , _curve(0)
 {
        _frozen = 0;
        _changed_when_thawed = false;
@@ -62,9 +63,8 @@ ControlList::ControlList (const ControlList& other)
        _max_yval = other._max_yval;
        _max_xval = other._max_xval;
        _default_value = other._default_value;
-       _rt_insertion_point = _events.end();
        _lookup_cache.range.first = _events.end();
-       _search_cache.range.first = _events.end();
+       _search_cache.first = _events.end();
        _sort_pending = false;
 
        for (const_iterator i = other._events.begin(); i != other._events.end(); ++i) {
@@ -77,7 +77,7 @@ ControlList::ControlList (const ControlList& other)
 ControlList::ControlList (const ControlList& other, double start, double end)
        : _parameter(other._parameter)
        , _interpolation(Linear)
-       , _curve(new Curve(*this))
+       , _curve(0)
 {
        _frozen = 0;
        _changed_when_thawed = false;
@@ -85,9 +85,8 @@ ControlList::ControlList (const ControlList& other, double start, double end)
        _max_yval = other._max_yval;
        _max_xval = other._max_xval;
        _default_value = other._default_value;
-       _rt_insertion_point = _events.end();
        _lookup_cache.range.first = _events.end();
-       _search_cache.range.first = _events.end();
+       _search_cache.first = _events.end();
        _sort_pending = false;
 
        /* now grab the relevant points, and shift them back if necessary */
@@ -108,6 +107,15 @@ ControlList::~ControlList()
        for (EventList::iterator x = _events.begin(); x != _events.end(); ++x) {
                delete (*x);
        }
+        
+       for (list<NascentInfo*>::iterator n = nascent.begin(); n != nascent.end(); ++n) {
+                for (EventList::iterator x = (*n)->events.begin(); x != (*n)->events.end(); ++x) {
+                        delete *x;
+                }
+               delete (*n);
+       }
+
+       delete _curve;
 }
 
 boost::shared_ptr<ControlList>
@@ -126,18 +134,18 @@ ControlList&
 ControlList::operator= (const ControlList& other)
 {
        if (this != &other) {
-               
+
                _events.clear ();
-               
+
                for (const_iterator i = other._events.begin(); i != other._events.end(); ++i) {
                        _events.push_back (new ControlEvent (**i));
                }
-               
+
                _min_yval = other._min_yval;
                _max_yval = other._max_yval;
                _max_xval = other._max_xval;
                _default_value = other._default_value;
-               
+
                mark_dirty ();
                maybe_signal_changed ();
        }
@@ -145,13 +153,27 @@ ControlList::operator= (const ControlList& other)
        return *this;
 }
 
+void
+ControlList::create_curve()
+{
+       _curve = new Curve(*this);
+}
+
+void
+ControlList::destroy_curve()
+{
+       delete _curve;
+       _curve = NULL;
+}
+
 void
 ControlList::maybe_signal_changed ()
 {
        mark_dirty ();
-       
-       if (_frozen)
+
+       if (_frozen) {
                _changed_when_thawed = true;
+       }
 }
 
 void
@@ -185,7 +207,8 @@ ControlList::extend_to (double when)
        return true;
 }
 
-void ControlList::_x_scale (double factor)
+void 
+ControlList::_x_scale (double factor)
 {
        for (iterator i = _events.begin(); i != _events.end(); ++i) {
                (*i)->when = floor ((*i)->when * factor);
@@ -195,90 +218,165 @@ void ControlList::_x_scale (double factor)
 }
 
 void
-ControlList::reposition_for_rt_add (double when)
+ControlList::write_pass_finished (double when)
 {
-       _rt_insertion_point = _events.end();
+        merge_nascent (when);
 }
 
 void
-ControlList::rt_add (double when, double value)
+ControlList::merge_nascent (double when)
 {
-       //cerr << "RT: alist " << this << " add " << value << " @ " << when << endl;
-
-       {
-               Glib::Mutex::Lock lm (_lock);
-
-               iterator where;
-               ControlEvent cp (when, 0.0);
-               bool done = false;
-
-               if ((_rt_insertion_point != _events.end()) && ((*_rt_insertion_point)->when < when) ) {
-
-                       /* we have a previous insertion point, so we should delete
-                          everything between it and the position where we are going
-                          to insert this point.
-                       */
-
-                       iterator after = _rt_insertion_point;
-
-                       if (++after != _events.end()) {
-                               iterator far = after;
-
-                               while (far != _events.end()) {
-                                       if ((*far)->when > when) {
-                                               break;
-                                       }
-                                       ++far;
-                               }
-
-                               if (_new_value) {
-                                       where = far;
-                                       _rt_insertion_point = where;
-
-                                       if ((*where)->when == when) {
-                                               (*where)->value = value;
-                                               done = true;
-                                       }
-                               } else {
-                                       where = _events.erase (after, far);
-                               }
-
-                       } else {
-
-                               where = after;
+        {
+                Glib::Mutex::Lock lm (_lock);
+
+                if (nascent.empty()) {
+                        return;
+                }
+
+                for (list<NascentInfo*>::iterator n = nascent.begin(); n != nascent.end(); ++n) {
+
+                        NascentInfo* ninfo = *n;
+                        EventList& nascent_events (ninfo->events);
+                        bool need_adjacent_start_clamp;
+                        bool need_adjacent_end_clamp;
+
+                        if (nascent_events.empty()) {
+                                delete ninfo;
+                                continue;
+                        }
+                        
+                        if (ninfo->start_time < 0.0) {
+                                ninfo->start_time = nascent_events.front()->when;
+                        }
+                        
+                        if (ninfo->end_time < 0.0) {
+                                ninfo->end_time = when;
+                        }
+
+                        bool preexisting = !_events.empty();
+
+                        if (!preexisting) {
+                                
+                                _events = nascent_events;
+                                
+                        } else if (ninfo->end_time < _events.front()->when) {
+                                
+                                /* all points in nascent are before the first existing point */
+
+                                _events.insert (_events.begin(), nascent_events.begin(), nascent_events.end());
+                                
+                        } else if (ninfo->start_time > _events.back()->when) {
+                                
+                                /* all points in nascent are after the last existing point */
+
+                                _events.insert (_events.end(), nascent_events.begin(), nascent_events.end());
+                                
+                        } else {
+                                
+                                /* find the range that overaps with nascent events,
+                                   and insert the contents of nascent events.
+                                */
+                                
+                                iterator i;
+                                iterator range_begin = _events.end();
+                                iterator range_end = _events.end();
+                                double end_value = unlocked_eval (ninfo->end_time);
+                                double start_value = unlocked_eval (ninfo->start_time - 1);
+
+                                need_adjacent_end_clamp = true;
+                                need_adjacent_start_clamp = true;
+
+                                for (i = _events.begin(); i != _events.end(); ++i) {
+
+                                        if ((*i)->when == ninfo->start_time) {
+                                                /* existing point at same time, remove it
+                                                   and the consider the next point instead.
+                                                */
+                                                i = _events.erase (i);
+
+                                                if (i == _events.end()) {
+                                                        break;
+                                                }
+
+                                                if (range_begin == _events.end()) {
+                                                        range_begin = i;
+                                                        need_adjacent_start_clamp = false;
+                                                } else {
+                                                        need_adjacent_end_clamp = false;
+                                                }
+                                                
+                                                if ((*i)->when > ninfo->end_time) {
+                                                        range_end = i;
+                                                        break;
+                                                }   
+
+                                        } else if ((*i)->when > ninfo->start_time) {
+                                                
+                                                if (range_begin == _events.end()) {
+                                                        range_begin = i;
+                                                }
+                                                
+                                                if ((*i)->when > ninfo->end_time) {
+                                                        range_end = i;
+                                                        break;
+                                                }
+                                        }
+                                }
+                                
+                                assert (range_begin != _events.end());
+                                
+                                if (range_begin != _events.begin()) {
+                                        /* clamp point before */
+                                        if (need_adjacent_start_clamp) {
+                                                _events.insert (range_begin, new ControlEvent (ninfo->start_time, start_value));
+                                        }
+                                }
+
+                                _events.insert (range_begin, nascent_events.begin(), nascent_events.end());
+
+                                if (range_end != _events.end()) {
+                                        /* clamp point after */
+                                        if (need_adjacent_end_clamp) {
+                                                _events.insert (range_begin, new ControlEvent (ninfo->end_time, end_value));
+                                        }
+                                }
+                                
+                                _events.erase (range_begin, range_end);
+                        }
+
+                        delete ninfo;
+                }
+
+                nascent.clear ();
+
+                if (writing()) {
+                        nascent.push_back (new NascentInfo (false));
+                }
+        }
+
+        maybe_signal_changed ();
+}
 
-                       }
-                       
-                       iterator previous = _rt_insertion_point;
-                       --previous;
-                       
-                       if (_rt_insertion_point != _events.begin() && (*_rt_insertion_point)->value == value && (*previous)->value == value) {
-                               (*_rt_insertion_point)->when = when;
-                               done = true;
-                               
-                       }
-                       
-               } else {
+void
+ControlList::rt_add (double when, double value)
+{
+        // this is for automation recording 
+        
+        if (touch_enabled() && !touching()) {
+                return;
+        }
 
-                       where = lower_bound (_events.begin(), _events.end(), &cp, time_comparator);
+       //cerr << "RT: alist " << this << " add " << value << " @ " << when << endl;
 
-                       if (where != _events.end()) {
-                               if ((*where)->when == when) {
-                                       (*where)->value = value;
-                                       done = true;
-                               }
-                       }
-               }
+        Glib::Mutex::Lock lm (_lock, Glib::TRY_LOCK);
 
-               if (!done) {
-                       _rt_insertion_point = _events.insert (where, new ControlEvent (when, value));
-               }
-               
-               _new_value = false;
-               mark_dirty ();
-       }
-
-       maybe_signal_changed ();
+        if (lm.locked()) {
+                assert (!nascent.empty());
+                if (!nascent.back()->events.empty()) {
+                        assert (when > nascent.back()->events.back()->when);
+                }
+                nascent.back()->events.push_back (new ControlEvent (when, value));
+        }
 }
 
 void
@@ -308,7 +406,7 @@ ControlList::add (double when, double value)
                                (*insertion_point)->value = value;
                                insert = false;
                                break;
-                       } 
+                       }
 
                        if ((*insertion_point)->when >= when) {
                                break;
@@ -316,11 +414,10 @@ ControlList::add (double when, double value)
                }
 
                if (insert) {
-                       
+
                        _events.insert (insertion_point, new ControlEvent (when, value));
-                       reposition_for_rt_add (0);
 
-               } 
+               }
 
                mark_dirty ();
        }
@@ -334,7 +431,6 @@ ControlList::erase (iterator i)
        {
                Glib::Mutex::Lock lm (_lock);
                _events.erase (i);
-               reposition_for_rt_add (0);
                mark_dirty ();
        }
        maybe_signal_changed ();
@@ -346,11 +442,10 @@ ControlList::erase (iterator start, iterator end)
        {
                Glib::Mutex::Lock lm (_lock);
                _events.erase (start, end);
-               reposition_for_rt_add (0);
                mark_dirty ();
        }
        maybe_signal_changed ();
-}      
+}
 
 void
 ControlList::reset_range (double start, double endt)
@@ -358,11 +453,11 @@ ControlList::reset_range (double start, double endt)
        bool reset = false;
 
        {
-        Glib::Mutex::Lock lm (_lock);
+               Glib::Mutex::Lock lm (_lock);
                ControlEvent cp (start, 0.0f);
                iterator s;
                iterator e;
-               
+
                if ((s = lower_bound (_events.begin(), _events.end(), &cp, time_comparator)) != _events.end()) {
 
                        cp.when = endt;
@@ -371,7 +466,7 @@ ControlList::reset_range (double start, double endt)
                        for (iterator i = s; i != e; ++i) {
                                (*i)->value = _default_value;
                        }
-                       
+
                        reset = true;
 
                        mark_dirty ();
@@ -393,10 +488,9 @@ ControlList::erase_range (double start, double endt)
                erased = erase_range_internal (start, endt, _events);
 
                if (erased) {
-                       reposition_for_rt_add (0);
                        mark_dirty ();
                }
-               
+
        }
 
        if (erased) {
@@ -431,7 +525,7 @@ ControlList::slide (iterator before, double distance)
                if (before == _events.end()) {
                        return;
                }
-               
+
                while (before != _events.end()) {
                        (*before)->when += distance;
                        ++before;
@@ -483,7 +577,7 @@ ControlList::control_points_adjacent (double xval)
        ret.second = _events.end();
 
        for (i = lower_bound (_events.begin(), _events.end(), &cp, time_comparator); i != _events.end(); ++i) {
-               
+
                if (ret.first == _events.end()) {
                        if ((*i)->when >= xval) {
                                if (i != _events.begin()) {
@@ -493,8 +587,8 @@ ControlList::control_points_adjacent (double xval)
                                        return ret;
                                }
                        }
-               } 
-               
+               }
+
                if ((*i)->when > xval) {
                        ret.second = i;
                        break;
@@ -535,13 +629,17 @@ ControlList::thaw ()
        }
 }
 
-void 
+void
 ControlList::mark_dirty () const
 {
        _lookup_cache.left = -1;
        _search_cache.left = -1;
-       if (_curve)
+
+       if (_curve) {
                _curve->mark_dirty();
+       }
+
+       Dirty (); /* EMIT SIGNAL */
 }
 
 void
@@ -562,7 +660,7 @@ ControlList::truncate_end (double last_coordinate)
                }
 
                if (last_coordinate > _events.back()->when) {
-                       
+
                        /* extending end:
                        */
 
@@ -590,7 +688,7 @@ ControlList::truncate_end (double last_coordinate)
                                iterator penultimate = _events.end();
                                --penultimate; /* points at last point */
                                --penultimate; /* points at the penultimate point */
-                               
+
                                if (_events.back()->value == (*penultimate)->value) {
                                        _events.back()->when = last_coordinate;
                                } else {
@@ -605,13 +703,13 @@ ControlList::truncate_end (double last_coordinate)
                        last_val = unlocked_eval (last_coordinate);
                        last_val = max ((double) _min_yval, last_val);
                        last_val = min ((double) _max_yval, last_val);
-                       
+
                        i = _events.rbegin();
-                       
+
                        /* make i point to the last control point */
-                       
+
                        ++i;
-                       
+
                        /* now go backwards, removing control points that are
                           beyond the new last coordinate.
                        */
@@ -619,28 +717,27 @@ ControlList::truncate_end (double last_coordinate)
                        // FIXME: SLOW! (size() == O(n))
 
                        uint32_t sz = _events.size();
-                       
+
                        while (i != _events.rend() && sz > 2) {
                                ControlList::reverse_iterator tmp;
-                               
+
                                tmp = i;
                                ++tmp;
-                               
+
                                if ((*i)->when < last_coordinate) {
                                        break;
                                }
-                               
+
                                _events.erase (i.base());
                                --sz;
 
                                i = tmp;
                        }
-                       
+
                        _events.back()->when = last_coordinate;
                        _events.back()->value = last_val;
                }
 
-               reposition_for_rt_add (0);
                mark_dirty();
        }
 
@@ -657,14 +754,14 @@ ControlList::truncate_start (double overall_length)
                double first_legal_coordinate;
 
                assert(!_events.empty());
-               
+
                if (overall_length == _events.back()->when) {
                        /* no change in overall length */
                        return;
                }
-               
+
                if (overall_length > _events.back()->when) {
-                       
+
                        /* growing at front: duplicate first point. shift all others */
 
                        double shift = overall_length - _events.back()->when;
@@ -688,7 +785,7 @@ ControlList::truncate_start (double overall_length)
 
                                iterator second = _events.begin();
                                ++second; /* points at the second point */
-                               
+
                                if (_events.front()->value == (*second)->value) {
                                        /* first segment is flat, just move start point back to zero */
                                        _events.front()->when = 0;
@@ -701,7 +798,7 @@ ControlList::truncate_start (double overall_length)
                } else {
 
                        /* shrinking at front */
-                       
+
                        first_legal_coordinate = _events.back()->when - overall_length;
                        first_legal_value = unlocked_eval (first_legal_coordinate);
                        first_legal_value = max (_min_yval, first_legal_value);
@@ -710,37 +807,35 @@ ControlList::truncate_start (double overall_length)
                        /* remove all events earlier than the new "front" */
 
                        i = _events.begin();
-                       
+
                        while (i != _events.end() && !_events.empty()) {
                                ControlList::iterator tmp;
-                               
+
                                tmp = i;
                                ++tmp;
-                               
+
                                if ((*i)->when > first_legal_coordinate) {
                                        break;
                                }
-                               
+
                                _events.erase (i);
-                               
+
                                i = tmp;
                        }
-                       
+
 
                        /* shift all remaining points left to keep their same
                           relative position
                        */
-                       
+
                        for (i = _events.begin(); i != _events.end(); ++i) {
                                (*i)->when -= first_legal_coordinate;
                        }
 
                        /* add a new point for the interpolated new value */
-                       
-                       _events.push_front (new ControlEvent (0, first_legal_value));
-               }           
 
-               reposition_for_rt_add (0);
+                       _events.push_front (new ControlEvent (0, first_legal_value));
+               }
 
                mark_dirty();
        }
@@ -758,31 +853,23 @@ ControlList::unlocked_eval (double x) const
        double fraction;
 
        const_iterator length_check_iter = _events.begin();
-       for (npoints = 0; npoints < 4; ++npoints, ++length_check_iter)
-               if (length_check_iter == _events.end())
+       for (npoints = 0; npoints < 4; ++npoints, ++length_check_iter) {
+               if (length_check_iter == _events.end()) {
                        break;
+               }
+       }
 
        switch (npoints) {
        case 0:
                return _default_value;
 
        case 1:
-               if (x >= _events.front()->when) {
-                       return _events.front()->value;
-               } else {
-                       // hansfbaier: v--------- Why commented ??? 
-                       // return _default_value;
-                       return _events.front()->value;
-               } 
-               
+               return _events.front()->value;
+
        case 2:
                if (x >= _events.back()->when) {
                        return _events.back()->value;
-               } else if (x == _events.front()->when) {
-                       return _events.front()->value;
-               } else if (x < _events.front()->when) {
-                       // hansfbaier: v--------- Why commented ??? 
-                       // return _default_value;
+               } else if (x <= _events.front()->when) {
                        return _events.front()->value;
                }
 
@@ -790,35 +877,27 @@ ControlList::unlocked_eval (double x) const
                lval = _events.front()->value;
                upos = _events.back()->when;
                uval = _events.back()->value;
-               
+
                if (_interpolation == Discrete) {
                        return lval;
                }
 
-               /* linear interpolation betweeen the two points
-               */
-
+               /* linear interpolation betweeen the two points */
                fraction = (double) (x - lpos) / (double) (upos - lpos);
                return lval + (fraction * (uval - lval));
 
        default:
-
                if (x >= _events.back()->when) {
                        return _events.back()->value;
-               } else if (x == _events.front()->when) {
-                       return _events.front()->value;
-               } else if (x < _events.front()->when) {
-                       // hansfbaier: v--------- Why commented ??? 
-                       // return _default_value;
+               } else if (x <= _events.front()->when) {
                        return _events.front()->value;
                }
 
                return multipoint_eval (x);
-               break;
        }
 
        /*NOTREACHED*/ /* stupid gcc */
-       return 0.0;
+       return _default_value;
 }
 
 double
@@ -827,7 +906,7 @@ ControlList::multipoint_eval (double x) const
        double upos, lpos;
        double uval, lval;
        double fraction;
-       
+
        /* "Stepped" lookup (no interpolation) */
        /* FIXME: no cache.  significant? */
        if (_interpolation == Discrete) {
@@ -846,15 +925,15 @@ ControlList::multipoint_eval (double x) const
        /* Only do the range lookup if x is in a different range than last time
         * this was called (or if the lookup cache has been marked "dirty" (left<0) */
        if ((_lookup_cache.left < 0) ||
-           ((_lookup_cache.left > x) || 
-            (_lookup_cache.range.first == _events.end()) || 
+           ((_lookup_cache.left > x) ||
+            (_lookup_cache.range.first == _events.end()) ||
             ((*_lookup_cache.range.second)->when < x))) {
 
                const ControlEvent cp (x, 0);
-               
+
                _lookup_cache.range = equal_range (_events.begin(), _events.end(), &cp, time_comparator);
        }
-       
+
        pair<const_iterator,const_iterator> range = _lookup_cache.range;
 
        if (range.first == range.second) {
@@ -872,7 +951,7 @@ ControlList::multipoint_eval (double x) const
                        // return _default_value;
                        return _events.front()->value;
                }
-               
+
                if (range.second == _events.end()) {
                        /* we're after the last point */
                        return _events.back()->value;
@@ -880,7 +959,7 @@ ControlList::multipoint_eval (double x) const
 
                upos = (*range.second)->when;
                uval = (*range.second)->value;
-               
+
                /* linear interpolation betweeen the two points
                   on either side of x
                */
@@ -888,7 +967,7 @@ ControlList::multipoint_eval (double x) const
                fraction = (double) (x - lpos) / (double) (upos - lpos);
                return lval + (fraction * (uval - lval));
 
-       } 
+       }
 
        /* x is a control point in the data */
        _lookup_cache.left = -1;
@@ -896,29 +975,23 @@ ControlList::multipoint_eval (double x) const
 }
 
 void
-ControlList::build_search_cache_if_necessary(double start, double end) const
+ControlList::build_search_cache_if_necessary (double start) const
 {
        /* Only do the range lookup if x is in a different range than last time
         * this was called (or if the search cache has been marked "dirty" (left<0) */
-       if (!_events.empty() && ((_search_cache.left < 0) ||
-                       ((_search_cache.left > start) ||
-                        (_search_cache.right < end)))) {
+       if (!_events.empty() && ((_search_cache.left < 0) || (_search_cache.left > start))) {
 
                const ControlEvent start_point (start, 0);
-               const ControlEvent end_point (end, 0);
 
                //cerr << "REBUILD: (" << _search_cache.left << ".." << _search_cache.right << ") := ("
                //      << start << ".." << end << ")" << endl;
 
-               _search_cache.range.first = lower_bound (_events.begin(), _events.end(), &start_point, time_comparator);
-               _search_cache.range.second = upper_bound (_events.begin(), _events.end(), &end_point, time_comparator);
-
+               _search_cache.first = lower_bound (_events.begin(), _events.end(), &start_point, time_comparator);
                _search_cache.left = start;
-               _search_cache.right = end;
        }
 }
 
-/** Get the earliest event between \a start and \a end, using the current interpolation style.
+/** Get the earliest event after \a start using the current interpolation style.
  *
  * If an event is found, \a x and \a y are set to its coordinates.
  *
@@ -926,7 +999,7 @@ ControlList::build_search_cache_if_necessary(double start, double end) const
  * \return true if event is found (and \a x and \a y are valid).
  */
 bool
-ControlList::rt_safe_earliest_event(double start, double end, double& x, double& y, bool inclusive) const
+ControlList::rt_safe_earliest_event (double start, double& x, double& y, bool inclusive) const
 {
        // FIXME: It would be nice if this was unnecessary..
        Glib::Mutex::Lock lm(_lock, Glib::TRY_LOCK);
@@ -934,11 +1007,11 @@ ControlList::rt_safe_earliest_event(double start, double end, double& x, double&
                return false;
        }
 
-       return rt_safe_earliest_event_unlocked(start, end, x, y, inclusive);
-} 
+       return rt_safe_earliest_event_unlocked (start, x, y, inclusive);
+}
 
 
-/** Get the earliest event between \a start and \a end, using the current interpolation style.
+/** Get the earliest event after \a start using the current interpolation style.
  *
  * If an event is found, \a x and \a y are set to its coordinates.
  *
@@ -946,16 +1019,17 @@ ControlList::rt_safe_earliest_event(double start, double end, double& x, double&
  * \return true if event is found (and \a x and \a y are valid).
  */
 bool
-ControlList::rt_safe_earliest_event_unlocked(double start, double end, double& x, double& y, bool inclusive) const
+ControlList::rt_safe_earliest_event_unlocked (double start, double& x, double& y, bool inclusive) const
 {
-       if (_interpolation == Discrete)
-               return rt_safe_earliest_event_discrete_unlocked(start, end, x, y, inclusive);
-       else
-               return rt_safe_earliest_event_linear_unlocked(start, end, x, y, inclusive);
-} 
+       if (_interpolation == Discrete) {
+               return rt_safe_earliest_event_discrete_unlocked(start, x, y, inclusive);
+       } else {
+               return rt_safe_earliest_event_linear_unlocked(start, x, y, inclusive);
+       }
+}
 
 
-/** Get the earliest event between \a start and \a end (Discrete (lack of) interpolation)
+/** Get the earliest event after \a start without interpolation.
  *
  * If an event is found, \a x and \a y are set to its coordinates.
  *
@@ -963,19 +1037,17 @@ ControlList::rt_safe_earliest_event_unlocked(double start, double end, double& x
  * \return true if event is found (and \a x and \a y are valid).
  */
 bool
-ControlList::rt_safe_earliest_event_discrete_unlocked (double start, double end, double& x, double& y, bool inclusive) const
+ControlList::rt_safe_earliest_event_discrete_unlocked (double start, double& x, double& y, bool inclusive) const
 {
-       build_search_cache_if_necessary(start, end);
-
-       const pair<const_iterator,const_iterator>& range = _search_cache.range;
+       build_search_cache_if_necessary (start);
 
-       if (range.first != _events.end()) {
-               const ControlEvent* const first = *range.first;
+       if (_search_cache.first != _events.end()) {
+               const ControlEvent* const first = *_search_cache.first;
 
                const bool past_start = (inclusive ? first->when >= start : first->when > start);
 
                /* Earliest points is in range, return it */
-               if (past_start >= start && first->when < end) {
+               if (past_start) {
 
                        x = first->when;
                        y = first->value;
@@ -983,21 +1055,17 @@ ControlList::rt_safe_earliest_event_discrete_unlocked (double start, double end,
                        /* Move left of cache to this point
                         * (Optimize for immediate call this cycle within range) */
                        _search_cache.left = x;
-                       ++_search_cache.range.first;
+                       ++_search_cache.first;
 
                        assert(x >= start);
-                       assert(x < end);
-                       cerr << "returned something" << endl;
                        return true;
 
                } else {
-                       cerr << "not between start and end" << endl;
                        return false;
                }
-       
+
        /* No points in range */
        } else {
-               cerr << "no points in range" << endl;
                return false;
        }
 }
@@ -1010,44 +1078,42 @@ ControlList::rt_safe_earliest_event_discrete_unlocked (double start, double end,
  * \return true if event is found (and \a x and \a y are valid).
  */
 bool
-ControlList::rt_safe_earliest_event_linear_unlocked (double start, double end, double& x, double& y, bool inclusive) const
+ControlList::rt_safe_earliest_event_linear_unlocked (double start, double& x, double& y, bool inclusive) const
 {
-       //cerr << "earliest_event(" << start << ", " << end << ", " << x << ", " << y << ", " << inclusive << endl;
+       // cout << "earliest_event(start: " << start << ", x: " << x << ", y: " << y << ", inclusive: " << inclusive <<  ")" << endl;
 
        const_iterator length_check_iter = _events.begin();
-       if (_events.empty()) // 0 events
+       if (_events.empty()) // 0 events
                return false;
-       else if (_events.end() == ++length_check_iter) // 1 event
-               return rt_safe_earliest_event_discrete_unlocked(start, end, x, y, inclusive);
+        } else if (_events.end() == ++length_check_iter) { // 1 event
+               return rt_safe_earliest_event_discrete_unlocked (start, x, y, inclusive);
+        }
 
        // Hack to avoid infinitely repeating the same event
-       build_search_cache_if_necessary(start, end);
-       
-       pair<const_iterator,const_iterator> range = _search_cache.range;
+       build_search_cache_if_necessary (start);
 
-       if (range.first != _events.end()) {
+       if (_search_cache.first != _events.end()) {
 
                const ControlEvent* first = NULL;
                const ControlEvent* next = NULL;
 
-               /* No events past start (maybe?) */
-               if (next && next->when < start)
-                       return false;
-
                /* Step is after first */
-               if (range.first == _events.begin() || (*range.first)->when == start) {
-                       first = *range.first;
-                       next = *(++range.first);
-                       ++_search_cache.range.first;
+               if (_search_cache.first == _events.begin() || (*_search_cache.first)->when <= start) {
+                       first = *_search_cache.first;
+                       ++_search_cache.first;
+                       if (_search_cache.first == _events.end()) {
+                               return false;
+                       }
+                       next = *_search_cache.first;
 
                /* Step is before first */
                } else {
-                       const_iterator prev = range.first;
+                       const_iterator prev = _search_cache.first;
                        --prev;
                        first = *prev;
-                       next = *range.first;
+                       next = *_search_cache.first;
                }
-               
+
                if (inclusive && first->when == start) {
                        x = first->when;
                        y = first->value;
@@ -1055,12 +1121,12 @@ ControlList::rt_safe_earliest_event_linear_unlocked (double start, double end, d
                         * (Optimize for immediate call this cycle within range) */
                        _search_cache.left = x;
                        //++_search_cache.range.first;
-                       assert(inclusive ? x >= start : x > start);
+                       assert(x >= start);
                        return true;
                }
-                       
+
                if (fabs(first->value - next->value) <= 1) {
-                       if (next->when <= end && (!inclusive || next->when > start)) {
+                       if (next->when > start) {
                                x = next->when;
                                y = next->value;
                                /* Move left of cache to this point
@@ -1086,9 +1152,9 @@ ControlList::rt_safe_earliest_event_linear_unlocked (double start, double end, d
                        y = floor(y);
 
                x = first->when + (y - first->value) / (double)slope;
-               
+
                while ((inclusive && x < start) || (x <= start && y != next->value)) {
-                       
+
                        if (first->value < next->value) // ramping up
                                y += 1.0;
                        else // ramping down
@@ -1104,9 +1170,9 @@ ControlList::rt_safe_earliest_event_linear_unlocked (double start, double end, d
                assert(    (y >= first->value && y <= next->value)
                                || (y <= first->value && y >= next->value) );
 
-               
+
                const bool past_start = (inclusive ? x >= start : x > start);
-               if (past_start && x < end) {
+               if (past_start) {
                        /* Move left of cache to this point
                         * (Optimize for immediate call this cycle within range) */
                        _search_cache.left = x;
@@ -1115,73 +1181,74 @@ ControlList::rt_safe_earliest_event_linear_unlocked (double start, double end, d
                } else {
                        return false;
                }
-       
+
        /* No points in the future, so no steps (towards them) in the future */
        } else {
                return false;
        }
 }
 
-boost::shared_ptr<ControlList>
-ControlList::cut (iterator start, iterator end)
-{
-       boost::shared_ptr<ControlList> nal = create (_parameter);
-
-       {
-               Glib::Mutex::Lock lm (_lock);
-
-               for (iterator x = start; x != end; ) {
-                       iterator tmp;
-                       
-                       tmp = x;
-                       ++tmp;
-                       
-                       nal->_events.push_back (new ControlEvent (**x));
-                       _events.erase (x);
-                       
-                       reposition_for_rt_add (0);
-
-                       x = tmp;
-               }
-
-               mark_dirty ();
-       }
-
-       maybe_signal_changed ();
-
-       return nal;
-}
 
+/** @param start Start position in model coordinates.
+ *  @param end End position in model coordinates.
+ *  @param op 0 = cut, 1 = copy, 2 = clear.
+ */
 boost::shared_ptr<ControlList>
 ControlList::cut_copy_clear (double start, double end, int op)
 {
        boost::shared_ptr<ControlList> nal = create (_parameter);
        iterator s, e;
-       ControlEvent cp (start, 0.0);
-       bool changed = false;
-       
+        ControlEvent cp (start, 0.0);
+
        {
-               Glib::Mutex::Lock lm (_lock);
+               Glib::Mutex::Lock lm (_lock);
+
+                /* first, determine s & e, two iterators that define the range of points
+                   affected by this operation
+                */
 
                if ((s = lower_bound (_events.begin(), _events.end(), &cp, time_comparator)) == _events.end()) {
                        return nal;
                }
 
+               /* and the last that is at or after `end' */
                cp.when = end;
                e = upper_bound (_events.begin(), _events.end(), &cp, time_comparator);
 
-               if (op != 2 && (*s)->when != start) {
-                       nal->_events.push_back (new ControlEvent (0, unlocked_eval (start)));
-               }
+
+                /* if "start" isn't the location of an existing point,
+                   evaluate the curve to get a value for the start. Add a point to
+                   both the existing event list, and if its not a "clear" operation,
+                   to the copy ("nal") as well. 
+
+                   Note that the time positions of the points in each list are different 
+                   because we want the copy ("nal") to have a zero time reference.
+                */
+
+                        
+                /* before we begin any cut/clear operations, get the value of the curve
+                   at "end".
+                */
+
+                double end_value = unlocked_eval (end);
+
+                if ((*s)->when != start) {
+                        
+                        double val = unlocked_eval (start);
+
+                       if (op == 0) { // cut
+                               if (start > _events.front()->when) {
+                                       _events.insert (s, (new ControlEvent (start, val)));
+                               }
+                       }
+                        
+                        if (op != 2) { // ! clear
+                                nal->_events.push_back (new ControlEvent (0, val));
+                        }
+                }
 
                for (iterator x = s; x != e; ) {
-                       iterator tmp;
-                       
-                       tmp = x;
-                       ++tmp;
 
-                       changed = true;
-                       
                        /* adjust new points to be relative to start, which
                           has been set to zero.
                        */
@@ -1191,51 +1258,36 @@ ControlList::cut_copy_clear (double start, double end, int op)
                        }
 
                        if (op != 1) {
-                               _events.erase (x);
-                       }
-                       
-                       x = tmp;
+                               x = _events.erase (x);
+                       } else {
+                                ++x;
+                        }
                }
+                
+                if (e == _events.end() || (*e)->when != end) {
 
-               if (op != 2 && nal->_events.back()->when != end - start) {
-                       nal->_events.push_back (new ControlEvent (end - start, unlocked_eval (end)));
-               }
+                        /* only add a boundary point if there is a point after "end"
+                         */
 
-               if (changed) {
-                       reposition_for_rt_add (0);
+                        if (op == 0 && (e != _events.end() && end < (*e)->when)) { // cut
+                                _events.insert (e, new ControlEvent (end, end_value));
+                        }
+
+                        if (op != 2 && (e != _events.end() && end < (*e)->when)) { // cut/copy
+                                nal->_events.push_back (new ControlEvent (end - start, end_value));
+                        }
                }
 
-               mark_dirty ();
+                mark_dirty ();
        }
 
-       maybe_signal_changed ();
+        if (op != 1) {
+                maybe_signal_changed ();
+        }
 
        return nal;
-
 }
 
-boost::shared_ptr<ControlList>
-ControlList::copy (iterator start, iterator end)
-{
-       boost::shared_ptr<ControlList> nal = create (_parameter);
-
-       {
-               Glib::Mutex::Lock lm (_lock);
-               
-               for (iterator x = start; x != end; ) {
-                       iterator tmp;
-                       
-                       tmp = x;
-                       ++tmp;
-                       
-                       nal->_events.push_back (new ControlEvent (**x));
-                       
-                       x = tmp;
-               }
-       }
-
-       return nal;
-}
 
 boost::shared_ptr<ControlList>
 ControlList::cut (double start, double end)
@@ -1252,11 +1304,12 @@ ControlList::copy (double start, double end)
 void
 ControlList::clear (double start, double end)
 {
-       (void) cut_copy_clear (start, end, 2);
+       cut_copy_clear (start, end, 2);
 }
 
+/** @param pos Position in model coordinates */
 bool
-ControlList::paste (ControlList& alist, double pos, float times)
+ControlList::paste (ControlList& alist, double pos, float /*times*/)
 {
        if (alist._events.empty()) {
                return false;
@@ -1275,9 +1328,9 @@ ControlList::paste (ControlList& alist, double pos, float times)
                        _events.insert (where, new ControlEvent( (*i)->when+pos,( *i)->value));
                        end = (*i)->when + pos;
                }
-       
-       
-               /* move all  points after the insertion along the timeline by 
+
+
+               /* move all  points after the insertion along the timeline by
                   the correct amount.
                */
 
@@ -1294,7 +1347,6 @@ ControlList::paste (ControlList& alist, double pos, float times)
                        }
                }
 
-               reposition_for_rt_add (0);
                mark_dirty ();
        }
 
@@ -1304,8 +1356,10 @@ ControlList::paste (ControlList& alist, double pos, float times)
 
 /** Move automation around according to a list of region movements */
 void
-ControlList::move_ranges (RangeMoveList const & movements)
+ControlList::move_ranges (const list< RangeMove<double> >& movements)
 {
+       typedef list< RangeMove<double> > RangeMoveList;
+
        {
                Glib::Mutex::Lock lm (_lock);
 
@@ -1323,8 +1377,8 @@ ControlList::move_ranges (RangeMoveList const & movements)
                /* copy the events into the new list */
                for (RangeMoveList::const_iterator i = movements.begin (); i != movements.end (); ++i) {
                        iterator j = old_events.begin ();
-                       EventTime const limit = i->from + i->length;
-                       EventTime const dx = i->to - i->from;
+                       const double limit = i->from + i->length;
+                       const double dx    = i->to - i->from;
                        while (j != old_events.end () && (*j)->when <= limit) {
                                if ((*j)->when >= i->from) {
                                        ControlEvent* ev = new ControlEvent (**j);
@@ -1341,12 +1395,22 @@ ControlList::move_ranges (RangeMoveList const & movements)
                        _sort_pending = true;
                }
 
-               reposition_for_rt_add (0);
                mark_dirty ();
        }
 
        maybe_signal_changed ();
 }
 
+void
+ControlList::set_interpolation (InterpolationStyle s)
+{
+       if (_interpolation == s) {
+               return;
+       }
+
+       _interpolation = s;
+       InterpolationChanged (s); /* EMIT SIGNAL */
+}
+
 } // namespace Evoral