Do not verify checksum upon seeking in the directory.
[lwext4.git] / lwext4 / ext4.c
index e3c8154222f99d57cea6af1474cf7d2a9d906d6d..ac379b95a0199052c5e216cf4d9b006f7731f039 100644 (file)
@@ -198,35 +198,36 @@ static int ext4_link(struct ext4_mountpoint *mp, struct ext4_inode_ref *parent,
        if (ext4_inode_is_type(&mp->fs.sb, child->inode,
                               EXT4_INODE_MODE_DIRECTORY) &&
            !rename) {
-               rc = ext4_dir_add_entry(child, ".", strlen("."), child);
-               if (rc != EOK) {
-                       ext4_dir_remove_entry(parent, name, strlen(name));
-                       return rc;
-               }
-
-               rc = ext4_dir_add_entry(child, "..", strlen(".."), parent);
-               if (rc != EOK) {
-                       ext4_dir_remove_entry(parent, name, strlen(name));
-                       ext4_dir_remove_entry(child, ".", strlen("."));
-                       return rc;
-               }
-
-               /*New empty directory. Two links (. and ..) */
-               ext4_inode_set_links_count(child->inode, 2);
 
 #if CONFIG_DIR_INDEX_ENABLE
                /* Initialize directory index if supported */
-               if (ext4_sb_has_feature_compatible(
-                       &mp->fs.sb, EXT4_FEATURE_COMPAT_DIR_INDEX)) {
-                       rc = ext4_dir_dx_init(child);
+               if (ext4_sb_feature_com(&mp->fs.sb, EXT4_FCOM_DIR_INDEX)) {
+                       rc = ext4_dir_dx_init(child, parent);
                        if (rc != EOK)
                                return rc;
 
                        ext4_inode_set_flag(child->inode,
                                            EXT4_INODE_FLAG_INDEX);
                        child->dirty = true;
-               }
+               } else
 #endif
+               {
+                       rc = ext4_dir_add_entry(child, ".", strlen("."), child);
+                       if (rc != EOK) {
+                               ext4_dir_remove_entry(parent, name, strlen(name));
+                               return rc;
+                       }
+
+                       rc = ext4_dir_add_entry(child, "..", strlen(".."), parent);
+                       if (rc != EOK) {
+                               ext4_dir_remove_entry(parent, name, strlen(name));
+                               ext4_dir_remove_entry(child, ".", strlen("."));
+                               return rc;
+                       }
+               }
+
+               /*New empty directory. Two links (. and ..) */
+               ext4_inode_set_links_count(child->inode, 2);
 
                ext4_fs_inode_links_count_inc(parent);
                child->dirty = true;
@@ -1254,13 +1255,15 @@ int ext4_ftruncate(ext4_file *f, uint64_t size)
 
 int ext4_fread(ext4_file *f, void *buf, size_t size, size_t *rcnt)
 {
-       uint32_t u;
-       uint32_t fblock;
-       uint32_t fblock_start;
-       uint32_t fblock_cnt;
-       uint32_t sblock;
-       uint32_t sblock_end;
+       uint32_t unaligned;
+       uint32_t iblock_idx;
+       uint32_t iblock_last;
        uint32_t block_size;
+
+       ext4_fsblk_t fblock;
+       ext4_fsblk_t fblock_start;
+       uint32_t fblock_count;
+
        uint8_t *u8_buf = buf;
        int r;
        struct ext4_block b;
@@ -1290,9 +1293,10 @@ int ext4_fread(ext4_file *f, void *buf, size_t size, size_t *rcnt)
 
        block_size = ext4_sb_get_block_size(&f->mp->fs.sb);
        size = size > (f->fsize - f->fpos) ? (f->fsize - f->fpos) : size;
-       sblock = (f->fpos) / block_size;
-       sblock_end = (f->fpos + size) / block_size;
-       u = (f->fpos) % block_size;
+
+       iblock_idx = (f->fpos) / block_size;
+       iblock_last = (f->fpos + size) / block_size;
+       unaligned = (f->fpos) % block_size;
 
        /*If the size of symlink is smaller than 60 bytes*/
        if (ext4_inode_is_type(&f->mp->fs.sb, ref.inode, EXT4_INODE_MODE_SOFTLINK)
@@ -1300,10 +1304,10 @@ int ext4_fread(ext4_file *f, void *buf, size_t size, size_t *rcnt)
                        && !ext4_inode_get_blocks_count(&f->mp->fs.sb, ref.inode)) {
                char *content = (char *)ref.inode->blocks;
                if (f->fpos < f->fsize) {
-                       r = (u + size > f->fsize)
-                               ?(f->fsize - u)
+                       r = (unaligned + size > f->fsize)
+                               ?(f->fsize - unaligned)
                                :(size);
-                       memcpy(buf, content + u, r);
+                       memcpy(buf, content + unaligned, r);
                        if (rcnt)
                                *rcnt = r;
 
@@ -1318,73 +1322,79 @@ int ext4_fread(ext4_file *f, void *buf, size_t size, size_t *rcnt)
                goto Finish;
        }
 
-       if (u) {
-
-               uint32_t ll = size > (block_size - u) ? (block_size - u) : size;
-
-               r = ext4_fs_get_inode_data_block_index(&ref, sblock, &fblock);
+       if (unaligned) {
+               uint32_t l = size > (block_size - unaligned) ?
+                               (block_size - unaligned) : size;
+               r = ext4_fs_get_inode_data_block_index(&ref, iblock_idx, &fblock,
+                               true);
                if (r != EOK)
                        goto Finish;
 
-               r = ext4_block_get(f->mp->fs.bdev, &b, fblock);
-               if (r != EOK)
-                       goto Finish;
+               /* Do we get an unwritten range? */
+               if (fblock != 0) {
+                       r = ext4_block_get(f->mp->fs.bdev, &b, fblock);
+                       if (r != EOK)
+                               goto Finish;
 
-               memcpy(u8_buf, b.data + u, ll);
+                       memcpy(u8_buf, b.data + unaligned, l);
 
-               r = ext4_block_set(f->mp->fs.bdev, &b);
-               if (r != EOK)
-                       goto Finish;
+                       r = ext4_block_set(f->mp->fs.bdev, &b);
+                       if (r != EOK)
+                               goto Finish;
+               } else {
+                       /* Yes, we do. */
+                       memset(u8_buf, 0, l);
+               }
 
-               u8_buf += ll;
-               size -= ll;
-               f->fpos += ll;
+               u8_buf += l;
+               size -= l;
+               f->fpos += l;
 
                if (rcnt)
-                       *rcnt += ll;
+                       *rcnt += l;
 
-               sblock++;
+               iblock_idx++;
        }
 
        fblock_start = 0;
-       fblock_cnt = 0;
+       fblock_count = 0;
        while (size >= block_size) {
-               while (sblock < sblock_end) {
-                       r = ext4_fs_get_inode_data_block_index(&ref, sblock,
-                                                              &fblock);
+               while (iblock_idx < iblock_last) {
+                       r = ext4_fs_get_inode_data_block_index(&ref, iblock_idx,
+                                                              &fblock, true);
                        if (r != EOK)
                                goto Finish;
 
-                       sblock++;
+                       iblock_idx++;
 
-                       if (!fblock_start) {
+                       if (!fblock_start)
                                fblock_start = fblock;
-                       }
 
-                       if ((fblock_start + fblock_cnt) != fblock)
+                       if ((fblock_start + fblock_count) != fblock)
                                break;
 
-                       fblock_cnt++;
+                       fblock_count++;
                }
 
                r = ext4_blocks_get_direct(f->mp->fs.bdev, u8_buf, fblock_start,
-                                          fblock_cnt);
+                                          fblock_count);
                if (r != EOK)
                        goto Finish;
 
-               size -= block_size * fblock_cnt;
-               u8_buf += block_size * fblock_cnt;
-               f->fpos += block_size * fblock_cnt;
+               size -= block_size * fblock_count;
+               u8_buf += block_size * fblock_count;
+               f->fpos += block_size * fblock_count;
 
                if (rcnt)
-                       *rcnt += block_size * fblock_cnt;
+                       *rcnt += block_size * fblock_count;
 
                fblock_start = fblock;
-               fblock_cnt = 1;
+               fblock_count = 1;
        }
 
        if (size) {
-               r = ext4_fs_get_inode_data_block_index(&ref, sblock, &fblock);
+               r = ext4_fs_get_inode_data_block_index(&ref, iblock_idx, &fblock,
+                               true);
                if (r != EOK)
                        goto Finish;
 
@@ -1412,20 +1422,20 @@ Finish:
 
 int ext4_fwrite(ext4_file *f, const void *buf, size_t size, size_t *wcnt)
 {
-       uint32_t u;
-       uint32_t fblock;
-
-       uint32_t sblock;
-       uint32_t sblock_end;
-       uint32_t file_blocks;
+       uint32_t unaligned;
+       uint32_t iblock_idx;
+       uint32_t iblock_last;
+       uint32_t ifile_blocks;
        uint32_t block_size;
-       uint32_t fblock_start;
-       uint32_t fblock_cnt;
+
+       uint32_t fblock_count;
+       ext4_fsblk_t fblock;
+       ext4_fsblk_t fblock_start;
 
        struct ext4_block b;
        struct ext4_inode_ref ref;
        const uint8_t *u8_buf = buf;
-       int r;
+       int r, rr = EOK;
 
        ext4_assert(f && f->mp);
 
@@ -1448,24 +1458,18 @@ int ext4_fwrite(ext4_file *f, const void *buf, size_t size, size_t *wcnt)
 
        /*Sync file size*/
        f->fsize = ext4_inode_get_size(&f->mp->fs.sb, ref.inode);
-
        block_size = ext4_sb_get_block_size(&f->mp->fs.sb);
 
-       sblock_end = (f->fpos + size) > f->fsize ? (f->fpos + size) : f->fsize;
-       sblock_end /= block_size;
-       file_blocks = (f->fsize / block_size);
-
-       if (f->fsize % block_size)
-               file_blocks++;
+       iblock_last = (f->fpos + size) / block_size;
+       iblock_idx = (f->fpos) / block_size;
+       ifile_blocks = (f->fsize + block_size - 1) / block_size;
 
-       sblock = (f->fpos) / block_size;
+       unaligned = (f->fpos) % block_size;
 
-       u = (f->fpos) % block_size;
-
-       if (u) {
-               uint32_t ll = size > (block_size - u) ? (block_size - u) : size;
-
-               r = ext4_fs_get_inode_data_block_index(&ref, sblock, &fblock);
+       if (unaligned) {
+               uint32_t l = size > (block_size - unaligned) ?
+                               (block_size - unaligned) : size;
+               r = ext4_fs_init_inode_data_block_index(&ref, iblock_idx, &fblock);
                if (r != EOK)
                        goto Finish;
 
@@ -1473,21 +1477,21 @@ int ext4_fwrite(ext4_file *f, const void *buf, size_t size, size_t *wcnt)
                if (r != EOK)
                        goto Finish;
 
-               memcpy(b.data + u, u8_buf, ll);
+               memcpy(b.data + unaligned, u8_buf, l);
                b.dirty = true;
 
                r = ext4_block_set(f->mp->fs.bdev, &b);
                if (r != EOK)
                        goto Finish;
 
-               u8_buf += ll;
-               size -= ll;
-               f->fpos += ll;
+               u8_buf += l;
+               size -= l;
+               f->fpos += l;
 
                if (wcnt)
-                       *wcnt += ll;
+                       *wcnt += l;
 
-               sblock++;
+               iblock_idx++;
        }
 
        /*Start write back cache mode.*/
@@ -1496,48 +1500,60 @@ int ext4_fwrite(ext4_file *f, const void *buf, size_t size, size_t *wcnt)
                goto Finish;
 
        fblock_start = 0;
-       fblock_cnt = 0;
+       fblock_count = 0;
        while (size >= block_size) {
 
-               while (sblock < sblock_end) {
-                       if (sblock < file_blocks) {
-                               r = ext4_fs_get_inode_data_block_index(
-                                   &ref, sblock, &fblock);
+               while (iblock_idx < iblock_last) {
+                       if (iblock_idx < ifile_blocks) {
+                               r = ext4_fs_init_inode_data_block_index(
+                                   &ref, iblock_idx, &fblock);
                                if (r != EOK)
-                                       break;
+                                       goto Finish;
                        } else {
-                               r = ext4_fs_append_inode_block(&ref, &fblock,
-                                                              &sblock);
-                               if (r != EOK)
+                               rr = ext4_fs_append_inode_block(&ref, &fblock,
+                                                              &iblock_idx);
+                               if (rr != EOK) {
+                                       /* Unable to append more blocks. But some
+                                        * block might be allocated already.
+                                        * */
                                        break;
+                               }
                        }
 
-                       sblock++;
+                       iblock_idx++;
 
                        if (!fblock_start) {
                                fblock_start = fblock;
                        }
 
-                       if ((fblock_start + fblock_cnt) != fblock)
+                       if ((fblock_start + fblock_count) != fblock)
                                break;
 
-                       fblock_cnt++;
+                       fblock_count++;
                }
 
                r = ext4_blocks_set_direct(f->mp->fs.bdev, u8_buf, fblock_start,
-                                          fblock_cnt);
+                                          fblock_count);
                if (r != EOK)
                        break;
 
-               size -= block_size * fblock_cnt;
-               u8_buf += block_size * fblock_cnt;
-               f->fpos += block_size * fblock_cnt;
+               size -= block_size * fblock_count;
+               u8_buf += block_size * fblock_count;
+               f->fpos += block_size * fblock_count;
 
                if (wcnt)
-                       *wcnt += block_size * fblock_cnt;
+                       *wcnt += block_size * fblock_count;
 
                fblock_start = fblock;
-               fblock_cnt = 1;
+               fblock_count = 1;
+
+               if (rr != EOK) {
+                       /*ext4_fs_append_inode_block has failed and no
+                        * more blocks might be written. But node size
+                        * should be updated.*/
+                       r = rr;
+                       goto out_fsize;
+               }
        }
 
        /*Stop write back cache mode*/
@@ -1547,15 +1563,16 @@ int ext4_fwrite(ext4_file *f, const void *buf, size_t size, size_t *wcnt)
                goto Finish;
 
        if (size) {
-               if (sblock < file_blocks) {
-                       r = ext4_fs_get_inode_data_block_index(&ref, sblock,
+               if (iblock_idx < ifile_blocks) {
+                       r = ext4_fs_init_inode_data_block_index(&ref, iblock_idx,
                                                               &fblock);
                        if (r != EOK)
                                goto Finish;
                } else {
-                       r = ext4_fs_append_inode_block(&ref, &fblock, &sblock);
+                       r = ext4_fs_append_inode_block(&ref, &fblock, &iblock_idx);
                        if (r != EOK)
-                               goto Finish;
+                               /*Node size sholud be updated.*/
+                               goto out_fsize;
                }
 
                r = ext4_block_get(f->mp->fs.bdev, &b, fblock);
@@ -1575,6 +1592,7 @@ int ext4_fwrite(ext4_file *f, const void *buf, size_t size, size_t *wcnt)
                        *wcnt += size;
        }
 
+out_fsize:
        if (f->fpos > f->fsize) {
                f->fsize = f->fpos;
                ext4_inode_set_size(ref.inode, f->fsize);
@@ -1793,7 +1811,8 @@ static int ext4_fsymlink_set(ext4_file *f, const void *buf, uint32_t size)
 {
        struct ext4_block b;
        struct ext4_inode_ref ref;
-       uint32_t sblock, fblock;
+       uint32_t sblock;
+       ext4_fsblk_t fblock;
        uint32_t block_size;
        int r;
 
@@ -1825,9 +1844,8 @@ static int ext4_fsymlink_set(ext4_file *f, const void *buf, uint32_t size)
 
        /*If the size of symlink is smaller than 60 bytes*/
        if (size < sizeof(ref.inode->blocks)) {
-               char *content = (char *)ref.inode->blocks;
-               memset(content, 0, sizeof(ref.inode->blocks));
-               memcpy(content, buf, size);
+               memset(ref.inode->blocks, 0, sizeof(ref.inode->blocks));
+               memcpy(ref.inode->blocks, buf, size);
                ext4_inode_clear_flag(ref.inode, EXT4_INODE_FLAG_EXTENTS);
        } else {
                ext4_fs_inode_blocks_init(&f->mp->fs, &ref);
@@ -1905,8 +1923,6 @@ int ext4_readlink(const char *path, char *buf, size_t bufsize, size_t *rcnt)
        if (!buf)
                return EINVAL;
 
-       memset(buf, 0, sizeof(bufsize));
-
        filetype = EXT4_DIRENTRY_SYMLINK;
 
        EXT4_MP_LOCK(mp);