FIX: no entries found during iteration.
[lwext4.git] / lwext4 / ext4_xattr.c
index 6c61d1f051247c1da3c25c8f9d9d0facc598600e..a38cc321409c8b3b87309e3e5ff939093810e1e3 100644 (file)
@@ -90,6 +90,35 @@ ext4_xattr_compute_hash(struct ext4_xattr_header *header,
        entry->e_hash = to_le32(hash);
 }
 
+#define BLOCK_HASH_SHIFT 16
+
+/*
+ * ext4_xattr_rehash()
+ *
+ * Re-compute the extended attribute hash value after an entry has changed.
+ */
+static void ext4_xattr_rehash(struct ext4_xattr_header *header,
+                             struct ext4_xattr_entry *entry)
+{
+       struct ext4_xattr_entry *here;
+       uint32_t hash = 0;
+
+       ext4_xattr_compute_hash(header, entry);
+       here = EXT4_XATTR_ENTRY(header+1);
+       while (!EXT4_XATTR_IS_LAST_ENTRY(here)) {
+               if (!here->e_hash) {
+                       /* Block is not shared if an entry's hash value == 0 */
+                       hash = 0;
+                       break;
+               }
+               hash = (hash << BLOCK_HASH_SHIFT) ^
+                      (hash >> (8*sizeof(hash) - BLOCK_HASH_SHIFT)) ^
+                      to_le32(here->e_hash);
+               here = EXT4_XATTR_NEXT(here);
+       }
+       header->h_hash = to_le32(hash);
+}
+
 static int ext4_xattr_item_cmp(struct ext4_xattr_item *a,
                                struct ext4_xattr_item *b)
 {
@@ -208,8 +237,8 @@ static void *ext4_xattr_entry_data(struct ext4_xattr_ref *xattr_ref,
                        ret = NULL;
 
        } else {
-               uint32_t block_size =
-                               ext4_sb_get_block_size(&xattr_ref->fs->sb);
+               int32_t block_size =
+                       ext4_sb_get_block_size(&xattr_ref->fs->sb);
                ret = (void *)((char *)xattr_ref->block.data + 
                                to_le16(entry->e_value_offs));
                if ((char *)ret + EXT4_XATTR_SIZE(to_le32(entry->e_value_size))
@@ -260,7 +289,8 @@ static int ext4_xattr_block_fetch(struct ext4_xattr_ref *xattr_ref)
                        goto Finish;
                }
                RB_INSERT(ext4_xattr_tree, &xattr_ref->root, item);
-               xattr_ref->ea_size += item->data_size;
+               xattr_ref->ea_size += EXT4_XATTR_SIZE(item->data_size) +
+                                       EXT4_XATTR_LEN(item->name_len);
        }
 
 Finish:
@@ -312,13 +342,32 @@ static int ext4_xattr_inode_fetch(struct ext4_xattr_ref *xattr_ref)
                        goto Finish;
                }
                RB_INSERT(ext4_xattr_tree, &xattr_ref->root, item);
-               xattr_ref->ea_size += item->data_size;
+               xattr_ref->ea_size += EXT4_XATTR_SIZE(item->data_size) +
+                                       EXT4_XATTR_LEN(item->name_len);
        }
 
 Finish:
        return ret;
 }
 
+
+static size_t
+ext4_xattr_inode_space(struct ext4_xattr_ref *xattr_ref)
+{
+       uint16_t inode_size = ext4_get16(&xattr_ref->fs->sb,
+                                        inode_size);
+       uint16_t size_rem = inode_size -
+                       EXT4_GOOD_OLD_INODE_SIZE -
+                       xattr_ref->inode_ref->inode->extra_isize;
+       return size_rem;
+}
+
+static size_t
+ext4_xattr_block_space(struct ext4_xattr_ref *xattr_ref)
+{
+       return ext4_sb_get_block_size(&xattr_ref->fs->sb);
+}
+
 static int ext4_xattr_fetch(struct ext4_xattr_ref *xattr_ref)
 {
        int ret = EOK;
@@ -353,10 +402,99 @@ ext4_xattr_lookup_item(struct ext4_xattr_ref *xattr_ref,
        return ret;
 }
 
+static struct ext4_xattr_item *
+ext4_xattr_insert_item(struct ext4_xattr_ref *xattr_ref,
+                      uint8_t name_index,
+                      char   *name,
+                      size_t  name_len,
+                      void   *data,
+                      size_t  data_size)
+{
+       struct ext4_xattr_item *item;
+       item = ext4_xattr_item_alloc(name_index,
+                                    name,
+                                    name_len);
+       if (!item)
+               return NULL;
+
+       if (xattr_ref->ea_size + EXT4_XATTR_SIZE(item->data_size) +
+                               EXT4_XATTR_LEN(item->name_len) >
+               ext4_xattr_inode_space(xattr_ref) +
+               ext4_xattr_block_space(xattr_ref)) {
+               ext4_xattr_item_free(item);
+               return NULL;
+       }
+       if (ext4_xattr_item_alloc_data(item,
+                                      data,
+                                      data_size) != EOK) {
+               ext4_xattr_item_free(item);
+               return NULL;
+       }
+       RB_INSERT(ext4_xattr_tree, &xattr_ref->root, item);
+       xattr_ref->ea_size += EXT4_XATTR_SIZE(item->data_size) +
+                               EXT4_XATTR_LEN(item->name_len);
+       xattr_ref->dirty = true;
+       return item;
+}
+
+static int
+ext4_xattr_remove_item(struct ext4_xattr_ref *xattr_ref,
+                      uint8_t name_index,
+                      char   *name,
+                      size_t  name_len)
+{
+       int ret = ENOENT;
+       struct ext4_xattr_item *item = 
+               ext4_xattr_lookup_item(xattr_ref,
+                                      name_index,
+                                      name,
+                                      name_len);
+       if (item) {
+               if (item == xattr_ref->iter_from)
+                       xattr_ref->iter_from = RB_NEXT(ext4_xattr_tree,
+                                                      &xattr_ref->root,
+                                                      item);
+
+               RB_REMOVE(ext4_xattr_tree, &xattr_ref->root, item);
+               ext4_xattr_item_free(item);
+               xattr_ref->ea_size -= EXT4_XATTR_SIZE(item->data_size) +
+                                       EXT4_XATTR_LEN(item->name_len);
+               xattr_ref->dirty = true;
+               ret = EOK;
+       }
+       return ret;
+}
+
+static int
+ext4_xattr_resize_item(struct ext4_xattr_ref *xattr_ref,
+                      struct ext4_xattr_item *item,
+                      size_t new_data_size)
+{
+       int ret = EOK;
+       if (xattr_ref->ea_size - EXT4_XATTR_SIZE(item->data_size) +
+                               EXT4_XATTR_SIZE(new_data_size) >
+               ext4_xattr_inode_space(xattr_ref) +
+               ext4_xattr_block_space(xattr_ref)) {
+
+               return ENOSPC;
+       }
+       ret = ext4_xattr_item_resize_data(item,
+                                         new_data_size);
+       if (ret != EOK) {
+               return ret;
+       }
+       xattr_ref->ea_size -= EXT4_XATTR_SIZE(item->data_size) +
+                               EXT4_XATTR_SIZE(new_data_size);
+       xattr_ref->dirty = true;
+       return ret;
+}
+
 static void
 ext4_xattr_purge_items(struct ext4_xattr_ref *xattr_ref)
 {
        struct ext4_xattr_item *item, *save_item;
+       uint64_t xattr_block = ext4_inode_get_file_acl(xattr_ref->inode_ref->inode,
+                                             &xattr_ref->fs->sb);
        RB_FOREACH_SAFE(item,
                        ext4_xattr_tree,
                        &xattr_ref->root,
@@ -365,47 +503,355 @@ ext4_xattr_purge_items(struct ext4_xattr_ref *xattr_ref)
                ext4_xattr_item_free(item);
        }
        xattr_ref->ea_size = 0;
+       if (xattr_block)
+               xattr_ref->ea_size += sizeof(struct ext4_xattr_header);
+
+       if (ext4_xattr_inode_space(xattr_ref) >
+           sizeof(struct ext4_xattr_ibody_header))
+               xattr_ref->ea_size += sizeof(struct ext4_xattr_ibody_header);
 }
 
-static size_t
-ext4_xattr_inode_space(struct ext4_xattr_ref *xattr_ref)
+
+static int
+ext4_xattr_try_alloc_block(struct ext4_xattr_ref *xattr_ref)
 {
-       uint16_t inode_size = ext4_get16(&xattr_ref->fs->sb,
-                                        inode_size);
-       uint16_t size_rem = inode_size -
-                       EXT4_GOOD_OLD_INODE_SIZE -
-                       xattr_ref->inode_ref->inode->extra_isize;
-       return size_rem;
+       int ret = EOK;
+
+       uint64_t xattr_block = 0;
+       xattr_block = ext4_inode_get_file_acl(xattr_ref->inode_ref->inode,
+                                             &xattr_ref->fs->sb);
+       if (!xattr_block) {
+               ret = ext4_balloc_alloc_block(xattr_ref->inode_ref,
+                               (uint32_t *)&xattr_block);
+               if (ret != EOK)
+                       goto Finish;
+
+               ret = ext4_block_get(xattr_ref->fs->bdev,
+                               &xattr_ref->block,
+                               xattr_block);
+               if (ret != EOK) {
+                       ext4_balloc_free_block(xattr_ref->inode_ref,
+                                       xattr_block);
+                       goto Finish;
+               }
+
+               ext4_inode_set_file_acl(xattr_ref->inode_ref->inode,
+                                       &xattr_ref->fs->sb,
+                                       xattr_block);
+               xattr_ref->inode_ref->dirty = true;
+               xattr_ref->block_loaded = true;
+               xattr_ref->ea_size += sizeof(struct ext4_xattr_header);
+       }
+
+Finish:
+       return ret;
 }
 
-static size_t
-ext4_xattr_block_space(struct ext4_xattr_ref *xattr_ref)
+static void
+ext4_xattr_try_free_block(struct ext4_xattr_ref *xattr_ref)
 {
-       return ext4_sb_get_block_size(&xattr_ref->fs->sb);
+       uint64_t xattr_block;
+       xattr_block =
+               ext4_inode_get_file_acl(xattr_ref->inode_ref->inode,
+                               &xattr_ref->fs->sb);
+       ext4_inode_set_file_acl(xattr_ref->inode_ref->inode,
+                       &xattr_ref->fs->sb,
+                       0);
+       ext4_block_set(xattr_ref->fs->bdev,
+                       &xattr_ref->block);
+       ext4_balloc_free_block(xattr_ref->inode_ref,
+                       xattr_block);
+       xattr_ref->inode_ref->dirty = true;
+       xattr_ref->block_loaded = false;
+       xattr_ref->ea_size -= sizeof(struct ext4_xattr_header);
+}
+
+static void
+ext4_xattr_set_block_header(struct ext4_xattr_ref *xattr_ref)
+{
+       struct ext4_xattr_header *block_header = NULL;
+       block_header = EXT4_XATTR_BHDR(&xattr_ref->block);
+
+       memset(block_header, 0, sizeof(struct ext4_xattr_header));
+       block_header->h_magic = EXT4_XATTR_MAGIC;
+       block_header->h_refcount = to_le32(1);
+       block_header->h_blocks = to_le32(1);
+}
+
+static void
+ext4_xattr_set_inode_entry(struct ext4_xattr_item *item,
+                          struct ext4_xattr_ibody_header *ibody_header,
+                          struct ext4_xattr_entry *entry,
+                          void *ibody_data_ptr)
+{
+       entry->e_name_len   = to_le32(item->name_len);
+       entry->e_name_index = item->name_index;
+       entry->e_value_offs =
+               (char *)ibody_data_ptr -
+               (char *)EXT4_XATTR_IFIRST(ibody_header);
+       entry->e_value_block = 0;
+       entry->e_value_size = item->data_size;
+}
+
+static void
+ext4_xattr_set_block_entry(struct ext4_xattr_item *item,
+                          struct ext4_xattr_header *block_header,
+                          struct ext4_xattr_entry *block_entry,
+                          void *block_data_ptr)
+{
+       block_entry->e_name_len   = to_le32(item->name_len);
+       block_entry->e_name_index = item->name_index;
+       block_entry->e_value_offs =
+               (char *)block_data_ptr - (char *)block_header;
+       block_entry->e_value_block = 0;
+       block_entry->e_value_size = item->data_size;
 }
 
 static int
 ext4_xattr_write_to_disk(struct ext4_xattr_ref *xattr_ref)
 {
        int ret = EOK;
+       bool block_modified = false;
+       void *ibody_data, *block_data;
        struct ext4_xattr_item *item, *save_item;
        size_t inode_size_rem, block_size_rem;
+       struct ext4_xattr_ibody_header *ibody_header = NULL;
+       struct ext4_xattr_header *block_header = NULL;
+       struct ext4_xattr_entry *entry = NULL;
+       struct ext4_xattr_entry *block_entry = NULL;
+
        inode_size_rem = ext4_xattr_inode_space(xattr_ref);
        block_size_rem = ext4_xattr_block_space(xattr_ref);
+       if (inode_size_rem > sizeof(struct ext4_xattr_ibody_header)) {
+               ibody_header = EXT4_XATTR_IHDR(xattr_ref->inode_ref->inode);
+               entry = EXT4_XATTR_IFIRST(ibody_header);
+       }
 
        if (xattr_ref->dirty) {
+               /* If there are enough spaces in the ibody EA table.*/
+               if (inode_size_rem > sizeof(struct ext4_xattr_ibody_header)) {
+                       memset(ibody_header, 0, inode_size_rem);
+                       ibody_header->h_magic = EXT4_XATTR_MAGIC;
+                       ibody_data = (char *)ibody_header + inode_size_rem;
+                       inode_size_rem -= sizeof(struct ext4_xattr_ibody_header);
+
+                       xattr_ref->inode_ref->dirty = true;
+               }
+               /* If we need an extra block to hold the EA entries*/
+               if (xattr_ref->ea_size > inode_size_rem) {
+                       if (!xattr_ref->block_loaded) {
+                               ret = ext4_xattr_try_alloc_block(xattr_ref);
+                               if (ret != EOK)
+                                       goto Finish;
+
+                       }
+                       block_header = EXT4_XATTR_BHDR(&xattr_ref->block);
+                       block_entry = EXT4_XATTR_BFIRST(&xattr_ref->block);
+                       ext4_xattr_set_block_header(xattr_ref);
+                       block_data = (char *)block_header + block_size_rem;
+                       block_size_rem -= sizeof(struct ext4_xattr_header);
+
+                       xattr_ref->block.dirty = true;
+               } else {
+                       /* We don't need an extra block.*/
+                       if (xattr_ref->block_loaded) {
+                               block_header = EXT4_XATTR_BHDR(&xattr_ref->block);
+                               block_header->h_refcount =
+                                       to_le32(to_le32(block_header->h_refcount) - 1);
+                               if (!block_header->h_refcount) {
+                                       ext4_xattr_try_free_block(xattr_ref);
+                                       block_header = NULL;
+                               } else {
+                                       block_entry = EXT4_XATTR_BFIRST(&xattr_ref->block);
+                                       block_data = (char *)block_header + block_size_rem;
+                                       block_size_rem -= sizeof(struct ext4_xattr_header);
+                                       ext4_inode_set_file_acl(xattr_ref->inode_ref->inode,
+                                                       &xattr_ref->fs->sb,
+                                                       0);
+
+                                       xattr_ref->inode_ref->dirty = true;
+                                       xattr_ref->block.dirty = true;
+                               }
+                       }
+               }
                RB_FOREACH_SAFE(item,
                                ext4_xattr_tree,
                                &xattr_ref->root,
                                save_item) {
-                       /*This should not fail!*/
-                       ext4_assert(inode_size_rem + block_size_rem);
-                       if (inode_size_rem) {
-                               
+                       if (EXT4_XATTR_SIZE(item->data_size) +
+                               EXT4_XATTR_LEN(item->name_len) <=
+                           inode_size_rem) {
+                               ibody_data = (char *)ibody_data -
+                                       EXT4_XATTR_SIZE(item->data_size);
+                               ext4_xattr_set_inode_entry(item,
+                                                          ibody_header,
+                                                          entry,
+                                                          ibody_data);
+                               memcpy(EXT4_XATTR_NAME(entry),
+                                       item->name, item->name_len);
+                               memcpy(ibody_data, item->data, item->data_size);
+                               entry = EXT4_XATTR_NEXT(entry);
+                               inode_size_rem -=
+                                       EXT4_XATTR_SIZE(item->data_size) +
+                                       EXT4_XATTR_LEN(item->name_len);
+
+                               xattr_ref->inode_ref->dirty = true;
+                               continue;
                        }
+                       if (EXT4_XATTR_SIZE(item->data_size) +
+                               EXT4_XATTR_LEN(item->name_len) > block_size_rem) {
+                               ret = ENOSPC;
+                               goto Finish;
+                       }
+                       block_data = (char *)block_data -
+                               EXT4_XATTR_SIZE(item->data_size);
+                       ext4_xattr_set_block_entry(item,
+                                                  block_header,
+                                                  block_entry,
+                                                  block_data);
+                       memcpy(EXT4_XATTR_NAME(block_entry),
+                               item->name, item->name_len);
+                       memcpy(block_data,
+                               item->data, item->data_size);
+                       block_entry = EXT4_XATTR_NEXT(block_entry);
+                       block_size_rem -=
+                               EXT4_XATTR_SIZE(item->data_size) +
+                               EXT4_XATTR_LEN(item->name_len);
+
+                       block_modified = true;
                }
                xattr_ref->dirty = false;
+               if (block_modified) {
+                       ext4_xattr_rehash(block_header,
+                                         EXT4_XATTR_BFIRST(&xattr_ref->block));
+                       xattr_ref->block.dirty = true;
+               }
        }
+
+Finish:
+       return ret;
+}
+
+void
+ext4_fs_xattr_iterate(struct ext4_xattr_ref *ref,
+                     int (iter)(struct ext4_xattr_ref *ref,
+                                struct ext4_xattr_item *item))
+{
+       struct ext4_xattr_item *item;
+       if (!ref->iter_from)
+               ref->iter_from = RB_MIN(ext4_xattr_tree, &ref->root);
+
+       RB_FOREACH_FROM(item,
+                       ext4_xattr_tree,
+                       ref->iter_from) {
+               int ret = EXT4_XATTR_ITERATE_CONT;
+               if (iter)
+                       iter(ref, item);
+
+               if (ret != EXT4_XATTR_ITERATE_CONT) {
+                       if (ret == EXT4_XATTR_ITERATE_STOP)
+                               ref->iter_from = NULL;
+
+                       break;
+               }
+       }
+}
+
+static void
+ext4_fs_xattr_iterate_reset(struct ext4_xattr_ref *ref)
+{
+       ref->iter_from = NULL;
+}
+
+int ext4_fs_set_xattr(struct ext4_xattr_ref *ref,
+                     uint8_t name_index,
+                     char   *name,
+                     size_t  name_len,
+                     void   *data,
+                     size_t  data_size,
+                     bool    replace)
+{
+       int ret = EOK;
+       struct ext4_xattr_item *item = 
+               ext4_xattr_lookup_item(ref,
+                                       name_index,
+                                       name,
+                                       name_len);
+       if (replace) {
+               if (!item) {
+                       ret = ENOATTR;
+                       goto Finish;
+               }
+               if (item->data_size != data_size)
+                       ret = ext4_xattr_resize_item(ref,
+                                                    item,
+                                                    data_size);
+
+               if (ret != EOK) {
+                       goto Finish;
+               }
+               memcpy(item->data, data, data_size);
+       } else {
+               if (item) {
+                       ret = EEXIST;
+                       goto Finish;
+               }
+               item = ext4_xattr_insert_item(ref,
+                                             name_index,
+                                             name,
+                                             name_len,
+                                             data,
+                                             data_size);
+               if (!item)
+                       ret = ENOMEM;
+
+       }
+Finish:
+       return ret;
+}
+
+int ext4_fs_remove_xattr(struct ext4_xattr_ref *ref,
+                        uint8_t name_index,
+                        char   *name,
+                        size_t  name_len)
+{
+       return ext4_xattr_remove_item(ref,
+                                     name_index,
+                                     name,
+                                     name_len);
+}
+
+int ext4_fs_get_xattr(struct ext4_xattr_ref *ref,
+                         uint8_t name_index,
+                         char    *name,
+                         size_t   name_len,
+                         void    *buf,
+                         size_t   buf_size,
+                         size_t  *size_got)
+{
+       int ret = EOK;
+       size_t item_size = 0;
+       struct ext4_xattr_item *item = 
+               ext4_xattr_lookup_item(ref,
+                                       name_index,
+                                       name,
+                                       name_len);
+
+       if (!item) {
+               ret = ENOATTR;
+               goto Finish;
+       }
+       item_size = item->data_size;
+       if (buf_size > item_size)
+               buf_size = item_size;
+
+       if (buf)
+               memcpy(buf, item->data, buf_size);
+
+Finish:
+       if (size_got)
+               *size_got = buf_size;
+
        return ret;
 }
 
@@ -418,12 +864,15 @@ int ext4_fs_get_xattr_ref(struct ext4_fs *fs,
        xattr_block = ext4_inode_get_file_acl(inode_ref->inode,
                                              &fs->sb);
        RB_INIT(&ref->root);
+       ref->ea_size = 0;
+       ref->iter_from = NULL;
        if (xattr_block) {
                rc = ext4_block_get(fs->bdev,
-                                   &inode_ref->block, xattr_block);
+                                   &ref->block, xattr_block);
                if (rc != EOK)
                        return EIO;
        
+               ref->ea_size += sizeof(struct ext4_xattr_header);
                ref->block_loaded = true;
        } else
                ref->block_loaded = false;
@@ -431,6 +880,10 @@ int ext4_fs_get_xattr_ref(struct ext4_fs *fs,
        ref->inode_ref = inode_ref;
        ref->fs = fs;
 
+       if (ext4_xattr_inode_space(ref) >
+           sizeof(struct ext4_xattr_ibody_header))
+               ref->ea_size += sizeof(struct ext4_xattr_ibody_header);
+
        rc = ext4_xattr_fetch(ref);
        if (rc != EOK) {
                ext4_xattr_purge_items(ref);
@@ -445,6 +898,7 @@ int ext4_fs_get_xattr_ref(struct ext4_fs *fs,
 
 void ext4_fs_put_xattr_ref(struct ext4_xattr_ref *ref)
 {
+       ext4_xattr_write_to_disk(ref);
        if (ref->block_loaded) {
                ext4_block_set(ref->fs->bdev, &ref->block);
                ref->block_loaded = false;