Do not verify checksum upon seeking in the directory.

[lwext4.git] / lwext4 / ext4_xattr.c

diff --git a/lwext4/ext4_xattr.c b/lwext4/ext4_xattr.c
index e4e19fb39c4820d08b58e0a583b33a8eeb2b8b2a..d50f5cd25cd98946f726dd9683323915054a656d 100644 (file)
--- a/lwext4/ext4_xattr.c
+++ b/lwext4/ext4_xattr.c
@@ -40,11 +40,11 @@
 #include "ext4_errno.h"
 #include "ext4_blockdev.h"
 #include "ext4_super.h"
+#include "ext4_crc32c.h"
 #include "ext4_debug.h"
 #include "ext4_block_group.h"
 #include "ext4_balloc.h"
 #include "ext4_inode.h"
-#include "ext4_extent.h"
 
 #include <string.h>
 #include <stdlib.h>
@@ -112,6 +112,53 @@ static void ext4_xattr_rehash(struct ext4_xattr_header *header,
        header->h_hash = to_le32(hash);
 }
 
+#if CONFIG_META_CSUM_ENABLE
+static uint32_t
+ext4_xattr_block_checksum(struct ext4_inode_ref *inode_ref,
+                         ext4_fsblk_t blocknr,
+                         struct ext4_xattr_header *header)
+{
+       uint32_t checksum = 0;
+       uint64_t le64_blocknr = blocknr;
+       struct ext4_sblock *sb = &inode_ref->fs->sb;
+
+       if (ext4_sb_feature_ro_com(sb, EXT4_FRO_COM_METADATA_CSUM)) {
+               uint32_t orig_checksum;
+
+               /* Preparation: temporarily set bg checksum to 0 */
+               orig_checksum = header->h_checksum;
+               header->h_checksum = 0;
+               /* First calculate crc32 checksum against fs uuid */
+               checksum = ext4_crc32c(EXT4_CRC32_INIT, sb->uuid,
+                               sizeof(sb->uuid));
+               /* Then calculate crc32 checksum block number */
+               checksum = ext4_crc32c(checksum, &le64_blocknr,
+                                    sizeof(le64_blocknr));
+               /* Finally calculate crc32 checksum against 
+                * the entire xattr block */
+               checksum = ext4_crc32c(checksum, header,
+                                  ext4_sb_get_block_size(sb));
+               header->h_checksum = orig_checksum;
+       }
+       return checksum;
+}
+#else
+#define ext4_xattr_block_checksum(...) 0
+#endif
+
+static void
+ext4_xattr_set_block_checksum(struct ext4_inode_ref *inode_ref,
+                             ext4_fsblk_t blocknr __unused,
+                             struct ext4_xattr_header *header)
+{
+       struct ext4_sblock *sb = &inode_ref->fs->sb;
+       if (!ext4_sb_feature_ro_com(sb, EXT4_FRO_COM_METADATA_CSUM))
+               return;
+
+       header->h_checksum =
+               ext4_xattr_block_checksum(inode_ref, blocknr, header);
+}
+
 static int ext4_xattr_item_cmp(struct ext4_xattr_item *a,
                               struct ext4_xattr_item *b)
 {
@@ -466,12 +513,16 @@ static int ext4_xattr_try_alloc_block(struct ext4_xattr_ref *xattr_ref)
 {
        int ret = EOK;
 
-       uint64_t xattr_block = 0;
+       ext4_fsblk_t xattr_block = 0;
        xattr_block = ext4_inode_get_file_acl(xattr_ref->inode_ref->inode,
                                              &xattr_ref->fs->sb);
        if (!xattr_block) {
+               ext4_fsblk_t goal =
+                       ext4_fs_inode_to_goal_block(xattr_ref->inode_ref);
+
                ret = ext4_balloc_alloc_block(xattr_ref->inode_ref,
-                                             (uint32_t *)&xattr_block);
+                                             goal,
+                                             &xattr_block);
                if (ret != EOK)
                        goto Finish;
 
@@ -495,7 +546,7 @@ Finish:
 
 static void ext4_xattr_try_free_block(struct ext4_xattr_ref *xattr_ref)
 {
-       uint64_t xattr_block;
+       ext4_fsblk_t xattr_block;
        xattr_block = ext4_inode_get_file_acl(xattr_ref->inode_ref->inode,
                                              &xattr_ref->fs->sb);
        ext4_inode_set_file_acl(xattr_ref->inode_ref->inode, &xattr_ref->fs->sb,
@@ -655,6 +706,9 @@ static int ext4_xattr_write_to_disk(struct ext4_xattr_ref *xattr_ref)
        if (block_modified) {
                ext4_xattr_rehash(block_header,
                                  EXT4_XATTR_BFIRST(&xattr_ref->block));
+               ext4_xattr_set_block_checksum(xattr_ref->inode_ref,
+                                             xattr_ref->block.lb_id,
+                                             block_header);
                xattr_ref->block.dirty = true;
        }
 
@@ -699,7 +753,7 @@ int ext4_fs_set_xattr(struct ext4_xattr_ref *ref, uint8_t name_index,
            ext4_xattr_lookup_item(ref, name_index, name, name_len);
        if (replace) {
                if (!item) {
-                       ret = ENOATTR;
+                       ret = ENODATA;
                        goto Finish;
                }
                if (item->data_size != data_size)
@@ -739,7 +793,7 @@ int ext4_fs_get_xattr(struct ext4_xattr_ref *ref, uint8_t name_index,
            ext4_xattr_lookup_item(ref, name_index, name, name_len);
 
        if (!item) {
-               ret = ENOATTR;
+               ret = ENODATA;
                goto Finish;
        }
        item_size = item->data_size;
@@ -760,7 +814,7 @@ int ext4_fs_get_xattr_ref(struct ext4_fs *fs, struct ext4_inode_ref *inode_ref,
                          struct ext4_xattr_ref *ref)
 {
        int rc;
-       uint64_t xattr_block;
+       ext4_fsblk_t xattr_block;
        xattr_block = ext4_inode_get_file_acl(inode_ref->inode, &fs->sb);
        RB_INIT(&ref->root);
        ref->ea_size = 0;