Release me
[asdcplib.git] / src / AS_DCP_internal.h
index 8b05dc77d1c92ec159e0acb3f2b30478c05c233c..83272c09b431a8861ab0a0355abc0172d186d961 100755 (executable)
@@ -1,5 +1,5 @@
 /*
-Copyright (c) 2004-2013, John Hurst
+Copyright (c) 2004-2018, John Hurst
 All rights reserved.
 
 Redistribution and use in source and binary forms, with or without
@@ -47,6 +47,10 @@ using namespace ASDCP::MXF;
 #endif
 
 
+// uncomment to remove MXFGCGenericEssenceMultipleMappings from your AS-02 files
+// #define ASDCP_GCMULTI_PATCH
+
+
 #ifdef DEFAULT_MD_DECL
 ASDCP::MXF::OP1aHeader *g_OP1aHeader;
 ASDCP::MXF::OPAtomIndexFooter *g_OPAtomIndexFooter;
@@ -60,7 +64,6 @@ extern MXF::RIP *g_RIP;
 
 namespace ASDCP
 {
-  void default_md_object_init();
 
   //
   static std::vector<int>
@@ -74,14 +77,14 @@ namespace ASDCP
       {
        assert(r >= pstr);
        if ( r > pstr )
-         result.push_back(atoi(pstr));
+         result.push_back(strtol(pstr, 0, 10));
 
        pstr = r + 1;
        r = strchr(pstr, '.');
       }
 
     if( strlen(pstr) > 0 )
-      result.push_back(atoi(pstr));
+      result.push_back(strtol(pstr, 0, 10));
 
     assert(result.size() == 3);
     return result;
@@ -123,6 +126,21 @@ namespace ASDCP
   { 0x43, 0x48, 0x55, 0x4b, 0x43, 0x48, 0x55, 0x4b,
     0x43, 0x48, 0x55, 0x4b, 0x43, 0x48, 0x55, 0x4b };
 
+  // Version of MXF spec to which an MXF file conforms
+  enum MXFVersion
+  {
+    MXFVersion_2004,
+    MXFVersion_2011,
+    MXFVersion_MAX
+  };
+
+  // version numbers from the MXF spec, to be written into files
+  
+  ui8_t const MXF_ObjectModelVersion = 1;
+  ui8_t const MXF_2004_MinorVersion = 2;
+  ui8_t const MXF_2011_MinorVersion = 3;
+           
+
   //------------------------------------------------------------------------------------------
   //
 
@@ -134,32 +152,28 @@ namespace ASDCP
   Result_t EncryptFrameBuffer(const ASDCP::FrameBuffer&, ASDCP::FrameBuffer&, AESEncContext*);
   Result_t DecryptFrameBuffer(const ASDCP::FrameBuffer&, ASDCP::FrameBuffer&, AESDecContext*);
 
-  Result_t MD_to_JP2K_PDesc(const ASDCP::MXF::RGBAEssenceDescriptor&  EssenceDescriptor,
+  Result_t MD_to_JP2K_PDesc(const ASDCP::MXF::GenericPictureEssenceDescriptor&  EssenceDescriptor,
                            const ASDCP::MXF::JPEG2000PictureSubDescriptor& EssenceSubDescriptor,
                            const ASDCP::Rational& EditRate, const ASDCP::Rational& SampleRate,
                            ASDCP::JP2K::PictureDescriptor& PDesc);
 
   Result_t JP2K_PDesc_to_MD(const JP2K::PictureDescriptor& PDesc,
                            const ASDCP::Dictionary& dict,
-                           ASDCP::MXF::RGBAEssenceDescriptor *EssenceDescriptor,
-                           ASDCP::MXF::JPEG2000PictureSubDescriptor *EssenceSubDescriptor);
-
-  Result_t MD_to_JP2K_PDesc(const ASDCP::MXF::CDCIEssenceDescriptor&  EssenceDescriptor,
-                           const ASDCP::MXF::JPEG2000PictureSubDescriptor& EssenceSubDescriptor,
-                           const ASDCP::Rational& EditRate, const ASDCP::Rational& SampleRate,
-                           ASDCP::JP2K::PictureDescriptor& PDesc);
-
-  Result_t JP2K_PDesc_to_MD(const JP2K::PictureDescriptor& PDesc,
-                           const ASDCP::Dictionary& dict,
-                           ASDCP::MXF::CDCIEssenceDescriptor *EssenceDescriptor,
-                           ASDCP::MXF::JPEG2000PictureSubDescriptor *EssenceSubDescriptor);
+                           ASDCP::MXF::GenericPictureEssenceDescriptor& EssenceDescriptor,
+                           ASDCP::MXF::JPEG2000PictureSubDescriptor& EssenceSubDescriptor);
 
   Result_t PCM_ADesc_to_MD(PCM::AudioDescriptor& ADesc, ASDCP::MXF::WaveAudioDescriptor* ADescObj);
   Result_t MD_to_PCM_ADesc(ASDCP::MXF::WaveAudioDescriptor* ADescObj, PCM::AudioDescriptor& ADesc);
 
-  void     AddDMScrypt(Partition& HeaderPart, SourcePackage& Package,
+  void     AddDmsCrypt(Partition& HeaderPart, SourcePackage& Package,
                       WriterInfo& Descr, const UL& WrappingUL, const Dictionary*& Dict);
 
+  Result_t AddDmsTrackGenericPartUtf8Text(Kumu::FileWriter&, ASDCP::MXF::OP1aHeader&, SourcePackage&,
+                                         ASDCP::MXF::RIP&, const Dictionary*&);
+  //
+  Result_t WriteGenericStreamPartition(Kumu::FileWriter&, ASDCP::MXF::OP1aHeader&, ASDCP::MXF::RIP&, const Dictionary*&,
+                                      const ASDCP::FrameBuffer&, ASDCP::AESEncContext* = 0, ASDCP::HMACContext* = 0);
+  
   Result_t Read_EKLV_Packet(Kumu::FileReader& File, const ASDCP::Dictionary& Dict,
                            const ASDCP::WriterInfo& Info, Kumu::fpos_t& LastPosition, ASDCP::FrameBuffer& CtFrameBuf,
                            ui32_t FrameNum, ui32_t SequenceNum, ASDCP::FrameBuffer& FrameBuf,
@@ -168,6 +182,7 @@ namespace ASDCP
   Result_t Write_EKLV_Packet(Kumu::FileWriter& File, const ASDCP::Dictionary& Dict, const MXF::OP1aHeader& HeaderPart,
                             const ASDCP::WriterInfo& Info, ASDCP::FrameBuffer& CtFrameBuf, ui32_t& FramesWritten,
                             ui64_t & StreamOffset, const ASDCP::FrameBuffer& FrameBuf, const byte_t* EssenceUL,
+                            const ui32_t& MinEssenceElementBerLength,
                             AESEncContext* Ctx, HMACContext* HMAC);
 
   //
@@ -223,7 +238,7 @@ namespace ASDCP
        const MXF::RIP& GetRIP() const { return m_RIP; }
 
        //
-       Result_t OpenMXFRead(const char* filename)
+       Result_t OpenMXFRead(const std::string& filename)
        {
          m_LastPosition = 0;
          Result_t result = m_File.OpenRead(filename);
@@ -234,7 +249,7 @@ namespace ASDCP
          if ( ASDCP_SUCCESS(result) )
            {
              result = m_RIP.InitFromFile(m_File);
-             ui32_t test_s = m_RIP.PairArray.size();
+             ui32_t test_s = (ui32_t)m_RIP.PairArray.size();
 
              if ( ASDCP_FAILURE(result) )
                {
@@ -386,6 +401,70 @@ namespace ASDCP
          return RESULT_OK;
        }
 
+       // Reads a Generic Stream Partition payload. Returns RESULT_FORMAT if the SID is
+       // not present in the  RIP, or if the actual partition at ByteOffset does not have
+       // a matching BodySID value. Encryption is not currently supported.
+       Result_t ReadGenericStreamPartitionPayload(const ui32_t sid, ASDCP::FrameBuffer& frame_buf,
+                                                  AESDecContext* Ctx, HMACContext* HMAC)
+       {
+         Kumu::fpos_t start_offset = 0, end_offset = 0;
+         ui32_t sequence = 0;
+
+         // locate SID, record the offset
+         // Count the sequence length in because this is the sequence
+         // value needed to  complete the HMAC.
+         ASDCP::MXF::RIP::const_pair_iterator i;
+         for ( i = m_RIP.PairArray.begin(); i != m_RIP.PairArray.end(); ++i, ++sequence )
+           {
+             if ( sid == i->BodySID )
+               {
+                 start_offset = i->ByteOffset;
+               }
+             else if ( start_offset != 0 )
+               {
+                 end_offset = i->ByteOffset;
+                 break;
+               }
+           }
+
+         if ( start_offset == 0 || end_offset == 0 )
+           {
+             DefaultLogSink().Error("Body SID not found: %d.\n", sid);
+             return RESULT_NOT_FOUND;
+           }
+
+         // Read the Partition header and then read the payload.
+         Result_t result = m_File.Seek(start_offset);
+
+         if ( KM_SUCCESS(result) )
+           {
+             result = frame_buf.Capacity(end_offset-start_offset);
+           }
+    
+         if ( KM_SUCCESS(result) )
+           {
+             // read the partition header
+             ASDCP::MXF::Partition GSPart(m_Dict);
+             result = GSPart.InitFromFile(m_File);
+
+             if ( KM_SUCCESS(result) )
+               {
+                 // check the SID
+                 if ( GSPart.BodySID != sid )
+                   {
+                     DefaultLogSink().Error("Generic stream partition Body SID differs: %s\n", sid);
+                     result = RESULT_FORMAT;
+                   }
+                 else
+                   {
+                     result = ReadEKLVPacket(0, sequence, frame_buf, m_Dict->ul(MDD_GenericStream_DataElement), Ctx, HMAC);
+                   }
+               }
+           }
+  
+         return result;
+       }
+
        //
        void Close()
        {
@@ -511,6 +590,7 @@ namespace ASDCP
 
        MaterialPackage*   m_MaterialPackage;
        SourcePackage*     m_FilePackage;
+       ContentStorage*    m_ContentStorage;
 
        FileDescriptor*    m_EssenceDescriptor;
        std::list<InterchangeObject*> m_EssenceSubDescriptorList;
@@ -525,9 +605,9 @@ namespace ASDCP
        DurationElementList_t m_DurationUpdateList;
 
       TrackFileWriter(const Dictionary& d) :
-       m_Dict(&d), m_HeaderPart(m_Dict), m_RIP(m_Dict),
-         m_HeaderSize(0), m_EssenceDescriptor(0),
-         m_FramesWritten(0), m_StreamOffset(0)
+       m_Dict(&d), m_HeaderSize(0), m_HeaderPart(m_Dict), m_RIP(m_Dict),
+         m_MaterialPackage(0), m_FilePackage(0), m_ContentStorage(0),
+         m_EssenceDescriptor(0), m_FramesWritten(0), m_StreamOffset(0)
          {
            default_md_object_init();
          }
@@ -538,11 +618,11 @@ namespace ASDCP
 
        const MXF::RIP& GetRIP() const { return m_RIP; }
 
-       void InitHeader()
+       void InitHeader(const MXFVersion& mxf_ver)
        {
          assert(m_Dict);
          assert(m_EssenceDescriptor);
-
          m_HeaderPart.m_Primer.ClearTagList();
          m_HeaderPart.m_Preface = new Preface(m_Dict);
          m_HeaderPart.AddChildObject(m_HeaderPart.m_Preface);
@@ -552,6 +632,20 @@ namespace ASDCP
          m_HeaderPart.m_Preface->OperationalPattern = UL(m_Dict->ul(MDD_OP1a));
          m_HeaderPart.OperationalPattern = m_HeaderPart.m_Preface->OperationalPattern;
 
+         if ( mxf_ver == MXFVersion_2004 )
+           {
+             m_HeaderPart.MinorVersion = MXF_2004_MinorVersion;
+             m_HeaderPart.m_Preface->Version = ((MXF_ObjectModelVersion << 8) | MXF_2004_MinorVersion);
+             m_HeaderPart.m_Preface->ObjectModelVersion = MXF_ObjectModelVersion;
+           }
+         else
+           {
+             assert(mxf_ver == MXFVersion_2011);
+             m_HeaderPart.MinorVersion = MXF_2011_MinorVersion;
+             m_HeaderPart.m_Preface->Version = ((MXF_ObjectModelVersion << 8) | MXF_2011_MinorVersion);
+             m_HeaderPart.m_Preface->ObjectModelVersion = MXF_ObjectModelVersion;
+           }
+
          // Identification
          Identification* Ident = new Identification(m_Dict);
          m_HeaderPart.AddChildObject(Ident);
@@ -579,14 +673,16 @@ namespace ASDCP
                           const std::string& TrackName, const UL& EssenceUL,
                           const UL& DataDefinition, const std::string& PackageLabel)
        {
-         //
-         ContentStorage* Storage = new ContentStorage(m_Dict);
-         m_HeaderPart.AddChildObject(Storage);
-         m_HeaderPart.m_Preface->ContentStorage = Storage->InstanceUID;
+         if ( m_ContentStorage == 0 )
+           {
+             m_ContentStorage = new ContentStorage(m_Dict);
+             m_HeaderPart.AddChildObject(m_ContentStorage);
+             m_HeaderPart.m_Preface->ContentStorage = m_ContentStorage->InstanceUID;
+           }
 
          EssenceContainerData* ECD = new EssenceContainerData(m_Dict);
          m_HeaderPart.AddChildObject(ECD);
-         Storage->EssenceContainerData.push_back(ECD->InstanceUID);
+         m_ContentStorage->EssenceContainerData.push_back(ECD->InstanceUID);
          ECD->IndexSID = 129;
          ECD->BodySID = 1;
 
@@ -599,21 +695,25 @@ namespace ASDCP
          // Material Package
          //
          m_MaterialPackage = new MaterialPackage(m_Dict);
-         m_MaterialPackage->Name = "AS-DCP Material Package";
+         m_MaterialPackage->Name = "Material Package";
          m_MaterialPackage->PackageUID = MaterialPackageUMID;
          m_HeaderPart.AddChildObject(m_MaterialPackage);
-         Storage->Packages.push_back(m_MaterialPackage->InstanceUID);
+         m_ContentStorage->Packages.push_back(m_MaterialPackage->InstanceUID);
 
          TrackSet<TimecodeComponent> MPTCTrack =
            CreateTimecodeTrack<MaterialPackage>(m_HeaderPart, *m_MaterialPackage,
                                                 tc_edit_rate, TCFrameRate, 0, m_Dict);
+
+         MPTCTrack.Sequence->Duration.set_has_value();
          m_DurationUpdateList.push_back(&(MPTCTrack.Sequence->Duration.get()));
+         MPTCTrack.Clip->Duration.set_has_value();
          m_DurationUpdateList.push_back(&(MPTCTrack.Clip->Duration.get()));
 
          TrackSet<SourceClip> MPTrack =
            CreateTrackAndSequence<MaterialPackage, SourceClip>(m_HeaderPart, *m_MaterialPackage,
                                                                TrackName, clip_edit_rate, DataDefinition,
                                                                2, m_Dict);
+         MPTrack.Sequence->Duration.set_has_value();
          m_DurationUpdateList.push_back(&(MPTrack.Sequence->Duration.get()));
 
          MPTrack.Clip = new SourceClip(m_Dict);
@@ -622,6 +722,8 @@ namespace ASDCP
          MPTrack.Clip->DataDefinition = DataDefinition;
          MPTrack.Clip->SourcePackageID = SourcePackageUMID;
          MPTrack.Clip->SourceTrackID = 2;
+
+         MPTrack.Clip->Duration.set_has_value();
          m_DurationUpdateList.push_back(&(MPTrack.Clip->Duration.get()));
 
   
@@ -634,18 +736,23 @@ namespace ASDCP
          ECD->LinkedPackageUID = SourcePackageUMID;
 
          m_HeaderPart.AddChildObject(m_FilePackage);
-         Storage->Packages.push_back(m_FilePackage->InstanceUID);
+         m_ContentStorage->Packages.push_back(m_FilePackage->InstanceUID);
 
          TrackSet<TimecodeComponent> FPTCTrack =
            CreateTimecodeTrack<SourcePackage>(m_HeaderPart, *m_FilePackage,
-                                              tc_edit_rate, TCFrameRate,
-                                              ui64_C(3600) * TCFrameRate, m_Dict);
+                                              tc_edit_rate, TCFrameRate, 0, m_Dict);
+
+         FPTCTrack.Sequence->Duration.set_has_value();
          m_DurationUpdateList.push_back(&(FPTCTrack.Sequence->Duration.get()));
+         FPTCTrack.Clip->Duration.set_has_value();
          m_DurationUpdateList.push_back(&(FPTCTrack.Clip->Duration.get()));
+
          TrackSet<SourceClip> FPTrack =
            CreateTrackAndSequence<SourcePackage, SourceClip>(m_HeaderPart, *m_FilePackage,
                                                              TrackName, clip_edit_rate, DataDefinition,
                                                              2, m_Dict);
+
+         FPTrack.Sequence->Duration.set_has_value();
          m_DurationUpdateList.push_back(&(FPTrack.Sequence->Duration.get()));
 
          // Consult ST 379:2004 Sec. 6.3, "Element to track relationship" to see where "12" comes from.
@@ -659,94 +766,10 @@ namespace ASDCP
          // for now we do not allow setting this value, so all files will be 'original'
          FPTrack.Clip->SourceTrackID = 0;
          FPTrack.Clip->SourcePackageID = NilUMID;
-         m_DurationUpdateList.push_back(&(FPTrack.Clip->Duration.get()));
-
-         m_EssenceDescriptor->LinkedTrackID = FPTrack.Track->TrackID;
-       }
-
-       //
-       void AddDMSegment(const MXF::Rational& clip_edit_rate,
-                         const MXF::Rational& tc_edit_rate, ui32_t tc_frame_rate,
-                         const std::string& TrackName, const UL& DataDefinition,
-                         const std::string& PackageLabel)
-       {
-         //
-         ContentStorage* Storage = new ContentStorage(m_Dict);
-         m_HeaderPart.AddChildObject(Storage);
-         m_HeaderPart.m_Preface->ContentStorage = Storage->InstanceUID;
 
-         EssenceContainerData* ECD = new EssenceContainerData(m_Dict);
-         m_HeaderPart.AddChildObject(ECD);
-         Storage->EssenceContainerData.push_back(ECD->InstanceUID);
-         ECD->IndexSID = 129;
-         ECD->BodySID = 1;
-
-         UUID assetUUID(m_Info.AssetUUID);
-         UMID SourcePackageUMID, MaterialPackageUMID;
-         SourcePackageUMID.MakeUMID(0x0f, assetUUID);
-         MaterialPackageUMID.MakeUMID(0x0f); // unidentified essence
-
-         //
-         // Material Package
-         //
-         m_MaterialPackage = new MaterialPackage(m_Dict);
-         m_MaterialPackage->Name = "AS-DCP Material Package";
-         m_MaterialPackage->PackageUID = MaterialPackageUMID;
-         m_HeaderPart.AddChildObject(m_MaterialPackage);
-         Storage->Packages.push_back(m_MaterialPackage->InstanceUID);
-
-         TrackSet<TimecodeComponent> MPTCTrack =
-           CreateTimecodeTrack<MaterialPackage>(m_HeaderPart, *m_MaterialPackage,
-                                                tc_edit_rate, tc_frame_rate, 0, m_Dict);
-         m_DurationUpdateList.push_back(&(MPTCTrack.Sequence->Duration.get()));
-         m_DurationUpdateList.push_back(&(MPTCTrack.Clip->Duration.get()));
-
-         TrackSet<DMSegment> MPTrack =
-           CreateTrackAndSequence<MaterialPackage, DMSegment>(m_HeaderPart, *m_MaterialPackage,
-                                                              TrackName, clip_edit_rate, DataDefinition,
-                                                              2, m_Dict);
-         m_DurationUpdateList.push_back(&(MPTrack.Sequence->Duration.get()));
-
-         MPTrack.Clip = new DMSegment(m_Dict);
-         m_HeaderPart.AddChildObject(MPTrack.Clip);
-         MPTrack.Sequence->StructuralComponents.push_back(MPTrack.Clip->InstanceUID);
-         MPTrack.Clip->DataDefinition = DataDefinition;
-         //  MPTrack.Clip->SourcePackageID = SourcePackageUMID;
-         //  MPTrack.Clip->SourceTrackID = 2;
-         m_DurationUpdateList.push_back(&(MPTrack.Clip->Duration));
-
-  
-         //
-         // File (Source) Package
-         //
-         m_FilePackage = new SourcePackage(m_Dict);
-         m_FilePackage->Name = PackageLabel.c_str();
-         m_FilePackage->PackageUID = SourcePackageUMID;
-         ECD->LinkedPackageUID = SourcePackageUMID;
-
-         m_HeaderPart.AddChildObject(m_FilePackage);
-         Storage->Packages.push_back(m_FilePackage->InstanceUID);
-
-         TrackSet<TimecodeComponent> FPTCTrack =
-           CreateTimecodeTrack<SourcePackage>(m_HeaderPart, *m_FilePackage,
-                                              clip_edit_rate, tc_frame_rate,
-                                              ui64_C(3600) * tc_frame_rate, m_Dict);
-         m_DurationUpdateList.push_back(&(FPTCTrack.Sequence->Duration.get()));
-         m_DurationUpdateList.push_back(&(FPTCTrack.Clip->Duration.get()));
-
-         TrackSet<DMSegment> FPTrack =
-           CreateTrackAndSequence<SourcePackage, DMSegment>(m_HeaderPart, *m_FilePackage,
-                                                            TrackName, clip_edit_rate, DataDefinition,
-                                                            2, m_Dict);
-         m_DurationUpdateList.push_back(&(FPTrack.Sequence->Duration.get()));
-
-         FPTrack.Clip = new DMSegment(m_Dict);
-         m_HeaderPart.AddChildObject(FPTrack.Clip);
-         FPTrack.Sequence->StructuralComponents.push_back(FPTrack.Clip->InstanceUID);
-         FPTrack.Clip->DataDefinition = DataDefinition;
-         FPTrack.Clip->EventComment = "ST 429-5 Timed Text";
+         FPTrack.Clip->Duration.set_has_value();
+         m_DurationUpdateList.push_back(&(FPTrack.Clip->Duration.get()));
 
-         m_DurationUpdateList.push_back(&(FPTrack.Clip->Duration));
          m_EssenceDescriptor->LinkedTrackID = FPTrack.Track->TrackID;
        }
 
@@ -763,15 +786,18 @@ namespace ASDCP
          // Essence Descriptors
          //
          assert(m_Dict);
+#ifndef ASDCP_GCMULTI_PATCH
          UL GenericContainerUL(m_Dict->ul(MDD_GCMulti));
          m_HeaderPart.EssenceContainers.push_back(GenericContainerUL);
+#endif
 
          if ( m_Info.EncryptedEssence )
            {
              UL CryptEssenceUL(m_Dict->ul(MDD_EncryptedContainerLabel));
              m_HeaderPart.EssenceContainers.push_back(CryptEssenceUL);
              m_HeaderPart.m_Preface->DMSchemes.push_back(UL(m_Dict->ul(MDD_CryptographicFrameworkLabel)));
-             AddDMScrypt(m_HeaderPart, *m_FilePackage, m_Info, WrappingUL, m_Dict);
+             AddDmsCrypt(m_HeaderPart, *m_FilePackage, m_Info, WrappingUL, m_Dict);
+             //// TODO: fix DMSegment Duration value
            }
          else
            {
@@ -788,6 +814,48 @@ namespace ASDCP
          m_FilePackage->Descriptor = m_EssenceDescriptor->InstanceUID;
        }
 
+       Result_t AddDmsGenericPartUtf8Text(const ASDCP::FrameBuffer& frame_buffer,
+                                          ASDCP::AESEncContext* enc = 0, ASDCP::HMACContext* hmac = 0)
+       {
+         Kumu::fpos_t previous_partition_offset = m_RIP.PairArray.back().ByteOffset;
+         Result_t result = AddDmsTrackGenericPartUtf8Text(m_File, m_HeaderPart, *m_FilePackage, m_RIP, m_Dict);
+
+         if ( KM_SUCCESS(result) )
+           {
+             // m_RIP now contains an entry (at the back) for the new generic stream
+             // (this entry was created during the call to AddDmsTrackGenericPartUtf8Text())
+             if ( m_File.Tell() != m_RIP.PairArray.back().ByteOffset )
+               {
+                 DefaultLogSink().Error("File offset has moved since RIP modification. Unrecoverable error.\n");
+                 return RESULT_FAIL;
+               }
+         
+             // create generic stream partition header
+             static UL GenericStream_DataElement(m_Dict->ul(MDD_GenericStream_DataElement));
+             ASDCP::MXF::Partition GSPart(m_Dict);
+
+             GSPart.MajorVersion = m_HeaderPart.MajorVersion;
+             GSPart.MinorVersion = m_HeaderPart.MinorVersion;
+             GSPart.ThisPartition = m_RIP.PairArray.back().ByteOffset;
+             GSPart.PreviousPartition = previous_partition_offset;
+             GSPart.OperationalPattern = m_HeaderPart.OperationalPattern;
+             GSPart.BodySID = m_RIP.PairArray.back().BodySID;
+             GSPart.EssenceContainers = m_HeaderPart.EssenceContainers;
+
+             static UL gs_part_ul(m_Dict->ul(MDD_GenericStreamPartition));
+             Result_t result = GSPart.WriteToFile(m_File, gs_part_ul);
+         
+             if ( KM_SUCCESS(result) )
+               {
+                 result = Write_EKLV_Packet(m_File, *m_Dict, m_HeaderPart, m_Info, m_CtFrameBuf, m_FramesWritten,
+                                            m_StreamOffset, frame_buffer, GenericStream_DataElement.Value(),
+                                            MXF_BER_LENGTH, enc, hmac);
+               }
+           }
+
+         return result;
+       }
+
        //
        void Close()
        {
@@ -813,7 +881,7 @@ namespace ASDCP
       h__ASDCPReader(const Dictionary&);
       virtual ~h__ASDCPReader();
 
-      Result_t OpenMXFRead(const char* filename);
+      Result_t OpenMXFRead(const std::string& filename);
       Result_t ReadEKLVFrame(ui32_t FrameNum, ASDCP::FrameBuffer& FrameBuf,
                             const byte_t* EssenceUL, AESDecContext* Ctx, HMACContext* HMAC);
       Result_t LocateFrame(ui32_t FrameNum, Kumu::fpos_t& streamOffset,
@@ -841,6 +909,7 @@ namespace ASDCP
 
       Result_t CreateBodyPart(const MXF::Rational& EditRate, ui32_t BytesPerEditUnit = 0);
       Result_t WriteEKLVPacket(const ASDCP::FrameBuffer& FrameBuf,const byte_t* EssenceUL,
+                              const ui32_t& MinEssenceElementBerLength,
                               AESEncContext* Ctx, HMACContext* HMAC);
       Result_t WriteASDCPFooter();
     };