X-Git-Url: https://git.carlh.net/gitweb/?a=blobdiff_plain;ds=inline;f=src%2Flib%2Ffilm.cc;h=361daa8b6c0e03114aaa1cb59ae4a9cf02af9d01;hb=0ca36c0d2b238a9e2165b5d113c22f144835a672;hp=57a4decd1fe915d41cbac4c0b86c9417c14a55ce;hpb=d8ea1796f34ff894b148a0af78c0a547e0496ee1;p=dcpomatic.git

diff --git a/src/lib/film.cc b/src/lib/film.cc
index 57a4decd1..361daa8b6 100644
--- a/src/lib/film.cc
+++ b/src/lib/film.cc
@@ -151,7 +151,7 @@ Film::Film (optional<boost::filesystem::path> dir)
 	, _audio_processor (0)
 	, _reel_type (REELTYPE_SINGLE)
 	, _reel_length (2000000000)
-	, _upload_after_make_dcp (false)
+	, _upload_after_make_dcp (Config::instance()->default_upload_after_make_dcp())
 	, _state_version (current_state_version)
 	, _dirty (false)
 {
@@ -309,7 +309,7 @@ Film::make_dcp ()
 	}
 
 	if (name().empty()) {
-		throw MissingSettingError (_("name"));
+		set_name ("DCP");
 	}
 
 	BOOST_FOREACH (shared_ptr<const Content> i, content ()) {
@@ -514,7 +514,7 @@ Film::read_metadata (optional<boost::filesystem::path> path)
 }
 
 /** Given a directory name, return its full path within the Film's directory.
- *  @param d directory name within the Filn's directory.
+ *  @param d directory name within the Film's directory.
  *  @param create true to create the directory (and its parents) if they do not exist.
  */
 boost::filesystem::path
@@ -669,7 +669,7 @@ Film::isdcf_name (bool if_created_now) const
 
 	/* XXX: this uses the first bit of content only */
 
-	/* The standard says we don't do this for trailers, for some strange reason */
+	/* Interior aspect ratio.  The standard says we don't do this for trailers, for some strange reason */
 	if (dcp_content_type() && dcp_content_type()->libdcp_kind() != dcp::TRAILER) {
 		Ratio const * content_ratio = 0;
 		BOOST_FOREACH (shared_ptr<Content> i, content ()) {
@@ -685,7 +685,8 @@ Film::isdcf_name (bool if_created_now) const
 		}
 
 		if (content_ratio && content_ratio != container()) {
-			d += "-" + content_ratio->isdcf_name();
+			/* This needs to be the numeric version of the ratio, and ::id() is close enough */
+			d += "-" + content_ratio->id();
 		}
 	}
 
@@ -1027,24 +1028,27 @@ Film::content () const
 	return _playlist->content ();
 }
 
+/** @param content Content to add.
+ *  @param disable_audio_analysis true to never do automatic audio analysis, even if it is enabled in configuration.
+ */
 void
-Film::examine_and_add_content (shared_ptr<Content> c)
+Film::examine_and_add_content (shared_ptr<Content> content, bool disable_audio_analysis)
 {
-	if (dynamic_pointer_cast<FFmpegContent> (c) && _directory) {
-		run_ffprobe (c->path(0), file ("ffprobe.log"), _log);
+	if (dynamic_pointer_cast<FFmpegContent> (content) && _directory) {
+		run_ffprobe (content->path(0), file ("ffprobe.log"), _log);
 	}
 
-	shared_ptr<Job> j (new ExamineContentJob (shared_from_this(), c));
+	shared_ptr<Job> j (new ExamineContentJob (shared_from_this(), content));
 
 	_job_connections.push_back (
-		j->Finished.connect (bind (&Film::maybe_add_content, this, weak_ptr<Job> (j), weak_ptr<Content> (c)))
+		j->Finished.connect (bind (&Film::maybe_add_content, this, weak_ptr<Job>(j), weak_ptr<Content>(content), disable_audio_analysis))
 		);
 
 	JobManager::instance()->add (j);
 }
 
 void
-Film::maybe_add_content (weak_ptr<Job> j, weak_ptr<Content> c)
+Film::maybe_add_content (weak_ptr<Job> j, weak_ptr<Content> c, bool disable_audio_analysis)
 {
 	shared_ptr<Job> job = j.lock ();
 	if (!job || !job->finished_ok ()) {
@@ -1058,7 +1062,7 @@ Film::maybe_add_content (weak_ptr<Job> j, weak_ptr<Content> c)
 
 	add_content (content);
 
-	if (Config::instance()->automatic_audio_analysis() && content->audio) {
+	if (Config::instance()->automatic_audio_analysis() && content->audio && !disable_audio_analysis) {
 		shared_ptr<Playlist> playlist (new Playlist);
 		playlist->add (content);
 		boost::signals2::connection c;
@@ -1083,7 +1087,7 @@ Film::add_content (shared_ptr<Content> c)
 		/* Take settings from the first piece of content of c's type in _template */
 		BOOST_FOREACH (shared_ptr<Content> i, _template_film->content()) {
 			if (typeid(i.get()) == typeid(c.get())) {
-				c->use_template (i);
+				c->take_settings_from (i);
 			}
 		}
 	}
@@ -1113,7 +1117,7 @@ Film::move_content_later (shared_ptr<Content> c)
 DCPTime
 Film::length () const
 {
-	return _playlist->length ();
+	return _playlist->length().ceil(video_frame_rate());
 }
 
 int
@@ -1456,7 +1460,7 @@ list<DCPTimePeriod>
 Film::reels () const
 {
 	list<DCPTimePeriod> p;
-	DCPTime const len = length().ceil (video_frame_rate ());
+	DCPTime const len = length();
 
 	switch (reel_type ()) {
 	case REELTYPE_SINGLE: