X-Git-Url: https://git.carlh.net/gitweb/?a=blobdiff_plain;f=gtk2_ardour%2Fport_matrix_column_labels.cc;h=04b57c404fc1994b8923106a851f38f2f1562f52;hb=e827bb2bff271f99abd3531ddd0e5a01c8ac5014;hp=ac4e1fef45236355ab4ef23b3a3bfb63c60e965b;hpb=9998ce310d81e0d16488a694902d296cde4a8ff7;p=ardour.git

diff --git a/gtk2_ardour/port_matrix_column_labels.cc b/gtk2_ardour/port_matrix_column_labels.cc
index ac4e1fef45..04b57c404f 100644
--- a/gtk2_ardour/port_matrix_column_labels.cc
+++ b/gtk2_ardour/port_matrix_column_labels.cc
@@ -39,9 +39,8 @@ PortMatrixColumnLabels::PortMatrixColumnLabels (PortMatrix* m, PortMatrixBody* b
 void
 PortMatrixColumnLabels::compute_dimensions ()
 {
-	GdkPixmap* pm = gdk_pixmap_new (NULL, 1, 1, 24);
-	gdk_drawable_set_colormap (pm, gdk_colormap_get_system());
-	cairo_t* cr = gdk_cairo_create (pm);
+	cairo_surface_t* surface = cairo_image_surface_create (CAIRO_FORMAT_RGB24, 200, 200);
+	cairo_t* cr = cairo_create (surface);
 
 	/* width of the longest bundle name */
 	_longest_bundle_name = 0;
@@ -95,7 +94,7 @@ PortMatrixColumnLabels::compute_dimensions ()
 	}
 
 	cairo_destroy (cr);
-	g_object_unref (pm);
+	cairo_surface_destroy (surface);
 
 	/* height of the whole thing */
 
@@ -133,25 +132,15 @@ PortMatrixColumnLabels::render (cairo_t* cr)
 	PortGroup::BundleList const & bundles = _matrix->visible_columns()->bundles ();
 	for (PortGroup::BundleList::const_iterator i = bundles.begin (); i != bundles.end(); ++i) {
 
-		bool should_show_this_bundle = false;
-		for (uint32_t j = 0; j < (*i)->bundle->nchannels().n_total(); ++j) {
-			if (_matrix->should_show ((*i)->bundle->channel_type (j))) {
-				should_show_this_bundle = true;
-				break;
-			}
-		}
-
-		if (should_show_this_bundle) {
-			Gdk::Color c = (*i)->has_colour ? (*i)->colour : get_a_bundle_colour (N);
-			render_bundle_name (cr, background_colour (), c, x, 0, (*i)->bundle);
-		}
+		Gdk::Color c = (*i)->has_colour ? (*i)->colour : get_a_bundle_colour (N);
+		render_bundle_name (cr, background_colour (), c, x, 0, (*i)->bundle);
 
 		if (_matrix->show_only_bundles()) {
 			x += grid_spacing();
 		} else {
-			x += _matrix->count_of_our_type ((*i)->bundle->nchannels()) * grid_spacing();
+			x += _matrix->count_of_our_type_min_1 ((*i)->bundle->nchannels()) * grid_spacing();
 		}
-		
+
 		++N;
 	}
 
@@ -163,17 +152,24 @@ PortMatrixColumnLabels::render (cairo_t* cr)
 
 		for (PortGroup::BundleList::const_iterator i = bundles.begin (); i != bundles.end(); ++i) {
 
-			for (uint32_t j = 0; j < (*i)->bundle->nchannels().n_total(); ++j) {
+			uint32_t const C = _matrix->count_of_our_type ((*i)->bundle->nchannels ());
 
-				if (!_matrix->should_show ((*i)->bundle->channel_type(j))) {
-					continue;
-				}
-				
+			for (uint32_t j = 0; j < C; ++j) {
 				Gdk::Color c = (*i)->has_colour ? (*i)->colour : get_a_bundle_colour (N);
-				render_channel_name (cr, background_colour (), c, x, 0, ARDOUR::BundleChannel ((*i)->bundle, j));
+
+				ARDOUR::BundleChannel bc (
+					(*i)->bundle,
+					(*i)->bundle->type_channel_to_overall (_matrix->type (), j)
+					);
+				
+				render_channel_name (cr, background_colour (), c, x, 0, bc);
 				x += grid_spacing();
 			}
-			
+
+			if (C == 0) {
+				x += grid_spacing ();
+			}
+
 			++N;
 		}
 	}
@@ -213,8 +209,8 @@ PortMatrixColumnLabels::mouseover_changed (list<PortMatrixNode> const &)
 
 		ARDOUR::BundleChannel c = i->column;
 		ARDOUR::BundleChannel r = i->row;
-		
-		if (c.bundle && r.bundle) {
+
+		if (PortMatrix::bundle_with_channels (c.bundle) && PortMatrix::bundle_with_channels (r.bundle)) {
 			add_channel_highlight (c);
 		} else if (c.bundle) {
 			_body->highlight_associated_channels (_matrix->column_index(), c);
@@ -273,7 +269,7 @@ PortMatrixColumnLabels::render_bundle_name (
 	if (_matrix->show_only_bundles()) {
 		w = grid_spacing ();
 	} else {
-		w = _matrix->count_of_our_type (b->nchannels()) * grid_spacing();
+		w = _matrix->count_of_our_type_min_1 (b->nchannels()) * grid_spacing();
 	}
 
 	double x_ = xoff;
@@ -359,7 +355,7 @@ PortMatrixColumnLabels::render_channel_name (
 			xoff + grid_spacing() - q * sin (angle ()),
 			yoff + _height - q * cos (angle ())
 			);
-				
+
 
 	} else {
 
@@ -375,15 +371,15 @@ PortMatrixColumnLabels::render_channel_name (
 
 		/* only plot the name if the bundle has more than one channel;
 		   the name of a single channel is assumed to be redundant */
-		
+
 		cairo_save (cr);
 		cairo_rotate (cr, -angle());
-		
+
 		cairo_show_text (
 			cr,
 			bc.bundle->channel_name(bc.channel).c_str()
 			);
-		
+
 		cairo_restore (cr);
 	}
 }
@@ -494,12 +490,11 @@ PortMatrixColumnLabels::motion (double x, double y)
 		) {
 
 		/* if the mouse is over a bundle name, highlight all channels in the bundle */
-		
+
 		list<PortMatrixNode> n;
 
 		for (uint32_t i = 0; i < w.bundle->nchannels().n_total(); ++i) {
-
-			if (!_matrix->should_show (w.bundle->channel_type(i))) {
+			if (!_matrix->should_show (w.bundle->channel_type (i))) {
 				continue;
 			}
 			
@@ -510,7 +505,7 @@ PortMatrixColumnLabels::motion (double x, double y)
 		_body->set_mouseover (n);
 
 	} else {
-	
+
 		_body->set_mouseover (PortMatrixNode (ARDOUR::BundleChannel (), w));
 	}
-}	
+}