X-Git-Url: https://git.carlh.net/gitweb/?a=blobdiff_plain;f=gtk2_ardour%2Ftempo_dialog.cc;h=0b570abdaa2fcc780de2b5dc78beb8ee8411db21;hb=1918fe43fa31f45251601891b911d038518c66e1;hp=a96958136910827123c3630fa8240e5db65627df;hpb=7815aa1e89e07e2785d6995b94a28a72a96c74cb;p=ardour.git

diff --git a/gtk2_ardour/tempo_dialog.cc b/gtk2_ardour/tempo_dialog.cc
index a969581369..0b570abdaa 100644
--- a/gtk2_ardour/tempo_dialog.cc
+++ b/gtk2_ardour/tempo_dialog.cc
@@ -23,9 +23,8 @@
 
 #include "gtkmm2ext/utils.h"
 
-#include "ardour/rc_configuration.h"
-
 #include "tempo_dialog.h"
+#include "ui_config.h"
 
 #include "i18n.h"
 
@@ -73,6 +72,7 @@ TempoDialog::init (const Timecode::BBT_Time& when, double bpm, double note_type,
 	bpm_spinner.set_digits (2);
 	bpm_spinner.set_wrap (true);
 	bpm_spinner.set_value (bpm);
+	bpm_spinner.set_alignment (1.0);
 
 	note_types.insert (make_pair (_("whole"), 1.0));
 	strings.push_back (_("whole"));
@@ -105,10 +105,10 @@ TempoDialog::init (const Timecode::BBT_Time& when, double bpm, double note_type,
 	if (x == note_types.end()) {
 		pulse_selector.set_active_text (strings[3]); // "quarter"
 	}
-	
+
 	Table* table;
 
-	if (Config->get_allow_non_quarter_pulse()) {
+	if (UIConfiguration::instance().get_allow_non_quarter_pulse()) {
 		table = manage (new Table (5, 5));
 	} else {
 		table = manage (new Table (5, 4));
@@ -122,7 +122,7 @@ TempoDialog::init (const Timecode::BBT_Time& when, double bpm, double note_type,
 	table->attach (*bpm_label, 0, 1, 0, 1);
 	table->attach (bpm_spinner, 1, 5, 0, 1);
 
-	if (Config->get_allow_non_quarter_pulse()) {
+	if (UIConfiguration::instance().get_allow_non_quarter_pulse()) {
 		table->attach (pulse_selector_label, 0, 1, 1, 2);
 		table->attach (pulse_selector, 1, 5, 1, 2);
 		row = 2;
@@ -130,16 +130,18 @@ TempoDialog::init (const Timecode::BBT_Time& when, double bpm, double note_type,
 		row = 1;
 	}
 
-	if (movable) {
-		char buf[64];
+	char buf[64];
 
-		snprintf (buf, sizeof (buf), "%" PRIu32, when.bars);
-		when_bar_entry.set_text (buf);
-		snprintf (buf, sizeof (buf), "%" PRIu32, when.beats);
-		when_beat_entry.set_text (buf);
+	snprintf (buf, sizeof (buf), "%" PRIu32, when.bars);
+	when_bar_entry.set_text (buf);
+	snprintf (buf, sizeof (buf), "%" PRIu32, when.beats);
+	when_beat_entry.set_text (buf);
 
+	if (movable) {
 		when_bar_entry.set_width_chars(4);
 		when_beat_entry.set_width_chars (4);
+		when_bar_entry.set_alignment (1.0);
+		when_beat_entry.set_alignment (1.0);
 
 		when_bar_label.set_name ("MetricLabel");
 		when_beat_label.set_name ("MetricLabel");
@@ -160,12 +162,13 @@ TempoDialog::init (const Timecode::BBT_Time& when, double bpm, double note_type,
 
 	add_button (Stock::CANCEL, RESPONSE_CANCEL);
 	add_button (Stock::APPLY, RESPONSE_ACCEPT);
-	set_response_sensitive (RESPONSE_ACCEPT, false);
+	set_response_sensitive (RESPONSE_ACCEPT, true);
 	set_default_response (RESPONSE_ACCEPT);
 
 	bpm_spinner.show ();
 	tap_tempo_button.show ();
 	get_vbox()->pack_end (tap_tempo_button);
+	bpm_spinner.grab_focus ();
 
 	set_name ("MetricDialog");
 
@@ -178,13 +181,24 @@ TempoDialog::init (const Timecode::BBT_Time& when, double bpm, double note_type,
 	when_beat_entry.signal_activate().connect (sigc::bind (sigc::mem_fun (*this, &TempoDialog::response), RESPONSE_ACCEPT));
 	when_beat_entry.signal_key_release_event().connect (sigc::mem_fun (*this, &TempoDialog::entry_key_release), false);
 	pulse_selector.signal_changed().connect (sigc::mem_fun (*this, &TempoDialog::pulse_change));
-	tap_tempo_button.signal_clicked().connect (sigc::mem_fun (*this, &TempoDialog::tap_tempo));
+	tap_tempo_button.signal_button_press_event().connect (sigc::mem_fun (*this, &TempoDialog::tap_tempo_button_press), false);
+	tap_tempo_button.signal_focus_out_event().connect (sigc::mem_fun (*this, &TempoDialog::tap_tempo_focus_out));
+
+	tapped = false;
+}
+
+bool
+TempoDialog::is_user_input_valid() const
+{
+	return (when_beat_entry.get_text() != "")
+		&& (when_bar_entry.get_text() != "")
+		&& (when_bar_entry.get_text() != "0");
 }
 
 void
 TempoDialog::bpm_changed ()
 {
-	set_response_sensitive (RESPONSE_ACCEPT, true);
+	set_response_sensitive (RESPONSE_ACCEPT, is_user_input_valid());
 }
 
 bool
@@ -198,18 +212,14 @@ TempoDialog::bpm_button_release (GdkEventButton*)
 {
 	/* the value has been modified, accept should work now */
 
-	set_response_sensitive (RESPONSE_ACCEPT, true);
+	set_response_sensitive (RESPONSE_ACCEPT, is_user_input_valid());
 	return false;
 }
 
 bool
 TempoDialog::entry_key_release (GdkEventKey*)
 {
-	if (when_beat_entry.get_text() != "" && when_bar_entry.get_text() != "") {
-	        set_response_sensitive (RESPONSE_ACCEPT, true);
-	} else {
-	        set_response_sensitive (RESPONSE_ACCEPT, false);
-	}
+	set_response_sensitive (RESPONSE_ACCEPT, is_user_input_valid());
 	return false;
 }
 
@@ -239,7 +249,7 @@ double
 TempoDialog::get_note_type ()
 {
 	NoteTypes::iterator x = note_types.find (pulse_selector.get_active_text());
-	
+
 	if (x == note_types.end()) {
 		error << string_compose(_("incomprehensible pulse note type (%1)"), pulse_selector.get_active_text()) << endmsg;
 		return 0;
@@ -251,45 +261,61 @@ TempoDialog::get_note_type ()
 void
 TempoDialog::pulse_change ()
 {
-        set_response_sensitive (RESPONSE_ACCEPT, true);
+	set_response_sensitive (RESPONSE_ACCEPT, is_user_input_valid());
 }
 
-void
-TempoDialog::tap_tempo ()
+bool
+TempoDialog::tap_tempo_button_press (GdkEventButton *ev)
 {
 	gint64 now;
 	now = g_get_monotonic_time (); // microseconds
 
-	if (last_tap > 0) {
+	if (tapped) {
 		double interval, bpm;
 		static const double decay = 0.5;
 
 		interval = (now - last_tap) * 1.0e-6;
 		if (interval <= 6.0) {
-			// >= 10 bpm, say
+			// <= 6 seconds (say): >= 10 bpm
 			if (average_interval > 0) {
+				if (average_interval > interval / 1.2 && average_interval < interval * 1.2) {
 				average_interval = interval * decay
 					+ average_interval * (1.0-decay);
+				} else {
+					average_interval = 0;
+				}
 			} else {
 				average_interval = interval;
 			}
 
-			bpm = 60.0 / average_interval;
-			bpm_spinner.set_value (bpm);
+			if (average_interval > 0) {
+				bpm = 60.0 / average_interval;
+				bpm_spinner.set_value (bpm);
+			}
 		} else {
 			average_interval = 0;
 		}
 	} else {
 		average_interval = 0;
+		tapped = true;
 	}
 	last_tap = now;
+
+	return true;
+}
+
+bool
+TempoDialog::tap_tempo_focus_out (GdkEventFocus* )
+{
+	tapped = false;
+	return false;
 }
 
 MeterDialog::MeterDialog (TempoMap& map, framepos_t frame, const string&)
 	: ArdourDialog (_("New Meter"))
 {
 	Timecode::BBT_Time when;
-	frame = map.round_to_bar(frame,0);
+	frame = map.round_to_bar(frame, RoundNearest);
 	Meter meter (map.meter_at(frame));
 
 	map.bbt_time (frame, when);
@@ -312,6 +338,7 @@ MeterDialog::init (const Timecode::BBT_Time& when, double bpb, double divisor, b
 	snprintf (buf, sizeof (buf), "%.2f", bpb);
 	bpb_entry.set_text (buf);
 	bpb_entry.select_region (0, -1);
+	bpb_entry.set_alignment (1.0);
 
 	note_types.insert (make_pair (_("whole"), 1.0));
 	strings.push_back (_("whole"));
@@ -340,7 +367,7 @@ MeterDialog::init (const Timecode::BBT_Time& when, double bpb, double divisor, b
 			break;
 		}
 	}
-	
+
 	if (x == note_types.end()) {
 		note_type.set_active_text (strings[3]); // "quarter"
 	}
@@ -355,18 +382,15 @@ MeterDialog::init (const Timecode::BBT_Time& when, double bpb, double divisor, b
 	table->attach (*note_label, 0, 1, 1, 2, FILL|EXPAND, FILL|EXPAND);
 	table->attach (note_type, 1, 2, 1, 2, FILL|EXPAND, SHRINK);
 
-	if (movable) {
-		char buf[64];
-
-		snprintf (buf, sizeof (buf), "%" PRIu32, when.bars);
-		when_bar_entry.set_text (buf);
+	snprintf (buf, sizeof (buf), "%" PRIu32, when.bars);
+	when_bar_entry.set_text (buf);
+	when_bar_entry.set_alignment (1.0);
 
+	if (movable) {
 		Label* when_label = manage (new Label(_("Meter begins at bar:"), ALIGN_LEFT, ALIGN_CENTER));
 
 		table->attach (*when_label, 0, 1, 2, 3, FILL | EXPAND, FILL | EXPAND);
 		table->attach (when_bar_entry, 1, 2, 2, 3, FILL | EXPAND, FILL | EXPAND);
-	} else {
-		when_bar_entry.set_text ("0");
 	}
 
 	get_vbox()->set_border_width (12);
@@ -374,7 +398,7 @@ MeterDialog::init (const Timecode::BBT_Time& when, double bpb, double divisor, b
 
 	add_button (Stock::CANCEL, RESPONSE_CANCEL);
 	add_button (Stock::APPLY, RESPONSE_ACCEPT);
-	set_response_sensitive (RESPONSE_ACCEPT, false);
+	set_response_sensitive (RESPONSE_ACCEPT, true);
 	set_default_response (RESPONSE_ACCEPT);
 
 	get_vbox()->show_all ();
@@ -389,6 +413,14 @@ MeterDialog::init (const Timecode::BBT_Time& when, double bpb, double divisor, b
 	note_type.signal_changed().connect (sigc::mem_fun (*this, &MeterDialog::note_type_change));
 }
 
+bool
+MeterDialog::is_user_input_valid() const
+{
+	return (when_bar_entry.get_text() != "")
+		&& (when_bar_entry.get_text() != "0")
+		&& (bpb_entry.get_text() != "");
+}
+
 bool
 MeterDialog::entry_key_press (GdkEventKey* ev)
 {
@@ -440,18 +472,14 @@ MeterDialog::entry_key_press (GdkEventKey* ev)
 bool
 MeterDialog::entry_key_release (GdkEventKey*)
 {
-        if (when_bar_entry.get_text() != "" && bpb_entry.get_text() != "") {
-	        set_response_sensitive (RESPONSE_ACCEPT, true);
-	} else {
-	        set_response_sensitive (RESPONSE_ACCEPT, false);
-	}
+	set_response_sensitive (RESPONSE_ACCEPT, is_user_input_valid());
 	return false;
 }
 
 void
 MeterDialog::note_type_change ()
 {
-        set_response_sensitive (RESPONSE_ACCEPT, true);
+        set_response_sensitive (RESPONSE_ACCEPT, is_user_input_valid());
 }
 
 double
@@ -470,7 +498,7 @@ double
 MeterDialog::get_note_type ()
 {
 	NoteTypes::iterator x = note_types.find (note_type.get_active_text());
-	
+
 	if (x == note_types.end()) {
 		error << string_compose(_("incomprehensible meter note type (%1)"), note_type.get_active_text()) << endmsg;
 		return 0;