X-Git-Url: https://git.carlh.net/gitweb/?a=blobdiff_plain;f=libs%2Fardour%2Fplaylist_source.cc;h=c27652851b22dc4f764c9a9a4a64cfab58327cf6;hb=d6c47def098ebf6c44e1b3e0ca2166d1c990e7d3;hp=7bbfdecd822efb4b2cd8edb922633336babe9251;hpb=d6be900da002cde17570e742bcc48f1588f73dc9;p=ardour.git

diff --git a/libs/ardour/playlist_source.cc b/libs/ardour/playlist_source.cc
index 7bbfdecd82..c27652851b 100644
--- a/libs/ardour/playlist_source.cc
+++ b/libs/ardour/playlist_source.cc
@@ -27,24 +27,21 @@
 #include <glibmm/miscutils.h>
 
 #include "pbd/error.h"
-#include "pbd/convert.h"
+#include "pbd/types_convert.h"
 #include "pbd/enumwriter.h"
 
 #include "ardour/playlist.h"
 #include "ardour/playlist_source.h"
 #include "ardour/playlist_factory.h"
-#include "ardour/session.h"
-#include "ardour/session_playlists.h"
-#include "ardour/source_factory.h"
 
-#include "i18n.h"
+#include "pbd/i18n.h"
 
 using namespace std;
 using namespace ARDOUR;
 using namespace PBD;
 
 PlaylistSource::PlaylistSource (Session& s, const ID& orig, const std::string& name, boost::shared_ptr<Playlist> p, DataType type,
-				frameoffset_t begin, framecnt_t len, Source::Flag flags)
+				frameoffset_t begin, framecnt_t len, Source::Flag /*flags*/)
 	: Source (s, type, name)
 	, _playlist (p)
 	, _original (orig)
@@ -64,7 +61,7 @@ PlaylistSource::PlaylistSource (Session& s, const XMLNode& node)
 {
 	/* PlaylistSources are never writable, renameable, removable or destructive */
 	_flags = Flag (_flags & ~(Writable|CanRename|Removable|RemovableIfEmpty|RemoveAtDestroy|Destructive));
-	
+
 
 	if (set_state (node, Stateful::loading_state_version)) {
 		throw failed_constructor ();
@@ -78,25 +75,20 @@ PlaylistSource::~PlaylistSource ()
 void
 PlaylistSource::add_state (XMLNode& node)
 {
-	char buf[64];
-
-	_playlist->id().print (buf, sizeof (buf));
-	node.add_property ("playlist", buf);
-	snprintf (buf, sizeof (buf), "%" PRIi64, _playlist_offset);
-	node.add_property ("offset", buf);
-	snprintf (buf, sizeof (buf), "%" PRIu64, _playlist_length);
-	node.add_property ("length", buf);
-	node.add_property ("original", _id.to_s());
-	
+	node.set_property ("playlist", _playlist->id ());
+	node.set_property ("offset", _playlist_offset);
+	node.set_property ("length", _playlist_length);
+	node.set_property ("original", id());
+
 	node.add_child_nocopy (_playlist->get_state());
 }
 
 int
-PlaylistSource::set_state (const XMLNode& node, int version) 
+PlaylistSource::set_state (const XMLNode& node, int /*version*/)
 {
 	/* check that we have a playlist ID */
 
-	const XMLProperty *prop = node.property (X_("playlist"));
+	XMLProperty const * prop = node.property (X_("playlist"));
 
 	if (!prop) {
 		error << _("No playlist ID in PlaylistSource XML!") << endmsg;
@@ -118,34 +110,37 @@ PlaylistSource::set_state (const XMLNode& node, int version)
 	}
 
 	if (!_playlist) {
-		error << _("No playlist node in PlaylistSource XML!") << endmsg;
+		error << _("Could not construct playlist for PlaylistSource from session data!") << endmsg;
 		throw failed_constructor ();
 	}
 
 	/* other properties */
 
-	if ((prop = node.property (X_("name"))) == 0) {
+	std::string name;
+	if (!node.get_property (X_("name"), name)) {
 		throw failed_constructor ();
 	}
-	
-	set_name (prop->value());
 
-	if ((prop = node.property (X_("offset"))) == 0) {
+	set_name (name);
+
+	if (!node.get_property (X_("offset"), _playlist_offset)) {
 		throw failed_constructor ();
 	}
-	sscanf (prop->value().c_str(), "%" PRIi64, &_playlist_offset);
 
-	if ((prop = node.property (X_("length"))) == 0) {
+	if (!node.get_property (X_("length"), _playlist_length)) {
 		throw failed_constructor ();
 	}
 
-	sscanf (prop->value().c_str(), "%" PRIu64, &_playlist_length);
+	/* XXX not quite sure why we set our ID back to the "original" one
+	   here. october 2011, paul
+	*/
 
-	if ((prop = node.property (X_("original"))) == 0) {
+	std::string str;
+	if (!node.get_property (X_("original"), str)) {
 		throw failed_constructor ();
 	}
 
-	_id = prop->value();
+	set_id (str);
 
 	_level = _playlist->max_source_level () + 1;