X-Git-Url: https://git.carlh.net/gitweb/?a=blobdiff_plain;f=src%2Flib%2Fbutler.h;h=6bb0467af1f526ed5670dde6237511c47cc0f8df;hb=2b0e9dd97a5773f52eba5704903b82e90f4c6f63;hp=cd3891754be508c51603b8b343e3069a3a95481a;hpb=3799e91d126d243d41c44dcb0ca1bfa66b53a57e;p=dcpomatic.git

diff --git a/src/lib/butler.h b/src/lib/butler.h
index cd3891754..6bb0467af 100644
--- a/src/lib/butler.h
+++ b/src/lib/butler.h
@@ -19,11 +19,16 @@
 */
 
 
+#ifndef DCPOMATIC_BUTLER_H
+#define DCPOMATIC_BUTLER_H
+
+
 #include "audio_mapping.h"
 #include "audio_ring_buffers.h"
 #include "change_signaller.h"
 #include "exception_store.h"
 #include "text_ring_buffers.h"
+#include "text_type.h"
 #include "video_ring_buffers.h"
 #include <boost/asio.hpp>
 #include <boost/signals2.hpp>
@@ -38,16 +43,23 @@ class PlayerVideo;
 class Butler : public ExceptionStore
 {
 public:
+	enum class Audio
+	{
+		ENABLED,
+		DISABLED
+	};
+
 	Butler (
 		std::weak_ptr<const Film> film,
-		std::shared_ptr<Player> player,
+		Player& player,
 		AudioMapping map,
 		int audio_channels,
 		std::function<AVPixelFormat (AVPixelFormat)> pixel_format,
 		VideoRange video_range,
 		Image::Alignment alignment,
 		bool fast,
-		bool prepare_only_proxy
+		bool prepare_only_proxy,
+		Audio audio
 		);
 
 	~Butler ();
@@ -59,28 +71,27 @@ public:
 
 	class Error {
 	public:
-		enum Code{
+		enum class Code {
 			NONE,
 			AGAIN,
 			DIED,
 			FINISHED
 		};
 
-		Error()
-			: code (NONE)
-		{}
-
-		Code code;
+		Code code = Code::NONE;
 		std::string message;
 
 		std::string summary () const;
 	};
 
-	std::pair<std::shared_ptr<PlayerVideo>, dcpomatic::DCPTime> get_video (bool blocking, Error* e = 0);
-	boost::optional<dcpomatic::DCPTime> get_audio (float* out, Frame frames);
-	boost::optional<TextRingBuffers::Data> get_closed_caption ();
+	enum class Behaviour {
+		BLOCKING,
+		NON_BLOCKING
+	};
 
-	void disable_audio ();
+	std::pair<std::shared_ptr<PlayerVideo>, dcpomatic::DCPTime> get_video (Behaviour behaviour, Error* e = nullptr);
+	boost::optional<dcpomatic::DCPTime> get_audio (Behaviour behaviour, float* out, Frame frames);
+	boost::optional<TextRingBuffers::Data> get_closed_caption ();
 
 	std::pair<size_t, std::string> memory_used () const;
 
@@ -95,7 +106,7 @@ private:
 	void seek_unlocked (dcpomatic::DCPTime position, bool accurate);
 
 	std::weak_ptr<const Film> _film;
-	std::shared_ptr<Player> _player;
+	Player& _player;
 	boost::thread _thread;
 
 	VideoRingBuffers _video;
@@ -130,7 +141,7 @@ private:
 
 	/** true to ask PlayerVideo::prepare to only prepare the ImageProxy and not also
 	 *  the final image.  We want to do this when the viewer is intending to call
-	 *  PlayerVideo::raw_image() and do the things in PlayerVideo::make_imgae() itself:
+	 *  PlayerVideo::raw_image() and do the things in PlayerVideo::make_image() itself:
 	 *  this is the case for the GLVideoView which can do scale, pixfmt conversion etc.
 	 *  in the shader.
 	 */
@@ -146,3 +157,7 @@ private:
 	boost::signals2::scoped_connection _player_text_connection;
 	boost::signals2::scoped_connection _player_change_connection;
 };
+
+
+#endif
+