X-Git-Url: https://git.carlh.net/gitweb/?a=blobdiff_plain;f=src%2Flib%2Fdcp_encoder.cc;h=50a8fd927264eecf385a0c208ab2171dc14ecaa3;hb=422eb00b446d90e3588ae6793f676917ee195cca;hp=3a4a793a87c5fdcfa35c5a1db3b150ce88440a07;hpb=ce43e15b4fd3d22470e319991391498ed32f19ed;p=dcpomatic.git diff --git a/src/lib/dcp_encoder.cc b/src/lib/dcp_encoder.cc index 3a4a793a8..50a8fd927 100644 --- a/src/lib/dcp_encoder.cc +++ b/src/lib/dcp_encoder.cc @@ -1,5 +1,5 @@ /* - Copyright (C) 2012-2017 Carl Hetherington + Copyright (C) 2012-2018 Carl Hetherington This file is part of DCP-o-matic. @@ -35,7 +35,7 @@ #include "writer.h" #include "compose.hpp" #include "referenced_reel_asset.h" -#include "subtitle_content.h" +#include "text_content.h" #include "player_video.h" #include #include @@ -49,6 +49,7 @@ using std::list; using boost::shared_ptr; using boost::weak_ptr; using boost::dynamic_pointer_cast; +using boost::optional; /** Construct a DCP encoder. * @param film Film that we are encoding. @@ -61,11 +62,13 @@ DCPEncoder::DCPEncoder (shared_ptr film, weak_ptr job) { _player_video_connection = _player->Video.connect (bind (&DCPEncoder::video, this, _1, _2)); _player_audio_connection = _player->Audio.connect (bind (&DCPEncoder::audio, this, _1, _2)); - _player_subtitle_connection = _player->Subtitle.connect (bind (&DCPEncoder::subtitle, this, _1, _2)); + _player_text_connection = _player->Text.connect (bind (&DCPEncoder::text, this, _1, _2, _3, _4)); BOOST_FOREACH (shared_ptr c, film->content ()) { - if (c->subtitle && c->subtitle->use() && !c->subtitle->burn()) { - _non_burnt_subtitles = true; + BOOST_FOREACH (shared_ptr i, c->text) { + if (i->use() && !i->burn()) { + _non_burnt_subtitles = true; + } } } } @@ -75,7 +78,7 @@ DCPEncoder::~DCPEncoder () /* We must stop receiving more video data before we die */ _player_video_connection.release (); _player_audio_connection.release (); - _player_subtitle_connection.release (); + _player_text_connection.release (); } void @@ -94,7 +97,18 @@ DCPEncoder::go () } if (_non_burnt_subtitles) { - _writer->write (_player->get_subtitle_fonts ()); + list > fonts = _player->get_subtitle_fonts (); + + if (fonts.size() > 1 && _film->interop()) { + /* Interop will ignore second and subsequent s so don't even + write them as they upset some validators. + */ + shared_ptr first = fonts.front (); + fonts.clear (); + fonts.push_back (first); + } + + _writer->write (fonts); } while (!_player->pass ()) {} @@ -130,10 +144,10 @@ DCPEncoder::audio (shared_ptr data, DCPTime time) } void -DCPEncoder::subtitle (PlayerSubtitles data, DCPTimePeriod period) +DCPEncoder::text (PlayerText data, TextType type, optional track, DCPTimePeriod period) { - if (_non_burnt_subtitles) { - _writer->write (data, period); + if (type == TEXT_CLOSED_CAPTION || _non_burnt_subtitles) { + _writer->write (data, type, track, period); } }