X-Git-Url: https://git.carlh.net/gitweb/?a=blobdiff_plain;f=src%2Flib%2Fdecoder.cc;h=5d191512874916c74a82eed7ce049b9e2e33803d;hb=60b80e1051c8c20ebce4b757d3fb67491dfdb79d;hp=2fddddc914dee09bee221af4c5b1fdc985d61c9b;hpb=cbd4450197a083bf58bda510e626f73ba583cb66;p=dcpomatic.git

diff --git a/src/lib/decoder.cc b/src/lib/decoder.cc
index 2fddddc91..5d1915128 100644
--- a/src/lib/decoder.cc
+++ b/src/lib/decoder.cc
@@ -1,5 +1,5 @@
 /*
-    Copyright (C) 2012-2018 Carl Hetherington <cth@carlh.net>
+    Copyright (C) 2012-2021 Carl Hetherington <cth@carlh.net>
 
     This file is part of DCP-o-matic.
 
@@ -18,40 +18,63 @@
 
 */
 
+
 #include "decoder.h"
 #include "video_decoder.h"
 #include "audio_decoder.h"
-#include "caption_decoder.h"
+#include "text_decoder.h"
 #include <boost/optional.hpp>
 #include <iostream>
 
+
 using std::cout;
 using boost::optional;
-using boost::shared_ptr;
+using std::shared_ptr;
+using std::weak_ptr;
+using namespace dcpomatic;
+
+
+Decoder::Decoder (weak_ptr<const Film> film)
+	: WeakConstFilm (film)
+{
+
+}
+
 
 /** @return Earliest time of content that the next pass() will emit */
 ContentTime
 Decoder::position () const
 {
 	optional<ContentTime> pos;
+	auto f = film();
 
-	if (video && !video->ignore() && (!pos || video->position() < *pos)) {
-		pos = video->position();
+	if (video && !video->ignore() && (!pos || video->position(f).get_value_or(ContentTime()) < *pos)) {
+		pos = video->position(f);
 	}
 
-	if (audio && !audio->ignore() && (!pos || audio->position() < *pos)) {
-		pos = audio->position();
+	if (audio && !audio->ignore() && (!pos || audio->position(f).get_value_or(ContentTime()) < *pos)) {
+		pos = audio->position(f);
 	}
 
-	BOOST_FOREACH (shared_ptr<CaptionDecoder> i, caption) {
-		if (!i->ignore() && (!pos || i->position() < *pos)) {
-			pos = i->position();
+	/* Only decide position based on subtitle sources if there is nothing else
+	   to go on.  Otherwise we can have problems with muxed sources which have
+	   (for example) video, audio and a subtitle.  If the subtitle data runs out
+	   before the video/audio the position() call will return the position of the
+	   end of the subs.  This causes this file to be pass()ed in favour of others,
+	   which can cause bugs like #1581.
+	*/
+	if (!pos) {
+		for (auto i: text) {
+			if (!i->ignore() && (!pos || i->position(f) < *pos)) {
+				pos = i->position(f);
+			}
 		}
 	}
 
 	return pos.get_value_or(ContentTime());
 }
 
+
 void
 Decoder::seek (ContentTime, bool)
 {
@@ -61,17 +84,18 @@ Decoder::seek (ContentTime, bool)
 	if (audio) {
 		audio->seek ();
 	}
-	BOOST_FOREACH (shared_ptr<CaptionDecoder> i, caption) {
+	for (auto i: text) {
 		i->seek ();
 	}
 }
 
-shared_ptr<CaptionDecoder>
-Decoder::only_caption () const
+
+shared_ptr<TextDecoder>
+Decoder::only_text () const
 {
-	DCPOMATIC_ASSERT (caption.size() < 2);
-	if (caption.empty ()) {
-		return shared_ptr<CaptionDecoder> ();
+	DCPOMATIC_ASSERT (text.size() < 2);
+	if (text.empty()) {
+		return {};
 	}
-	return caption.front ();
+	return text.front();
 }