X-Git-Url: https://git.carlh.net/gitweb/?a=blobdiff_plain;f=src%2Flib%2Fimage_decoder.cc;h=3d543eaf28562572a8ee3f0ce29d50cd3b921ec6;hb=e60bb3e51bd1508b149e6b8f6608f09b5196ae26;hp=5de0c8582facb1aca80ed8d03479bdf2928331d4;hpb=ee77b3cf5f59f775e75e628aa28e8f2f9f941530;p=dcpomatic.git

diff --git a/src/lib/image_decoder.cc b/src/lib/image_decoder.cc
index 5de0c8582..3d543eaf2 100644
--- a/src/lib/image_decoder.cc
+++ b/src/lib/image_decoder.cc
@@ -23,6 +23,8 @@
 #include "image_content.h"
 #include "image_decoder.h"
 #include "image.h"
+#include "magick_image_proxy.h"
+#include "j2k_image_proxy.h"
 #include "film.h"
 #include "exceptions.h"
 
@@ -35,6 +37,7 @@ using dcp::Size;
 ImageDecoder::ImageDecoder (shared_ptr<const ImageContent> c)
 	: VideoDecoder (c)
 	, _image_content (c)
+	, _video_position (0)
 {
 
 }
@@ -42,49 +45,25 @@ ImageDecoder::ImageDecoder (shared_ptr<const ImageContent> c)
 bool
 ImageDecoder::pass ()
 {
-	if (_video_position >= _image_content->video_length().frames (_image_content->video_frame_rate ())) {
+	if (_video_position >= _image_content->video_length()) {
 		return true;
 	}
 
-	if (_image && _image_content->still ()) {
-		video (_image, _video_position);
-		++_video_position;
-		return false;
-	}
-
-	Magick::Image* magick_image = 0;
-
-	boost::filesystem::path const path = _image_content->path (_image_content->still() ? 0 : _video_position);
-	
-	try {
-		magick_image = new Magick::Image (path.string ());
-	} catch (...) {
-		throw OpenFileError (path);
-	}
-	
-	dcp::Size size (magick_image->columns(), magick_image->rows());
-
-	_image.reset (new Image (PIX_FMT_RGB24, size, true));
-
-	using namespace MagickCore;
-	
-	uint8_t* p = _image->data()[0];
-	for (int y = 0; y < size.height; ++y) {
-		uint8_t* q = p;
-		for (int x = 0; x < size.width; ++x) {
-			Magick::Color c = magick_image->pixelColor (x, y);
-			*q++ = c.redQuantum() * 255 / QuantumRange;
-			*q++ = c.greenQuantum() * 255 / QuantumRange;
-			*q++ = c.blueQuantum() * 255 / QuantumRange;
+	if (!_image_content->still() || !_image) {
+		/* Either we need an image or we are using moving images, so load one */
+		boost::filesystem::path path = _image_content->path (_image_content->still() ? 0 : _video_position);
+		if (valid_j2k_file (path)) {
+			/* We can't extract image size from a JPEG2000 codestream without decoding it,
+			   so pass in the image content's size here.
+			*/
+			_image.reset (new J2KImageProxy (path, _image_content->video_size ()));
+		} else {
+			_image.reset (new MagickImageProxy (path));
 		}
-		p += _image->stride()[0];
 	}
 
-	delete magick_image;
-
 	video (_image, _video_position);
 	++_video_position;
-
 	return false;
 }