X-Git-Url: https://git.carlh.net/gitweb/?a=blobdiff_plain;f=src%2Flib%2Fj2k_image_proxy.cc;h=0e4d3ca2f21319e494324b32a1c50472230a1cbe;hb=cc0ac806a2dc698d9c20b24498bc865e2d9798ad;hp=7877eca178187b7227dce592840b598425912d79;hpb=78d8f1166fb0f8f8cee7996e3c9b7f5d088f72df;p=dcpomatic.git

diff --git a/src/lib/j2k_image_proxy.cc b/src/lib/j2k_image_proxy.cc
index 7877eca17..0e4d3ca2f 100644
--- a/src/lib/j2k_image_proxy.cc
+++ b/src/lib/j2k_image_proxy.cc
@@ -20,15 +20,16 @@
 #include "j2k_image_proxy.h"
 #include "dcpomatic_socket.h"
 #include "image.h"
-#include "data.h"
 #include "raw_convert.h"
 #include <dcp/openjpeg_image.h>
 #include <dcp/mono_picture_frame.h>
 #include <dcp/stereo_picture_frame.h>
 #include <dcp/colour_conversion.h>
 #include <dcp/rgb_xyz.h>
+#include <dcp/j2k.h>
 #include <libcxml/cxml.h>
 #include <libxml++/libxml++.h>
+#include <iostream>
 
 #include "i18n.h"
 
@@ -37,6 +38,7 @@ using std::cout;
 using boost::shared_ptr;
 using boost::optional;
 using boost::dynamic_pointer_cast;
+using dcp::Data;
 
 /** Construct a J2KImageProxy from a JPEG2000 file */
 J2KImageProxy::J2KImageProxy (boost::filesystem::path path, dcp::Size size)
@@ -79,39 +81,46 @@ J2KImageProxy::J2KImageProxy (shared_ptr<cxml::Node> xml, shared_ptr<Socket> soc
 	socket->read (_data.data().get (), _data.size ());
 }
 
-shared_ptr<Image>
-J2KImageProxy::image (optional<dcp::NoteHandler> note) const
+void
+J2KImageProxy::ensure_j2k () const
 {
-	shared_ptr<Image> image (new Image (PIX_FMT_RGB48LE, _size, true));
+	if (!_j2k) {
+		_j2k = dcp::decompress_j2k (const_cast<uint8_t*> (_data.data().get()), _data.size (), 0);
+	}
+}
 
-	shared_ptr<dcp::OpenJPEGImage> oj = dcp::decompress_j2k (const_cast<uint8_t*> (_data.data().get()), _data.size (), 0);
+shared_ptr<Image>
+J2KImageProxy::image (optional<dcp::NoteHandler>) const
+{
+	ensure_j2k ();
 
-	if (oj->opj_image()->comps[0].prec < 12) {
-		int const shift = 12 - oj->opj_image()->comps[0].prec;
+	if (_j2k->precision(0) < 12) {
+		int const shift = 12 - _j2k->precision (0);
 		for (int c = 0; c < 3; ++c) {
-			int* p = oj->data (c);
-			for (int y = 0; y < oj->size().height; ++y) {
-				for (int x = 0; x < oj->size().width; ++x) {
+			int* p = _j2k->data (c);
+			for (int y = 0; y < _j2k->size().height; ++y) {
+				for (int x = 0; x < _j2k->size().width; ++x) {
 					*p++ <<= shift;
 				}
 			}
 		}
 	}
 
-	if (oj->opj_image()->color_space == CLRSPC_SRGB) {
-		/* No XYZ -> RGB conversion necessary; just copy and interleave the values */
-		int p = 0;
-		for (int y = 0; y < oj->size().height; ++y) {
-			uint16_t* q = (uint16_t *) (image->data()[0] + y * image->stride()[0]);
-			for (int x = 0; x < oj->size().width; ++x) {
-				for (int c = 0; c < 3; ++c) {
-					*q++ = oj->data(c)[p] << 4;
-				}
-				++p;
+	shared_ptr<Image> image (new Image (pixel_format(), _size, true));
+
+	/* Copy data in whatever format (sRGB or XYZ) into our Image; I'm assuming
+	   the data is 12-bit either way.
+	*/
+
+	int p = 0;
+	for (int y = 0; y < _j2k->size().height; ++y) {
+		uint16_t* q = (uint16_t *) (image->data()[0] + y * image->stride()[0]);
+		for (int x = 0; x < _j2k->size().width; ++x) {
+			for (int c = 0; c < 3; ++c) {
+				*q++ = _j2k->data(c)[p] << 4;
 			}
+			++p;
 		}
-	} else {
-		dcp::xyz_to_rgb (oj, dcp::ColourConversion::srgb_to_xyz(), image->data()[0], image->stride()[0], note);
 	}
 
 	return image;
@@ -150,6 +159,18 @@ J2KImageProxy::same (shared_ptr<const ImageProxy> other) const
 	return memcmp (_data.data().get(), jp->_data.data().get(), _data.size()) == 0;
 }
 
+AVPixelFormat
+J2KImageProxy::pixel_format () const
+{
+	ensure_j2k ();
+
+	if (_j2k->srgb ()) {
+		return AV_PIX_FMT_RGB48LE;
+	}
+
+	return AV_PIX_FMT_XYZ12LE;
+}
+
 J2KImageProxy::J2KImageProxy (Data data, dcp::Size size)
 	: _data (data)
 	, _size (size)