X-Git-Url: https://git.carlh.net/gitweb/?a=blobdiff_plain;f=src%2Flib%2Fjob_manager.cc;h=1724879d0656ffe38b0a6962374a1489744af377;hb=acfbd1c01020ea95d9e7eb3d63ddb14b9407732a;hp=e2302a2153a01275686c20d724849328bb3c752a;hpb=b8f0865d6a5d182dc4c718b9320c82091864e55b;p=dcpomatic.git

diff --git a/src/lib/job_manager.cc b/src/lib/job_manager.cc
index e2302a215..1724879d0 100644
--- a/src/lib/job_manager.cc
+++ b/src/lib/job_manager.cc
@@ -1,5 +1,5 @@
 /*
-    Copyright (C) 2012-2018 Carl Hetherington <cth@carlh.net>
+    Copyright (C) 2012-2020 Carl Hetherington <cth@carlh.net>
 
     This file is part of DCP-o-matic.
 
@@ -26,18 +26,18 @@
 #include "job.h"
 #include "cross.h"
 #include "analyse_audio_job.h"
+#include "analyse_subtitles_job.h"
 #include "film.h"
 #include <boost/thread.hpp>
-#include <boost/foreach.hpp>
 #include <iostream>
 
 using std::string;
 using std::list;
 using std::cout;
-using boost::shared_ptr;
-using boost::weak_ptr;
+using std::shared_ptr;
+using std::weak_ptr;
 using boost::function;
-using boost::dynamic_pointer_cast;
+using std::dynamic_pointer_cast;
 using boost::optional;
 using boost::bind;
 
@@ -46,7 +46,6 @@ JobManager* JobManager::_instance = 0;
 JobManager::JobManager ()
 	: _terminate (false)
 	, _paused (false)
-	, _scheduler (0)
 {
 
 }
@@ -54,15 +53,17 @@ JobManager::JobManager ()
 void
 JobManager::start ()
 {
-	_scheduler = new boost::thread (boost::bind (&JobManager::scheduler, this));
+	_scheduler = boost::thread (boost::bind(&JobManager::scheduler, this));
 #ifdef DCPOMATIC_LINUX
-	pthread_setname_np (_scheduler->native_handle(), "job-scheduler");
+	pthread_setname_np (_scheduler.native_handle(), "job-scheduler");
 #endif
 }
 
 JobManager::~JobManager ()
 {
-	BOOST_FOREACH (boost::signals2::connection& i, _connections) {
+	boost::this_thread::disable_interruption dis;
+
+	for (auto& i: _connections) {
 		i.disconnect ();
 	}
 
@@ -72,16 +73,9 @@ JobManager::~JobManager ()
 		_empty_condition.notify_all ();
 	}
 
-	if (_scheduler) {
-		/* Ideally this would be a DCPOMATIC_ASSERT(_scheduler->joinable()) but we
-		   can't throw exceptions from a destructor.
-		*/
-		if (_scheduler->joinable ()) {
-			_scheduler->join ();
-		}
-	}
-
-	delete _scheduler;
+	try {
+		_scheduler.join();
+	} catch (...) {}
 }
 
 shared_ptr<Job>
@@ -137,7 +131,7 @@ bool
 JobManager::errors () const
 {
 	boost::mutex::scoped_lock lm (_mutex);
-	BOOST_FOREACH (shared_ptr<Job> i, _jobs) {
+	for (auto i: _jobs) {
 		if (i->finished_in_error ()) {
 			return true;
 		}
@@ -156,7 +150,7 @@ JobManager::scheduler ()
 		while (true) {
 			bool have_new = false;
 			bool have_running = false;
-			BOOST_FOREACH (shared_ptr<Job> i, _jobs) {
+			for (auto i: _jobs) {
 				if (i->running()) {
 					have_running = true;
 				}
@@ -176,7 +170,7 @@ JobManager::scheduler ()
 			break;
 		}
 
-		BOOST_FOREACH (shared_ptr<Job> i, _jobs) {
+		for (auto i: _jobs) {
 			if (i->is_new()) {
 				_connections.push_back (i->FinishedImmediate.connect(bind(&JobManager::job_finished, this)));
 				i->start ();
@@ -231,9 +225,9 @@ JobManager::analyse_audio (
 	{
 		boost::mutex::scoped_lock lm (_mutex);
 
-		BOOST_FOREACH (shared_ptr<Job> i, _jobs) {
+		for (auto i: _jobs) {
 			shared_ptr<AnalyseAudioJob> a = dynamic_pointer_cast<AnalyseAudioJob> (i);
-			if (a && a->playlist () == playlist) {
+			if (a && a->path() == film->audio_analysis_path(playlist) && !i->finished_cancelled()) {
 				i->when_finished (connection, ready);
 				return;
 			}
@@ -254,6 +248,42 @@ JobManager::analyse_audio (
 	emit (boost::bind (boost::ref (JobAdded), weak_ptr<Job> (job)));
 }
 
+
+void
+JobManager::analyse_subtitles (
+	shared_ptr<const Film> film,
+	shared_ptr<Content> content,
+	boost::signals2::connection& connection,
+	function<void()> ready
+	)
+{
+	{
+		boost::mutex::scoped_lock lm (_mutex);
+
+		for (auto i: _jobs) {
+			shared_ptr<AnalyseSubtitlesJob> a = dynamic_pointer_cast<AnalyseSubtitlesJob> (i);
+			if (a && a->path() == film->subtitle_analysis_path(content)) {
+				i->when_finished (connection, ready);
+				return;
+			}
+		}
+	}
+
+	shared_ptr<AnalyseSubtitlesJob> job;
+
+	{
+		boost::mutex::scoped_lock lm (_mutex);
+
+		job.reset (new AnalyseSubtitlesJob(film, content));
+		connection = job->Finished.connect (ready);
+		_jobs.push_back (job);
+		_empty_condition.notify_all ();
+	}
+
+	emit (boost::bind (boost::ref (JobAdded), weak_ptr<Job> (job)));
+}
+
+
 void
 JobManager::increase_priority (shared_ptr<Job> job)
 {
@@ -284,7 +314,7 @@ JobManager::priority_changed ()
 		boost::mutex::scoped_lock lm (_mutex);
 
 		bool first = true;
-		BOOST_FOREACH (shared_ptr<Job> i, _jobs) {
+		for (auto i: _jobs) {
 			if (first) {
 				if (i->is_new ()) {
 					i->start ();
@@ -335,7 +365,7 @@ JobManager::pause ()
 		return;
 	}
 
-	BOOST_FOREACH (shared_ptr<Job> i, _jobs) {
+	for (auto i: _jobs) {
 		if (i->pause_by_user()) {
 			_paused_job = i;
 		}