X-Git-Url: https://git.carlh.net/gitweb/?a=blobdiff_plain;f=src%2Flib%2Fplayer_video.cc;h=b5f0b5fa5fde53309692c9380eb1cdf920c3f9c1;hb=b6c780d3107557d452c6612d715d01e2be52dbda;hp=a44264ceddd23bcad2c3e5dea92512e6e8d0c9ec;hpb=53a18f3564b6dcd431e44b01ab2a505be135d2b7;p=dcpomatic.git

diff --git a/src/lib/player_video.cc b/src/lib/player_video.cc
index a44264ced..b5f0b5fa5 100644
--- a/src/lib/player_video.cc
+++ b/src/lib/player_video.cc
@@ -29,21 +29,24 @@ using std::cout;
 using dcp::raw_convert;
 using boost::shared_ptr;
 using boost::dynamic_pointer_cast;
+using boost::optional;
 
 PlayerVideo::PlayerVideo (
 	shared_ptr<const ImageProxy> in,
 	DCPTime time,
 	Crop crop,
+	boost::optional<float> fade,
 	dcp::Size inter_size,
 	dcp::Size out_size,
 	Scaler const * scaler,
 	Eyes eyes,
 	Part part,
-	ColourConversion colour_conversion
+	optional<ColourConversion> colour_conversion
 	)
 	: _in (in)
 	, _time (time)
 	, _crop (crop)
+	, _fade (fade)
 	, _inter_size (inter_size)
 	, _out_size (out_size)
 	, _scaler (scaler)
@@ -58,13 +61,14 @@ PlayerVideo::PlayerVideo (shared_ptr<cxml::Node> node, shared_ptr<Socket> socket
 {
 	_time = DCPTime (node->number_child<DCPTime::Type> ("Time"));
 	_crop = Crop (node);
+	_fade = node->optional_number_child<float> ("Fade");
 
 	_inter_size = dcp::Size (node->number_child<int> ("InterWidth"), node->number_child<int> ("InterHeight"));
 	_out_size = dcp::Size (node->number_child<int> ("OutWidth"), node->number_child<int> ("OutHeight"));
 	_scaler = Scaler::from_id (node->string_child ("Scaler"));
 	_eyes = (Eyes) node->number_child<int> ("Eyes");
 	_part = (Part) node->number_child<int> ("Part");
-	_colour_conversion = ColourConversion (node);
+	_colour_conversion = ColourConversion::from_xml (node);
 
 	_in = image_proxy_factory (node->node_child ("In"), socket, log);
 
@@ -87,7 +91,7 @@ PlayerVideo::set_subtitle (PositionImage image)
 }
 
 shared_ptr<Image>
-PlayerVideo::image (bool burn_subtitle) const
+PlayerVideo::image (AVPixelFormat pixel_format, bool burn_subtitle) const
 {
 	shared_ptr<Image> im = _in->image ();
 	
@@ -109,14 +113,16 @@ PlayerVideo::image (bool burn_subtitle) const
 		break;
 	}
 		
-	shared_ptr<Image> out = im->crop_scale_window (total_crop, _inter_size, _out_size, _scaler, PIX_FMT_RGB24, true);
-
-	Position<int> const container_offset ((_out_size.width - _inter_size.width) / 2, (_out_size.height - _inter_size.width) / 2);
+	shared_ptr<Image> out = im->crop_scale_window (total_crop, _inter_size, _out_size, _scaler, pixel_format, true);
 
 	if (burn_subtitle && _subtitle.image) {
 		out->alpha_blend (_subtitle.image, _subtitle.position);
 	}
 
+	if (_fade) {
+		out->fade (_fade.get ());
+	}
+
 	return out;
 }
 
@@ -125,6 +131,9 @@ PlayerVideo::add_metadata (xmlpp::Node* node, bool send_subtitles) const
 {
 	node->add_child("Time")->add_child_text (raw_convert<string> (_time.get ()));
 	_crop.as_xml (node);
+	if (_fade) {
+		node->add_child("Fade")->add_child_text (raw_convert<string> (_fade.get ()));
+	}
 	_in->add_metadata (node->add_child ("In"));
 	node->add_child("InterWidth")->add_child_text (raw_convert<string> (_inter_size.width));
 	node->add_child("InterHeight")->add_child_text (raw_convert<string> (_inter_size.height));
@@ -133,7 +142,9 @@ PlayerVideo::add_metadata (xmlpp::Node* node, bool send_subtitles) const
 	node->add_child("Scaler")->add_child_text (_scaler->id ());
 	node->add_child("Eyes")->add_child_text (raw_convert<string> (_eyes));
 	node->add_child("Part")->add_child_text (raw_convert<string> (_part));
-	_colour_conversion.as_xml (node);
+	if (_colour_conversion) {
+		_colour_conversion.get().as_xml (node);
+	}
 	if (send_subtitles && _subtitle.image) {
 		node->add_child ("SubtitleWidth")->add_child_text (raw_convert<string> (_subtitle.image->size().width));
 		node->add_child ("SubtitleHeight")->add_child_text (raw_convert<string> (_subtitle.image->size().height));
@@ -171,3 +182,31 @@ PlayerVideo::j2k () const
 	assert (j2k);
 	return j2k->j2k ();
 }
+
+Position<int>
+PlayerVideo::inter_position () const
+{
+	return Position<int> ((_out_size.width - _inter_size.width) / 2, (_out_size.height - _inter_size.height) / 2);
+}
+
+/** @return true if this PlayerVideo is definitely the same as another
+ * (apart from _time), false if it is probably not
+ */
+bool
+PlayerVideo::same (shared_ptr<const PlayerVideo> other) const
+{
+	if (_in != other->_in ||
+	    _crop != other->_crop ||
+	    _fade.get_value_or(0) != other->_fade.get_value_or(0) ||
+	    _inter_size != other->_inter_size ||
+	    _out_size != other->_out_size ||
+	    _scaler != other->_scaler ||
+	    _eyes != other->_eyes ||
+	    _part != other->_part ||
+	    _colour_conversion != other->_colour_conversion ||
+	    !_subtitle.same (other->_subtitle)) {
+		return false;
+	}
+
+	return _in->same (other->_in);
+}