X-Git-Url: https://git.carlh.net/gitweb/?a=blobdiff_plain;f=src%2Flib%2Frect.h;h=a01e0f8858ffba6d31eb6b9675d0cff571b4571d;hb=6f66251a1267ad57e9a3f72a5688511b0dba15dd;hp=5758dd04e4496955af9b7cc994c492bf785c40b6;hpb=218ffe2c5f92ed19ec488cda5012b64fcabd5e3f;p=dcpomatic.git

diff --git a/src/lib/rect.h b/src/lib/rect.h
index 5758dd04e..a01e0f885 100644
--- a/src/lib/rect.h
+++ b/src/lib/rect.h
@@ -1,33 +1,39 @@
 /*
-    Copyright (C) 2013 Carl Hetherington <cth@carlh.net>
+    Copyright (C) 2013-2021 Carl Hetherington <cth@carlh.net>
 
-    This program is free software; you can redistribute it and/or modify
+    This file is part of DCP-o-matic.
+
+    DCP-o-matic is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
     the Free Software Foundation; either version 2 of the License, or
     (at your option) any later version.
 
-    This program is distributed in the hope that it will be useful,
+    DCP-o-matic is distributed in the hope that it will be useful,
     but WITHOUT ANY WARRANTY; without even the implied warranty of
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
     GNU General Public License for more details.
 
     You should have received a copy of the GNU General Public License
-    along with this program; if not, write to the Free Software
-    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+    along with DCP-o-matic.  If not, see <http://www.gnu.org/licenses/>.
 
 */
 
+
 #ifndef DCPOMATIC_RECT_H
 #define DCPOMATIC_RECT_H
 
+
 #include "position.h"
+#include <boost/optional.hpp>
 #include <algorithm>
 
+
 /* Put this inside a namespace as Apple put a Rect in the global namespace */
 
 namespace dcpomatic
 {
 
+
 /** @struct Rect
  *  @brief A rectangle.
  */
@@ -67,24 +73,34 @@ public:
 		return Position<T> (x, y);
 	}
 
-	Rect<T> intersection (Rect<T> const & other) const
+	boost::optional<Rect<T>> intersection (Rect<T> const & other) const
 	{
-		T const tx = max (x, other.x);
-		T const ty = max (y, other.y);
+		/* This isn't exactly the paragon of mathematical precision */
+
+		T const tx = std::max (x, other.x);
+		T const ty = std::max (y, other.y);
 
-		return Rect (
+		Rect r (
 			tx, ty,
-			min (x + width, other.x + other.width) - tx,
-			min (y + height, other.y + other.height) - ty
+			std::min (x + width, other.x + other.width) - tx,
+			std::min (y + height, other.y + other.height) - ty
 			);
+
+		if (r.width < 0 || r.height < 0) {
+			return {};
+		}
+
+		return r;
 	}
 
 	void extend (Rect<T> const & other)
 	{
+		T old_x = x;
+		T old_y = y;
 		x = std::min (x, other.x);
 		y = std::min (y, other.y);
-		width = std::max (x + width, other.x + other.width) - x;
-		height = std::max (y + height, other.y + other.height) - y;
+		width = std::max (old_x + width, other.x + other.width) - x;
+		height = std::max (old_y + height, other.y + other.height) - y;
 	}
 
 	Rect<T> extended (T amount) const {
@@ -102,6 +118,15 @@ public:
 	}
 };
 
+
+template <class T>
+bool operator== (Rect<T> const& a, Rect<T> const& b)
+{
+	return a.x == b.x && a.y == b.y && a.width == b.width && a.height == b.height;
 }
 
+
+}
+
+
 #endif