X-Git-Url: https://git.carlh.net/gitweb/?a=blobdiff_plain;f=src%2Flib%2Fscp_dcp_job.cc;h=86eec16b24771b3844e31bd07585706a6dac7938;hb=e60bb3e51bd1508b149e6b8f6608f09b5196ae26;hp=a9fdfefda2f01671698c83279a624e5102ed894d;hpb=0d3f5aae5b99832b7c5d55f32f5bccb365caa3fd;p=dcpomatic.git

diff --git a/src/lib/scp_dcp_job.cc b/src/lib/scp_dcp_job.cc
index a9fdfefda..86eec16b2 100644
--- a/src/lib/scp_dcp_job.cc
+++ b/src/lib/scp_dcp_job.cc
@@ -1,5 +1,5 @@
 /*
-    Copyright (C) 2012 Carl Hetherington <cth@carlh.net>
+    Copyright (C) 2012-2015 Carl Hetherington <cth@carlh.net>
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
@@ -33,11 +33,13 @@
 #include "config.h"
 #include "log.h"
 #include "film.h"
+#include "cross.h"
 
 #include "i18n.h"
 
+#define LOG_GENERAL_NC(...) _film->log()->log (__VA_ARGS__, Log::TYPE_GENERAL);
+
 using std::string;
-using std::stringstream;
 using std::min;
 using boost::shared_ptr;
 
@@ -72,7 +74,7 @@ public:
 
 	ssh_session session;
 
-private:	
+private:
 	bool _connected;
 };
 
@@ -96,8 +98,8 @@ public:
 };
 
 
-SCPDCPJob::SCPDCPJob (shared_ptr<Film> f)
-	: Job (f)
+SCPDCPJob::SCPDCPJob (shared_ptr<const Film> film)
+	: Job (film)
 	, _status (_("Waiting"))
 {
 
@@ -109,68 +111,74 @@ SCPDCPJob::name () const
 	return _("Copy DCP to TMS");
 }
 
+string
+SCPDCPJob::json_name () const
+{
+	return N_("scp_dcp");
+}
+
 void
 SCPDCPJob::run ()
 {
-	_film->log()->log (N_("SCP DCP job starting"));
-	
+	LOG_GENERAL_NC (N_("SCP DCP job starting"));
+
 	SSHSession ss;
-	
+
 	set_status (_("connecting"));
-	
+
 	ssh_options_set (ss.session, SSH_OPTIONS_HOST, Config::instance()->tms_ip().c_str ());
 	ssh_options_set (ss.session, SSH_OPTIONS_USER, Config::instance()->tms_user().c_str ());
 	int const port = 22;
 	ssh_options_set (ss.session, SSH_OPTIONS_PORT, &port);
-	
+
 	int r = ss.connect ();
 	if (r != SSH_OK) {
 		throw NetworkError (String::compose (_("Could not connect to server %1 (%2)"), Config::instance()->tms_ip(), ssh_get_error (ss.session)));
 	}
-	
+
 	int const state = ssh_is_server_known (ss.session);
 	if (state == SSH_SERVER_ERROR) {
 		throw NetworkError (String::compose (_("SSH error (%1)"), ssh_get_error (ss.session)));
 	}
-	
+
 	r = ssh_userauth_password (ss.session, 0, Config::instance()->tms_password().c_str ());
 	if (r != SSH_AUTH_SUCCESS) {
 		throw NetworkError (String::compose (_("Failed to authenticate with server (%1)"), ssh_get_error (ss.session)));
 	}
-	
+
 	SSHSCP sc (ss.session);
-	
+
 	r = ssh_scp_init (sc.scp);
 	if (r != SSH_OK) {
 		throw NetworkError (String::compose (_("Could not start SCP session (%1)"), ssh_get_error (ss.session)));
 	}
-	
+
 	r = ssh_scp_push_directory (sc.scp, _film->dcp_name().c_str(), S_IRWXU);
 	if (r != SSH_OK) {
 		throw NetworkError (String::compose (_("Could not create remote directory %1 (%2)"), _film->dcp_name(), ssh_get_error (ss.session)));
 	}
-	
-	string const dcp_dir = _film->dir (_film->dcp_name());
-	
+
+	boost::filesystem::path const dcp_dir = _film->dir (_film->dcp_name());
+
 	boost::uintmax_t bytes_to_transfer = 0;
 	for (boost::filesystem::directory_iterator i = boost::filesystem::directory_iterator (dcp_dir); i != boost::filesystem::directory_iterator(); ++i) {
 		bytes_to_transfer += boost::filesystem::file_size (*i);
 	}
-	
+
 	boost::uintmax_t buffer_size = 64 * 1024;
 	char buffer[buffer_size];
 	boost::uintmax_t bytes_transferred = 0;
-	
+
 	for (boost::filesystem::directory_iterator i = boost::filesystem::directory_iterator (dcp_dir); i != boost::filesystem::directory_iterator(); ++i) {
-		
+
 		string const leaf = boost::filesystem::path(*i).leaf().generic_string ();
-		
+
 		set_status (String::compose (_("copying %1"), leaf));
-		
+
 		boost::uintmax_t to_do = boost::filesystem::file_size (*i);
 		ssh_scp_push_file (sc.scp, leaf.c_str(), to_do, S_IRUSR | S_IWUSR);
 
-		FILE* f = fopen (boost::filesystem::path (*i).string().c_str(), N_("rb"));
+		FILE* f = fopen_boost (boost::filesystem::path (*i), "rb");
 		if (f == 0) {
 			throw NetworkError (String::compose (_("Could not open %1 to send"), *i));
 		}
@@ -179,22 +187,26 @@ SCPDCPJob::run ()
 			int const t = min (to_do, buffer_size);
 			size_t const read = fread (buffer, 1, t, f);
 			if (read != size_t (t)) {
+				fclose (f);
 				throw ReadFileError (boost::filesystem::path (*i).string());
 			}
-			
+
 			r = ssh_scp_write (sc.scp, buffer, t);
 			if (r != SSH_OK) {
+				fclose (f);
 				throw NetworkError (String::compose (_("Could not write to remote file (%1)"), ssh_get_error (ss.session)));
 			}
 			to_do -= t;
 			bytes_transferred += t;
-			
-			set_progress ((double) bytes_transferred / bytes_to_transfer);
+
+			if (bytes_to_transfer > 0) {
+				set_progress ((double) bytes_transferred / bytes_to_transfer);
+			}
 		}
 
 		fclose (f);
 	}
-	
+
 	set_progress (1);
 	set_status (N_(""));
 	set_state (FINISHED_OK);
@@ -204,12 +216,11 @@ string
 SCPDCPJob::status () const
 {
 	boost::mutex::scoped_lock lm (_status_mutex);
-	stringstream s;
-	s << Job::status ();
+	string s = Job::status ();
 	if (!_status.empty ()) {
-		s << N_("; ") << _status;
+		s += N_("; ") + _status;
 	}
-	return s.str ();
+	return s;
 }
 
 void
@@ -218,4 +229,3 @@ SCPDCPJob::set_status (string s)
 	boost::mutex::scoped_lock lm (_status_mutex);
 	_status = s;
 }
-