X-Git-Url: https://git.carlh.net/gitweb/?a=blobdiff_plain;f=src%2Flib%2Fsubtitle.cc;h=bd5f0c87969cc76b473c4af506c0c88e913ec235;hb=b1873c51b2e8265a01a8f0eced7fc3465f1677dc;hp=dcb747828a954598074619e6ecf57833aa6ffcf4;hpb=7ef2ba523ca2ddc0470f5837bc88ad9c597361e2;p=dcpomatic.git

diff --git a/src/lib/subtitle.cc b/src/lib/subtitle.cc
index dcb747828..bd5f0c879 100644
--- a/src/lib/subtitle.cc
+++ b/src/lib/subtitle.cc
@@ -24,10 +24,10 @@
 #include "subtitle.h"
 #include "image.h"
 #include "exceptions.h"
-#include "film_state.h"
 
 using namespace std;
 using namespace boost;
+using libdcp::Size;
 
 /** Construct a TimedSubtitle.  This is a subtitle image, position,
  *  and a range of time over which it should be shown.
@@ -35,8 +35,12 @@ using namespace boost;
  */
 TimedSubtitle::TimedSubtitle (AVSubtitle const & sub)
 {
-	/* subtitle PTS in seconds */
-	float const packet_time = (sub.pts / AV_TIME_BASE) + float (sub.pts % AV_TIME_BASE) / 1e6;
+	assert (sub.num_rects > 0);
+	
+	/* Subtitle PTS in seconds (within the source, not taking into account any of the
+	   source that we may have chopped off for the DCP)
+	*/
+	double const packet_time = static_cast<double> (sub.pts) / AV_TIME_BASE;
 	
 	/* hence start time for this sub */
 	_from = packet_time + (double (sub.start_display_time) / 1e3);
@@ -52,7 +56,7 @@ TimedSubtitle::TimedSubtitle (AVSubtitle const & sub)
 		throw DecodeError ("non-bitmap subtitles not yet supported");
 	}
 	
-	shared_ptr<Image> image (new AlignedImage (PIX_FMT_RGBA, Size (rect->w, rect->h)));
+	shared_ptr<Image> image (new SimpleImage (PIX_FMT_RGBA, libdcp::Size (rect->w, rect->h), true));
 
 	/* Start of the first line in the subtitle */
 	uint8_t* sub_p = rect->pict.data[0];
@@ -74,7 +78,7 @@ TimedSubtitle::TimedSubtitle (AVSubtitle const & sub)
 	_subtitle.reset (new Subtitle (Position (rect->x, rect->y), image));
 }	
 
-/** @param t Time in seconds from the start of the film */
+/** @param t Time in seconds from the start of the source */
 bool
 TimedSubtitle::displayed_at (double t) const
 {
@@ -102,13 +106,13 @@ Subtitle::Subtitle (Position p, shared_ptr<Image> i)
  *  in the coordinate space of the source.
  *  @param subtitle_scale scaling factor to apply to the subtitle image.
  */
-Rectangle
+Rect
 subtitle_transformed_area (
 	float target_x_scale, float target_y_scale,
-	Rectangle sub_area, int subtitle_offset, float subtitle_scale
+	Rect sub_area, int subtitle_offset, float subtitle_scale
 	)
 {
-	Rectangle tx;
+	Rect tx;
 
 	sub_area.y += subtitle_offset;
 
@@ -136,9 +140,9 @@ subtitle_transformed_area (
 	return tx;
 }
 
-/** @return area that this subtitle take up, in the original uncropped source's coordinate space */
-Rectangle
+/** @return area that this subtitle takes up, in the original uncropped source's coordinate space */
+Rect
 Subtitle::area () const
 {
-	return Rectangle (_position.x, _position.y, _image->size().width, _image->size().height);
+	return Rect (_position.x, _position.y, _image->size().width, _image->size().height);
 }