X-Git-Url: https://git.carlh.net/gitweb/?a=blobdiff_plain;f=src%2Ftools%2Fdcpomatic.cc;h=af4576fd5e2daeee848eebc2ed981e00e185c136;hb=963c7649da903b87637975e8c2d634da887d3109;hp=9990f05ad67953e81bf2e096567fc3419fb80ba1;hpb=3e6b2d886961177c8d89b3f9168393d33c13bff2;p=dcpomatic.git diff --git a/src/tools/dcpomatic.cc b/src/tools/dcpomatic.cc index 9990f05ad..af4576fd5 100644 --- a/src/tools/dcpomatic.cc +++ b/src/tools/dcpomatic.cc @@ -24,88 +24,91 @@ */ -#include "wx/standard_controls.h" -#include "wx/film_viewer.h" -#include "wx/film_editor.h" -#include "wx/job_manager_view.h" -#include "wx/full_config_dialog.h" -#include "wx/wx_util.h" -#include "wx/film_name_location_dialog.h" -#include "wx/wx_signal_manager.h" -#include "wx/recreate_chain_dialog.h" #include "wx/about_dialog.h" -#include "wx/kdm_dialog.h" -#include "wx/dkdm_dialog.h" -#include "wx/self_dkdm_dialog.h" -#include "wx/servers_list_dialog.h" -#include "wx/hints_dialog.h" -#include "wx/update_dialog.h" #include "wx/content_panel.h" -#include "wx/report_problem_dialog.h" -#include "wx/video_waveform_dialog.h" -#include "wx/system_information_dialog.h" -#include "wx/save_template_dialog.h" -#include "wx/templates_dialog.h" -#include "wx/nag_dialog.h" +#include "wx/dkdm_dialog.h" #include "wx/export_subtitles_dialog.h" #include "wx/export_video_file_dialog.h" -#include "wx/paste_dialog.h" +#include "wx/film_editor.h" +#include "wx/film_name_location_dialog.h" +#include "wx/film_viewer.h" #include "wx/focus_manager.h" +#include "wx/full_config_dialog.h" +#include "wx/hints_dialog.h" #include "wx/html_dialog.h" -#include "wx/send_i18n_dialog.h" #include "wx/i18n_hook.h" -#include "lib/film.h" +#include "wx/job_manager_view.h" +#include "wx/kdm_dialog.h" +#include "wx/nag_dialog.h" +#include "wx/paste_dialog.h" +#include "wx/recreate_chain_dialog.h" +#include "wx/report_problem_dialog.h" +#include "wx/save_template_dialog.h" +#include "wx/self_dkdm_dialog.h" +#include "wx/send_i18n_dialog.h" +#include "wx/servers_list_dialog.h" +#include "wx/standard_controls.h" +#include "wx/system_information_dialog.h" +#include "wx/templates_dialog.h" +#include "wx/update_dialog.h" +#include "wx/video_waveform_dialog.h" +#include "wx/wx_signal_manager.h" +#include "wx/wx_ptr.h" +#include "wx/wx_util.h" #include "lib/analytics.h" -#include "lib/emailer.h" +#include "lib/audio_content.h" +#include "lib/check_content_job.h" +#include "lib/cinema.h" +#include "lib/compose.hpp" #include "lib/config.h" -#include "lib/cross.h" -#include "lib/util.h" -#include "lib/video_content.h" +#include "lib/constants.h" #include "lib/content.h" -#include "lib/version.h" -#include "lib/signal_manager.h" -#include "lib/log.h" -#include "lib/screen.h" -#include "lib/job_manager.h" -#include "lib/exceptions.h" -#include "lib/cinema.h" -#include "lib/kdm_with_metadata.h" -#include "lib/send_kdm_email_job.h" -#include "lib/encode_server_finder.h" -#include "lib/update_checker.h" -#include "lib/cross.h" #include "lib/content_factory.h" -#include "lib/compose.hpp" -#include "lib/dcpomatic_socket.h" -#include "lib/hints.h" +#include "lib/cross.h" +#include "lib/cross.h" #include "lib/dcp_content.h" -#include "lib/ffmpeg_encoder.h" -#include "lib/transcode_job.h" -#include "lib/dkdm_wrapper.h" -#include "lib/audio_content.h" -#include "lib/check_content_change_job.h" -#include "lib/text_content.h" #include "lib/dcpomatic_log.h" +#include "lib/dcpomatic_socket.h" +#include "lib/dkdm_wrapper.h" +#include "lib/emailer.h" +#include "lib/encode_server_finder.h" +#include "lib/exceptions.h" +#include "lib/ffmpeg_encoder.h" +#include "lib/film.h" +#include "lib/hints.h" +#include "lib/job_manager.h" +#include "lib/kdm_with_metadata.h" +#include "lib/log.h" +#include "lib/make_dcp.h" +#include "lib/release_notes.h" +#include "lib/screen.h" +#include "lib/send_kdm_email_job.h" +#include "lib/signal_manager.h" #include "lib/subtitle_encoder.h" -#include "lib/warnings.h" +#include "lib/text_content.h" +#include "lib/transcode_job.h" +#include "lib/update_checker.h" +#include "lib/version.h" +#include "lib/video_content.h" #include #include -DCPOMATIC_DISABLE_WARNINGS -#include -#include +#include +LIBDCP_DISABLE_WARNINGS #include +#include #include #include +#include #include -DCPOMATIC_ENABLE_WARNINGS +LIBDCP_ENABLE_WARNINGS #ifdef __WXGTK__ #include #endif #ifdef __WXMSW__ #include #endif -#include #include +#include #include #include /* This is OK as it's only used with DCPOMATIC_WINDOWS */ @@ -256,6 +259,7 @@ enum { ID_tools_send_translations, ID_tools_system_information, ID_tools_restore_default_preferences, + ID_tools_export_preferences, ID_help_report_a_problem, /* IDs for shortcuts (with no associated menu item) */ ID_add_file, @@ -267,11 +271,58 @@ enum { }; +class LimitedFrameSplitter : public wxSplitterWindow +{ +public: + LimitedFrameSplitter(wxWindow* parent) + : wxSplitterWindow(parent, wxID_ANY, wxDefaultPosition, wxDefaultSize, wxSP_NOBORDER | wxSP_3DSASH | wxSP_LIVE_UPDATE) + { + /* This value doesn't really mean much but we just want to stop double-click on the + divider from shrinking the left panel. + */ + SetMinimumPaneSize(64); + + Bind(wxEVT_SIZE, boost::bind(&LimitedFrameSplitter::sized, this, _1)); + } + + bool OnSashPositionChange(int new_position) override + { + /* Try to stop the left bit of the splitter getting too small */ + auto const ok = new_position > _left_panel_minimum_size; + if (ok) { + Config::instance()->set_main_divider_sash_position(new_position); + } + return ok; + } + +private: + void sized(wxSizeEvent& ev) + { + if (GetSize().GetWidth() > _left_panel_minimum_size && GetSashPosition() < _left_panel_minimum_size) { + /* The window is now fairly big but the left panel is small; this happens when the DCP-o-matic window + * is shrunk and then made larger again. Try to set a sensible left panel size in this case. + */ + SetSashPosition(Config::instance()->main_divider_sash_position().get_value_or(_left_panel_minimum_size)); + } + + ev.Skip(); + } + + int const _left_panel_minimum_size = 200; +}; + + class DOMFrame : public wxFrame { public: explicit DOMFrame (wxString const& title) : wxFrame (nullptr, -1, title) + /* Use a panel as the only child of the Frame so that we avoid + the dark-grey background on Windows. + */ + , _splitter(new LimitedFrameSplitter(this)) + , _right_panel(new wxPanel(_splitter, wxID_ANY)) + , _film_viewer(_right_panel) { #if defined(DCPOMATIC_WINDOWS) if (Config::instance()->win32_console()) { @@ -338,40 +389,40 @@ public: Bind (wxEVT_MENU, boost::bind (&DOMFrame::tools_send_translations, this), ID_tools_send_translations); Bind (wxEVT_MENU, boost::bind (&DOMFrame::tools_system_information, this),ID_tools_system_information); Bind (wxEVT_MENU, boost::bind (&DOMFrame::tools_restore_default_preferences, this), ID_tools_restore_default_preferences); + Bind (wxEVT_MENU, boost::bind (&DOMFrame::tools_export_preferences, this), ID_tools_export_preferences); Bind (wxEVT_MENU, boost::bind (&DOMFrame::help_about, this), wxID_ABOUT); Bind (wxEVT_MENU, boost::bind (&DOMFrame::help_report_a_problem, this), ID_help_report_a_problem); Bind (wxEVT_CLOSE_WINDOW, boost::bind (&DOMFrame::close, this, _1)); Bind (wxEVT_SHOW, boost::bind (&DOMFrame::show, this, _1)); - /* Use a panel as the only child of the Frame so that we avoid - the dark-grey background on Windows. - */ - auto overall_panel = new wxPanel (this, wxID_ANY); + auto left_panel = new wxPanel(_splitter, wxID_ANY); + + _film_editor = new FilmEditor(left_panel, _film_viewer); - _film_viewer.reset (new FilmViewer (overall_panel)); - _controls = new StandardControls (overall_panel, _film_viewer, true); - _film_editor = new FilmEditor (overall_panel, _film_viewer); - auto job_manager_view = new JobManagerView (overall_panel, false); + auto left_sizer = new wxBoxSizer(wxHORIZONTAL); + left_sizer->Add(_film_editor, 1, wxEXPAND); + + left_panel->SetSizerAndFit(left_sizer); + + _controls = new StandardControls(_right_panel, _film_viewer, true); + auto job_manager_view = new JobManagerView(_right_panel, false); auto right_sizer = new wxBoxSizer (wxVERTICAL); - right_sizer->Add (_film_viewer->panel(), 2, wxEXPAND | wxALL, 6); + right_sizer->Add(_film_viewer.panel(), 2, wxEXPAND | wxALL, 6); right_sizer->Add (_controls, 0, wxEXPAND | wxALL, 6); right_sizer->Add (job_manager_view, 1, wxEXPAND | wxALL, 6); - wxBoxSizer* main_sizer = new wxBoxSizer (wxHORIZONTAL); - main_sizer->Add (_film_editor, 0, wxEXPAND | wxALL, 6); - main_sizer->Add (right_sizer, 1, wxEXPAND | wxALL, 6); + _right_panel->SetSizer(right_sizer); + + _splitter->SplitVertically(left_panel, _right_panel, Config::instance()->main_divider_sash_position().get_value_or(left_panel->GetSize().GetWidth() + 8)); set_menu_sensitivity (); - _film_editor->FileChanged.connect (bind (&DOMFrame::file_changed, this, _1)); _film_editor->content_panel()->SelectionChanged.connect (boost::bind (&DOMFrame::set_menu_sensitivity, this)); - file_changed (""); - - JobManager::instance()->ActiveJobsChanged.connect (boost::bind (&DOMFrame::set_menu_sensitivity, this)); + set_title (); - overall_panel->SetSizer (main_sizer); + JobManager::instance()->ActiveJobsChanged.connect(boost::bind(&DOMFrame::active_jobs_changed, this)); UpdateChecker::instance()->StateChanged.connect(boost::bind(&DOMFrame::update_checker_state_changed, this)); @@ -387,7 +438,7 @@ public: #else int accelerators = 6; #endif - auto accel = new wxAcceleratorEntry[accelerators]; + std::vector accel(accelerators); /* [Shortcut] Ctrl+A:Add file(s) to the film */ accel[0].Set (wxACCEL_CTRL, static_cast('A'), ID_add_file); /* [Shortcut] Delete:Remove selected content from film */ @@ -409,9 +460,8 @@ public: Bind (wxEVT_MENU, boost::bind (&DOMFrame::timeline_pressed, this), ID_timeline); Bind (wxEVT_MENU, boost::bind (&DOMFrame::back_frame, this), ID_back_frame); Bind (wxEVT_MENU, boost::bind (&DOMFrame::forward_frame, this), ID_forward_frame); - wxAcceleratorTable accel_table (accelerators, accel); + wxAcceleratorTable accel_table (accelerators, accel.data()); SetAcceleratorTable (accel_table); - delete[] accel; } void remove_accelerators () @@ -457,7 +507,7 @@ public: set_film (film); - JobManager::instance()->add(shared_ptr(new CheckContentChangeJob(film))); + JobManager::instance()->add(make_shared(film)); } catch (FileNotFoundError& e) { auto const dir = e.file().parent_path(); @@ -479,8 +529,8 @@ public: void set_film (shared_ptr film) { _film = film; - _film_viewer->set_film (_film); - _film_editor->set_film (_film); + _film_viewer.set_film(_film); + _film_editor->set_film(_film); _controls->set_film (_film); if (_video_waveform_dialog) { _video_waveform_dialog->Destroy (); @@ -493,8 +543,10 @@ public: if (_film) { _film->Change.connect (boost::bind (&DOMFrame::film_change, this, _1)); _film->Message.connect (boost::bind(&DOMFrame::film_message, this, _1)); + _film->DirtyChange.connect (boost::bind(&DOMFrame::set_title, this)); dcpomatic_log = _film->log (); } + set_title (); } shared_ptr film () const { @@ -523,54 +575,44 @@ private: } } - void file_changed (boost::filesystem::path f) - { - auto s = wx_to_std(_("DCP-o-matic")); - if (!f.empty ()) { - s += " - " + f.string (); - } - - SetTitle (std_to_wx (s)); - } - void file_new () { - auto d = new FilmNameLocationDialog (this, _("New Film"), true); + auto d = make_wx(this, _("New Film"), true); int const r = d->ShowModal (); - if (r == wxID_OK && d->check_path() && maybe_save_then_delete_film()) { - try { - new_film (d->path(), d->template_name()); - } catch (boost::filesystem::filesystem_error& e) { + if (r != wxID_OK || !d->check_path() || !maybe_save_then_delete_film()) { + return; + } + + try { + new_film (d->path(), d->template_name()); + } catch (boost::filesystem::filesystem_error& e) { #ifdef DCPOMATIC_WINDOWS - string bad_chars = "<>:\"/|?*"; - string const filename = d->path().filename().string(); - string found_bad_chars; - for (size_t i = 0; i < bad_chars.length(); ++i) { - if (filename.find(bad_chars[i]) != string::npos && found_bad_chars.find(bad_chars[i]) == string::npos) { - found_bad_chars += bad_chars[i]; - } - } - wxString message = _("Could not create folder to store film."); - message += " "; - if (!found_bad_chars.empty()) { - message += wxString::Format (_("Try removing the %s characters from your folder name."), std_to_wx(found_bad_chars).data()); - } else { - message += _("Please check that you do not have Windows controlled folder access enabled for DCP-o-matic."); + string bad_chars = "<>:\"/|?*"; + string const filename = d->path().filename().string(); + string found_bad_chars; + for (size_t i = 0; i < bad_chars.length(); ++i) { + if (filename.find(bad_chars[i]) != string::npos && found_bad_chars.find(bad_chars[i]) == string::npos) { + found_bad_chars += bad_chars[i]; } - error_dialog (this, message, std_to_wx(e.what())); + } + wxString message = _("Could not create folder to store film."); + message += " "; + if (!found_bad_chars.empty()) { + message += wxString::Format (_("Try removing the %s characters from your folder name."), std_to_wx(found_bad_chars).data()); + } else { + message += _("Please check that you do not have Windows controlled folder access enabled for DCP-o-matic."); + } + error_dialog (this, message, std_to_wx(e.what())); #else - error_dialog (this, _("Could not create folder to store film."), std_to_wx(e.what())); + error_dialog (this, _("Could not create folder to store film."), std_to_wx(e.what())); #endif - } } - - d->Destroy (); } void file_open () { - auto c = new wxDirDialog ( + auto c = make_wx( this, _("Select film to open"), std_to_wx (Config::instance()->default_directory_or (wx_to_std (wxStandardPaths::Get().GetDocumentsDir())).string ()), @@ -590,8 +632,6 @@ private: if (r == wxID_OK && maybe_save_then_delete_film()) { load_film (wx_to_std (c->GetPath ())); } - - c->Destroy (); } void file_save () @@ -601,43 +641,35 @@ private: void file_save_as_template () { - auto d = new SaveTemplateDialog (this); - int const r = d->ShowModal (); - if (r == wxID_OK) { + auto d = make_wx(this); + if (d->ShowModal() == wxID_OK) { Config::instance()->save_template (_film, d->name ()); } - d->Destroy (); } void file_duplicate () { - auto d = new FilmNameLocationDialog (this, _("Duplicate Film"), false); - int const r = d->ShowModal (); + auto d = make_wx(this, _("Duplicate Film"), false); - if (r == wxID_OK && d->check_path() && maybe_save_film()) { + if (d->ShowModal() == wxID_OK && d->check_path() && maybe_save_film()) { shared_ptr film (new Film (d->path())); film->copy_from (_film); film->set_name (d->path().filename().generic_string()); film->write_metadata (); } - - d->Destroy (); } void file_duplicate_and_open () { - auto d = new FilmNameLocationDialog (this, _("Duplicate Film"), false); - int const r = d->ShowModal (); + auto d = make_wx(this, _("Duplicate Film"), false); - if (r == wxID_OK && d->check_path() && maybe_save_film()) { - shared_ptr film (new Film (d->path())); + if (d->ShowModal() == wxID_OK && d->check_path() && maybe_save_film()) { + auto film = make_shared(d->path()); film->copy_from (_film); film->set_name (d->path().filename().generic_string()); film->write_metadata (); set_film (film); } - - d->Destroy (); } void file_close () @@ -691,30 +723,31 @@ private: { DCPOMATIC_ASSERT (_clipboard); - auto d = new PasteDialog (this, static_cast(_clipboard->video), static_cast(_clipboard->audio), !_clipboard->text.empty()); - if (d->ShowModal() == wxID_OK) { - for (auto i: _film_editor->content_panel()->selected()) { - if (d->video() && i->video) { - DCPOMATIC_ASSERT (_clipboard->video); - i->video->take_settings_from (_clipboard->video); - } - if (d->audio() && i->audio) { - DCPOMATIC_ASSERT (_clipboard->audio); - i->audio->take_settings_from (_clipboard->audio); - } + auto d = make_wx(this, static_cast(_clipboard->video), static_cast(_clipboard->audio), !_clipboard->text.empty()); + if (d->ShowModal() != wxID_OK) { + return; + } - if (d->text()) { - auto j = i->text.begin (); - auto k = _clipboard->text.begin (); - while (j != i->text.end() && k != _clipboard->text.end()) { - (*j)->take_settings_from (*k); - ++j; - ++k; - } + for (auto i: _film_editor->content_panel()->selected()) { + if (d->video() && i->video) { + DCPOMATIC_ASSERT (_clipboard->video); + i->video->take_settings_from (_clipboard->video); + } + if (d->audio() && i->audio) { + DCPOMATIC_ASSERT (_clipboard->audio); + i->audio->take_settings_from (_clipboard->audio); + } + + if (d->text()) { + auto j = i->text.begin (); + auto k = _clipboard->text.begin (); + while (j != i->text.end() && k != _clipboard->text.end()) { + (*j)->take_settings_from (*k); + ++j; + ++k; } } } - d->Destroy (); } void edit_select_all () @@ -732,21 +765,30 @@ private: void tools_restore_default_preferences () { - auto d = new wxMessageDialog ( - 0, + auto d = make_wx( + nullptr, _("Are you sure you want to restore preferences to their defaults? This cannot be undone."), _("Restore default preferences"), wxYES_NO | wxYES_DEFAULT | wxICON_QUESTION ); - int const r = d->ShowModal (); - d->Destroy (); - - if (r == wxID_YES) { + if (d->ShowModal() == wxID_YES) { Config::restore_defaults (); } } + void tools_export_preferences () + { + auto dialog = make_wx( + this, _("Specify ZIP file"), wxEmptyString, wxT("dcpomatic_config.zip"), wxT("ZIP files (*.zip)|*.zip"), + wxFD_SAVE | wxFD_OVERWRITE_PROMPT + ); + + if (dialog->ShowModal() == wxID_OK) { + save_all_config_as_zip (wx_to_std(dialog->GetPath())); + } + } + void jobs_make_dcp () { double required; @@ -766,10 +808,8 @@ private: } if (Config::instance()->show_hints_before_make_dcp()) { - auto hints = new HintsDialog (this, _film, false); - int const r = hints->ShowModal(); - hints->Destroy (); - if (r == wxID_CANCEL) { + auto hints = make_wx(this, _film, false); + if (hints->ShowModal() == wxID_CANCEL) { return; } } @@ -799,7 +839,7 @@ private: a long time, and crashes/power failures are moderately likely. */ _film->write_metadata (); - _film->make_dcp (TranscodeJob::ChangedBehaviour::EXAMINE_THEN_STOP); + make_dcp (_film, TranscodeJob::ChangedBehaviour::EXAMINE_THEN_STOP); } catch (BadSettingError& e) { error_dialog (this, wxString::Format (_("Bad setting for %s."), std_to_wx(e.setting()).data()), std_to_wx(e.what())); } catch (std::exception& e) { @@ -880,10 +920,8 @@ private: } if (Config::instance()->show_hints_before_make_dcp()) { - auto hints = new HintsDialog (this, _film, false); - int const r = hints->ShowModal(); - hints->Destroy (); - if (r == wxID_CANCEL) { + auto hints = make_wx(this, _film, false); + if (hints->ShowModal() == wxID_CANCEL) { return; } } @@ -920,9 +958,8 @@ private: return; } - auto d = new SelfDKDMDialog (this, _film); + auto d = make_wx(this, _film); if (d->ShowModal () != wxID_OK) { - d->Destroy (); return; } @@ -972,49 +1009,47 @@ private: kdm->as_xml (path); } } - - d->Destroy (); } void jobs_export_video_file () { - auto d = new ExportVideoFileDialog (this, _film->isdcf_name(true)); - if (d->ShowModal() == wxID_OK) { - if (boost::filesystem::exists(d->path())) { - bool ok = confirm_dialog( - this, - wxString::Format (_("File %s already exists. Do you want to overwrite it?"), std_to_wx(d->path().string()).data()) - ); - - if (!ok) { - d->Destroy (); - return; - } - } + auto d = make_wx(this, _film->isdcf_name(true)); + if (d->ShowModal() != wxID_OK) { + return; + } - auto job = make_shared(_film, TranscodeJob::ChangedBehaviour::EXAMINE_THEN_STOP); - job->set_encoder ( - make_shared ( - _film, job, d->path(), d->format(), d->mixdown_to_stereo(), d->split_reels(), d->split_streams(), d->x264_crf()) - ); - JobManager::instance()->add (job); + if (boost::filesystem::exists(d->path())) { + bool ok = confirm_dialog( + this, + wxString::Format (_("File %s already exists. Do you want to overwrite it?"), std_to_wx(d->path().string()).data()) + ); + + if (!ok) { + return; + } } - d->Destroy (); + + auto job = make_shared(_film, TranscodeJob::ChangedBehaviour::EXAMINE_THEN_STOP); + job->set_encoder ( + make_shared ( + _film, job, d->path(), d->format(), d->mixdown_to_stereo(), d->split_reels(), d->split_streams(), d->x264_crf()) + ); + JobManager::instance()->add (job); } void jobs_export_subtitles () { - auto d = new ExportSubtitlesDialog (this, _film->reels().size(), _film->interop()); - if (d->ShowModal() == wxID_OK) { - auto job = make_shared(_film, TranscodeJob::ChangedBehaviour::EXAMINE_THEN_STOP); - job->set_encoder ( - make_shared(_film, job, d->path(), _film->isdcf_name(true), d->split_reels(), d->include_font()) - ); - JobManager::instance()->add (job); + auto d = make_wx(this, _film->reels().size(), _film->interop()); + if (d->ShowModal() != wxID_OK) { + return; } - d->Destroy (); + auto job = make_shared(_film, TranscodeJob::ChangedBehaviour::EXAMINE_THEN_STOP); + job->set_encoder( + make_shared(_film, job, d->path(), _film->isdcf_name(true), d->split_reels(), d->include_font()) + ); + JobManager::instance()->add(job); } @@ -1033,7 +1068,7 @@ private: void view_closed_captions () { - _film_viewer->show_closed_captions (); + _film_viewer.show_closed_captions (); } void view_video_waveform () @@ -1089,48 +1124,46 @@ private: void tools_send_translations () { - auto d = new SendI18NDialog (this); - if (d->ShowModal() == wxID_OK) { - string body; - body += d->name() + "\n"; - body += d->language() + "\n"; - body += string(dcpomatic_version) + " " + string(dcpomatic_git_commit) + "\n"; - body += "--\n"; - auto translations = I18NHook::translations (); - for (auto i: translations) { - body += i.first + "\n" + i.second + "\n\n"; - } - list to = { "carl@dcpomatic.com" }; - if (d->email().find("@") == string::npos) { - error_dialog (this, _("You must enter a valid email address when sending translations, " - "otherwise the DCP-o-matic maintainers cannot credit you or contact you with questions.")); - } else { - Emailer emailer (d->email(), to, "DCP-o-matic translations", body); - try { - emailer.send ("main.carlh.net", 2525, EmailProtocol::STARTTLS); - } catch (NetworkError& e) { - error_dialog (this, _("Could not send translations"), std_to_wx(e.what())); - } - } + auto d = make_wx(this); + if (d->ShowModal() != wxID_OK) { + return; } - d->Destroy (); + string body; + body += d->name() + "\n"; + body += d->language() + "\n"; + body += string(dcpomatic_version) + " " + string(dcpomatic_git_commit) + "\n"; + body += "--\n"; + auto translations = I18NHook::translations (); + for (auto i: translations) { + body += i.first + "\n" + i.second + "\n\n"; + } + list to = { "carl@dcpomatic.com" }; + if (d->email().find("@") == string::npos) { + error_dialog (this, _("You must enter a valid email address when sending translations, " + "otherwise the DCP-o-matic maintainers cannot credit you or contact you with questions.")); + } else { + Emailer emailer (d->email(), to, "DCP-o-matic translations", body); + try { + emailer.send ("main.carlh.net", 2525, EmailProtocol::STARTTLS); + } catch (NetworkError& e) { + error_dialog (this, _("Could not send translations"), std_to_wx(e.what())); + } + } } void help_about () { - auto d = new AboutDialog (this); + auto d = make_wx(this); d->ShowModal (); - d->Destroy (); } void help_report_a_problem () { - auto d = new ReportProblemDialog (this, _film); + auto d = make_wx(this, _film); if (d->ShowModal () == wxID_OK) { d->report (); } - d->Destroy (); } bool should_close () @@ -1139,16 +1172,14 @@ private: return true; } - auto d = new wxMessageDialog ( - 0, + auto d = make_wx( + nullptr, _("There are unfinished jobs; are you sure you want to quit?"), _("Unfinished jobs"), wxYES_NO | wxYES_DEFAULT | wxICON_QUESTION ); - bool const r = d->ShowModal() == wxID_YES; - d->Destroy (); - return r; + return d->ShowModal() == wxID_YES; } void close (wxCloseEvent& ev) @@ -1191,6 +1222,15 @@ private: ev.Skip (); } + void active_jobs_changed() + { + /* ActiveJobsChanged can be called while JobManager holds a lock on its mutex, making + * the call to JobManager::get() in set_menu_sensitivity() deadlock unless we work around + * it by using an idle callback. This feels quite unpleasant. + */ + signal_manager->when_idle(boost::bind(&DOMFrame::set_menu_sensitivity, this)); + } + void set_menu_sensitivity () { auto jobs = JobManager::instance()->get (); @@ -1375,6 +1415,8 @@ private: add_item (tools, _("System information..."), ID_tools_system_information, 0); tools->AppendSeparator (); add_item (tools, _("Restore default preferences"), ID_tools_restore_default_preferences, ALWAYS); + tools->AppendSeparator (); + add_item (tools, _("Export preferences..."), ID_tools_export_preferences, ALWAYS); wxMenu* help = new wxMenu; #ifdef __WXOSX__ @@ -1433,7 +1475,7 @@ private: int pos = _history_position; - /* Clear out non-existant history items before we re-build the menu */ + /* Clear out non-existent history items before we re-build the menu */ Config::instance()->clean_history (); auto history = Config::instance()->history(); @@ -1472,9 +1514,8 @@ private: } if (uc->state() == UpdateChecker::State::YES) { - auto dialog = new UpdateDialog (this, uc->stable(), uc->test()); + auto dialog = make_wx(this, uc->stable(), uc->test()); dialog->ShowModal (); - dialog->Destroy (); } else if (uc->state() == UpdateChecker::State::FAILED) { error_dialog (this, _("The DCP-o-matic download server could not be contacted.")); } else { @@ -1486,10 +1527,10 @@ private: void start_stop_pressed () { - if (_film_viewer->playing()) { - _film_viewer->stop(); + if (_film_viewer.playing()) { + _film_viewer.stop(); } else { - _film_viewer->start(); + _film_viewer.start(); } } @@ -1500,23 +1541,39 @@ private: void back_frame () { - _film_viewer->seek_by (-_film_viewer->one_video_frame(), true); + _film_viewer.seek_by(-_film_viewer.one_video_frame(), true); } void forward_frame () { - _film_viewer->seek_by (_film_viewer->one_video_frame(), true); + _film_viewer.seek_by(_film_viewer.one_video_frame(), true); } void analytics_message (string title, string html) { - auto d = new HTMLDialog(this, std_to_wx(title), std_to_wx(html)); + auto d = make_wx(this, std_to_wx(title), std_to_wx(html)); d->ShowModal(); - d->Destroy(); + } + + void set_title () + { + auto s = wx_to_std(_("DCP-o-matic")); + if (_film) { + if (_film->directory()) { + s += " - " + _film->directory()->string(); + } + if (_film->dirty()) { + s += " *"; + } + } + + SetTitle (std_to_wx(s)); } FilmEditor* _film_editor; - std::shared_ptr _film_viewer; + LimitedFrameSplitter* _splitter; + wxPanel* _right_panel; + FilmViewer _film_viewer; StandardControls* _controls; VideoWaveformDialog* _video_waveform_dialog = nullptr; SystemInformationDialog* _system_information_dialog = nullptr; @@ -1566,12 +1623,12 @@ public: private: - bool OnInit () + bool OnInit () override { try { wxInitAllImageHandlers (); - Config::FailedToLoad.connect (boost::bind (&App::config_failed_to_load, this)); + Config::FailedToLoad.connect(boost::bind(&App::config_failed_to_load, this, _1)); Config::Warning.connect (boost::bind (&App::config_warning, this, _1)); _splash = maybe_show_splash (); @@ -1661,26 +1718,30 @@ private: if (Config::instance()->check_for_updates ()) { UpdateChecker::instance()->run (); } + + auto release_notes = find_release_notes(gui_is_dark()); + if (release_notes) { + auto notes = make_wx(nullptr, _("Release notes"), std_to_wx(*release_notes), true); + notes->Centre(); + notes->ShowModal(); + } } catch (exception& e) { - if (_splash) { - _splash->Destroy (); - _splash = nullptr; - } + _splash.reset(); error_dialog (nullptr, wxString::Format ("DCP-o-matic could not start."), std_to_wx(e.what())); } return true; } - void OnInitCmdLine (wxCmdLineParser& parser) + void OnInitCmdLine (wxCmdLineParser& parser) override { parser.SetDesc (command_line_description); parser.SetSwitchChars (wxT ("-")); } - bool OnCmdLineParsed (wxCmdLineParser& parser) + bool OnCmdLineParsed (wxCmdLineParser& parser) override { if (parser.Found (wxT("version"))) { cout << "dcpomatic version " << dcpomatic_version << " " << dcpomatic_git_commit << "\n"; @@ -1750,14 +1811,14 @@ private: } /* An unhandled exception has occurred inside the main event loop */ - bool OnExceptionInMainLoop () + bool OnExceptionInMainLoop () override { report_exception (); /* This will terminate the program */ return false; } - void OnUnhandledException () + void OnUnhandledException () override { report_exception (); } @@ -1779,15 +1840,12 @@ private: void close_splash () { - if (_splash) { - _splash->Destroy (); - _splash = 0; - } + _splash.reset(); } - void config_failed_to_load () + void config_failed_to_load (Config::LoadFailure what) { - message_dialog (_frame, _("The existing configuration failed to load. Default values will be used instead. These may take a short time to create.")); + report_config_load_failure(_frame, what); } void config_warning (string m) @@ -1800,34 +1858,31 @@ private: /* Destroy the splash screen here, as otherwise bad things seem to happen (for reasons unknown) when we open our recreate dialog, close it, *then* try to Destroy the splash (the Destroy fails). */ - _splash->Destroy (); - _splash = nullptr; + _splash.reset(); auto config = Config::instance(); switch (reason) { case Config::BAD_SIGNER_UTF8_STRINGS: { - if (config->nagged(Config::NAG_BAD_SIGNER_CHAIN)) { + if (config->nagged(Config::NAG_BAD_SIGNER_CHAIN_UTF8)) { return false; } - auto d = new RecreateChainDialog ( + auto d = make_wx( _frame, _("Recreate signing certificates"), _("The certificate chain that DCP-o-matic uses for signing DCPs and KDMs contains a small error\n" "which will prevent DCPs from being validated correctly on some systems. Do you want to re-create\n" "the certificate chain for signing DCPs and KDMs?"), _("Do nothing"), - Config::NAG_BAD_SIGNER_CHAIN + Config::NAG_BAD_SIGNER_CHAIN_UTF8 ); - int const r = d->ShowModal (); - d->Destroy (); - return r == wxID_OK; + return d->ShowModal() == wxID_OK; } case Config::BAD_SIGNER_VALIDITY_TOO_LONG: { if (config->nagged(Config::NAG_BAD_SIGNER_CHAIN_VALIDITY)) { return false; } - auto d = new RecreateChainDialog ( + auto d = make_wx( _frame, _("Recreate signing certificates"), _("The certificate chain that DCP-o-matic uses for signing DCPs and KDMs has a validity period\n" "that is too long. This will cause problems playing back DCPs on some systems.\n" @@ -1835,29 +1890,25 @@ private: _("Do nothing"), Config::NAG_BAD_SIGNER_CHAIN_VALIDITY ); - int const r = d->ShowModal (); - d->Destroy (); - return r == wxID_OK; + return d->ShowModal() == wxID_OK; } case Config::BAD_SIGNER_INCONSISTENT: { - auto d = new RecreateChainDialog ( + auto d = make_wx( _frame, _("Recreate signing certificates"), _("The certificate chain that DCP-o-matic uses for signing DCPs and KDMs is inconsistent and\n" "cannot be used. DCP-o-matic cannot start unless you re-create it. Do you want to re-create\n" "the certificate chain for signing DCPs and KDMs?"), _("Close DCP-o-matic") ); - int const r = d->ShowModal (); - d->Destroy (); - if (r != wxID_OK) { + if (d->ShowModal() != wxID_OK) { exit (EXIT_FAILURE); } return true; } case Config::BAD_DECRYPTION_INCONSISTENT: { - auto d = new RecreateChainDialog ( + auto d = make_wx( _frame, _("Recreate KDM decryption chain"), _("The certificate chain that DCP-o-matic uses for decrypting KDMs is inconsistent and\n" "cannot be used. DCP-o-matic cannot start unless you re-create it. Do you want to re-create\n" @@ -1865,9 +1916,7 @@ private: "configuration before continuing."), _("Close DCP-o-matic") ); - int const r = d->ShowModal (); - d->Destroy (); - if (r != wxID_OK) { + if (d->ShowModal() != wxID_OK) { exit (EXIT_FAILURE); } return true; @@ -1878,7 +1927,7 @@ private: } DOMFrame* _frame = nullptr; - wxSplashScreen* _splash = nullptr; + wx_ptr _splash; shared_ptr _timer; string _film_to_load; string _film_to_create;