X-Git-Url: https://git.carlh.net/gitweb/?a=blobdiff_plain;f=src%2Fwx%2Fhints_dialog.cc;h=72ab0eef41f84e6e7fbac6772bf1eee7895768b0;hb=a8a0dfd1b21de6c0facf965ab119833ff6f790bf;hp=83b4ece84ddbe639d201fc971f11855b9bf8040f;hpb=ea3e9db20ede512d5e5d73b41c4cb796eeef56d3;p=dcpomatic.git diff --git a/src/wx/hints_dialog.cc b/src/wx/hints_dialog.cc index 83b4ece84..72ab0eef4 100644 --- a/src/wx/hints_dialog.cc +++ b/src/wx/hints_dialog.cc @@ -1,38 +1,43 @@ /* - Copyright (C) 2012-2015 Carl Hetherington + Copyright (C) 2012-2016 Carl Hetherington - This program is free software; you can redistribute it and/or modify + This file is part of DCP-o-matic. + + DCP-o-matic is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. - This program is distributed in the hope that it will be useful, + DCP-o-matic is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; if not, write to the Free Software - Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. + along with DCP-o-matic. If not, see . */ +#include "hints_dialog.h" #include "lib/film.h" #include "lib/ratio.h" #include "lib/video_content.h" #include "lib/subtitle_content.h" #include "lib/font.h" -#include "hints_dialog.h" +#include "lib/content.h" +#include "lib/audio_analysis.h" #include #include #include +using std::max; using boost::shared_ptr; +using boost::optional; using boost::dynamic_pointer_cast; -HintsDialog::HintsDialog (wxWindow* parent, boost::weak_ptr f) +HintsDialog::HintsDialog (wxWindow* parent, boost::weak_ptr film) : wxDialog (parent, wxID_ANY, _("Hints")) - , _film (f) + , _film (film) { wxBoxSizer* sizer = new wxBoxSizer (wxVERTICAL); _text = new wxRichTextCtrl (this, wxID_ANY, wxEmptyString, wxDefaultPosition, wxSize (400, 300), wxRE_READONLY); @@ -49,10 +54,10 @@ HintsDialog::HintsDialog (wxWindow* parent, boost::weak_ptr f) _text->GetCaret()->Hide (); - boost::shared_ptr film = _film.lock (); - if (film) { - _film_changed_connection = film->Changed.connect (boost::bind (&HintsDialog::film_changed, this)); - _film_content_changed_connection = film->ContentChanged.connect (boost::bind (&HintsDialog::film_changed, this)); + boost::shared_ptr locked_film = _film.lock (); + if (locked_film) { + _film_changed_connection = locked_film->Changed.connect (boost::bind (&HintsDialog::film_changed, this)); + _film_content_changed_connection = locked_film->ContentChanged.connect (boost::bind (&HintsDialog::film_changed, this)); } film_changed (); @@ -63,24 +68,26 @@ HintsDialog::film_changed () { _text->Clear (); bool hint = false; - + boost::shared_ptr film = _film.lock (); if (!film) { return; } ContentList content = film->content (); - + _text->BeginStandardBullet (N_("standard/circle"), 1, 50); bool big_font_files = false; if (film->interop ()) { BOOST_FOREACH (shared_ptr i, content) { - shared_ptr s = dynamic_pointer_cast (i); - if (s) { - BOOST_FOREACH (shared_ptr j, s->fonts ()) { - if (j->file && boost::filesystem::file_size (j->file.get ()) >= (640 * 1024)) { - big_font_files = true; + if (i->subtitle) { + BOOST_FOREACH (shared_ptr j, i->subtitle->fonts ()) { + for (int k = 0; k < FontFiles::VARIANTS; ++k) { + optional const p = j->file (static_cast (k)); + if (p && boost::filesystem::file_size (p.get()) >= (640 * 1024)) { + big_font_files = true; + } } } } @@ -92,27 +99,17 @@ HintsDialog::film_changed () _text->WriteText (_("You have specified a font file which is larger than 640kB. This is very likely to cause problems on playback.")); } - if (film->audio_channels() % 2) { - hint = true; - _text->WriteText (_("Your DCP has an odd number of audio channels. This is very likely to cause problems on playback.")); - _text->Newline (); - } else if (film->audio_channels() < 6) { + if (film->audio_channels() < 6) { hint = true; _text->WriteText (_("Your DCP has fewer than 6 audio channels. This may cause problems on some projectors.")); _text->Newline (); - } else if (film->audio_channels() == 0) { - /* Carsten Kurz reckons having no audio can be a problem */ - hint = true; - _text->WriteText (_("Your DCP has no audio channels. This is likely to cause problems on playback.")); - _text->Newline (); } int flat_or_narrower = 0; int scope = 0; - for (ContentList::const_iterator i = content.begin(); i != content.end(); ++i) { - shared_ptr vc = dynamic_pointer_cast (*i); - if (vc) { - Ratio const * r = vc->scale().ratio (); + BOOST_FOREACH (shared_ptr i, content) { + if (i->video) { + Ratio const * r = i->video->scale().ratio (); if (r && r->id() == "239") { ++scope; } else if (r && r->id() != "239" && r->id() != "full-frame") { @@ -132,7 +129,7 @@ HintsDialog::film_changed () _text->WriteText (_("All of your content is at 1.85:1 or narrower but your DCP's container is Scope (2.39:1). This will pillar-box your content inside a Flat (1.85:1) frame. You may prefer to set your DCP's container to Flat (1.85:1) in the \"DCP\" tab.")); _text->Newline (); } - + if (film->video_frame_rate() != 24 && film->video_frame_rate() != 48) { hint = true; _text->WriteText (wxString::Format (_("Your DCP frame rate (%d fps) may cause problems in a few (mostly older) projectors. Use 24 or 48 frames per second to be on the safe side."), film->video_frame_rate())); @@ -145,9 +142,15 @@ HintsDialog::film_changed () _text->Newline (); } + if (film->interop() && film->video_frame_rate() != 24 && film->video_frame_rate() != 48) { + hint = true; + _text->WriteText (_("You are set up for an Interop DCP at a frame rate which is not officially supported. You are advised to make a SMPTE DCP instead.")); + _text->Newline (); + } + int vob = 0; - for (ContentList::const_iterator i = content.begin(); i != content.end(); ++i) { - if (boost::algorithm::starts_with ((*i)->path(0).filename().string(), "VTS_")) { + BOOST_FOREACH (shared_ptr i, content) { + if (boost::algorithm::starts_with (i->path(0).filename().string(), "VTS_")) { ++vob; } } @@ -159,19 +162,36 @@ HintsDialog::film_changed () } int three_d = 0; - for (ContentList::const_iterator i = content.begin(); i != content.end(); ++i) { - shared_ptr vc = dynamic_pointer_cast (*i); - if (vc && vc->video_frame_type() != VIDEO_FRAME_TYPE_2D) { + BOOST_FOREACH (shared_ptr i, content) { + if (i->video && i->video->frame_type() != VIDEO_FRAME_TYPE_2D) { ++three_d; } } - if (three_d > 0) { + if (three_d > 0 && !film->three_d()) { hint = true; _text->WriteText (_("You are using 3D content but your DCP is set to 2D. Set the DCP to 3D if you want to play it back on a 3D system (e.g. Real-D, MasterImage etc.)")); _text->Newline (); } + boost::filesystem::path path = film->audio_analysis_path (film->playlist ()); + if (boost::filesystem::exists (path)) { + shared_ptr an (new AudioAnalysis (path)); + if (an->sample_peak() || an->true_peak()) { + float const peak = max (an->sample_peak().get_value_or(0), an->true_peak().get_value_or(0)); + float const peak_dB = 20 * log10 (peak) + an->gain_correction (film->playlist ()); + if (peak_dB > -3 && peak_dB < -0.5) { + hint = true; + _text->WriteText (_("Your audio level is very high. You should reduce the gain of your audio content.")); + _text->Newline (); + } else if (peak_dB > -0.5) { + hint = true; + _text->WriteText (_("Your audio level is very close to clipping. You should reduce the gain of your audio content.")); + _text->Newline (); + } + } + } + _text->EndSymbolBullet (); if (!hint) {