X-Git-Url: https://git.carlh.net/gitweb/?a=blobdiff_plain;f=src%2Fwx%2Fhints_dialog.cc;h=b5d5c6971dd819972b9e4a583291b109a05491b1;hb=4dbc6ef917aeceb906b1ef1caf6911033e7e2c54;hp=668d713216e8ad49b1a40a8a9acd41b0ab7e62fd;hpb=8bef34f672815c3c9b4236d06fdee8dfd0bffbc2;p=dcpomatic.git

diff --git a/src/wx/hints_dialog.cc b/src/wx/hints_dialog.cc
index 668d71321..b5d5c6971 100644
--- a/src/wx/hints_dialog.cc
+++ b/src/wx/hints_dialog.cc
@@ -17,10 +17,15 @@
 
 */
 
-#include <boost/algorithm/string.hpp>
-#include <wx/richtext/richtextctrl.h>
 #include "lib/film.h"
+#include "lib/ratio.h"
+#include "lib/video_content.h"
 #include "hints_dialog.h"
+#include <boost/algorithm/string.hpp>
+#include <wx/richtext/richtextctrl.h>
+
+using boost::shared_ptr;
+using boost::dynamic_pointer_cast;
 
 HintsDialog::HintsDialog (wxWindow* parent, boost::weak_ptr<Film> f)
 	: wxDialog (parent, wxID_ANY, _("Hints"))
@@ -44,6 +49,7 @@ HintsDialog::HintsDialog (wxWindow* parent, boost::weak_ptr<Film> f)
 	boost::shared_ptr<Film> film = _film.lock ();
 	if (film) {
 		film->Changed.connect (boost::bind (&HintsDialog::film_changed, this));
+		film->ContentChanged.connect (boost::bind (&HintsDialog::film_changed, this));
 	}
 
 	film_changed ();
@@ -69,15 +75,52 @@ HintsDialog::film_changed ()
 		hint = true;
 		_text->WriteText (_("Your DCP has fewer than 6 audio channels.  This may cause problems on some projectors."));
 		_text->Newline ();
+	} else if (film->audio_channels() == 0) {
+		/* Carsten Kurz reckons having no audio can be a problem */
+		hint = true;
+		_text->WriteText (_("Your DCP has no audio channels.  This is likely to cause problems on playback."));
+		_text->Newline ();
 	}
 
+	ContentList content = film->content ();
+	int flat_or_narrower = 0;
+	int scope = 0;
+	for (ContentList::const_iterator i = content.begin(); i != content.end(); ++i) {
+		shared_ptr<VideoContent> vc = dynamic_pointer_cast<VideoContent> (*i);
+		if (vc) {
+			Ratio const * r = vc->scale().ratio ();
+			if (r && r->id() == "239") {
+				++scope;
+			} else if (r && r->id() != "239" && r->id() != "full-frame") {
+				++flat_or_narrower;
+			}
+		}
+	}
+
+	if (scope && !flat_or_narrower && film->container()->id() == "185") {
+		hint = true;
+		_text->WriteText (_("All of your content is in Scope (2.39:1) but your DCP's container is Flat (1.85:1).  This will letter-box your content inside a Flat (1.85:1) frame.  You may prefer to set your DCP's container to Scope (2.39:1) in the \"DCP\" tab."));
+		_text->Newline ();
+	}
+
+	if (!scope && flat_or_narrower && film->container()->id() == "239") {
+		hint = true;
+		_text->WriteText (_("All of your content is at 1.85:1 or narrower but your DCP's container is Scope (2.39:1).  This will pillar-box your content inside a Flat (1.85:1) frame.  You may prefer to set your DCP's container to Flat (1.85:1) in the \"DCP\" tab."));
+		_text->Newline ();
+	}
+	
 	if (film->video_frame_rate() != 24 && film->video_frame_rate() != 48) {
 		hint = true;
 		_text->WriteText (wxString::Format (_("Your DCP frame rate (%d fps) may cause problems in a few (mostly older) projectors.  Use 24 or 48 frames per second to be on the safe side."), film->video_frame_rate()));
 		_text->Newline ();
 	}
 
-	ContentList content = film->content ();
+	if (film->j2k_bandwidth() >= 245000000) {
+		hint = true;
+		_text->WriteText (_("A few projectors have problems playing back very high bit-rate DCPs.  It is a good idea to drop the JPEG2000 bandwidth down to about 200Mbit/s; this is unlikely to have any visible effect on the image."));
+		_text->Newline ();
+	}
+
 	int vob = 0;
 	for (ContentList::const_iterator i = content.begin(); i != content.end(); ++i) {
 		if (boost::algorithm::starts_with ((*i)->path(0).filename().string(), "VTS_")) {
@@ -91,6 +134,20 @@ HintsDialog::film_changed ()
 		_text->Newline ();
 	}
 
+	int three_d = 0;
+	for (ContentList::const_iterator i = content.begin(); i != content.end(); ++i) {
+		shared_ptr<const VideoContent> vc = dynamic_pointer_cast<const VideoContent> (*i);
+		if (vc && vc->video_frame_type() != VIDEO_FRAME_TYPE_2D) {
+			++three_d;
+		}
+	}
+
+	if (three_d > 0) {
+		hint = true;
+		_text->WriteText (_("You are using 3D content but your DCP is set to 2D.  Set the DCP to 3D if you want to play it back on a 3D system (e.g. Real-D, MasterImage etc.)"));
+		_text->Newline ();
+	}
+
 	_text->EndSymbolBullet ();
 
 	if (!hint) {