X-Git-Url: https://git.carlh.net/gitweb/?a=blobdiff_plain;f=src%2Fwx%2Fhints_dialog.cc;h=cb971a671a02f9d82ca1eae733d977acc1e43b1d;hb=6433cf55c702939f564ce01c3877dd9296a7e6cf;hp=df22500d2ca6b6a1f8eca51913f1202a8000656a;hpb=ce835adf99ec81ea182ac151f6e0d1cc3376d175;p=dcpomatic.git

diff --git a/src/wx/hints_dialog.cc b/src/wx/hints_dialog.cc
index df22500d2..cb971a671 100644
--- a/src/wx/hints_dialog.cc
+++ b/src/wx/hints_dialog.cc
@@ -1,49 +1,73 @@
 /*
-    Copyright (C) 2012-2013 Carl Hetherington <cth@carlh.net>
+    Copyright (C) 2012-2016 Carl Hetherington <cth@carlh.net>
 
-    This program is free software; you can redistribute it and/or modify
+    This file is part of DCP-o-matic.
+
+    DCP-o-matic is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
     the Free Software Foundation; either version 2 of the License, or
     (at your option) any later version.
 
-    This program is distributed in the hope that it will be useful,
+    DCP-o-matic is distributed in the hope that it will be useful,
     but WITHOUT ANY WARRANTY; without even the implied warranty of
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
     GNU General Public License for more details.
 
     You should have received a copy of the GNU General Public License
-    along with this program; if not, write to the Free Software
-    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+    along with DCP-o-matic.  If not, see <http://www.gnu.org/licenses/>.
 
 */
 
-#include <boost/algorithm/string.hpp>
-#include <wx/richtext/richtextctrl.h>
-#include "lib/film.h"
 #include "hints_dialog.h"
+#include "wx_util.h"
+#include "lib/film.h"
+#include "lib/hints.h"
+#include "lib/config.h"
+#include <wx/richtext/richtextctrl.h>
+#include <boost/foreach.hpp>
+
+using std::max;
+using std::vector;
+using std::string;
+using boost::shared_ptr;
+using boost::optional;
+using boost::dynamic_pointer_cast;
 
-HintsDialog::HintsDialog (wxWindow* parent, boost::weak_ptr<Film> f)
+HintsDialog::HintsDialog (wxWindow* parent, boost::weak_ptr<Film> film, bool ok)
 	: wxDialog (parent, wxID_ANY, _("Hints"))
-	, _film (f)
+	, _film (film)
 {
 	wxBoxSizer* sizer = new wxBoxSizer (wxVERTICAL);
 	_text = new wxRichTextCtrl (this, wxID_ANY, wxEmptyString, wxDefaultPosition, wxSize (400, 300), wxRE_READONLY);
 	sizer->Add (_text, 1, wxEXPAND | wxALL, 6);
 
-	wxSizer* buttons = CreateSeparatedButtonSizer (wxOK);
-	if (buttons) {
-		sizer->Add (buttons, wxSizerFlags().Expand().DoubleBorder());
+	if (!ok) {
+		wxCheckBox* b = new wxCheckBox (this, wxID_ANY, _("Don't show hints again"));
+		sizer->Add (b, 0, wxALL, 6);
+		b->Bind (wxEVT_COMMAND_CHECKBOX_CLICKED, bind (&HintsDialog::shut_up, this, _1));
 	}
 
+	wxStdDialogButtonSizer* buttons = CreateStdDialogButtonSizer (0);
+	sizer->Add (CreateSeparatedSizer(buttons), wxSizerFlags().Expand().DoubleBorder());
+	if (ok) {
+		buttons->SetAffirmativeButton (new wxButton (this, wxID_OK));
+	} else {
+		buttons->SetAffirmativeButton (new wxButton (this, wxID_OK, _("Make DCP anyway")));
+		buttons->SetNegativeButton (new wxButton (this, wxID_CANCEL, _("Go back")));
+	}
+
+	buttons->Realize ();
+
 	SetSizer (sizer);
 	sizer->Layout ();
 	sizer->SetSizeHints (this);
 
 	_text->GetCaret()->Hide ();
 
-	boost::shared_ptr<Film> film = _film.lock ();
-	if (film) {
-		film->Changed.connect (boost::bind (&HintsDialog::film_changed, this));
+	boost::shared_ptr<Film> locked_film = _film.lock ();
+	if (locked_film) {
+		_film_changed_connection = locked_film->Changed.connect (boost::bind (&HintsDialog::film_changed, this));
+		_film_content_changed_connection = locked_film->ContentChanged.connect (boost::bind (&HintsDialog::film_changed, this));
 	}
 
 	film_changed ();
@@ -53,47 +77,28 @@ void
 HintsDialog::film_changed ()
 {
 	_text->Clear ();
-	bool hint = false;
-	
+
 	boost::shared_ptr<Film> film = _film.lock ();
 	if (!film) {
 		return;
 	}
 
-	_text->BeginStandardBullet (N_("standard/circle"), 1, 50);
-	if (film->audio_channels() % 2) {
-		hint = true;
-		_text->WriteText (_("Your DCP has an odd number of audio channels.  This is very likely to cause problems on playback."));
-		_text->Newline ();
-	} else if (film->audio_channels() < 6) {
-		hint = true;
-		_text->WriteText (_("Your DCP has fewer than 6 audio channels.  This may cause problems on some projectors."));
-		_text->Newline ();
-	}
+	vector<string> hints = get_hints (film);
 
-	if (film->video_frame_rate() != 24 && film->video_frame_rate() != 48) {
-		hint = true;
-		_text->WriteText (wxString::Format (_("Your DCP frame rate (%d fps) may cause problems in a few (mostly older) projectors.  Use 24 or 48 frames per second to be on the safe side."), film->video_frame_rate()));
-		_text->Newline ();
-	}
-
-	ContentList content = film->content ();
-	int vob = 0;
-	for (ContentList::const_iterator i = content.begin(); i != content.end(); ++i) {
-		if (boost::algorithm::starts_with ((*i)->path().filename().string(), "VTS_")) {
-			++vob;
+	if (hints.empty ()) {
+		_text->WriteText (_("There are no hints: everything looks good!"));
+	} else {
+		_text->BeginStandardBullet (N_("standard/circle"), 1, 50);
+		BOOST_FOREACH (string i, hints) {
+			_text->WriteText (std_to_wx (i));
+			_text->Newline ();
 		}
+		_text->EndSymbolBullet ();
 	}
+}
 
-	if (vob > 1) {
-		hint = true;
-		_text->WriteText (wxString::Format (_("You have %d files that look like they are VOB files from DVD.  You should coalesce them to ensure smooth joins between the files."), vob));
-		_text->Newline ();
-	}
-
-	_text->EndSymbolBullet ();
-
-	if (!hint) {
-		_text->WriteText (_("There are no hints: everything looks good!"));
-	}
+void
+HintsDialog::shut_up (wxCommandEvent& ev)
+{
+	Config::instance()->set_show_hints_before_make_dcp (!ev.IsChecked());
 }