X-Git-Url: https://git.carlh.net/gitweb/?a=blobdiff_plain;f=src%2Fwx%2Fscreen_dialog.cc;h=0ad8d9cf2e705136b518dc8c7a1d41ff4e6cd9dc;hb=5ee919f413a6c1048aecf83676d42ab3fd94e06e;hp=1f1fc2fad7ae746170dad7d2088c776e6a2d78fc;hpb=2eb7ac323df51a65df1a7cf856058fb4cf0bc020;p=dcpomatic.git diff --git a/src/wx/screen_dialog.cc b/src/wx/screen_dialog.cc index 1f1fc2fad..0ad8d9cf2 100644 --- a/src/wx/screen_dialog.cc +++ b/src/wx/screen_dialog.cc @@ -64,14 +64,13 @@ public: void load_certificate () { - auto dialog = new FileDialog(this, _("Trusted Device certificate"), wxEmptyString, wxFD_DEFAULT_STYLE, "SelectCertificatePath"); - ScopeGuard sg = [dialog]() { dialog->Destroy(); }; - if (!dialog->show()) { + FileDialog dialog(this, _("Trusted Device certificate"), wxEmptyString, wxFD_DEFAULT_STYLE, "SelectCertificatePath"); + if (!dialog.show()) { return; } try { - _certificate = dcp::Certificate(dcp::file_to_string(dialog->paths()[0])); + _certificate = dcp::Certificate(dcp::file_to_string(dialog.paths()[0])); _thumbprint->SetValue (std_to_wx(_certificate->thumbprint())); } catch (dcp::MiscError& e) { error_dialog(this, wxString::Format(_("Could not load certificate (%s)"), std_to_wx(e.what()))); @@ -122,43 +121,69 @@ ScreenDialog::ScreenDialog ( _sizer = new wxGridBagSizer (DCPOMATIC_SIZER_X_GAP, DCPOMATIC_SIZER_Y_GAP); int r = 0; - add_label_to_sizer (_sizer, this, _("Name"), true, wxGBPosition(r, 0)); + wxFont subheading_font(*wxNORMAL_FONT); + subheading_font.SetWeight(wxFONTWEIGHT_BOLD); + + auto subheading = new StaticText(this, _("Details")); + subheading->SetFont(subheading_font); + _sizer->Add(subheading, wxGBPosition(r, 0), wxGBSpan(1, 2)); + ++r; + + add_label_to_sizer(_sizer, this, _("Name"), true, wxGBPosition(r, 0), wxDefaultSpan, true); _name = new wxTextCtrl (this, wxID_ANY, std_to_wx (name), wxDefaultPosition, wxSize (320, -1)); _sizer->Add (_name, wxGBPosition (r, 1)); ++r; - add_label_to_sizer (_sizer, this, _("Notes"), true, wxGBPosition(r, 0)); + add_label_to_sizer(_sizer, this, _("Notes"), true, wxGBPosition(r, 0), wxDefaultSpan, true); _notes = new wxTextCtrl (this, wxID_ANY, std_to_wx(notes), wxDefaultPosition, wxSize(320, -1)); _sizer->Add (_notes, wxGBPosition(r, 1)); ++r; - wxClientDC dc (this); - wxFont font = _name->GetFont (); - font.SetFamily (wxFONTFAMILY_TELETYPE); - dc.SetFont (font); - wxSize size = dc.GetTextExtent (wxT("1234567890123456789012345678")); - size.SetHeight (-1); - - add_label_to_sizer (_sizer, this, _("Recipient certificate"), true, wxGBPosition(r, 0)); - auto s = new wxBoxSizer (wxHORIZONTAL); - _recipient_thumbprint = new StaticText (this, wxT (""), wxDefaultPosition, size); - _recipient_thumbprint->SetFont (font); - set_recipient (recipient); + subheading = new StaticText(this, _("Recipient")); + subheading->SetFont(subheading_font); + _sizer->Add(subheading, wxGBPosition(r, 0), wxGBSpan(1, 2), wxTOP, DCPOMATIC_SUBHEADING_TOP_PAD); + ++r; _get_recipient_from_file = new Button (this, _("Get from file...")); _download_recipient = new Button (this, _("Download...")); - s->Add (_recipient_thumbprint, 1, wxRIGHT | wxALIGN_CENTER_VERTICAL | wxALIGN_LEFT, DCPOMATIC_SIZER_X_GAP); + auto s = new wxBoxSizer (wxHORIZONTAL); s->Add (_get_recipient_from_file, 0, wxLEFT | wxRIGHT | wxEXPAND, DCPOMATIC_SIZER_X_GAP); s->Add (_download_recipient, 0, wxLEFT | wxRIGHT | wxEXPAND, DCPOMATIC_SIZER_X_GAP); - _sizer->Add (s, wxGBPosition (r, 1)); + _sizer->Add(s, wxGBPosition(r, 0), wxGBSpan(1, 2)); ++r; - add_label_to_sizer (_sizer, this, _("Filename"), true, wxGBPosition(r, 0)); - _recipient_file = new wxStaticText (this, wxID_ANY, wxT("")); - checked_set (_recipient_file, recipient_file.get_value_or("")); + auto add_certificate_detail = [&r, this](wxString name, wxStaticText** value, wxSize size = wxDefaultSize) { + add_label_to_sizer(_sizer, this, name, true, wxGBPosition(r, 0), wxDefaultSpan, true); + *value = new StaticText(this, wxT (""), wxDefaultPosition, size); + _sizer->Add(*value, wxGBPosition(r, 1)); + ++r; + }; + + wxClientDC dc (this); + wxFont teletype_font = _name->GetFont(); + teletype_font.SetFamily(wxFONTFAMILY_TELETYPE); + dc.SetFont(teletype_font); + wxSize size = dc.GetTextExtent (wxT("1234567890123456789012345678")); + size.SetHeight (-1); + + add_certificate_detail(_("Thumbprint"), &_recipient_thumbprint, size); + _recipient_thumbprint->SetFont(teletype_font); + + add_label_to_sizer(_sizer, this, _("Filename"), true, wxGBPosition(r, 0), wxDefaultSpan, true); + _recipient_file = new wxStaticText(this, wxID_ANY, wxT(""), wxDefaultPosition, wxSize(600, -1), wxST_ELLIPSIZE_MIDDLE | wxST_NO_AUTORESIZE); + set_recipient_file(recipient_file.get_value_or("")); _sizer->Add (_recipient_file, wxGBPosition(r, 1), wxDefaultSpan, wxALIGN_CENTER_VERTICAL, DCPOMATIC_SIZER_Y_GAP); ++r; + add_certificate_detail(_("Subject common name"), &_subject_common_name); + add_certificate_detail(_("Subject organization name"), &_subject_organization_name); + add_certificate_detail(_("Issuer common name"), &_issuer_common_name); + add_certificate_detail(_("Issuer organization name"), &_issuer_organization_name); + add_certificate_detail(_("Not valid before"), &_not_valid_before); + add_certificate_detail(_("Not valid after"), &_not_valid_after); + + set_recipient (recipient); + { int flags = wxALIGN_CENTER_VERTICAL | wxTOP; #ifdef __WXOSX__ @@ -167,7 +192,8 @@ ScreenDialog::ScreenDialog ( #else auto m = new StaticText (this, _("Other trusted devices")); #endif - _sizer->Add (m, wxGBPosition(r, 0), wxDefaultSpan, flags, DCPOMATIC_SIZER_Y_GAP); + m->SetFont(subheading_font); + _sizer->Add(m, wxGBPosition(r, 0), wxDefaultSpan, flags, DCPOMATIC_SUBHEADING_TOP_PAD); } ++r; @@ -185,7 +211,7 @@ ScreenDialog::ScreenDialog ( EditableListButton::NEW | EditableListButton::EDIT | EditableListButton::REMOVE ); - _sizer->Add (_trusted_device_list, wxGBPosition (r, 0), wxGBSpan (1, 3), wxEXPAND); + _sizer->Add(_trusted_device_list, wxGBPosition (r, 0), wxGBSpan (1, 3), wxEXPAND | wxLEFT, DCPOMATIC_SIZER_X_GAP); ++r; _name->Bind (wxEVT_TEXT, boost::bind (&ScreenDialog::setup_sensitivity, this)); @@ -194,7 +220,7 @@ ScreenDialog::ScreenDialog ( overall_sizer->Add (_sizer, 1, wxEXPAND | wxALL, DCPOMATIC_DIALOG_BORDER); - wxSizer* buttons = CreateSeparatedButtonSizer (wxOK | wxCANCEL); + auto buttons = CreateSeparatedButtonSizer (wxOK | wxCANCEL); if (buttons) { overall_sizer->Add (buttons, wxSizerFlags().Expand().DoubleBorder()); } @@ -249,7 +275,7 @@ ScreenDialog::load_recipient (boost::filesystem::path file) return; } set_recipient (c.leaf ()); - checked_set (_recipient_file, file.string()); + set_recipient_file(file.string()); } catch (dcp::MiscError& e) { error_dialog (this, _("Could not read certificate file."), std_to_wx(e.what())); } @@ -259,10 +285,9 @@ ScreenDialog::load_recipient (boost::filesystem::path file) void ScreenDialog::get_recipient_from_file () { - auto dialog = new FileDialog(this, _("Select Certificate File"), wxEmptyString, wxFD_DEFAULT_STYLE , "SelectCertificatePath"); - ScopeGuard sg = [dialog]() { dialog->Destroy(); }; - if (dialog->show()) { - load_recipient(dialog->paths()[0]); + FileDialog dialog(this, _("Select Certificate File"), wxEmptyString, wxFD_DEFAULT_STYLE , "SelectCertificatePath"); + if (dialog.show()) { + load_recipient(dialog.paths()[0]); } setup_sensitivity (); @@ -272,12 +297,11 @@ ScreenDialog::get_recipient_from_file () void ScreenDialog::download_recipient () { - auto d = new DownloadCertificateDialog (this); - if (d->ShowModal() == wxID_OK) { - set_recipient (d->certificate()); - checked_set (_recipient_file, d->url()); + DownloadCertificateDialog dialog(this); + if (dialog.ShowModal() == wxID_OK) { + set_recipient(dialog.certificate()); + set_recipient_file(dialog.url()); } - d->Destroy (); setup_sensitivity (); } @@ -299,6 +323,21 @@ ScreenDialog::set_recipient (optional r) if (_recipient) { _recipient_thumbprint->SetLabel (std_to_wx (_recipient->thumbprint ())); + _subject_common_name->SetLabel(std_to_wx(_recipient->subject_common_name())); + _subject_organization_name->SetLabel(std_to_wx(_recipient->subject_organization_name())); + _issuer_common_name->SetLabel(std_to_wx(_recipient->issuer_common_name())); + _issuer_organization_name->SetLabel(std_to_wx(_recipient->issuer_organization_name())); + _not_valid_before->SetLabel(std_to_wx(_recipient->not_before().as_string())); + _not_valid_after->SetLabel(std_to_wx(_recipient->not_after().as_string())); _sizer->Layout (); } } + + +void +ScreenDialog::set_recipient_file(string file) +{ + checked_set(_recipient_file, file); + _recipient_file->SetToolTip(std_to_wx(file)); +} +