X-Git-Url: https://git.carlh.net/gitweb/?a=blobdiff_plain;f=test%2Fcreate_cli_test.cc;h=97ac25374da8a135e3e6c7f38e46c099f93749f3;hb=280454a14ebf4dceeac3077e41fceec36d9ec3e3;hp=dff10a11c2fed9203329a8360b3c770d190d9bdc;hpb=5f206d32ff60148ab72b35d5823f56bdbb7f50bf;p=dcpomatic.git

diff --git a/test/create_cli_test.cc b/test/create_cli_test.cc
index dff10a11c..97ac25374 100644
--- a/test/create_cli_test.cc
+++ b/test/create_cli_test.cc
@@ -37,21 +37,19 @@ run (string cmd)
 	boost::escaped_list_separator<char> els ("", " ", "\"\'");
 	boost::tokenizer<boost::escaped_list_separator<char> > tok (cmd, els);
 
-	char** argv = new char*[256];
+	std::vector<char*> argv(256);
 	int argc = 0;
 
 	for (boost::tokenizer<boost::escaped_list_separator<char> >::iterator i = tok.begin(); i != tok.end(); ++i) {
 		argv[argc++] = strdup (i->c_str());
 	}
 
-	CreateCLI cc (argc, argv);
+	CreateCLI cc (argc, argv.data());
 
 	for (int i = 0; i < argc; ++i) {
 		free (argv[i]);
 	}
 
-	delete[] argv;
-
 	return cc;
 }
 
@@ -144,6 +142,12 @@ BOOST_AUTO_TEST_CASE (create_cli_test)
 	BOOST_CHECK_EQUAL (cc.content[1].frame_type, VideoFrameType::THREE_D_RIGHT);
 	BOOST_CHECK_EQUAL (cc.fourk, false);
 
+	cc = run ("dcpomatic2_create --twok foo.mp4");
+	BOOST_REQUIRE_EQUAL (cc.content.size(), 1U);
+	BOOST_CHECK_EQUAL (cc.content[0].path, "foo.mp4");
+	BOOST_CHECK_EQUAL (cc.twok, true);
+	BOOST_CHECK (!cc.error);
+
 	cc = run ("dcpomatic2_create --fourk foo.mp4");
 	BOOST_REQUIRE_EQUAL (cc.content.size(), 1U);
 	BOOST_CHECK_EQUAL (cc.content[0].path, "foo.mp4");
@@ -171,4 +175,13 @@ BOOST_AUTO_TEST_CASE (create_cli_test)
 	cc = run ("dcpomatic2_create --channel foo fred.wav");
 	BOOST_REQUIRE (cc.error);
 	BOOST_CHECK (boost::algorithm::starts_with(*cc.error, "dcpomatic2_create: foo is not valid for --channel"));
+
+	cc = run ("dcpomatic2_create fred.wav --gain -6 jim.wav --gain 2 sheila.wav");
+	BOOST_REQUIRE_EQUAL (cc.content.size(), 3U);
+	BOOST_CHECK_EQUAL (cc.content[0].path, "fred.wav");
+	BOOST_CHECK (!cc.content[0].gain);
+	BOOST_CHECK_EQUAL (cc.content[1].path, "jim.wav");
+	BOOST_CHECK_CLOSE (*cc.content[1].gain, -6, 0.001);
+	BOOST_CHECK_EQUAL (cc.content[2].path, "sheila.wav");
+	BOOST_CHECK_CLOSE (*cc.content[2].gain, 2, 0.001);
 }