X-Git-Url: https://git.carlh.net/gitweb/?a=blobdiff_plain;f=test%2Fdcp_subtitle_test.cc;h=407ac26164e405cc674c0b349f4c4dcd7869f5ee;hb=99bcbf1e71585a13c00d9696284d5a1e71913fbd;hp=27dd87bbf940d416ae4e508f2b16563a02265549;hpb=b1dc9c3a2f7e55c9afc5bf2d5b465371b048e14f;p=dcpomatic.git

diff --git a/test/dcp_subtitle_test.cc b/test/dcp_subtitle_test.cc
index 27dd87bbf..407ac2616 100644
--- a/test/dcp_subtitle_test.cc
+++ b/test/dcp_subtitle_test.cc
@@ -1,5 +1,5 @@
 /*
-    Copyright (C) 2014 Carl Hetherington <cth@carlh.net>
+    Copyright (C) 2014-2016 Carl Hetherington <cth@carlh.net>
 
     This file is part of DCP-o-matic.
 
@@ -20,6 +20,7 @@
 
 /** @file  test/dcp_subtitle_test.cc
  *  @brief Test DCP subtitle content in various ways.
+ *  @ingroup specific
  */
 
 #include <boost/test/unit_test.hpp>
@@ -29,6 +30,7 @@
 #include "lib/ratio.h"
 #include "lib/dcp_decoder.h"
 #include "lib/dcp_content_type.h"
+#include "lib/dcp_subtitle_decoder.h"
 #include "lib/subtitle_content.h"
 #include "lib/content_subtitle.h"
 #include "lib/subtitle_decoder.h"
@@ -38,6 +40,21 @@
 using std::cout;
 using std::list;
 using boost::shared_ptr;
+using boost::optional;
+
+optional<ContentTextSubtitle> stored;
+
+static void
+store (ContentTextSubtitle sub)
+{
+	if (!stored) {
+		stored = sub;
+	} else {
+		BOOST_FOREACH (dcp::SubtitleString i, sub.subs) {
+			stored->subs.push_back (i);
+		}
+	}
+}
 
 /** Test pass-through of a very simple DCP subtitle file */
 BOOST_AUTO_TEST_CASE (dcp_subtitle_test)
@@ -46,6 +63,7 @@ BOOST_AUTO_TEST_CASE (dcp_subtitle_test)
 	film->set_container (Ratio::from_id ("185"));
 	film->set_dcp_content_type (DCPContentType::from_isdcf_name ("TLR"));
 	film->set_name ("frobozz");
+	film->set_interop (false);
 	shared_ptr<DCPSubtitleContent> content (new DCPSubtitleContent (film, "test/data/dcp_sub.xml"));
 	film->examine_and_add_content (content);
 	wait_for_jobs ();
@@ -71,33 +89,71 @@ BOOST_AUTO_TEST_CASE (dcp_subtitle_within_dcp_test)
 	film->examine_and_add_content (content);
 	wait_for_jobs ();
 
-	shared_ptr<DCPDecoder> decoder (new DCPDecoder (content, film->log()));
-
-	list<ContentTimePeriod> ctp = decoder->text_subtitles_during (
-		ContentTimePeriod (
-			ContentTime::from_seconds (25),
-			ContentTime::from_seconds (26)
-			),
-		true
-		);
-
-	BOOST_REQUIRE_EQUAL (ctp.size(), 2);
-	BOOST_CHECK_EQUAL (ctp.front().from.get(), ContentTime::from_seconds(25 + 12 * 0.04).get());
-	BOOST_CHECK_EQUAL (ctp.front().to.get(), ContentTime::from_seconds(26 + 4 * 0.04).get());
-	BOOST_CHECK_EQUAL (ctp.back().from.get(), ContentTime::from_seconds(25 + 12 * 0.04).get());
-	BOOST_CHECK_EQUAL (ctp.back().to.get(), ContentTime::from_seconds(26 + 4 * 0.04).get());
-
-	list<ContentTextSubtitle> subs = decoder->subtitle->get_text (
-		ContentTimePeriod (
-			ContentTime::from_seconds (25),
-			ContentTime::from_seconds (26)
-			),
-		true,
-		true
-		);
-
-	BOOST_REQUIRE_EQUAL (subs.size(), 1);
-	BOOST_REQUIRE_EQUAL (subs.front().subs.size(), 2);
-	BOOST_CHECK_EQUAL (subs.front().subs.front().text(), "Noch mal.");
-	BOOST_CHECK_EQUAL (subs.front().subs.back().text(), "Encore une fois.");
+	shared_ptr<DCPDecoder> decoder (new DCPDecoder (content, film->log(), false));
+	decoder->subtitle->TextStart.connect (bind (store, _1));
+
+	stored = optional<ContentTextSubtitle> ();
+	while (!decoder->pass() && !stored) {}
+
+	BOOST_REQUIRE (stored);
+	BOOST_REQUIRE_EQUAL (stored->subs.size(), 2);
+	BOOST_CHECK_EQUAL (stored->subs.front().text(), "Noch mal.");
+	BOOST_CHECK_EQUAL (stored->subs.back().text(), "Encore une fois.");
+}
+
+/** Test subtitles whose text includes things like &lt;b&gt; */
+BOOST_AUTO_TEST_CASE (dcp_subtitle_test2)
+{
+	shared_ptr<Film> film = new_test_film ("dcp_subtitle_test2");
+	film->set_container (Ratio::from_id ("185"));
+	film->set_dcp_content_type (DCPContentType::from_isdcf_name ("TLR"));
+	film->set_name ("frobozz");
+	shared_ptr<DCPSubtitleContent> content (new DCPSubtitleContent (film, "test/data/dcp_sub2.xml"));
+	film->examine_and_add_content (content);
+	wait_for_jobs ();
+
+	shared_ptr<DCPSubtitleDecoder> decoder (new DCPSubtitleDecoder (content, film->log()));
+	decoder->subtitle->TextStart.connect (bind (store, _1));
+
+	stored = optional<ContentTextSubtitle> ();
+	while (!decoder->pass ()) {
+		if (stored && stored->from() == ContentTime(0)) {
+			BOOST_CHECK_EQUAL (stored->subs.front().text(), "&lt;b&gt;Hello world!&lt;/b&gt;");
+		}
+	}
+}
+
+/** Test a failure case */
+BOOST_AUTO_TEST_CASE (dcp_subtitle_test3)
+{
+	shared_ptr<Film> film = new_test_film ("dcp_subtitle_test3");
+	film->set_container (Ratio::from_id ("185"));
+	film->set_dcp_content_type (DCPContentType::from_isdcf_name ("TLR"));
+	film->set_name ("frobozz");
+	film->set_interop (true);
+	shared_ptr<DCPSubtitleContent> content (new DCPSubtitleContent (film, "test/data/dcp_sub3.xml"));
+	film->examine_and_add_content (content);
+	wait_for_jobs ();
+
+	film->make_dcp ();
+	wait_for_jobs ();
+
+	shared_ptr<DCPSubtitleDecoder> decoder (new DCPSubtitleDecoder (content, film->log()));
+	stored = optional<ContentTextSubtitle> ();
+	while (!decoder->pass ()) {
+		decoder->subtitle->TextStart.connect (bind (store, _1));
+		if (stored && stored->from() == ContentTime::from_seconds(0.08)) {
+			list<dcp::SubtitleString> s = stored->subs;
+			list<dcp::SubtitleString>::const_iterator i = s.begin ();
+			BOOST_CHECK_EQUAL (i->text(), "This");
+			++i;
+			BOOST_REQUIRE (i != s.end ());
+			BOOST_CHECK_EQUAL (i->text(), " is ");
+			++i;
+			BOOST_REQUIRE (i != s.end ());
+			BOOST_CHECK_EQUAL (i->text(), "wrong.");
+			++i;
+			BOOST_REQUIRE (i == s.end ());
+		}
+	}
 }