X-Git-Url: https://git.carlh.net/gitweb/?a=blobdiff_plain;f=test%2Fffmpeg_decoder_sequential_test.cc;h=03bf9e2ce3adfe0de8e4de5df599e05e402577ce;hb=refs%2Fheads%2Frelease%2Fv2.7.0-fix;hp=96de9be2784e1ce5830ee7d5cf1fe180815181c2;hpb=c86ed0c80b762d31eb68386662a7c37ae4e21b6b;p=dcpomatic.git

diff --git a/test/ffmpeg_decoder_sequential_test.cc b/test/ffmpeg_decoder_sequential_test.cc
index 96de9be27..03bf9e2ce 100644
--- a/test/ffmpeg_decoder_sequential_test.cc
+++ b/test/ffmpeg_decoder_sequential_test.cc
@@ -17,22 +17,28 @@
 
 */
 
-#include <boost/test/unit_test.hpp>
-#include <boost/filesystem.hpp>
+/** @file  test/ffmpeg_decoder_sequential_test.cc
+ *  @brief Check that the FFmpeg decoder produces sequential frames without gaps or dropped frames;
+ *  (dropped frames being checked by assert() in VideoDecoder).  Also that the decoder picks up frame rates correctly.
+ */
+
 #include "lib/ffmpeg_content.h"
 #include "lib/ffmpeg_decoder.h"
-#include "lib/log.h"
+#include "lib/null_log.h"
 #include "lib/film.h"
 #include "test.h"
+#include <boost/filesystem.hpp>
+#include <boost/test/unit_test.hpp>
+#include <iostream>
 
 using std::cout;
 using std::cerr;
+using std::list;
 using boost::shared_ptr;
 using boost::optional;
 
-/** @param black Frame index of first frame in the video */ 
 static void
-test (boost::filesystem::path file, float fps, int first)
+test (boost::filesystem::path file, float fps, int gaps, int video_length)
 {
 	boost::filesystem::path path = private_data / file;
 	if (!boost::filesystem::exists (path)) {
@@ -41,36 +47,34 @@ test (boost::filesystem::path file, float fps, int first)
 	}
 
 	shared_ptr<Film> film = new_test_film ("ffmpeg_decoder_seek_test_" + file.string());
-	shared_ptr<FFmpegContent> content (new FFmpegContent (film, path)); 
+	shared_ptr<FFmpegContent> content (new FFmpegContent (film, path));
 	film->examine_and_add_content (content);
 	wait_for_jobs ();
 	shared_ptr<Log> log (new NullLog);
-	FFmpegDecoder decoder (content, log);
+	shared_ptr<FFmpegDecoder> decoder (new FFmpegDecoder (content, log, false));
+
+	BOOST_CHECK_CLOSE (decoder->video_content()->video_frame_rate(), fps, 0.01);
 
-	BOOST_CHECK_CLOSE (decoder.video_content()->video_frame_rate(), fps, 0.01);
-	
-	VideoFrame const N = decoder.video_content()->video_length().frames (decoder.video_content()->video_frame_rate ());
-	decoder.test_gaps = 0;
-	for (VideoFrame i = 0; i < N; ++i) {
-		optional<ContentVideo> v;
-		v = decoder.get_video (i, true);
-		if (i < first) {
-			BOOST_CHECK (!v);
-		} else {
-			BOOST_CHECK (v);
-			BOOST_CHECK_EQUAL (v->frame, i);
-		}
+#ifdef DCPOMATIC_DEBUG
+	decoder->test_gaps = 0;
+#endif
+	for (Frame i = 0; i < video_length; ++i) {
+		list<ContentVideo> v;
+		v = decoder->get_video (i, true);
+		BOOST_REQUIRE_EQUAL (v.size(), 1U);
+		BOOST_CHECK_EQUAL (v.front().frame, i);
 	}
-	BOOST_CHECK_EQUAL (decoder.test_gaps, 0);
+#ifdef DCPOMATIC_DEBUG
+	BOOST_CHECK_EQUAL (decoder->test_gaps, gaps);
+#endif
 }
 
-/** Check that the FFmpeg decoder produces sequential frames without gaps or dropped frames;
- *  (dropped frames being checked by assert() in VideoDecoder).  Also that the decoder picks up frame rates correctly.
- */
 BOOST_AUTO_TEST_CASE (ffmpeg_decoder_sequential_test)
 {
-	//test ("boon_telly.mkv", 29.97, 0);
-	//test ("Sintel_Trailer1.480p.DivX_Plus_HD.mkv", 24, 0);
-	test ("prophet_clip.mkv", 23.976, 12);
+	test ("boon_telly.mkv", 29.97, 0, 6910);
+	test ("Sintel_Trailer1.480p.DivX_Plus_HD.mkv", 24, 0, 1248);
+	/* The first video frame is 12 here, so VideoDecoder should see 12 gaps
+	   (at the start of the file)
+	*/
+	test ("prophet_clip.mkv", 23.976, 12, 2875);
 }
-