X-Git-Url: https://git.carlh.net/gitweb/?a=blobdiff_plain;f=test%2Ffilm_metadata_test.cc;h=029b990e9d0ffbc5886535d4df13995882e3a7dc;hb=21333e55ec55cce4d8fcf5bb7fa1e21292fc9c17;hp=0b4495b486989f3dc8b0adde516a7d936b9bf151;hpb=5f0f0de782100a5cb558f30c7768c8af0c19bcb7;p=dcpomatic.git diff --git a/test/film_metadata_test.cc b/test/film_metadata_test.cc index 0b4495b48..029b990e9 100644 --- a/test/film_metadata_test.cc +++ b/test/film_metadata_test.cc @@ -1,76 +1,127 @@ /* - Copyright (C) 2013 Carl Hetherington + Copyright (C) 2013-2014 Carl Hetherington - This program is free software; you can redistribute it and/or modify + This file is part of DCP-o-matic. + + DCP-o-matic is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. - This program is distributed in the hope that it will be useful, + DCP-o-matic is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; if not, write to the Free Software - Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. + along with DCP-o-matic. If not, see . */ + +/** @file test/film_metadata_test.cc + * @brief Test some basic reading/writing of film metadata. + * @ingroup feature + */ + + +#include "lib/content.h" +#include "lib/content_factory.h" +#include "lib/dcp_content.h" +#include "lib/dcp_content_type.h" +#include "lib/film.h" +#include "lib/ratio.h" +#include "lib/text_content.h" +#include "test.h" +#include +#include +#include + + +using std::string; +using std::list; +using std::make_shared; + + BOOST_AUTO_TEST_CASE (film_metadata_test) { - string const test_film = "build/test/film_metadata_test"; - - if (boost::filesystem::exists (test_film)) { - boost::filesystem::remove_all (test_film); - } - - BOOST_CHECK_THROW (new Film (test_film, true), OpenFileError); - - shared_ptr f (new Film (test_film, false)); - f->_dci_date = boost::gregorian::from_undelimited_string ("20130211"); - BOOST_CHECK (f->format() == 0); - BOOST_CHECK (f->dcp_content_type() == 0); - BOOST_CHECK (f->filters ().empty()); - - f->set_name ("fred"); - BOOST_CHECK_THROW (f->set_content ("jim"), OpenFileError); - f->set_dcp_content_type (DCPContentType::from_pretty_name ("Short")); - f->set_format (Format::from_nickname ("Flat")); - f->set_left_crop (1); - f->set_right_crop (2); - f->set_top_crop (3); - f->set_bottom_crop (4); - vector f_filters; - f_filters.push_back (Filter::from_id ("pphb")); - f_filters.push_back (Filter::from_id ("unsharp")); - f->set_filters (f_filters); - f->set_trim_start (42); - f->set_trim_end (99); - f->set_dcp_ab (true); - f->write_metadata (); - - stringstream s; - s << "diff -u test/metadata.ref " << test_film << "/metadata"; - BOOST_CHECK_EQUAL (::system (s.str().c_str ()), 0); - - shared_ptr g (new Film (test_film, true)); + auto film = new_test_film ("film_metadata_test"); + auto dir = test_film_dir ("film_metadata_test"); + + film->_isdcf_date = boost::gregorian::from_undelimited_string ("20130211"); + BOOST_CHECK (film->container() == Ratio::from_id ("185")); + BOOST_CHECK (film->dcp_content_type() == nullptr); + + film->set_name ("fred"); + film->set_dcp_content_type (DCPContentType::from_isdcf_name ("SHR")); + film->set_container (Ratio::from_id ("185")); + film->set_j2k_bandwidth (200000000); + film->set_interop (false); + film->set_chain (string("")); + film->set_distributor (string("")); + film->set_facility (string("")); + film->set_release_territory (dcp::LanguageTag::RegionSubtag("US")); + film->write_metadata (); + + list ignore = { "Key", "ContextID", "LastWrittenBy" }; + check_xml ("test/data/metadata.xml.ref", dir.string() + "/metadata.xml", ignore); + + auto g = make_shared(dir); + g->read_metadata (); BOOST_CHECK_EQUAL (g->name(), "fred"); - BOOST_CHECK_EQUAL (g->dcp_content_type(), DCPContentType::from_pretty_name ("Short")); - BOOST_CHECK_EQUAL (g->format(), Format::from_nickname ("Flat")); - BOOST_CHECK_EQUAL (g->crop().left, 1); - BOOST_CHECK_EQUAL (g->crop().right, 2); - BOOST_CHECK_EQUAL (g->crop().top, 3); - BOOST_CHECK_EQUAL (g->crop().bottom, 4); - vector g_filters = g->filters (); - BOOST_CHECK_EQUAL (g_filters.size(), 2); - BOOST_CHECK_EQUAL (g_filters.front(), Filter::from_id ("pphb")); - BOOST_CHECK_EQUAL (g_filters.back(), Filter::from_id ("unsharp")); - BOOST_CHECK_EQUAL (g->trim_start(), 42); - BOOST_CHECK_EQUAL (g->trim_end(), 99); - BOOST_CHECK_EQUAL (g->dcp_ab(), true); - + BOOST_CHECK_EQUAL (g->dcp_content_type(), DCPContentType::from_isdcf_name ("SHR")); + BOOST_CHECK_EQUAL (g->container(), Ratio::from_id ("185")); + g->write_metadata (); - BOOST_CHECK_EQUAL (::system (s.str().c_str ()), 0); + check_xml ("test/data/metadata.xml.ref", dir.string() + "/metadata.xml", ignore); +} + + +/** Check a bug where tags with multiple s would fail to load */ +BOOST_AUTO_TEST_CASE (multiple_text_nodes_are_allowed) +{ + auto subs = content_factory("test/data/15s.srt").front(); + auto caps = content_factory("test/data/15s.srt").front(); + auto film = new_test_film2("multiple_text_nodes_are_allowed1", { subs, caps }); + caps->only_text()->set_type(TextType::CLOSED_CAPTION); + make_and_verify_dcp ( + film, + { + dcp::VerificationNote::Code::MISSING_CPL_METADATA, + dcp::VerificationNote::Code::MISSING_SUBTITLE_LANGUAGE, + dcp::VerificationNote::Code::INVALID_SUBTITLE_FIRST_TEXT_TIME + }); + + auto reload = make_shared(film->dir(film->dcp_name())); + auto film2 = new_test_film2("multiple_text_nodes_are_allowed2", { reload }); + film2->write_metadata (); + + auto test = make_shared(boost::filesystem::path("build/test/multiple_text_nodes_are_allowed2")); + test->read_metadata(); +} + + +/** Read some metadata from v2.14.x that fails to open on 2.15.x */ +BOOST_AUTO_TEST_CASE (metadata_loads_from_2_14_x_1) +{ + namespace fs = boost::filesystem; + auto film = make_shared(fs::path("build/test/metadata_loads_from_2_14_x_1")); + auto notes = film->read_metadata(fs::path("test/data/2.14.x.metadata.1.xml")); + BOOST_REQUIRE_EQUAL (notes.size(), 0U); } + + +/** Read some more metadata from v2.14.x that fails to open on 2.15.x */ +BOOST_AUTO_TEST_CASE (metadata_loads_from_2_14_x_2) +{ + namespace fs = boost::filesystem; + auto film = make_shared(fs::path("build/test/metadata_loads_from_2_14_x_2")); + auto notes = film->read_metadata(fs::path("test/data/2.14.x.metadata.2.xml")); + BOOST_REQUIRE_EQUAL (notes.size(), 1U); + BOOST_REQUIRE_EQUAL (notes.front(), + "A subtitle or closed caption file in this project is marked with the language 'eng', " + "which DCP-o-matic does not recognise. The file's language has been cleared." + ); +} +