X-Git-Url: https://git.carlh.net/gitweb/?a=blobdiff_plain;f=test%2Ffilm_metadata_test.cc;h=5c44c2a91377204e5a19e2da91dc8ddc131507ad;hb=7ec6c86c913fba820870565ee757fdf43ae47433;hp=5fcb4b195eedcf714d53e9e1c9dce4d18b903b82;hpb=21702cc5f4b0e6fc7114f9fffb118246fbfda2e2;p=dcpomatic.git diff --git a/test/film_metadata_test.cc b/test/film_metadata_test.cc index 5fcb4b195..5c44c2a91 100644 --- a/test/film_metadata_test.cc +++ b/test/film_metadata_test.cc @@ -18,6 +18,7 @@ */ + /** @file test/film_metadata_test.cc * @brief Test some basic reading/writing of film metadata. * @ingroup feature @@ -31,6 +32,7 @@ #include "lib/film.h" #include "lib/ratio.h" #include "lib/text_content.h" +#include "lib/video_content.h" #include "test.h" #include #include @@ -40,7 +42,7 @@ using std::string; using std::list; using std::make_shared; -using std::shared_ptr; +using std::vector; BOOST_AUTO_TEST_CASE (film_metadata_test) @@ -50,7 +52,7 @@ BOOST_AUTO_TEST_CASE (film_metadata_test) film->_isdcf_date = boost::gregorian::from_undelimited_string ("20130211"); BOOST_CHECK (film->container() == Ratio::from_id ("185")); - BOOST_CHECK (film->dcp_content_type() == 0); + BOOST_CHECK (film->dcp_content_type() == nullptr); film->set_name ("fred"); film->set_dcp_content_type (DCPContentType::from_isdcf_name ("SHR")); @@ -63,7 +65,7 @@ BOOST_AUTO_TEST_CASE (film_metadata_test) film->set_release_territory (dcp::LanguageTag::RegionSubtag("US")); film->write_metadata (); - list ignore = { "Key", "ContextID" }; + list ignore = { "Key", "ContextID", "LastWrittenBy" }; check_xml ("test/data/metadata.xml.ref", dir.string() + "/metadata.xml", ignore); auto g = make_shared(dir); @@ -76,3 +78,135 @@ BOOST_AUTO_TEST_CASE (film_metadata_test) g->write_metadata (); check_xml ("test/data/metadata.xml.ref", dir.string() + "/metadata.xml", ignore); } + + +/** Check a bug where tags with multiple s would fail to load */ +BOOST_AUTO_TEST_CASE (multiple_text_nodes_are_allowed) +{ + auto subs = content_factory("test/data/15s.srt").front(); + auto caps = content_factory("test/data/15s.srt").front(); + auto film = new_test_film2("multiple_text_nodes_are_allowed1", { subs, caps }); + caps->only_text()->set_type(TextType::CLOSED_CAPTION); + make_and_verify_dcp ( + film, + { + dcp::VerificationNote::Code::MISSING_CPL_METADATA, + dcp::VerificationNote::Code::MISSING_SUBTITLE_LANGUAGE, + dcp::VerificationNote::Code::INVALID_SUBTITLE_FIRST_TEXT_TIME + }); + + auto reload = make_shared(film->dir(film->dcp_name())); + auto film2 = new_test_film2("multiple_text_nodes_are_allowed2", { reload }); + film2->write_metadata (); + + auto test = make_shared(boost::filesystem::path("build/test/multiple_text_nodes_are_allowed2")); + test->read_metadata(); +} + + +/** Read some metadata from v2.14.x that fails to open on 2.15.x */ +BOOST_AUTO_TEST_CASE (metadata_loads_from_2_14_x_1) +{ + namespace fs = boost::filesystem; + auto dir = fs::path("build/test/metadata_loads_from_2_14_x_1"); + fs::remove_all(dir); + auto film = make_shared(dir); + fs::copy_file("test/data/2.14.x.metadata.1.xml", dir / "metadata.xml"); + auto notes = film->read_metadata(dir / "metadata.xml"); + BOOST_REQUIRE_EQUAL (notes.size(), 0U); +} + + +/** Read some more metadata from v2.14.x that fails to open on 2.15.x */ +BOOST_AUTO_TEST_CASE (metadata_loads_from_2_14_x_2) +{ + namespace fs = boost::filesystem; + auto dir = fs::path("build/test/metadata_loads_from_2_14_x_2"); + fs::remove_all(dir); + auto film = make_shared(dir); + fs::copy_file("test/data/2.14.x.metadata.2.xml", dir / "metadata.xml"); + auto notes = film->read_metadata(dir / "metadata.xml"); + BOOST_REQUIRE_EQUAL (notes.size(), 1U); + BOOST_REQUIRE_EQUAL (notes.front(), + "A subtitle or closed caption file in this project is marked with the language 'eng', " + "which DCP-o-matic does not recognise. The file's language has been cleared." + ); +} + + +BOOST_AUTO_TEST_CASE (metadata_loads_from_2_14_x_3) +{ + namespace fs = boost::filesystem; + auto dir = fs::path("build/test/metadata_loads_from_2_14_x_3"); + fs::remove_all(dir); + auto film = make_shared(dir); + fs::copy_file("test/data/2.14.x.metadata.3.xml", dir / "metadata.xml"); + auto notes = film->read_metadata(dir / "metadata.xml"); + + BOOST_REQUIRE (film->release_territory()); + BOOST_REQUIRE (film->release_territory()->subtag() == dcp::LanguageTag::RegionSubtag("de").subtag()); + + BOOST_REQUIRE (film->audio_language()); + BOOST_REQUIRE (*film->audio_language() == dcp::LanguageTag("sv-SE")); + + BOOST_REQUIRE (film->content_versions() == vector{"3"}); + BOOST_REQUIRE (film->ratings() == vector{ dcp::Rating("", "214rating") }); + BOOST_REQUIRE_EQUAL (film->studio().get_value_or(""), "214studio"); + BOOST_REQUIRE_EQUAL (film->facility().get_value_or(""), "214facility"); + BOOST_REQUIRE_EQUAL (film->temp_version(), true); + BOOST_REQUIRE_EQUAL (film->pre_release(), true); + BOOST_REQUIRE_EQUAL (film->red_band(), true); + BOOST_REQUIRE_EQUAL (film->two_d_version_of_three_d(), true); + BOOST_REQUIRE_EQUAL (film->chain().get_value_or(""), "214chain"); + BOOST_REQUIRE (film->luminance() == dcp::Luminance(14, dcp::Luminance::Unit::FOOT_LAMBERT)); +} + + +/** Check that an empty tag results in the film's luminance being unset */ +BOOST_AUTO_TEST_CASE (metadata_loads_from_2_14_x_4) +{ + namespace fs = boost::filesystem; + auto dir = fs::path("build/test/metadata_loads_from_2_14_x_4"); + fs::remove_all(dir); + auto film = make_shared(dir); + fs::copy_file("test/data/2.14.x.metadata.4.xml", dir / "metadata.xml"); + auto notes = film->read_metadata(dir / "metadata.xml"); + + BOOST_REQUIRE (!film->luminance()); +} + + +BOOST_AUTO_TEST_CASE (metadata_video_range_guessed_for_dcp) +{ + namespace fs = boost::filesystem; + auto film = make_shared(fs::path("test/data/214x_dcp")); + film->read_metadata(); + + BOOST_REQUIRE_EQUAL(film->content().size(), 1U); + BOOST_REQUIRE(film->content()[0]->video); + BOOST_CHECK(film->content()[0]->video->range() == VideoRange::FULL); +} + + +BOOST_AUTO_TEST_CASE (metadata_video_range_guessed_for_mp4_with_unknown_range) +{ + namespace fs = boost::filesystem; + auto film = make_shared(fs::path("test/data/214x_mp4")); + film->read_metadata(); + + BOOST_REQUIRE_EQUAL(film->content().size(), 1U); + BOOST_REQUIRE(film->content()[0]->video); + BOOST_CHECK(film->content()[0]->video->range() == VideoRange::VIDEO); +} + + +BOOST_AUTO_TEST_CASE (metadata_video_range_guessed_for_png) +{ + namespace fs = boost::filesystem; + auto film = make_shared(fs::path("test/data/214x_png")); + film->read_metadata(); + + BOOST_REQUIRE_EQUAL(film->content().size(), 1U); + BOOST_REQUIRE(film->content()[0]->video); + BOOST_CHECK(film->content()[0]->video->range() == VideoRange::FULL); +}