X-Git-Url: https://git.carlh.net/gitweb/?a=blobdiff_plain;f=test%2Fhints_test.cc;h=bc858192dc6f33876a82adc61603d81677727c5c;hb=8a8c977c12fc65f1f50ea05099387e0fc8840e7d;hp=c228cd07af4c6b38089c259dd9242a0b0785b20f;hpb=cd6c6a693f19fcaa6c75ed60f48a54a8cae51352;p=dcpomatic.git

diff --git a/test/hints_test.cc b/test/hints_test.cc
index c228cd07a..bc858192d 100644
--- a/test/hints_test.cc
+++ b/test/hints_test.cc
@@ -1,5 +1,5 @@
 /*
-    Copyright (C) 2020-2021 Carl Hetherington <cth@carlh.net>
+    Copyright (C) 2020-2022 Carl Hetherington <cth@carlh.net>
 
     This file is part of DCP-o-matic.
 
@@ -20,6 +20,7 @@
 
 
 #include "lib/audio_content.h"
+#include "lib/config.h"
 #include "lib/content.h"
 #include "lib/content_factory.h"
 #include "lib/cross.h"
@@ -199,16 +200,16 @@ BOOST_AUTO_TEST_CASE (hint_closed_caption_xml_too_big)
 
 	auto film = new_test_film2 (name);
 
-	auto ccap = fopen_boost (String::compose("build/test/%1.srt", name), "w");
+	dcp::File ccap(String::compose("build/test/%1.srt", name), "w");
 	BOOST_REQUIRE (ccap);
 	for (int i = 0; i < 2048; ++i) {
-		fprintf(ccap, "%d\n", i + 1);
+		fprintf(ccap.get(), "%d\n", i + 1);
 		int second = i * 2;
 		int minute = second % 60;
-		fprintf(ccap, "00:%02d:%02d,000 --> 00:%02d:%02d,000\n", minute, second, minute, second + 1);
-		fprintf(ccap, "Here are some closed captions.\n\n");
+		fprintf(ccap.get(), "00:%02d:%02d,000 --> 00:%02d:%02d,000\n", minute, second, minute, second + 1);
+		fprintf(ccap.get(), "Here are some closed captions.\n\n");
 	}
-	fclose (ccap);
+	ccap.close();
 
 	auto content = content_factory("build/test/" + name + ".srt").front();
 	content->text.front()->set_type (TextType::CLOSED_CAPTION);
@@ -254,6 +255,24 @@ BOOST_AUTO_TEST_CASE (hints_audio_with_no_language)
 		"Some of your content has audio but you have not set the audio language.  It is advisable to set the audio language "
 		"in the \"DCP\" tab unless your audio has no spoken parts."
 		);
+}
+
+
+BOOST_AUTO_TEST_CASE (hints_certificate_validity)
+{
+	ConfigRestorer cr;
+
+	Config::instance()->set_signer_chain(make_shared<dcp::CertificateChain>(openssl_path(), 40 * 365));
 
+	auto film = new_test_film2 ("hints_certificate_validity");
+	auto hints = get_hints (film);
+	BOOST_REQUIRE_EQUAL (hints.size(), 1U);
+	BOOST_CHECK_EQUAL (
+		hints[0],
+		"The certificate chain that DCP-o-matic uses for signing DCPs and KDMs has a validity period "
+		"that is too long.  This will cause problems playing back DCPs on some systems. "
+		"You are advised to re-create the signing certificate chain by clicking the "
+		"\"Re-make certificates and key...\" button in the Keys page of Preferences."
+		);
 }