X-Git-Url: https://git.carlh.net/gitweb/?a=blobdiff_plain;f=test%2Fplayer_test.cc;h=4ff79b436d0fd2436d123381fc32d560adfdf436;hb=27b83475435dda4e84a90cf59a52f150905c4ab1;hp=5a31076f26ef27eb82d430b1b2cb15986209a67a;hpb=0329a95dfdbcc185346c8431d6bb50df1a521100;p=dcpomatic.git diff --git a/test/player_test.cc b/test/player_test.cc index 5a31076f2..4ff79b436 100644 --- a/test/player_test.cc +++ b/test/player_test.cc @@ -1,5 +1,5 @@ /* - Copyright (C) 2014 Carl Hetherington + Copyright (C) 2014-2018 Carl Hetherington This file is part of DCP-o-matic. @@ -23,8 +23,6 @@ * @ingroup selfcontained */ -#include -#include #include "lib/film.h" #include "lib/ffmpeg_content.h" #include "lib/dcp_content_type.h" @@ -33,19 +31,28 @@ #include "lib/player.h" #include "lib/video_content.h" #include "lib/image_content.h" +#include "lib/text_caption_file_content.h" +#include "lib/content_factory.h" +#include "lib/dcp_content.h" +#include "lib/caption_content.h" +#include "lib/butler.h" +#include "lib/compose.hpp" #include "test.h" +#include +#include using std::cout; using std::list; +using std::pair; using boost::shared_ptr; using boost::bind; +using boost::optional; static shared_ptr accumulated; static void -accumulate (shared_ptr audio, DCPTime t) +accumulate (shared_ptr audio, DCPTime) { - cout << "got " << audio->frames() << " @ " << to_string(t) << "\n"; BOOST_REQUIRE (accumulated); accumulated->append (audio); } @@ -85,6 +92,7 @@ BOOST_AUTO_TEST_CASE (player_black_fill_test) film->set_name ("black_fill_test"); film->set_container (Ratio::from_id ("185")); film->set_sequence (false); + film->set_interop (false); shared_ptr contentA (new ImageContent (film, "test/data/simple_testcard_640x480.png")); shared_ptr contentB (new ImageContent (film, "test/data/simple_testcard_640x480.png")); @@ -116,3 +124,161 @@ BOOST_AUTO_TEST_CASE (player_black_fill_test) check_dcp (ref.string(), check.string()); } + +/** Check behaviour with an awkward playlist whose data does not end on a video frame start */ +BOOST_AUTO_TEST_CASE (player_subframe_test) +{ + shared_ptr film = new_test_film ("reels_test7"); + film->set_name ("reels_test7"); + film->set_container (Ratio::from_id ("185")); + film->set_dcp_content_type (DCPContentType::from_isdcf_name ("TST")); + shared_ptr A = content_factory(film, "test/data/flat_red.png").front(); + film->examine_and_add_content (A); + BOOST_REQUIRE (!wait_for_jobs ()); + shared_ptr B = content_factory(film, "test/data/awkward_length.wav").front(); + film->examine_and_add_content (B); + BOOST_REQUIRE (!wait_for_jobs ()); + film->set_video_frame_rate (24); + A->video->set_length (3 * 24); + + BOOST_CHECK (A->full_length() == DCPTime::from_frames(3 * 24, 24)); + BOOST_CHECK (B->full_length() == DCPTime(289920)); + /* Length should be rounded up from B's length to the next video frame */ + BOOST_CHECK (film->length() == DCPTime::from_frames(3 * 24 + 1, 24)); + + shared_ptr player (new Player (film, film->playlist ())); + player->setup_pieces (); + BOOST_REQUIRE_EQUAL (player->_black._periods.size(), 1); + BOOST_CHECK (player->_black._periods.front() == DCPTimePeriod(DCPTime::from_frames(3 * 24, 24), DCPTime::from_frames(3 * 24 + 1, 24))); + BOOST_REQUIRE_EQUAL (player->_silent._periods.size(), 1); + BOOST_CHECK (player->_silent._periods.front() == DCPTimePeriod(DCPTime(289920), DCPTime::from_frames(3 * 24 + 1, 24))); +} + +static Frame video_frames; +static Frame audio_frames; + +static void +video (shared_ptr, DCPTime) +{ + ++video_frames; +} + +static void +audio (shared_ptr audio, DCPTime) +{ + audio_frames += audio->frames(); +} + +/** Check with a video-only file that the video and audio emissions happen more-or-less together */ +BOOST_AUTO_TEST_CASE (player_interleave_test) +{ + shared_ptr film = new_test_film ("ffmpeg_transcoder_basic_test_subs"); + film->set_name ("ffmpeg_transcoder_basic_test"); + film->set_container (Ratio::from_id ("185")); + film->set_audio_channels (6); + + shared_ptr c (new FFmpegContent (film, "test/data/test.mp4")); + film->examine_and_add_content (c); + BOOST_REQUIRE (!wait_for_jobs ()); + + shared_ptr s (new TextCaptionFileContent (film, "test/data/subrip.srt")); + film->examine_and_add_content (s); + BOOST_REQUIRE (!wait_for_jobs ()); + + shared_ptr player (new Player(film, film->playlist())); + player->Video.connect (bind (&video, _1, _2)); + player->Audio.connect (bind (&audio, _1, _2)); + video_frames = audio_frames = 0; + while (!player->pass ()) { + BOOST_CHECK (abs(video_frames - (audio_frames / 2000)) < 8); + } +} + +static void +note_handler (dcp::NoteType, std::string) +{ + +} + +/** Test some seeks towards the start of a DCP with awkward subtitles; see mantis #1085 + * and a number of others. I thought this was a player seek bug but in fact it was + * caused by the subtitle starting just after the start of the video frame and hence + * being faded out. + */ +BOOST_AUTO_TEST_CASE (player_seek_test) +{ + shared_ptr film (new Film (optional())); + shared_ptr dcp (new DCPContent (film, private_data / "awkward_subs")); + film->examine_and_add_content (dcp, true); + BOOST_REQUIRE (!wait_for_jobs ()); + dcp->caption->set_use (true); + + shared_ptr player (new Player (film, film->playlist())); + player->set_fast (); + player->set_always_burn_subtitles (true); + player->set_play_referenced (); + + shared_ptr butler (new Butler (player, film->log(), AudioMapping(), 2)); + butler->disable_audio(); + + for (int i = 0; i < 10; ++i) { + DCPTime t = DCPTime::from_frames (i, 24); + butler->seek (t, true); + pair, DCPTime> video = butler->get_video(); + BOOST_CHECK_EQUAL(video.second.get(), t.get()); + write_image(video.first->image(note_handler, PlayerVideo::always_rgb, false, true), String::compose("build/test/player_seek_test_%1.png", i), "RGB"); + /* This 0.011 is empirically chosen (hopefully) to accept changes in rendering between the reference and a test machine + (17.10 and 16.04 seem to anti-alias a little differently) but to reject gross errors e.g. missing fonts or missing + text altogether. + */ + check_image(String::compose("test/data/player_seek_test_%1.png", i), String::compose("build/test/player_seek_test_%1.png", i), 0.011); + } +} + +/** Test some more seeks towards the start of a DCP with awkward subtitles */ +BOOST_AUTO_TEST_CASE (player_seek_test2) +{ + shared_ptr film (new Film (optional())); + shared_ptr dcp (new DCPContent (film, private_data / "awkward_subs2")); + film->examine_and_add_content (dcp, true); + BOOST_REQUIRE (!wait_for_jobs ()); + dcp->caption->set_use (true); + + shared_ptr player (new Player (film, film->playlist())); + player->set_fast (); + player->set_always_burn_subtitles (true); + player->set_play_referenced (); + + shared_ptr butler (new Butler (player, film->log(), AudioMapping(), 2)); + butler->disable_audio(); + + butler->seek(DCPTime::from_seconds(5), true); + + for (int i = 0; i < 10; ++i) { + DCPTime t = DCPTime::from_seconds(5) + DCPTime::from_frames (i, 24); + butler->seek (t, true); + pair, DCPTime> video = butler->get_video(); + BOOST_CHECK_EQUAL(video.second.get(), t.get()); + write_image(video.first->image(note_handler, PlayerVideo::always_rgb, false, true), String::compose("build/test/player_seek_test2_%1.png", i), "RGB"); + check_image(String::compose("test/data/player_seek_test2_%1.png", i), String::compose("build/test/player_seek_test2_%1.png", i), 0.011); + } +} + +/** Test a bug when trimmed content follows other content */ +BOOST_AUTO_TEST_CASE (player_trim_test) +{ + shared_ptr film = new_test_film2 ("player_trim_test"); + shared_ptr A = content_factory(film, "test/data/flat_red.png").front(); + film->examine_and_add_content (A); + BOOST_REQUIRE (!wait_for_jobs ()); + A->video->set_length (10 * 24); + shared_ptr B = content_factory(film, "test/data/flat_red.png").front(); + film->examine_and_add_content (B); + BOOST_REQUIRE (!wait_for_jobs ()); + B->video->set_length (10 * 24); + B->set_position (DCPTime::from_seconds (10)); + B->set_trim_start (ContentTime::from_seconds (2)); + + film->make_dcp (); + BOOST_REQUIRE (!wait_for_jobs ()); +}