Remove Evoral::MIDIEvent
authorDavid Robillard <d@drobilla.net>
Mon, 7 Nov 2016 03:04:35 +0000 (22:04 -0500)
committerDavid Robillard <d@drobilla.net>
Sat, 3 Dec 2016 20:18:21 +0000 (15:18 -0500)
commit08fffeffec10beb708610fd35eb9e7c35365d446
treece9c8c77e6a926b4d8be90052c32945b7718bb4b
parent875b1367b2c4750ecd861424c57ed4bcc9c642d2
Remove Evoral::MIDIEvent

It is slightly questionable whether type specific methods like
velocity() belong on Event at all, these may be better off as free
functions.  However the code currently uses them as methods in many
places, and it seems like a step in the right direction, since, for
example, we might some day have events that have a velocity but aren't
stored as MIDI messages (e.g. if Ardour uses an internal musical model
that is more expressive).

In any case, the former inheritance and plethora of sloppy casts is
definitely not the right thing.
33 files changed:
gtk2_ardour/midi_region_view.cc
libs/ardour/amp.cc
libs/ardour/ardour/buffer_set.h
libs/ardour/ardour/midi_buffer.h
libs/ardour/async_midi_port.cc
libs/ardour/audio_unit.cc
libs/ardour/buffer_set.cc
libs/ardour/delayline.cc
libs/ardour/luabindings.cc
libs/ardour/luaproc.cc
libs/ardour/lv2_plugin.cc
libs/ardour/meter.cc
libs/ardour/midi_buffer.cc
libs/ardour/midi_channel_filter.cc
libs/ardour/midi_diskstream.cc
libs/ardour/midi_model.cc
libs/ardour/midi_port.cc
libs/ardour/midi_scene_changer.cc
libs/ardour/midi_state_tracker.cc
libs/ardour/midi_track.cc
libs/ardour/smf_source.cc
libs/evoral/MSVCevoral/evoral.vcproj
libs/evoral/evoral/Event.hpp
libs/evoral/evoral/MIDIEvent.hpp [deleted file]
libs/evoral/evoral/MIDIXML.hpp
libs/evoral/evoral/Note.hpp
libs/evoral/evoral/PatchChange.hpp
libs/evoral/evoral/Sequence.hpp
libs/evoral/src/Note.cpp
libs/evoral/src/Sequence.cpp
libs/evoral/test/SequenceTest.cpp
libs/midi++2/midi++/event.h
libs/midi++2/midnam_patch.cc