From: Carl Hetherington <cth@carlh.net>
Date: Fri, 20 Jan 2023 21:37:18 +0000 (+0100)
Subject: Cleanup: use an early return.
X-Git-Tag: v2.16.45~18^2~15
X-Git-Url: https://git.carlh.net/gitweb/?a=commitdiff_plain;ds=inline;h=b95b521c63233aa08d42026098429cae4633c95a;p=dcpomatic.git

Cleanup: use an early return.
---

diff --git a/src/lib/analyse_subtitles_job.cc b/src/lib/analyse_subtitles_job.cc
index 7f1b8ad04..f0dacf36b 100644
--- a/src/lib/analyse_subtitles_job.cc
+++ b/src/lib/analyse_subtitles_job.cc
@@ -106,19 +106,21 @@ AnalyseSubtitlesJob::analyse (PlayerText text, TextType type)
 		}
 	}
 
-	if (!text.string.empty()) {
-		/* We can provide dummy values for time and frame rate here as they are only used to calculate fades */
-		dcp::Size const frame = _film->frame_size();
-		for (auto i: render_text(text.string, frame, dcpomatic::DCPTime(), 24)) {
-			dcpomatic::Rect<double> rect (
-					double(i.position.x) / frame.width, double(i.position.y) / frame.height,
-					double(i.image->size().width) / frame.width, double(i.image->size().height) / frame.height
-					);
-			if (!_bounding_box) {
-				_bounding_box = rect;
-			} else {
-				_bounding_box->extend (rect);
-			}
+	if (text.string.empty()) {
+		return;
+	}
+
+	/* We can provide dummy values for time and frame rate here as they are only used to calculate fades */
+	dcp::Size const frame = _film->frame_size();
+	for (auto i: render_text(text.string, frame, dcpomatic::DCPTime(), 24)) {
+		dcpomatic::Rect<double> rect (
+			double(i.position.x) / frame.width, double(i.position.y) / frame.height,
+			double(i.image->size().width) / frame.width, double(i.image->size().height) / frame.height
+			);
+		if (!_bounding_box) {
+			_bounding_box = rect;
+		} else {
+			_bounding_box->extend (rect);
 		}
 	}
 }