From: Carl Hetherington <cth@carlh.net>
Date: Thu, 9 Jun 2016 13:06:41 +0000 (+0100)
Subject: Don't fill in vertical_position.lines with an arbitrary value.
X-Git-Tag: v1.1.13~23
X-Git-Url: https://git.carlh.net/gitweb/?a=commitdiff_plain;h=70bd2d59775cf0e3d3bacac03bf07e6101860d5f;p=libsub.git

Don't fill in vertical_position.lines with an arbitrary value.
---

diff --git a/src/stl_text_reader.cc b/src/stl_text_reader.cc
index c4c1090..c7b1fcf 100644
--- a/src/stl_text_reader.cc
+++ b/src/stl_text_reader.cc
@@ -1,5 +1,5 @@
 /*
-    Copyright (C) 2014-2015 Carl Hetherington <cth@carlh.net>
+    Copyright (C) 2014-2016 Carl Hetherington <cth@carlh.net>
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
@@ -39,10 +39,11 @@ using namespace sub;
 
 STLTextReader::STLTextReader (istream& in)
 {
+	/* This reader extracts no information about where the subtitle
+	   should be on screen, so its reference is TOP_OF_SUBTITLE.
+	*/
 	_subtitle.vertical_position.line = 0;
-	/* XXX: no idea what this should be */
-	_subtitle.vertical_position.lines = 32;
-	_subtitle.vertical_position.reference = TOP_OF_SCREEN;
+	_subtitle.vertical_position.reference = TOP_OF_SUBTITLE;
 
 	while (in.good ()) {
 		string line;