From: Carl Hetherington <cth@carlh.net>
Date: Mon, 4 May 2020 21:37:22 +0000 (+0200)
Subject: Pull some methods out of CinemaKDMs.
X-Git-Url: https://git.carlh.net/gitweb/?a=commitdiff_plain;h=8c443af9b1c3078ca3a86c4d24bbf76322c37d1d;p=dcpomatic.git

Pull some methods out of CinemaKDMs.
---

diff --git a/src/lib/cinema_kdms.cc b/src/lib/cinema_kdms.cc
index 56b76d3f9..b3badc03b 100644
--- a/src/lib/cinema_kdms.cc
+++ b/src/lib/cinema_kdms.cc
@@ -62,7 +62,7 @@ CinemaKDMs::make_zip_file (boost::filesystem::path zip_file, dcp::NameFormat nam
  *  CinemaKDM contains the KDMs for its cinema.
  */
 list<CinemaKDMs>
-CinemaKDMs::collect (list<KDMWithMetadataPtr> screen_kdms)
+collect (list<KDMWithMetadataPtr> screen_kdms)
 {
 	list<CinemaKDMs> cinema_kdms;
 
@@ -98,7 +98,7 @@ CinemaKDMs::collect (list<KDMWithMetadataPtr> screen_kdms)
 
 /** Write one directory per cinema into another directory */
 int
-CinemaKDMs::write_directories (
+write_directories (
 	list<CinemaKDMs> cinema_kdms,
 	boost::filesystem::path directory,
 	dcp::NameFormat container_name_format,
@@ -128,7 +128,7 @@ CinemaKDMs::write_directories (
 
 /** Write one ZIP file per cinema into a directory */
 int
-CinemaKDMs::write_zip_files (
+write_zip_files (
 	list<CinemaKDMs> cinema_kdms,
 	boost::filesystem::path directory,
 	dcp::NameFormat container_name_format,
@@ -167,7 +167,7 @@ CinemaKDMs::write_zip_files (
  *  @param cpl_name Name of the CPL that the KDMs are for.
  */
 void
-CinemaKDMs::email (
+email (
 	list<CinemaKDMs> cinema_kdms,
 	dcp::NameFormat container_name_format,
 	dcp::NameFormat filename_format,
diff --git a/src/lib/cinema_kdms.h b/src/lib/cinema_kdms.h
index 918670397..a61418e9f 100644
--- a/src/lib/cinema_kdms.h
+++ b/src/lib/cinema_kdms.h
@@ -29,9 +29,14 @@ class CinemaKDMs
 public:
 	void make_zip_file (boost::filesystem::path zip_file, dcp::NameFormat name_format, dcp::NameFormat::Map name_values) const;
 
-	static std::list<CinemaKDMs> collect (std::list<KDMWithMetadataPtr > kdms);
+	boost::shared_ptr<Cinema> cinema;
+	std::list<KDMWithMetadataPtr > screen_kdms;
+};
+
 
-	static int write_directories (
+std::list<CinemaKDMs> collect (std::list<KDMWithMetadataPtr > kdms);
+
+int write_directories (
 		std::list<CinemaKDMs> cinema_kdms,
 		boost::filesystem::path directory,
 		dcp::NameFormat container_name_format,
@@ -40,7 +45,7 @@ public:
 		boost::function<bool (boost::filesystem::path)> confirm_overwrite
 		);
 
-	static int write_zip_files (
+int write_zip_files (
 		std::list<CinemaKDMs> cinema_kdms,
 		boost::filesystem::path directory,
 		dcp::NameFormat container_name_format,
@@ -49,7 +54,7 @@ public:
 		boost::function<bool (boost::filesystem::path)> confirm_overwrite
 		);
 
-	static void email (
+void email (
 		std::list<CinemaKDMs> cinema_kdms,
 		dcp::NameFormat container_name_format,
 		dcp::NameFormat filename_format,
@@ -57,6 +62,3 @@ public:
 		std::string cpl_name
 		);
 
-	boost::shared_ptr<Cinema> cinema;
-	std::list<KDMWithMetadataPtr > screen_kdms;
-};
diff --git a/src/lib/send_kdm_email_job.cc b/src/lib/send_kdm_email_job.cc
index 1b476fa63..10a571ead 100644
--- a/src/lib/send_kdm_email_job.cc
+++ b/src/lib/send_kdm_email_job.cc
@@ -79,7 +79,7 @@ void
 SendKDMEmailJob::run ()
 {
 	set_progress_unknown ();
-	CinemaKDMs::email (_cinema_kdms, _container_name_format, _filename_format, _name_values, _cpl_name);
+	email (_cinema_kdms, _container_name_format, _filename_format, _name_values, _cpl_name);
 	set_progress (1);
 	set_state (FINISHED_OK);
 }
diff --git a/src/tools/dcpomatic_kdm_cli.cc b/src/tools/dcpomatic_kdm_cli.cc
index dd7fc82e3..493eea2c9 100644
--- a/src/tools/dcpomatic_kdm_cli.cc
+++ b/src/tools/dcpomatic_kdm_cli.cc
@@ -140,8 +140,8 @@ write_files (
 	)
 {
 	if (zip) {
-		int const N = CinemaKDMs::write_zip_files (
-			CinemaKDMs::collect (screen_kdms),
+		int const N = write_zip_files (
+			collect (screen_kdms),
 			output,
 			container_name_format,
 			filename_format,
diff --git a/src/wx/kdm_output_panel.cc b/src/wx/kdm_output_panel.cc
index 541674ae1..fe87dfccd 100644
--- a/src/wx/kdm_output_panel.cc
+++ b/src/wx/kdm_output_panel.cc
@@ -186,7 +186,7 @@ KDMOutputPanel::make (
 	list<KDMWithMetadataPtr> screen_kdms, string name, KDMTimingPanel* timing, function<bool (boost::filesystem::path)> confirm_overwrite
 	)
 {
-	list<CinemaKDMs> const cinema_kdms = CinemaKDMs::collect (screen_kdms);
+	list<CinemaKDMs> const cinema_kdms = collect (screen_kdms);
 
 	/* Decide whether to proceed */
 
@@ -255,8 +255,8 @@ KDMOutputPanel::make (
 					confirm_overwrite
 					);
 			} else if (_write_folder->GetValue()) {
-				written = CinemaKDMs::write_directories (
-					CinemaKDMs::collect (screen_kdms),
+				written = write_directories (
+					collect (screen_kdms),
 					directory(),
 					_container_name_format->get(),
 					_filename_format->get(),
@@ -264,8 +264,8 @@ KDMOutputPanel::make (
 					confirm_overwrite
 					);
 			} else if (_write_zip->GetValue()) {
-				written = CinemaKDMs::write_zip_files (
-					CinemaKDMs::collect (screen_kdms),
+				written = write_zip_files (
+					collect (screen_kdms),
 					directory(),
 					_container_name_format->get(),
 					_filename_format->get(),