ardour.git
14 years agoConsistent test source file naming (not the Ardour convention though, maybe should...
David Robillard [Tue, 27 Oct 2009 16:17:07 +0000 (16:17 +0000)]
Consistent test source file naming (not the Ardour convention though, maybe should change, whatever).

git-svn-id: svn://localhost/ardour2/branches/3.0@5944 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoAaaaaaaaaaaand actually add those files.
David Robillard [Tue, 27 Oct 2009 16:15:33 +0000 (16:15 +0000)]
Aaaaaaaaaaaand actually add those files.

git-svn-id: svn://localhost/ardour2/branches/3.0@5943 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoSkeleton tests for BBT_Time.
David Robillard [Tue, 27 Oct 2009 16:15:12 +0000 (16:15 +0000)]
Skeleton tests for BBT_Time.

git-svn-id: svn://localhost/ardour2/branches/3.0@5942 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoardour/tests => ardour/test (consistency with evoral).
David Robillard [Tue, 27 Oct 2009 16:07:03 +0000 (16:07 +0000)]
ardour/tests => ardour/test (consistency with evoral).

git-svn-id: svn://localhost/ardour2/branches/3.0@5941 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoAdd OK/Cancel buttons to quantize dialog.
David Robillard [Tue, 27 Oct 2009 02:36:42 +0000 (02:36 +0000)]
Add OK/Cancel buttons to quantize dialog.

git-svn-id: svn://localhost/ardour2/branches/3.0@5939 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoadd file
Paul Davis [Tue, 27 Oct 2009 02:32:11 +0000 (02:32 +0000)]
add file

git-svn-id: svn://localhost/ardour2/branches/3.0@5938 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoadd file
Paul Davis [Tue, 27 Oct 2009 02:29:49 +0000 (02:29 +0000)]
add file

git-svn-id: svn://localhost/ardour2/branches/3.0@5937 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agonew SnapBBT debug option, split out BBT_time and start work on BBT arithmetic framewo...
Paul Davis [Tue, 27 Oct 2009 02:24:56 +0000 (02:24 +0000)]
new SnapBBT debug option, split out BBT_time and start work on BBT arithmetic framework. this will cause a full recompile, so find something else to do

git-svn-id: svn://localhost/ardour2/branches/3.0@5936 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix 2884 and also potential crash if there are no control outs.
Carl Hetherington [Tue, 27 Oct 2009 00:53:24 +0000 (00:53 +0000)]
Fix 2884 and also potential crash if there are no control outs.

git-svn-id: svn://localhost/ardour2/branches/3.0@5935 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoprovide accessors to Editor::snap_{type,mode} ; when nudging notes, use grid in prefe...
Paul Davis [Mon, 26 Oct 2009 23:43:04 +0000 (23:43 +0000)]
provide accessors to Editor::snap_{type,mode} ; when nudging notes, use grid in preference to nudge clock

git-svn-id: svn://localhost/ardour2/branches/3.0@5934 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoDon't prevent user from choosing Linear interpolation for controllers if they want...
David Robillard [Mon, 26 Oct 2009 22:07:23 +0000 (22:07 +0000)]
Don't prevent user from choosing Linear interpolation for controllers if they want to (just set default).

git-svn-id: svn://localhost/ardour2/branches/3.0@5933 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix adding control points to MIDI 'automation' regions.
David Robillard [Mon, 26 Oct 2009 22:01:46 +0000 (22:01 +0000)]
Fix adding control points to MIDI 'automation' regions.

This one wins the award for most time spent finding really stupid tiny little error.

git-svn-id: svn://localhost/ardour2/branches/3.0@5932 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoMake automation error non-fatal so we can actually work on this stuff...
David Robillard [Mon, 26 Oct 2009 22:01:01 +0000 (22:01 +0000)]
Make automation error non-fatal so we can actually work on this stuff...

git-svn-id: svn://localhost/ardour2/branches/3.0@5931 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoRemove idiocy.
David Robillard [Mon, 26 Oct 2009 21:38:09 +0000 (21:38 +0000)]
Remove idiocy.

git-svn-id: svn://localhost/ardour2/branches/3.0@5930 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoRemove cyclic Source->Playlist references (and with it all dependence on Playlist...
David Robillard [Mon, 26 Oct 2009 17:24:08 +0000 (17:24 +0000)]
Remove cyclic Source->Playlist references (and with it all dependence on Playlist from Source and children and a bunch of finicky reference managing code).

git-svn-id: svn://localhost/ardour2/branches/3.0@5925 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agochange the use of "SMPTE" to "Timecode" to reflect the global economy and the end...
Paul Davis [Mon, 26 Oct 2009 14:38:58 +0000 (14:38 +0000)]
change the use of "SMPTE" to "Timecode" to reflect the global economy and the end of american dominance on the world audio production stage

git-svn-id: svn://localhost/ardour2/branches/3.0@5924 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agorevert patch for 2388 (from 2.0-ongoing)
Paul Davis [Mon, 26 Oct 2009 12:06:02 +0000 (12:06 +0000)]
revert patch for 2388 (from 2.0-ongoing)

git-svn-id: svn://localhost/ardour2/branches/3.0@5923 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years ago(forward ported from 2.0-ongoing) fix for peak data reading (carl h, #2388)
Paul Davis [Mon, 26 Oct 2009 01:07:45 +0000 (01:07 +0000)]
(forward ported from 2.0-ongoing) fix for peak data reading (carl h, #2388)

git-svn-id: svn://localhost/ardour2/branches/3.0@5921 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoTidy up debug printing.
David Robillard [Sun, 25 Oct 2009 22:09:54 +0000 (22:09 +0000)]
Tidy up debug printing.

git-svn-id: svn://localhost/ardour2/branches/3.0@5919 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoRemove random crazy comment fragment.
David Robillard [Sun, 25 Oct 2009 22:04:05 +0000 (22:04 +0000)]
Remove random crazy comment fragment.
Fix spacey tabs.

git-svn-id: svn://localhost/ardour2/branches/3.0@5918 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoRemove unused source file_changed methods.
David Robillard [Sun, 25 Oct 2009 21:45:19 +0000 (21:45 +0000)]
Remove unused source file_changed methods.

git-svn-id: svn://localhost/ardour2/branches/3.0@5917 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoRemove Session dependency from BeatsFramesConverter.
David Robillard [Sun, 25 Oct 2009 21:13:02 +0000 (21:13 +0000)]
Remove Session dependency from BeatsFramesConverter.
More constey TempoMap accessors.

git-svn-id: svn://localhost/ardour2/branches/3.0@5916 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agosearch $TOP/build/default/gtk2_ardour BEFORE ../gtk2_ardour when looking for bindings...
Paul Davis [Sun, 25 Oct 2009 20:36:10 +0000 (20:36 +0000)]
search $TOP/build/default/gtk2_ardour BEFORE ../gtk2_ardour when looking for bindings files etc ; make debug tracing show the "debug option" the output relates to as a prefix

git-svn-id: svn://localhost/ardour2/branches/3.0@5915 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agofix default binding for toggling MIDI edit mode
Paul Davis [Sun, 25 Oct 2009 18:28:34 +0000 (18:28 +0000)]
fix default binding for toggling MIDI edit mode

git-svn-id: svn://localhost/ardour2/branches/3.0@5914 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agodo not sort MIDI regions by layer since they are all transparent
Paul Davis [Sun, 25 Oct 2009 15:59:02 +0000 (15:59 +0000)]
do not sort MIDI regions by layer since they are all transparent

git-svn-id: svn://localhost/ardour2/branches/3.0@5913 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agomake per-region note-tracking in MidiPlaylist work correctly, or something very close...
Paul Davis [Sun, 25 Oct 2009 14:42:46 +0000 (14:42 +0000)]
make per-region note-tracking in MidiPlaylist work correctly, or something very close to it. note that locking isssues remain when regions (and thus note trackers) are removed

git-svn-id: svn://localhost/ardour2/branches/3.0@5912 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoStrip trailing whitespace.
David Robillard [Sat, 24 Oct 2009 22:41:27 +0000 (22:41 +0000)]
Strip trailing whitespace.

git-svn-id: svn://localhost/ardour2/branches/3.0@5910 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix needlessley explodey MidiPlaylist constructor.
David Robillard [Sat, 24 Oct 2009 22:39:11 +0000 (22:39 +0000)]
Fix needlessley explodey MidiPlaylist constructor.

git-svn-id: svn://localhost/ardour2/branches/3.0@5909 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix tab width assumption used for alignment.
David Robillard [Sat, 24 Oct 2009 15:47:48 +0000 (15:47 +0000)]
Fix tab width assumption used for alignment.

git-svn-id: svn://localhost/ardour2/branches/3.0@5908 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoMore standard --help output.
David Robillard [Sat, 24 Oct 2009 15:43:59 +0000 (15:43 +0000)]
More standard --help output.

git-svn-id: svn://localhost/ardour2/branches/3.0@5907 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoMove newlines outside of translated string.
David Robillard [Sat, 24 Oct 2009 15:39:11 +0000 (15:39 +0000)]
Move newlines outside of translated string.

git-svn-id: svn://localhost/ardour2/branches/3.0@5906 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoApply accurate copyright header.
David Robillard [Sat, 24 Oct 2009 15:35:50 +0000 (15:35 +0000)]
Apply accurate copyright header.
Shrink.

git-svn-id: svn://localhost/ardour2/branches/3.0@5905 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agodebug-tracify current MIDI playlist debug output
Paul Davis [Sat, 24 Oct 2009 13:51:33 +0000 (13:51 +0000)]
debug-tracify current MIDI playlist debug output

git-svn-id: svn://localhost/ardour2/branches/3.0@5904 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years ago(FULL commit) start of a nominal debug tracing system, with 64 bits available for...
Paul Davis [Sat, 24 Oct 2009 13:26:56 +0000 (13:26 +0000)]
(FULL commit) start of a nominal debug tracing system, with 64 bits available for flags; track notes by region in MidiPlaylist, and resolve them if they are left hanging at region boundaries. note: MIDI playback is still not working 100% though its better now.

git-svn-id: svn://localhost/ardour2/branches/3.0@5903 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agostart of a nominal debug tracing system, with 64 bits available for flags; track...
Paul Davis [Sat, 24 Oct 2009 13:26:26 +0000 (13:26 +0000)]
start of a nominal debug tracing system, with 64 bits available for flags; track notes by region in MidiPlaylist, and resolve them if they are left hanging at region boundaries. note: MIDI playback is still not working 100% though its better now.

git-svn-id: svn://localhost/ardour2/branches/3.0@5902 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoMove butler methods from Session to Butler.
David Robillard [Sat, 24 Oct 2009 00:39:28 +0000 (00:39 +0000)]
Move butler methods from Session to Butler.
Slay the dragon.  A lil' bit.

git-svn-id: svn://localhost/ardour2/branches/3.0@5901 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoSplit butler into separate object (partially, just data so far...)
David Robillard [Fri, 23 Oct 2009 23:23:00 +0000 (23:23 +0000)]
Split butler into separate object (partially, just data so far...)

git-svn-id: svn://localhost/ardour2/branches/3.0@5900 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoPatch from colinf to show region gain in the region editor (mantis 2879)
Carl Hetherington [Fri, 23 Oct 2009 23:21:55 +0000 (23:21 +0000)]
Patch from colinf to show region gain in the region editor (mantis 2879)

git-svn-id: svn://localhost/ardour2/branches/3.0@5899 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoRemove unused Session::butler_mixdown_buffer and Session::butler_gain_buffer.
David Robillard [Fri, 23 Oct 2009 23:02:59 +0000 (23:02 +0000)]
Remove unused Session::butler_mixdown_buffer and Session::butler_gain_buffer.
Odd...

git-svn-id: svn://localhost/ardour2/branches/3.0@5898 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoClean up and simplify code to find marks before and after a position, and hence impro...
Carl Hetherington [Fri, 23 Oct 2009 22:28:27 +0000 (22:28 +0000)]
Clean up and simplify code to find marks before and after a position, and hence improve snap to markers so that both start and end positions of a range marker are taken into account.

git-svn-id: svn://localhost/ardour2/branches/3.0@5897 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix stacking of automation region views.
David Robillard [Fri, 23 Oct 2009 20:17:41 +0000 (20:17 +0000)]
Fix stacking of automation region views.

git-svn-id: svn://localhost/ardour2/branches/3.0@5896 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years ago"Fix" what seems to be an inevitable assertion failure...
David Robillard [Fri, 23 Oct 2009 20:17:20 +0000 (20:17 +0000)]
"Fix" what seems to be an inevitable assertion failure...

git-svn-id: svn://localhost/ardour2/branches/3.0@5895 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoTurn off error limit for valgrind which we inevitably surpass by a mile.
David Robillard [Fri, 23 Oct 2009 20:15:35 +0000 (20:15 +0000)]
Turn off error limit for valgrind which we inevitably surpass by a mile.

git-svn-id: svn://localhost/ardour2/branches/3.0@5894 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix sketchy casts.
David Robillard [Fri, 23 Oct 2009 20:11:56 +0000 (20:11 +0000)]
Fix sketchy casts.

git-svn-id: svn://localhost/ardour2/branches/3.0@5893 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoUnit test code coverage using lcov.
David Robillard [Fri, 23 Oct 2009 17:30:11 +0000 (17:30 +0000)]
Unit test code coverage using lcov.

git-svn-id: svn://localhost/ardour2/branches/3.0@5892 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoMove Mac configuration stuff to wscript where it belongs.
David Robillard [Fri, 23 Oct 2009 16:31:54 +0000 (16:31 +0000)]
Move Mac configuration stuff to wscript where it belongs.

Please do not break autowaf:

*** ARDOUR SPECIFIC CONFIGURATION/BUILDING CODE BELONGS IN A WSCRIPT,
*** NOT AUTOWAF.PY

git-svn-id: svn://localhost/ardour2/branches/3.0@5891 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoAdd waf fix for library versioning <http://code.google.com/p/waf/issues/detail?id...
David Robillard [Fri, 23 Oct 2009 15:11:01 +0000 (15:11 +0000)]
Add waf fix for library versioning <code.google.com/p/waf/issues/detail?id=537>.

git-svn-id: svn://localhost/ardour2/branches/3.0@5890 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix whitespace.
David Robillard [Fri, 23 Oct 2009 05:17:14 +0000 (05:17 +0000)]
Fix whitespace.

git-svn-id: svn://localhost/ardour2/branches/3.0@5889 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix crash changing automation state of MIDI 'automation' tracks.
David Robillard [Fri, 23 Oct 2009 04:54:10 +0000 (04:54 +0000)]
Fix crash changing automation state of MIDI 'automation' tracks.

git-svn-id: svn://localhost/ardour2/branches/3.0@5888 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix crash on multiple record due to not initiating write on source.
David Robillard [Fri, 23 Oct 2009 04:49:25 +0000 (04:49 +0000)]
Fix crash on multiple record due to not initiating write on source.

Fixes it, but this seems a bit dirty... audio has the same problem (but lives)...

git-svn-id: svn://localhost/ardour2/branches/3.0@5887 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix controller iteration / linear interpolation.
David Robillard [Fri, 23 Oct 2009 04:24:20 +0000 (04:24 +0000)]
Fix controller iteration / linear interpolation.
Add unit test for controller iteration / linear interpolation.

git-svn-id: svn://localhost/ardour2/branches/3.0@5886 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix whitespace.
David Robillard [Fri, 23 Oct 2009 03:58:11 +0000 (03:58 +0000)]
Fix whitespace.

git-svn-id: svn://localhost/ardour2/branches/3.0@5885 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoSshh.
David Robillard [Fri, 23 Oct 2009 03:57:52 +0000 (03:57 +0000)]
Sshh.

git-svn-id: svn://localhost/ardour2/branches/3.0@5884 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix compilation with DEBUG_SEQUENCE on.
David Robillard [Fri, 23 Oct 2009 03:32:54 +0000 (03:32 +0000)]
Fix compilation with DEBUG_SEQUENCE on.

git-svn-id: svn://localhost/ardour2/branches/3.0@5883 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoTesting how anal retentive I can be without anyone saying anything.
David Robillard [Fri, 23 Oct 2009 02:53:47 +0000 (02:53 +0000)]
Testing how anal retentive I can be without anyone saying anything.

git-svn-id: svn://localhost/ardour2/branches/3.0@5882 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix yet more crazy tabs.
David Robillard [Fri, 23 Oct 2009 02:49:12 +0000 (02:49 +0000)]
Fix yet more crazy tabs.

git-svn-id: svn://localhost/ardour2/branches/3.0@5881 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoUpgrade to waf 1.5.9.
David Robillard [Fri, 23 Oct 2009 01:58:32 +0000 (01:58 +0000)]
Upgrade to waf 1.5.9.

git-svn-id: svn://localhost/ardour2/branches/3.0@5880 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoMore correct looking MidiSource::midi_read.
David Robillard [Fri, 23 Oct 2009 01:39:40 +0000 (01:39 +0000)]
More correct looking MidiSource::midi_read.

Testing seems to show the old way and this both working equally well, which is a bit weird since the old way really doesn't seem to make any sense whatsoever.
This way works as well as far as I can tell and actually makes sense, so hey, let's go with this one.

git-svn-id: svn://localhost/ardour2/branches/3.0@5879 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoMake deferred plugin stuff work with old compiler or different sigc version or whatever.
David Robillard [Fri, 23 Oct 2009 01:00:13 +0000 (01:00 +0000)]
Make deferred plugin stuff work with old compiler or different sigc version or whatever.

git-svn-id: svn://localhost/ardour2/branches/3.0@5878 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix crash when adding automation tracks caused by route ordering.
David Robillard [Fri, 23 Oct 2009 00:05:50 +0000 (00:05 +0000)]
Fix crash when adding automation tracks caused by route ordering.

I have no idea what caused this, or whether this is a kludge or not, but it's certainly less crap than not being able to display automation whatsoever.

git-svn-id: svn://localhost/ardour2/branches/3.0@5877 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoWhitespace.
David Robillard [Thu, 22 Oct 2009 22:38:53 +0000 (22:38 +0000)]
Whitespace.

git-svn-id: svn://localhost/ardour2/branches/3.0@5876 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix crash on save of MIDI data.
David Robillard [Thu, 22 Oct 2009 22:14:25 +0000 (22:14 +0000)]
Fix crash on save of MIDI data.

git-svn-id: svn://localhost/ardour2/branches/3.0@5875 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoIndentation.
David Robillard [Thu, 22 Oct 2009 22:05:49 +0000 (22:05 +0000)]
Indentation.

git-svn-id: svn://localhost/ardour2/branches/3.0@5874 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoMore spacey tabs.
David Robillard [Thu, 22 Oct 2009 22:04:43 +0000 (22:04 +0000)]
More spacey tabs.
Can we please stop with the spacey tabs?
Thanks.

git-svn-id: svn://localhost/ardour2/branches/3.0@5873 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix adding multiple notes with the same time stamp (geeze).
David Robillard [Thu, 22 Oct 2009 21:54:32 +0000 (21:54 +0000)]
Fix adding multiple notes with the same time stamp (geeze).

git-svn-id: svn://localhost/ardour2/branches/3.0@5872 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoDisable canvas verbose cursor for notes, which locks up on note adding sometimes.
David Robillard [Thu, 22 Oct 2009 21:54:00 +0000 (21:54 +0000)]
Disable canvas verbose cursor for notes, which locks up on note adding sometimes.
The backtrace ain't pretty :/

git-svn-id: svn://localhost/ardour2/branches/3.0@5871 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoRemove linear search when adding/removing a note from/to a Sequence.
David Robillard [Thu, 22 Oct 2009 21:33:05 +0000 (21:33 +0000)]
Remove linear search when adding/removing a note from/to a Sequence.

git-svn-id: svn://localhost/ardour2/branches/3.0@5870 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoActually load MIDI data from disk on session load (kludgey, forces model to always...
David Robillard [Thu, 22 Oct 2009 21:03:47 +0000 (21:03 +0000)]
Actually load MIDI data from disk on session load (kludgey, forces model to always be loaded, this needs fixing later).
Fix hilariously braindead non-lock in SMFSource::load_model.

git-svn-id: svn://localhost/ardour2/branches/3.0@5869 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix deadlocks on MIDI record.
David Robillard [Thu, 22 Oct 2009 20:37:24 +0000 (20:37 +0000)]
Fix deadlocks on MIDI record.

More locking than is strictly necessary, but the assertion in MidiModel::write_lock is a nice check, at least for now...

git-svn-id: svn://localhost/ardour2/branches/3.0@5868 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoUse info stream for infoey things.
David Robillard [Thu, 22 Oct 2009 20:36:38 +0000 (20:36 +0000)]
Use info stream for infoey things.

git-svn-id: svn://localhost/ardour2/branches/3.0@5867 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoUse info stream for infoey things.
David Robillard [Thu, 22 Oct 2009 20:05:40 +0000 (20:05 +0000)]
Use info stream for infoey things.

git-svn-id: svn://localhost/ardour2/branches/3.0@5866 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoUse a more reasonable default size for log window.
David Robillard [Thu, 22 Oct 2009 20:05:15 +0000 (20:05 +0000)]
Use a more reasonable default size for log window.
Only pop up log window if message level is not INFO (i.e. iff it is WARNING, ERROR, or FATAL).

git-svn-id: svn://localhost/ardour2/branches/3.0@5865 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix colours of log window messages.
David Robillard [Thu, 22 Oct 2009 19:53:22 +0000 (19:53 +0000)]
Fix colours of log window messages.

If anyone has a better way of making this actually work than the absurd kludge in gtk_ui.cc, feel free.

git-svn-id: svn://localhost/ardour2/branches/3.0@5864 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix whitespace.
David Robillard [Thu, 22 Oct 2009 19:00:40 +0000 (19:00 +0000)]
Fix whitespace.

git-svn-id: svn://localhost/ardour2/branches/3.0@5863 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix whitespace.
David Robillard [Thu, 22 Oct 2009 18:55:39 +0000 (18:55 +0000)]
Fix whitespace.

git-svn-id: svn://localhost/ardour2/branches/3.0@5862 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoAdd log window to windows menu.
David Robillard [Thu, 22 Oct 2009 18:11:22 +0000 (18:11 +0000)]
Add log window to windows menu.

git-svn-id: svn://localhost/ardour2/branches/3.0@5861 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix whitespace.
David Robillard [Thu, 22 Oct 2009 17:33:36 +0000 (17:33 +0000)]
Fix whitespace.

git-svn-id: svn://localhost/ardour2/branches/3.0@5860 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoDefer plugin discovery until actually needed (significant startup time improvement...
David Robillard [Thu, 22 Oct 2009 17:17:34 +0000 (17:17 +0000)]
Defer plugin discovery until actually needed (significant startup time improvement, especially with LV2).

git-svn-id: svn://localhost/ardour2/branches/3.0@5859 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoUse line comments.
David Robillard [Thu, 22 Oct 2009 16:24:47 +0000 (16:24 +0000)]
Use line comments.

git-svn-id: svn://localhost/ardour2/branches/3.0@5858 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoReplace horribly error-prone Sequence/MidiModel/MidiSource locking API with scoped...
David Robillard [Thu, 22 Oct 2009 16:15:36 +0000 (16:15 +0000)]
Replace horribly error-prone Sequence/MidiModel/MidiSource locking API with scoped locks that automatically Do The Right Thing.
Make Sequence::read_lock const correct in the process (a read lock can be taken out on a const Sequence, but not a write lock).

git-svn-id: svn://localhost/ardour2/branches/3.0@5857 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoSshh.
David Robillard [Thu, 22 Oct 2009 16:14:00 +0000 (16:14 +0000)]
Sshh.

git-svn-id: svn://localhost/ardour2/branches/3.0@5856 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix occasional crash on startup with MIDI tracks (race?).
David Robillard [Thu, 22 Oct 2009 16:10:21 +0000 (16:10 +0000)]
Fix occasional crash on startup with MIDI tracks (race?).

git-svn-id: svn://localhost/ardour2/branches/3.0@5855 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix MidiBuffer::merge_in_place and add aggressive correctness checking.
David Robillard [Thu, 22 Oct 2009 14:46:47 +0000 (14:46 +0000)]
Fix MidiBuffer::merge_in_place and add aggressive correctness checking.

git-svn-id: svn://localhost/ardour2/branches/3.0@5854 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix repeated linear search on read when cached model iterator reaches end.
David Robillard [Thu, 22 Oct 2009 14:46:03 +0000 (14:46 +0000)]
Fix repeated linear search on read when cached model iterator reaches end.

git-svn-id: svn://localhost/ardour2/branches/3.0@5853 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoremember to reset inm1 each time around the interpolation loop
Paul Davis [Thu, 22 Oct 2009 13:29:09 +0000 (13:29 +0000)]
remember to reset inm1 each time around the interpolation loop

git-svn-id: svn://localhost/ardour2/branches/3.0@5852 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix compilation with -DDEBUG_MIDI_CLOCK
David Robillard [Wed, 21 Oct 2009 22:25:46 +0000 (22:25 +0000)]
Fix compilation with -DDEBUG_MIDI_CLOCK

git-svn-id: svn://localhost/ardour2/branches/3.0@5851 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix failed assertion when end_write is called multiple times.
David Robillard [Wed, 21 Oct 2009 22:21:44 +0000 (22:21 +0000)]
Fix failed assertion when end_write is called multiple times.

Bad logic, but oh well, doesn't hurt.

git-svn-id: svn://localhost/ardour2/branches/3.0@5850 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoMerge all BufferSet iterators using a single template (way less duplicatedish code).
David Robillard [Wed, 21 Oct 2009 17:24:14 +0000 (17:24 +0000)]
Merge all BufferSet iterators using a single template (way less duplicatedish code).

git-svn-id: svn://localhost/ardour2/branches/3.0@5845 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix unnecessarily type specific code, tidy, fix whitespace.
David Robillard [Wed, 21 Oct 2009 16:56:58 +0000 (16:56 +0000)]
Fix unnecessarily type specific code, tidy, fix whitespace.

git-svn-id: svn://localhost/ardour2/branches/3.0@5844 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix O(n) search on MIDI rec region update (now O(log(n)) per update, but could be...
David Robillard [Wed, 21 Oct 2009 16:39:39 +0000 (16:39 +0000)]
Fix O(n) search on MIDI rec region update (now O(log(n)) per update, but could be O(1) with caching...)

git-svn-id: svn://localhost/ardour2/branches/3.0@5843 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix MIDI rec regions.
David Robillard [Wed, 21 Oct 2009 16:26:18 +0000 (16:26 +0000)]
Fix MIDI rec regions.

git-svn-id: svn://localhost/ardour2/branches/3.0@5842 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoTidy up region gain line drawing slightly so that it doesn't overhang its region.
Carl Hetherington [Wed, 21 Oct 2009 12:32:46 +0000 (12:32 +0000)]
Tidy up region gain line drawing slightly so that it doesn't overhang its region.

git-svn-id: svn://localhost/ardour2/branches/3.0@5839 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix MIDI thru, though why this is any different from audio (monitoring) I don't know.
David Robillard [Wed, 21 Oct 2009 00:53:26 +0000 (00:53 +0000)]
Fix MIDI thru, though why this is any different from audio (monitoring) I don't know.

git-svn-id: svn://localhost/ardour2/branches/3.0@5837 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix creation of plugin presets.
Carl Hetherington [Wed, 21 Oct 2009 00:21:02 +0000 (00:21 +0000)]
Fix creation of plugin presets.

git-svn-id: svn://localhost/ardour2/branches/3.0@5836 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix unused parameter warnings since GCC apparently doesn't feel like listening to...
David Robillard [Wed, 21 Oct 2009 00:15:42 +0000 (00:15 +0000)]
Fix unused parameter warnings since GCC apparently doesn't feel like listening to -Wno-unused-parameter

git-svn-id: svn://localhost/ardour2/branches/3.0@5835 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoDisable excessive debug printing.
David Robillard [Wed, 21 Oct 2009 00:00:56 +0000 (00:00 +0000)]
Disable excessive debug printing.

git-svn-id: svn://localhost/ardour2/branches/3.0@5834 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix various MIDI control and installation issues:
David Robillard [Tue, 20 Oct 2009 23:43:19 +0000 (23:43 +0000)]
Fix various MIDI control and installation issues:

 * Install ardour3_ui_default.conf to system config dir

 * Set -DDATA_DIR etc. defines to proper absolute paths

 * Set default MIDI control port name to "control"
   (it was "control" some places, "default" other, so the generic MIDI
   control surface didn't work.  The real problem here is probably that
   the name is hardcoded in the surface code, ick)

 * Install surfaces to correct system directory

 * Generate and install ardour_system.rc

User POV:

 * Installed versions not run from the source directory discover configuration
   files and surfaces, and generally work

 * Building and/or starting a fresh copy of ardour3 with no pre-existing
   configuration will run an ardour with a single MIDI "control" port, which
   you can plug a surface into and control MMC and controllers and such
   (after turning on the generic MIDI surface, which IMO should be loaded
    by default anyway, especially since it's no longer in a menu)

git-svn-id: svn://localhost/ardour2/branches/3.0@5833 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoDelete comment window in destructor to close mantis 1870.
Carl Hetherington [Tue, 20 Oct 2009 22:58:50 +0000 (22:58 +0000)]
Delete comment window in destructor to close mantis 1870.

git-svn-id: svn://localhost/ardour2/branches/3.0@5831 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoFix crash with input (not duplex) control MIDI ports.
David Robillard [Tue, 20 Oct 2009 22:33:08 +0000 (22:33 +0000)]
Fix crash with input (not duplex) control MIDI ports.

git-svn-id: svn://localhost/ardour2/branches/3.0@5829 d708f5d6-7413-0410-9779-e7cbd77b26cf

14 years agoEnsure that the loop/punch ruler is always visible when punch in/out is enabled;...
Carl Hetherington [Tue, 20 Oct 2009 21:58:46 +0000 (21:58 +0000)]
Ensure that the loop/punch ruler is always visible when punch in/out is enabled; closes mantis 1294.

git-svn-id: svn://localhost/ardour2/branches/3.0@5828 d708f5d6-7413-0410-9779-e7cbd77b26cf