Robin Gareus [Mon, 16 Mar 2015 14:09:16 +0000 (15:09 +0100)]
work-around engine dialog crashes.
Thanks to brilliant detective work by John E. we
can now reveal that the actual crash in
EngineControl::print_channel_count() is caused
by a seemingly unrelated exception.
The root cause however is waves/ASIO backend reporting a
buffersize that is not in list of available buffer-sizes
it reported earlier.
Robin Gareus [Mon, 16 Mar 2015 13:37:06 +0000 (14:37 +0100)]
add API to query Gtk::ComboBoxText entries
..the overly complex C++ style variant.
iterate twice.. hell yeah.
Paul Davis [Sun, 15 Mar 2015 16:52:28 +0000 (11:52 -0500)]
prevent single-axis drags in the editor summary from affecting the other axis.
In theory, the EditorSummary::get_editor()/set_editor() calls
should be no-ops if the values are just passed between them,
but this turns out to be not precisely the case. Rather than
figure out exactly how ensure that this is true, mark the
new rect boundaries for the non-moving axis with -1 so that
we know to leave it alone
nick_m [Sun, 15 Mar 2015 17:01:30 +0000 (04:01 +1100)]
Add route dialog order hint changes.
Add an option to insert new routes at the top of the list ("First").
Reorder/rename the entries in the dialog.
Session's _order_hint is now the signed int it always wanted to be.
David Robillard [Sun, 15 Mar 2015 07:45:26 +0000 (03:45 -0400)]
Fix dragging regions to/from drop zone (#6137).
The previous code assumed that dragging up from the drop zone into the last
track is always valid. This is not true when the type of the dragged region(s)
do not match that route, which resulted in a crash and/or bizarre behaviour.
This took entirely too long to figure out, there are some real nightmares in
the region drag code...
Robin Gareus [Sat, 14 Mar 2015 21:58:40 +0000 (22:58 +0100)]
improve port-matrix text contrast
Robin Gareus [Sat, 14 Mar 2015 20:59:12 +0000 (21:59 +0100)]
desaturate port matrix colors
grün und blau schmückt die sau.
Robin Gareus [Sat, 14 Mar 2015 18:26:21 +0000 (19:26 +0100)]
note to self.
Robin Gareus [Sat, 14 Mar 2015 18:25:44 +0000 (19:25 +0100)]
proper port unregistration (just some refactoring, noop)
nick_m [Sat, 14 Mar 2015 19:25:06 +0000 (06:25 +1100)]
Non-transient ArdourDialogs and ArdourWindows appear in the centre
of the screen initially (first use in a new session) rather than at
the mouse position.
nick_m [Sat, 14 Mar 2015 18:23:09 +0000 (05:23 +1100)]
Session import dialog is no longer a transient for the editor.
Robin Gareus [Sat, 14 Mar 2015 17:26:53 +0000 (18:26 +0100)]
OSX has a wall clock already.
Robin Gareus [Sat, 14 Mar 2015 17:26:10 +0000 (18:26 +0100)]
tweak status-bar spacing
Robin Gareus [Sat, 14 Mar 2015 16:28:20 +0000 (17:28 +0100)]
automatic error log window popup be gone.
nick_m [Sat, 14 Mar 2015 16:06:39 +0000 (03:06 +1100)]
Remove the use of Window::set_keep_above() throughout startup.
This has been tested, but needs testing on more platforms (check for
obscured windows/dialogs.
Also use WIN_POS_CENTER in the "ask about loading session" dialog.
nick_m [Sat, 14 Mar 2015 16:00:06 +0000 (03:00 +1100)]
Keep the left hand list pane of the mixer the same size when resizing
the mixer window (thanks JohnE).
Speeds up redisplay a bit.
nick_m [Sat, 14 Mar 2015 15:57:39 +0000 (02:57 +1100)]
Fix incorrect track ordering when creating a session from a template
(supplied order keys are correct).
This really shouldn't be needed, but historically there have been races
between the treeview and the editor order keys.
Interesting to note that there have been no reported ordering bugs when
loading sessions.
David Robillard [Sat, 14 Mar 2015 05:12:29 +0000 (01:12 -0400)]
Only sound selected notes momentarily (#6142).
This is debatable, the "sustained until mouse release" behaviour is handy
sometimes, but this way seems like what most people probably want.
Also, this "fire it and forget it and let it delete itself a bit later" thing
with MidiPlayer makes me nervous. I guess it's unlikely someone manages to
select a note then delete a track within 100ms, but, well...
David Robillard [Sat, 14 Mar 2015 04:39:52 +0000 (00:39 -0400)]
Fix stretch for MIDI regions (#6164).
David Robillard [Sat, 14 Mar 2015 04:21:29 +0000 (00:21 -0400)]
Move PC flags to avoid obscuring region name.
Fixes bug #6179. Top vs. bottom seems pretty arbitrary to me, and this solves
the obscuring issue (which is quite common since there are often PC events at
the start of MIDI files), so bottom it is.
David Robillard [Sat, 14 Mar 2015 02:30:11 +0000 (22:30 -0400)]
Fix note visibility (#
0006168).
David Robillard [Sat, 14 Mar 2015 01:54:57 +0000 (21:54 -0400)]
Don't expand track headers to show MIDI stuff.
Fixes bug #
0006138. This solution does make the other label move when settings
are changed (presumably what the fixed width stuff was for), but I don't think
this is a big deal. Lesser of two evils, at least.
Robin Gareus [Sat, 14 Mar 2015 00:49:02 +0000 (01:49 +0100)]
ignore master & monitor when “solo all [in group]”
should fix #6193
Ben Loftis [Fri, 13 Mar 2015 21:24:55 +0000 (16:24 -0500)]
Right-clicking on the Loop/Punch ruler should "Do Something".
John Emmas [Fri, 13 Mar 2015 17:37:07 +0000 (17:37 +0000)]
Fix some build anomalies between PROGRAM_NAME and PROGRAM_VERSION
When building with MSVC, some libraries had PROGRAM_NAME set to "Mixbus" and PROGRAM_VERSION set to "3". Whereas other libraries had PROGRAM_NAME set to "Mixbus3" while PROGRAM_VERSION was an empty string.
I've a horrible feeling there must have been a reason for this but I can't quite think what it was. Hopefully though, this change will standardize everything.
nick_m [Fri, 13 Mar 2015 16:56:14 +0000 (03:56 +1100)]
Align number entry in the meter dialog to the right in lieu of finding
the reason behind ComboBoxText's apparent miscalculation of its' layout
width).
nick_m [Fri, 13 Mar 2015 16:53:43 +0000 (03:53 +1100)]
Don't show stock icons in any buttons (explicitly setting an image will
still work).
nick_m [Fri, 13 Mar 2015 16:52:03 +0000 (03:52 +1100)]
Don't set the following dialogs to be transients for the editor:
Control point dialog
Edit note dialog
Both types of tempo dialog
Both types of meter dialog.
Robin Gareus [Fri, 13 Mar 2015 13:05:12 +0000 (14:05 +0100)]
clean out cruft from CoreAudio Backend
Robin Gareus [Fri, 13 Mar 2015 12:31:48 +0000 (13:31 +0100)]
only jack+windows use portaudio.
fixes missing lib if portaudio-backend is used on on non-windows
platforms (pkg-config defines HAVE_PORTAUDIO)
Robin Gareus [Fri, 13 Mar 2015 03:05:53 +0000 (04:05 +0100)]
call me Mr. Backend
simple blocking (no callback) PortAudio Backend
Paul Davis [Thu, 12 Mar 2015 22:45:31 +0000 (17:45 -0500)]
check for old configuration files and copy if user requests it.
A restart is required. There is a circular dependency between the config files and the GUI, and this restart breaks it
Paul Davis [Thu, 12 Mar 2015 22:44:50 +0000 (17:44 -0500)]
alter config file copying infrastructure so it can be used at a suitable time in the instance's lifetime
Robin Gareus [Thu, 12 Mar 2015 19:30:46 +0000 (20:30 +0100)]
always show language dialog on windows
Robin Gareus [Thu, 12 Mar 2015 17:02:20 +0000 (18:02 +0100)]
NOOP whitespace fixes.
nick_m [Thu, 12 Mar 2015 17:01:55 +0000 (04:01 +1100)]
Don't mess with the track selection at all from the editor route list
when adding tracks (thinko in last commit).
Robin Gareus [Thu, 12 Mar 2015 16:56:06 +0000 (17:56 +0100)]
fix
0096aa5 (at least for mingw)
nick_m [Thu, 12 Mar 2015 15:47:16 +0000 (02:47 +1100)]
Add new routes to selection in the editor, rather than the editor
route list.
Fixes new tracks not being selected.
Also begin selection op history when adding routes.
Robin Gareus [Thu, 12 Mar 2015 15:09:55 +0000 (16:09 +0100)]
amend
7bb9d04, fix midi looping
Robin Gareus [Thu, 12 Mar 2015 14:56:26 +0000 (15:56 +0100)]
indicate MIDI port names (vs audio system ports)
Paul Davis [Thu, 12 Mar 2015 15:06:02 +0000 (10:06 -0500)]
add seek info to readtest
Paul Davis [Thu, 12 Mar 2015 13:46:38 +0000 (08:46 -0500)]
try to clean MSVC/Windows mess in main(), hopefully without breaking anything
Robin Gareus [Thu, 12 Mar 2015 14:21:31 +0000 (15:21 +0100)]
cont’d work on
a16dd7c, fixes #6170
Robin Gareus [Thu, 12 Mar 2015 13:16:55 +0000 (14:16 +0100)]
explain midi starvation, issue #6170
this is not a fix yet, just some comments and
code cleanup done while reading/investigating:
* limit reads to available write-space
* skip inactive tracks
* handle potential unsigned + negative value.
Tim Mayberry [Thu, 12 Mar 2015 12:34:54 +0000 (22:34 +1000)]
Revert commit
635578b3 relating to pthread debugging
This breaks the build for windows builds that don't use the pthreads_win32
library. Using the opaque pthread_t type like this is probably not a great
idea. Using PBD::pthread_name is another option that I've used elsewhere
that seems more useful.
Tim Mayberry [Thu, 12 Mar 2015 12:15:41 +0000 (22:15 +1000)]
Define DEBUG_THREAD_SELF when debug is enabled
Tim Mayberry [Thu, 12 Mar 2015 11:56:00 +0000 (21:56 +1000)]
Use DEBUG_THREAD_SELF macro in session_vst.cc
Tim Mayberry [Thu, 19 Feb 2015 10:33:46 +0000 (20:33 +1000)]
Don't try linking libclearlooks files with mingw build
I believe this is unnecessary for cross and native builds
Tim Mayberry [Wed, 18 Feb 2015 03:09:57 +0000 (13:09 +1000)]
Include windows.h in Dummy backend for LARGE_INTEGER
This is necessary for a native build using MSYS2 and mingw-w64
Tim Mayberry [Wed, 18 Feb 2015 03:07:27 +0000 (13:07 +1000)]
Include windows.h on windows build for LARGE_INTEGER
This is necessary for a native build using MSYS2 with mingw-w64
Robin Gareus [Thu, 12 Mar 2015 12:19:26 +0000 (13:19 +0100)]
OSX use xjadeo directly (no IPC indirection)
Robin Gareus [Thu, 12 Mar 2015 12:15:12 +0000 (13:15 +0100)]
pimp readtest.
Robin Gareus [Thu, 12 Mar 2015 11:26:23 +0000 (12:26 +0100)]
further ardourbutton ellipsis fixes
Robin Gareus [Thu, 12 Mar 2015 02:52:10 +0000 (03:52 +0100)]
have another go at windows i18n
Robin Gareus [Thu, 12 Mar 2015 02:24:09 +0000 (03:24 +0100)]
Robin Gareus [Thu, 12 Mar 2015 01:36:33 +0000 (02:36 +0100)]
fix ‘ export’ installdir typo
Robin Gareus [Thu, 12 Mar 2015 01:36:01 +0000 (02:36 +0100)]
prepare windows i18n
Ben Loftis [Wed, 11 Mar 2015 20:33:03 +0000 (15:33 -0500)]
more verbose captions on automation track headers; include the plug name.
Robin Gareus [Wed, 11 Mar 2015 20:18:17 +0000 (21:18 +0100)]
add video-monitor to timeline context-menu
Paul Davis [Wed, 11 Mar 2015 19:28:22 +0000 (14:28 -0500)]
finish (?) infrastructure for copying configuration files from a3 to a4
Robin Gareus [Wed, 11 Mar 2015 18:46:22 +0000 (19:46 +0100)]
NOOP, add a missing ‘p’
Robin Gareus [Wed, 11 Mar 2015 18:45:02 +0000 (19:45 +0100)]
renice connection button labels
* pango ellipsize text
* use pretty-names if available
Robin Gareus [Wed, 11 Mar 2015 17:18:37 +0000 (18:18 +0100)]
interpret CoreMidi unique ID as unsigned for consistency.
coremidi specifies it as SInt32 but system:midi_playback_-
126632214 ,
even if only used internally, just does not seem right.
Paul Davis [Wed, 11 Mar 2015 18:24:40 +0000 (13:24 -0500)]
more infrastructure for copying old configuration files
Paul Davis [Wed, 11 Mar 2015 18:24:11 +0000 (13:24 -0500)]
efficiency is overrated - don't cache the return value of user_config_directory_name() since it can be called with different arguments
Paul Davis [Wed, 11 Mar 2015 17:12:50 +0000 (12:12 -0500)]
global ARDOUR signal to ask GUI to copy configuration files across versions
Paul Davis [Wed, 11 Mar 2015 17:12:08 +0000 (12:12 -0500)]
only create user configuration directory if no explicit version was given
nick_m [Wed, 11 Mar 2015 17:06:20 +0000 (04:06 +1100)]
Metadata windows are no longer transient windows.
Comment out input and output IOSelectorWindows being set to KEEP_ABOVE
in the route ui (just in case there is a good reason for it).
nick_m [Wed, 11 Mar 2015 16:46:11 +0000 (03:46 +1100)]
Add route dialog is never a transient window.
Fixes a hack where it's transient parent was used to give an order hint
(for the order key of any new tracks).
This commit adds a new combobox "insert_at" to let the user tell us
where they want new tracks to go.
Paul Davis [Wed, 11 Mar 2015 15:30:42 +0000 (10:30 -0500)]
hide user_config_dir_name; alter API for user_config_dir() to allow specification of a version number
Robin Gareus [Wed, 11 Mar 2015 13:58:02 +0000 (14:58 +0100)]
mingw: all code is position independent
Robin Gareus [Wed, 11 Mar 2015 11:29:45 +0000 (12:29 +0100)]
NOOP, midi-auditioner clean API usage
Robin Gareus [Wed, 11 Mar 2015 11:28:47 +0000 (12:28 +0100)]
remove duplicate code
set_header_timeline_position() does exactly that. Also doing it
twice may have lead to a NULL-pointer dereference.
Robin Gareus [Wed, 11 Mar 2015 11:23:05 +0000 (12:23 +0100)]
reasonably sized CoreMidi Buffers
nick_m [Tue, 10 Mar 2015 23:50:35 +0000 (10:50 +1100)]
Fix windows compilation for merged waveview branch.
Robin Gareus [Tue, 10 Mar 2015 23:27:14 +0000 (00:27 +0100)]
coreaudio backend: switch threads early
Robin Gareus [Tue, 10 Mar 2015 23:25:10 +0000 (00:25 +0100)]
fix “no per-thread pool” abort
For some backends the process thread can change (e.g.
switch coreaudio headphone + internal speakers)
If there are existing x-thread event calls this can lead to
the following situation:
1) SessionEvent::operator new
2) audioengine process thread change
3) SessionEvent::operator delete -> crash, wrong thread
SessionEvent::operator delete can safely push the event back to
the pool for later cleanup..
Robin Gareus [Tue, 10 Mar 2015 21:12:35 +0000 (22:12 +0100)]
NOOP, re-indent.
Robin Gareus [Tue, 10 Mar 2015 21:06:28 +0000 (22:06 +0100)]
yet unheard of edge-case.
Robin Gareus [Tue, 10 Mar 2015 21:05:47 +0000 (22:05 +0100)]
audio interpolation is really private
Robin Gareus [Tue, 10 Mar 2015 21:05:21 +0000 (22:05 +0100)]
MIDI vari-speed playback
Robin Gareus [Tue, 10 Mar 2015 18:33:05 +0000 (19:33 +0100)]
prototype basic midi varispeed
Ben Loftis [Tue, 10 Mar 2015 20:54:54 +0000 (15:54 -0500)]
Groups created from the (edit,mix) windows should share the same default properties.
In the past, we chose different defaults in homage to ardour's old mix/edit groups.
But that wasn't a very good idea.
For now they have all properties enabled and the user can disable them as-needed.
It might also be nice to make the user's property selections perist for new groups.
nick_m [Tue, 10 Mar 2015 14:57:16 +0000 (01:57 +1100)]
Fix compilation for osx.
nick_m [Tue, 10 Mar 2015 13:40:02 +0000 (00:40 +1100)]
Manual merge of the backend (peakfile reading) part of waveview branch.
Summary:
* use mmap() for the whole peakfile instead of lots of small seek/reads
* cache the computed peaks
* where possible, open files with O_NOATIME.
Robin Gareus [Tue, 10 Mar 2015 13:28:17 +0000 (14:28 +0100)]
fix OSX/Clang optimized builds
not quite sure how -fomit-frame-pointer can make a difference with 64bit
builds, but it does crash on start in
gdk_window_new -> .. -> [NSColor _controlColor] -> GetThemeImage
-> _NSAppKitThemeLock with no other threads involved.
full backtrace: http://pastebin.com/FxsCMzSY
nick_m [Tue, 10 Mar 2015 12:35:53 +0000 (23:35 +1100)]
Manual merge of the drawing component of waveview branch.
In summary:
* no antialiasing of waveviews
* no diagonal lines
* simplify clip detection
* don't use LINE_CAP_ROUND for outline
* use the wave colour when drawing outline only
Robin Gareus [Tue, 10 Mar 2015 10:34:37 +0000 (11:34 +0100)]
windows package: pick up major version
Robin Gareus [Tue, 10 Mar 2015 10:00:53 +0000 (11:00 +0100)]
increase shuttle speed display granularity.
Robin Gareus [Tue, 10 Mar 2015 09:52:44 +0000 (10:52 +0100)]
dramatically reduce ShuttleControl CPU usage
Robin Gareus [Tue, 10 Mar 2015 09:46:24 +0000 (10:46 +0100)]
throttle TransportStateChange signal emissions
Robin Gareus [Tue, 10 Mar 2015 02:49:00 +0000 (03:49 +0100)]
clean up and refine shuttle control rendering.
Robin Gareus [Tue, 10 Mar 2015 01:48:14 +0000 (02:48 +0100)]
circles and circles and circles, again my friend
escape the cairo vicious circle, fixes varispeed playback
& major CPU hog on OSX.
Robin Gareus [Tue, 10 Mar 2015 00:41:52 +0000 (01:41 +0100)]
tweak OS X packaging for 10.9
Robin Gareus [Mon, 9 Mar 2015 23:21:37 +0000 (00:21 +0100)]
disk-space calc is windows (not MSVC) specific.
Robin Gareus [Mon, 9 Mar 2015 23:09:01 +0000 (00:09 +0100)]
10ms = 1e7 nsec
Robin Gareus [Mon, 9 Mar 2015 22:28:18 +0000 (23:28 +0100)]
rework/optimize CoreMidi
Robin Gareus [Mon, 9 Mar 2015 18:01:24 +0000 (19:01 +0100)]
NOOP, add header-guards and namespace to CA backend
Paul Davis [Mon, 9 Mar 2015 18:50:49 +0000 (13:50 -0500)]
more work to remove hard coding of major version number for linux packaging
Paul Davis [Mon, 9 Mar 2015 18:50:17 +0000 (13:50 -0500)]
more work to remove hard coding of major version number for linux packaging