Robin Gareus [Tue, 25 Nov 2014 09:23:10 +0000 (10:23 +0100)]
NOOP, fix some “missing sentinel” -Wformat
David Robillard [Tue, 25 Nov 2014 07:20:21 +0000 (02:20 -0500)]
Check for clang with an actual code check.
Turns out Apple in its infinite wisdom installs clang as /usr/bin/g++, so
guessing based on executable name doesn't work.
David Robillard [Tue, 25 Nov 2014 07:11:44 +0000 (02:11 -0500)]
Remove dead code.
David Robillard [Tue, 25 Nov 2014 07:08:35 +0000 (02:08 -0500)]
Shup up clang about gtkmm/papertraits.h.
David Robillard [Tue, 25 Nov 2014 07:07:40 +0000 (02:07 -0500)]
Don't add non-clang flag regardless of platform.
David Robillard [Tue, 25 Nov 2014 07:07:07 +0000 (02:07 -0500)]
Fix clang check for versioned clang executables.
Paul Davis [Mon, 24 Nov 2014 19:58:56 +0000 (21:58 +0200)]
when dragging on the canvas, use x,y pointer coordinates to decide if motion has occured.
Using _last_pointer_frame breaks when dragging to the left of the canvas, because we clamp
the value of the frame to >= 0. Motion would step once the pointer crossed the left edge
of the canvas because the frame value would always be zero.
This is not a problem when using the pointer x,y values which end up appropriately negative
under all conditions.
Robin Gareus [Mon, 24 Nov 2014 19:35:38 +0000 (20:35 +0100)]
fix OSX open URL in browser
John Emmas [Mon, 24 Nov 2014 13:01:16 +0000 (13:01 +0000)]
Add a newly introduced header file to our MSVC project (gtk2_ardour)
John Emmas [Mon, 24 Nov 2014 12:58:26 +0000 (12:58 +0000)]
Now that we're building pango's language modules statically (i.e. no longer as DLLs) it's not necessary to edit the user's 'pango.modules' file
John Emmas [Mon, 24 Nov 2014 12:56:07 +0000 (12:56 +0000)]
Simulate 'trunc()' which isn't available in MSVC
(needed by 'gtk2_ardour/editor.cc')
John Emmas [Mon, 24 Nov 2014 12:53:24 +0000 (12:53 +0000)]
Remove a commented out line in 'pbd/stacktrace.h'
(was probably just needed for testing at some stage)
John Emmas [Mon, 24 Nov 2014 12:51:54 +0000 (12:51 +0000)]
Changes needed to accommodate building libevoral with MSVC
Note that class 'MusicalTime' needn't be exportable (with a little work, this could be reverted if it affects the other builds)
Robin Gareus [Mon, 24 Nov 2014 03:56:31 +0000 (04:56 +0100)]
waf is fun
Robin Gareus [Mon, 24 Nov 2014 03:24:58 +0000 (04:24 +0100)]
OSX gcc does not support local-typedef warning
Robin Gareus [Mon, 24 Nov 2014 00:43:31 +0000 (01:43 +0100)]
also search for 32bit xjadeo on 64bit windows
Robin Gareus [Sun, 23 Nov 2014 23:04:45 +0000 (00:04 +0100)]
Robin Gareus [Sun, 23 Nov 2014 23:00:58 +0000 (00:00 +0100)]
lost quote
Robin Gareus [Sun, 23 Nov 2014 22:56:39 +0000 (23:56 +0100)]
hotfix windows-compilation (unfinished
bfe49540b9)
..at least it compiles and starts. Mackie support etc
is probably still broken.
Robin Gareus [Sun, 23 Nov 2014 22:55:41 +0000 (23:55 +0100)]
update harvid & ffmpeg binary path discovery on windows (64 & 32 bit)
Robin Gareus [Sun, 23 Nov 2014 22:37:21 +0000 (23:37 +0100)]
make debug message more useful
Robin Gareus [Sun, 23 Nov 2014 21:04:32 +0000 (22:04 +0100)]
fix/silence various compiler warnings.
* ifdef unused static functions
* brackets around assignment and comparision
* no return statement in function returning non-void
* boost concept_checks.hpp unused-local-typedefs
David Robillard [Sun, 23 Nov 2014 21:30:09 +0000 (16:30 -0500)]
Fix build with a certain awful broken compiler.
Robin Gareus [Sun, 23 Nov 2014 20:01:06 +0000 (21:01 +0100)]
-Wunused-function on windows
Robin Gareus [Sun, 23 Nov 2014 19:56:03 +0000 (20:56 +0100)]
use NULL not 0 for c-functions (even in c++ code)
4.3 KBytes less compiler warnings.
Paul Davis [Sun, 23 Nov 2014 15:37:13 +0000 (17:37 +0200)]
remove use of CrossThreadChannel::selectable() to allow cross-platform implementation of CrossThreadChannel via Glib::IOSource
Paul Davis [Sun, 23 Nov 2014 12:34:46 +0000 (14:34 +0200)]
assign minsec_ruler_scale and minsec_mark_modulo when zoomed very far out
Avoids crash when computing % minsec_mark_modulo.
David Robillard [Sun, 23 Nov 2014 02:49:42 +0000 (21:49 -0500)]
Fix quantization and other time-related ops.
David Robillard [Sat, 22 Nov 2014 21:33:32 +0000 (16:33 -0500)]
Max is max and min is min and I am dumb.
David Robillard [Sat, 22 Nov 2014 20:33:40 +0000 (15:33 -0500)]
Fix note resizing.
David Robillard [Sat, 22 Nov 2014 20:26:41 +0000 (15:26 -0500)]
Fix clang and MSVC build.
David Robillard [Sat, 22 Nov 2014 09:39:30 +0000 (04:39 -0500)]
Fix invisible discrete control points.
David Robillard [Sat, 22 Nov 2014 09:05:42 +0000 (04:05 -0500)]
Wrap MusicalTime in a class.
This lets us get a more explicit handle on time conversions, and is the main
step towards using actual beat:tick time and getting away from floating point
precision problems.
David Robillard [Sat, 22 Nov 2014 05:44:48 +0000 (00:44 -0500)]
Fix assert failure in control list interpolation.
How we never hit this before is beyond me, it's in some ooooold code.
David Robillard [Fri, 21 Nov 2014 07:49:41 +0000 (02:49 -0500)]
Fix const violation warnings in tempo.cc.
David Robillard [Fri, 21 Nov 2014 07:37:42 +0000 (02:37 -0500)]
Factor out copy-paste code to get grid type in beats defaulting to 1.
David Robillard [Thu, 20 Nov 2014 22:36:09 +0000 (17:36 -0500)]
Move time converters only to the region views that actually need them.
A step towards sorting out time issues more solidly, the time situation of MIDI
region views and automation region views is slightly different.
Robin Gareus [Fri, 21 Nov 2014 22:12:17 +0000 (23:12 +0100)]
add a variable to specify windows build concurrency
David Robillard [Thu, 20 Nov 2014 20:36:11 +0000 (15:36 -0500)]
Fix lost MIDI note offs and controllers.
Fix initial read of discrete MIDI controllers.
Fix spurious note offs when starting to play in the middle of a note.
Faster search for initial event when cached iterator is invalid.
So much for dropping the cached iterator. The iterator is responsible for
handling note offs, so that doesn't work. This design means we have some stuck
note issues at the source read level, but they should be taken care of by the
state tracker anyway.
David Robillard [Thu, 20 Nov 2014 20:32:06 +0000 (15:32 -0500)]
Reduce unnecessary non-const MIDI buffer access.
David Robillard [Thu, 20 Nov 2014 17:01:39 +0000 (12:01 -0500)]
Use memento_command_binder() to (probably) fix MSVC build and other things.
Remove ugly hack that does the same thing.
David Robillard [Thu, 20 Nov 2014 01:47:18 +0000 (20:47 -0500)]
Clean up some MIDI code.
David Robillard [Thu, 20 Nov 2014 01:46:03 +0000 (20:46 -0500)]
Remove unused variables.
Robin Gareus [Thu, 20 Nov 2014 01:46:30 +0000 (02:46 +0100)]
debug trace lost midi-messages
David Robillard [Thu, 20 Nov 2014 00:24:07 +0000 (19:24 -0500)]
Fix dropped MIDI events, especially with record enabled.
I am not precisely sure why the cached iterator was causing this problem, it
shouldn't be invalidated, and the times make sense. It may be some lock
related issue since the iterator holds a lock on the source.
In any case, this cached iterator was just to avoid repeated linear search of
the model, but since the model has a logarithmic search, instead just scrap all
this problematic persistent state and search for the appropriate start time
every read. No need to be careful about invalidating when anything changes.
Ben Loftis [Wed, 19 Nov 2014 23:27:13 +0000 (17:27 -0600)]
fix range selection of mixer strips; shift+selecting a single strip would select from there til the end
Robin Gareus [Wed, 19 Nov 2014 19:38:50 +0000 (20:38 +0100)]
some const'ness and hints for clang
Robin Gareus [Tue, 18 Nov 2014 22:39:35 +0000 (23:39 +0100)]
copy hotspots file when packaging windows cursors
Robin Gareus [Tue, 18 Nov 2014 22:39:00 +0000 (23:39 +0100)]
also load hotspot file (if it exists) for default cursors
Ben Loftis [Tue, 18 Nov 2014 23:04:23 +0000 (17:04 -0600)]
allow dummy backend for any product
Robin Gareus [Tue, 18 Nov 2014 21:32:06 +0000 (22:32 +0100)]
fix windows icon deply path
Robin Gareus [Tue, 18 Nov 2014 21:11:12 +0000 (22:11 +0100)]
drop hotspot info when changing cursors.
Robin Gareus [Tue, 18 Nov 2014 21:08:51 +0000 (22:08 +0100)]
deploy square cursors as default for windows
Robin Gareus [Tue, 18 Nov 2014 21:00:58 +0000 (22:00 +0100)]
add square cursors (for windows)
cursor icons squared with north-west gravity.
hotspots are identical to original icons.
otherwise gdkcursor-win32 creates square cursors with
center gravity and hotspot X/Y differs.
Robin Gareus [Tue, 18 Nov 2014 20:59:28 +0000 (21:59 +0100)]
tabs are tabs and spaces are spaces
see http://ardour.org/styleguide.html #26
Robin Gareus [Tue, 18 Nov 2014 20:59:04 +0000 (21:59 +0100)]
assert no null pointer dereference
Jeremy Carter [Sat, 15 Nov 2014 01:34:05 +0000 (20:34 -0500)]
Plugin Automation All: Fix bug where Switches weren't being changed.
David Robillard [Tue, 18 Nov 2014 07:52:56 +0000 (02:52 -0500)]
Make MIDI channel selector rows/col constraints actually do something.
Seems kind of pointless since it's always 4 anyway, but whatever.
David Robillard [Tue, 18 Nov 2014 07:37:30 +0000 (02:37 -0500)]
Avoid possible use of uninitialized values.
This could only happen with a broken widget, but it shuts up clang and doesn't
hurt.
David Robillard [Tue, 18 Nov 2014 07:36:28 +0000 (02:36 -0500)]
Remove obviously dead/redundant code.
David Robillard [Tue, 18 Nov 2014 07:35:35 +0000 (02:35 -0500)]
Clean up funny code and initialize variables.
David Robillard [Tue, 18 Nov 2014 07:34:18 +0000 (02:34 -0500)]
Constrain variable scopen and avoid uninitialized values existing at all.
Note: dead assignments trigger scan-build dead code warnings, which
initializations do not.
David Robillard [Tue, 18 Nov 2014 07:31:54 +0000 (02:31 -0500)]
Remove unused variable and redundant arithmetic.
David Robillard [Tue, 18 Nov 2014 07:29:50 +0000 (02:29 -0500)]
Gracefully avoid importing audio that somehow has 0 channels.
David Robillard [Tue, 18 Nov 2014 07:27:25 +0000 (02:27 -0500)]
Fix potential use of uninitialized value.
David Robillard [Tue, 18 Nov 2014 07:26:56 +0000 (02:26 -0500)]
Fix NULL pointer dereference on malformed Playlist XML.
David Robillard [Tue, 18 Nov 2014 07:26:37 +0000 (02:26 -0500)]
Avoid potential division by zero.
David Robillard [Tue, 18 Nov 2014 07:25:02 +0000 (02:25 -0500)]
Fix broken logic and possible NULL pointer dereference for Bundle XML.
David Robillard [Tue, 18 Nov 2014 07:23:49 +0000 (02:23 -0500)]
Fix incredibly unlikely NULL pointer dereference.
David Robillard [Tue, 18 Nov 2014 07:23:28 +0000 (02:23 -0500)]
Fix Region::verify_length() so it actually does something.
David Robillard [Tue, 18 Nov 2014 07:22:44 +0000 (02:22 -0500)]
Fix incredibly unlikely NULL pointer dereference.
David Robillard [Tue, 18 Nov 2014 07:22:06 +0000 (02:22 -0500)]
Fix zoom out limiting logic to actually limit minimum zoom.
David Robillard [Tue, 18 Nov 2014 07:20:38 +0000 (02:20 -0500)]
Fix mismatched note resize drag cursor and behaviour.
David Robillard [Tue, 18 Nov 2014 07:19:03 +0000 (02:19 -0500)]
Fix edit point selector on Mixbus.
Robin Gareus [Tue, 18 Nov 2014 05:15:22 +0000 (06:15 +0100)]
remove cruft
Robin Gareus [Tue, 18 Nov 2014 04:28:27 +0000 (05:28 +0100)]
Robin Gareus [Tue, 18 Nov 2014 03:46:37 +0000 (04:46 +0100)]
silence clang "dead assignment" warnings
Robin Gareus [Tue, 18 Nov 2014 02:49:20 +0000 (03:49 +0100)]
synchronize preferences and monitor-section
Robin Gareus [Tue, 18 Nov 2014 01:13:15 +0000 (02:13 +0100)]
files should have at least one channel.
Robin Gareus [Tue, 18 Nov 2014 01:09:09 +0000 (02:09 +0100)]
remove cruft (monitor section knobs are cairo now)
Robin Gareus [Tue, 18 Nov 2014 00:39:57 +0000 (01:39 +0100)]
NOOP, re-indent and remove trailing whitespace
Robin Gareus [Tue, 18 Nov 2014 00:09:18 +0000 (01:09 +0100)]
remove dead assignment
Robin Gareus [Tue, 18 Nov 2014 00:09:00 +0000 (01:09 +0100)]
remove superfluous if-branch (_session is checked a few lines above)
David Robillard [Tue, 18 Nov 2014 00:53:30 +0000 (19:53 -0500)]
Fix "maybe" rounding bug.
Introduced in
d63161426f256c293c92b73f1be4b375f962d298.
Robin Gareus [Mon, 17 Nov 2014 08:07:39 +0000 (09:07 +0100)]
waves/coreaudio PPC support
Robin Gareus [Mon, 17 Nov 2014 06:49:16 +0000 (07:49 +0100)]
OSX packaging:
* postfix DMG with "-dbg" if not optimized.
* strip binary and libs if optimized
Robin Gareus [Mon, 17 Nov 2014 05:41:01 +0000 (06:41 +0100)]
check alsa midi ringbuffer
David Robillard [Mon, 17 Nov 2014 05:13:53 +0000 (00:13 -0500)]
Fix visibility of MIDI controller automation tracks across saves.
Fix some inaccurate/misleading comments that led to said bug.
Gracefully handle the "impossible" case where we can't figure out a state ID
for an automation track, instead of crashing.
David Robillard [Mon, 17 Nov 2014 03:46:59 +0000 (22:46 -0500)]
Don't hide selected control points.
There was already code for this, but actually setting the corresponding
visibility flags seems to have been lost at some point.
David Robillard [Mon, 17 Nov 2014 03:35:37 +0000 (22:35 -0500)]
Support cut/copy/paste of MIDI notes and controllers at the same time.
David Robillard [Sun, 16 Nov 2014 22:04:27 +0000 (17:04 -0500)]
Support cut/copy/paste of several regions and lines at once.
The idea here is to do the reasonable thing, and copy objects of some
type (e.g. MIDI region, gain line) to tracks with a matching type. The user
can override this with a track selection, which will be used straight-up.
Lost: ability to copy/paste lines across types, e.g. gain to pan. This is
often questionable, but sometimes useful, so we will need to implement some
sort of "greedy mode" to make it possible. Implementation simple, but not sure
what to do. Perhaps this should only be possible if one automation track is
explicitly (i.e. via track selection) involved, and the types are at least
compatible-ish?
David Robillard [Sun, 16 Nov 2014 21:48:15 +0000 (16:48 -0500)]
Don't add spurious points when copy/pasting automation.
David Robillard [Sun, 16 Nov 2014 07:51:18 +0000 (02:51 -0500)]
Reset repeated paste state on cut/copy.
David Robillard [Sun, 16 Nov 2014 07:09:33 +0000 (02:09 -0500)]
Don't add origin value to MIDI controller regions on initial insert.
This should probably hijack the same modifier as the guard points and work the
same on all automation tracks, but I did it this way to not change behaviour of
track automation where a default is much more reasonable.
David Robillard [Sun, 16 Nov 2014 07:01:02 +0000 (02:01 -0500)]
Add "maybe" rounding modes for rounding only if necessary.
David Robillard [Sun, 16 Nov 2014 06:05:21 +0000 (01:05 -0500)]
Use an enum for RoundMode instead of magic numbers.
No functional changes in this one (for easier auditing), but towards having
round up/down only if necessary modes, rather than kludging around that
situation with a double round as we do currently.
David Robillard [Sun, 16 Nov 2014 03:42:51 +0000 (22:42 -0500)]
Make selected control points bright red rather than vice-versa.
David Robillard [Sat, 15 Nov 2014 23:53:53 +0000 (18:53 -0500)]
Make ControlList::paste const-correct.
David Robillard [Sat, 15 Nov 2014 21:32:08 +0000 (16:32 -0500)]
Use symbol for paste operation like everywhere else.
David Robillard [Sat, 15 Nov 2014 20:56:56 +0000 (15:56 -0500)]
Fix crash when splitting regions in internal edit mode.