From 15e9cb7324f1b331acde37d30590ba42c032eff2 Mon Sep 17 00:00:00 2001 From: Carl Hetherington Date: Sat, 4 May 2019 21:43:45 +0000 Subject: [PATCH] Fix crash in audio mapping view in various circumstances. --- src/wx/audio_mapping_view.cc | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/wx/audio_mapping_view.cc b/src/wx/audio_mapping_view.cc index 27094d3b2..ef37e1b7a 100644 --- a/src/wx/audio_mapping_view.cc +++ b/src/wx/audio_mapping_view.cc @@ -269,8 +269,12 @@ AudioMappingView::paint_row_lines (wxGraphicsContext* gc) void AudioMappingView::paint_indicators (wxDC& dc) { - for (size_t x = 0; x < _output_channels.size(); ++x) { - for (size_t y = 0; y < _input_channels.size(); ++y) { + /* _{input,output}_channels and _map may not always be in sync, be careful here */ + size_t const output = min(_output_channels.size(), _map.output_channels()); + size_t const input = min(_input_channels.size(), _map.input_channels()); + + for (size_t x = 0; x < output; ++x) { + for (size_t y = 0; y < input; ++y) { dc.SetBrush (*wxWHITE_BRUSH); dc.DrawRectangle ( wxRect( -- 2.30.2