From 69da43180e638518ed47424f2eba20cd25f2e093 Mon Sep 17 00:00:00 2001 From: Carl Hetherington Date: Sun, 26 Jul 2020 22:47:51 +0200 Subject: [PATCH] Fix some ignored return values. --- src/lib/cross_linux.cc | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/lib/cross_linux.cc b/src/lib/cross_linux.cc index 25fd3490e..28b8a4b41 100644 --- a/src/lib/cross_linux.cc +++ b/src/lib/cross_linux.cc @@ -113,7 +113,10 @@ run_ffprobe (boost::filesystem::path content, boost::filesystem::path out) { string ffprobe = "ffprobe \"" + content.string() + "\" 2> \"" + out.string() + "\""; LOG_GENERAL (N_("Probing with %1"), ffprobe); - system (ffprobe.c_str ()); + int const r = system (ffprobe.c_str()); + if (r == -1 || (WIFEXITED(r) && WEXITSTATUS(r) != 0)) { + LOG_GENERAL (N_("Could not run ffprobe (system returned %1"), r); + } } list > @@ -378,7 +381,10 @@ unprivileged () cerr << "getresuid() failed.\n"; exit (EXIT_FAILURE); } - seteuid (ruid); + if (seteuid(ruid) == -1) { + cerr << "seteuid() failed.\n"; + exit (EXIT_FAILURE); + } } PrivilegeEscalator::~PrivilegeEscalator () -- 2.30.2