From b46a2eb2ea4311ae5bdd13a2b0f209b493f81b12 Mon Sep 17 00:00:00 2001 From: Carl Hetherington Date: Wed, 18 Oct 2023 01:03:55 +0200 Subject: [PATCH] Fix crash when removing multiple cinemas caused by _selected_cinemas being changed as we read it (#2632). --- src/wx/screens_panel.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/wx/screens_panel.cc b/src/wx/screens_panel.cc index 9d322e45e..99f0d8ef0 100644 --- a/src/wx/screens_panel.cc +++ b/src/wx/screens_panel.cc @@ -330,7 +330,9 @@ ScreensPanel::remove_cinema_clicked () } } - for (auto const& cinema: _selected_cinemas) { + auto cinemas_to_remove = _selected_cinemas; + + for (auto const& cinema: cinemas_to_remove) { _ignore_cinemas_changed = true; ScopeGuard sg = [this]() { _ignore_cinemas_changed = false; }; for (auto screen: cinema->screens()) { -- 2.30.2