From d8bbc508e959d8d38c54a6db6cfc868bd64697f5 Mon Sep 17 00:00:00 2001 From: Carl Hetherington Date: Mon, 26 Feb 2024 23:18:15 +0100 Subject: [PATCH] Disallow referring to OV audio unless channel counts match (#2780). --- src/lib/dcp_content.cc | 8 ++++++++ src/wx/audio_panel.cc | 1 + 2 files changed, 9 insertions(+) diff --git a/src/lib/dcp_content.cc b/src/lib/dcp_content.cc index 6185b3a19..bdd5e0e09 100644 --- a/src/lib/dcp_content.cc +++ b/src/lib/dcp_content.cc @@ -720,6 +720,14 @@ DCPContent::can_reference_audio (shared_ptr film, string& why_not) c return false; } + if (audio && audio->stream()) { + auto const channels = audio->stream()->channels(); + if (channels != film->audio_channels()) { + why_not = String::compose(_("it has a different number of audio channels than the project; set the project to have %1 channels."), channels); + return false; + } + } + /// TRANSLATORS: this string will follow "Cannot reference this DCP: " return can_reference( film, [](shared_ptr c) { diff --git a/src/wx/audio_panel.cc b/src/wx/audio_panel.cc index f0863431a..fcadd0c68 100644 --- a/src/wx/audio_panel.cc +++ b/src/wx/audio_panel.cc @@ -208,6 +208,7 @@ AudioPanel::film_changed (FilmProperty property) case FilmProperty::AUDIO_PROCESSOR: _mapping->set_output_channels (_parent->film()->audio_output_names ()); setup_peak (); + setup_sensitivity(); break; case FilmProperty::VIDEO_FRAME_RATE: setup_description (); -- 2.30.2