Paul Davis [Fri, 7 Dec 2018 21:07:13 +0000 (16:07 -0500)]
use new action map API instead of ActionManager::get_action
Paul Davis [Fri, 7 Dec 2018 21:07:13 +0000 (16:07 -0500)]
use new action map API instead of ActionManager::get_action
Paul Davis [Fri, 7 Dec 2018 21:07:13 +0000 (16:07 -0500)]
use new action map API instead of ActionManager::get_action
Paul Davis [Fri, 7 Dec 2018 21:07:13 +0000 (16:07 -0500)]
use new action map API instead of ActionManager::get_action
Paul Davis [Fri, 7 Dec 2018 21:05:56 +0000 (16:05 -0500)]
provide (Static)ActionMapOwner::action_map()
Robin Gareus [Sun, 9 Dec 2018 00:31:27 +0000 (01:31 +0100)]
Unhardode log-message domain when logging to stdout
Robin Gareus [Sun, 9 Dec 2018 00:27:55 +0000 (01:27 +0100)]
"only"
1048576 -- sounds like it's not sufficient
Robin Gareus [Sat, 8 Dec 2018 22:39:50 +0000 (23:39 +0100)]
Better version of
9ccc56e1625, implicit signal disconnect
Robin Gareus [Sat, 8 Dec 2018 21:38:03 +0000 (22:38 +0100)]
Properly keep track of Window Visibility, action state
This fixes inconsistent WM::Proxy state when a window is destroyed
Specifically "session-options-editor" when the session is unloaded;
previously "toggle-session-options-editor" was never unset.
Robin Gareus [Sat, 8 Dec 2018 20:18:54 +0000 (21:18 +0100)]
Fix CheckOption crash on session-reload
The ToggleAction has a lifetime of the UI, independent of the
CheckOption widget. The CheckOption needs to unsubscribe from the
signal_toggled() signal when it is deleted.
Also a CheckOption without a Action makes no sense. require _action
to be give at instantiation time.
Robin Gareus [Sat, 8 Dec 2018 19:17:01 +0000 (20:17 +0100)]
NO-OP: whitespace and some guaranteed assertion removal
Robin Gareus [Sat, 8 Dec 2018 19:15:53 +0000 (20:15 +0100)]
Fix crash when closing session, recursive mon-section removal
Robin Gareus [Sat, 8 Dec 2018 16:04:32 +0000 (17:04 +0100)]
Fix gmsynth detection
Previously this worked since gmsynth was sorted after reasonably synth
Ben Loftis [Tue, 4 Dec 2018 00:55:52 +0000 (18:55 -0600)]
Tweaks to Mixer and Monitor keybindings:
Add Mixer-specific view keybindings for list, vca, mon. (thanks to: the_CLA)
Move monitor keybindings (mute, dim, mono) to be globally-accessible.
Implement new mixer-specific actions to show/hide monitor,vcas,mixbuses (the_CLA)
Move monitor funcs (mute,dim,mono) to globally-accessible actions.
Make a new Monitor group insted of using Transport group.
Allow use-monitor-section to be controlled by both menu and session-options dialog.
Robin Gareus [Fri, 7 Dec 2018 03:41:22 +0000 (04:41 +0100)]
Fix progress report when resampling to fixed-point on import
Robin Gareus [Fri, 7 Dec 2018 03:15:55 +0000 (04:15 +0100)]
Fix importing to a fixed-point format with resampling
ResampledImportableSource::read() returns audio-frames;
multiplication by number of channels read beyond the buffer.
Paul Davis [Fri, 7 Dec 2018 03:12:27 +0000 (22:12 -0500)]
add syntactic sugar for fetching toggle and radio actions
Robin Gareus [Fri, 7 Dec 2018 02:46:58 +0000 (03:46 +0100)]
Remove redundant call (there's no session, nothing to save)
Robin Gareus [Fri, 7 Dec 2018 02:36:48 +0000 (03:36 +0100)]
Fix editor sizing issue introduced in
4dc65e66
Previously Editor::instant_save() returned if no session was loaded,
effectively Config->add_instant_xml(get_state()); was never called.
instant save() is called early on, in Editor's c'tor before the editor
is realized and saves invalid window-size and window-state, which
are used later.
Robin Gareus [Thu, 6 Dec 2018 01:23:53 +0000 (02:23 +0100)]
Prefer testing the session instead of using a global variable
Robin Gareus [Thu, 6 Dec 2018 01:23:09 +0000 (02:23 +0100)]
Fix inconsistent session-check
under some circumstances, e.g. session-exit it is possible to to have
inconsistent information
ARDOUR_UI::instance()->session_loaded == true
&& ARDOUR_UI::instance()->the_session() == NULL
This lead to a crash on MacOS/X. stopping the engine at exit may destory
an Aggregate Device, leading to DeviceListChanged which in turn updates
the engine-dialog..
else if (ARDOUR_UI::instance()->session_loaded) {
float active_sr = ARDOUR_UI::instance()->the_session()->nominal_sample_rate ();
Paul Davis [Wed, 5 Dec 2018 22:48:34 +0000 (17:48 -0500)]
another replacement of ActionManager::get_action() by ActionMap::find_action()
Paul Davis [Wed, 5 Dec 2018 22:32:35 +0000 (17:32 -0500)]
start using ActionMap in preference to ActionManager
Paul Davis [Wed, 5 Dec 2018 22:32:02 +0000 (17:32 -0500)]
some ActionMap infrastructure to start removing ActionManager
Paul Davis [Wed, 5 Dec 2018 20:22:48 +0000 (15:22 -0500)]
add new variant of ActionMap::find_action()
This is more useful when replacing ActionManager::get_action
Robin Gareus [Wed, 5 Dec 2018 19:18:56 +0000 (20:18 +0100)]
Fix generic plugin UI for plugins with only properties
e.g. reMID.lv2 has only a atom/file-property and no control-inputs.
Robin Gareus [Wed, 5 Dec 2018 15:05:56 +0000 (16:05 +0100)]
Skip silent sources on session-archive -- fixes #7699
Robin Gareus [Wed, 5 Dec 2018 15:04:29 +0000 (16:04 +0100)]
Prevent endless read of silent files
This fixes issues with analysis and archiving that rely on a readable
to return 0.
Note however that createSilent() uses max_samplecnt (INT64_MAX) by
default. This relies on a region setting the length of its missing
source.
Robin Gareus [Tue, 4 Dec 2018 21:12:43 +0000 (22:12 +0100)]
Use atomic read for an atomic variable
This probably no real world effect since there is a mutex in the
loop that acts as a memory barrier.
Robin Gareus [Tue, 4 Dec 2018 21:07:27 +0000 (22:07 +0100)]
Tab to prev/next name-entry: skip only rec-armed tracks
Robin Gareus [Tue, 4 Dec 2018 16:06:13 +0000 (17:06 +0100)]
Fix logic-error in
d1cf2163: hide info for optimized builds
Robin Gareus [Mon, 3 Dec 2018 21:45:22 +0000 (22:45 +0100)]
Expose DSP load window
Robin Gareus [Mon, 3 Dec 2018 21:34:14 +0000 (22:34 +0100)]
Don't show DSP stats of inserts that don't collect them.
Robin Gareus [Mon, 3 Dec 2018 21:29:25 +0000 (22:29 +0100)]
Special case Mixbus Chanstrip for load calculation
These processors don't have a UI, so their load stats are not easily
visible. The stats can still be queried via Lua API or DSP-load
overview window, so we retain this for debug builds.
Robin Gareus [Mon, 3 Dec 2018 19:45:06 +0000 (20:45 +0100)]
Consistent AU factory Preset IDs
Use AU's preset->presetNumber as identifier since std::map are sorted
this also indirectly sorts presets by preset-number. (user presets
start with a '/' and are listed first, sorted by name).
Since Presets are now identified by URI on session load (
53a0199a0)
and AU user-presets can added/be removed (since
ae4604a24b7), simple
sequential numbering is no longer an option.
Robin Gareus [Sun, 2 Dec 2018 01:04:21 +0000 (02:04 +0100)]
Don't invalidate AU preset on load
This works around async parameter-changed signal emission when loading
an AU preset. A simple timeout is used to delay making the preset
as modified.
Robin Gareus [Sun, 2 Dec 2018 00:38:14 +0000 (01:38 +0100)]
GUI Updates for plugin save/delete operations
Robin Gareus [Sun, 2 Dec 2018 00:37:33 +0000 (01:37 +0100)]
Implement AU plugin-preset removal
Robin Gareus [Sun, 2 Dec 2018 00:36:32 +0000 (01:36 +0100)]
Restore actual plugin-preset on session-load
This checks if the preset is actually available on the given system
and also sets the user-flag correctly.
Robin Gareus [Sat, 1 Dec 2018 23:26:57 +0000 (00:26 +0100)]
Towards fixing AU preset invalidation
This is a step in the right direction: first load the preset and
only if preset-loading was successful mark it as loaded.
This still does not properly unset "parameter_changed_since_last_preset".
AU signals "kAudioUnitEvent_ParameterValueChange" later in the event-loop.
Robin Gareus [Sat, 1 Dec 2018 04:36:33 +0000 (05:36 +0100)]
AU: mark preset dirty when parameter changes
Robin Gareus [Sat, 1 Dec 2018 04:33:26 +0000 (05:33 +0100)]
Fix AU preset handling
load_property_list() takes a file-path (not URI). Actually it's not
clear why we've ever used a `file:///` URI internally.
Robin Gareus [Sat, 1 Dec 2018 02:21:45 +0000 (03:21 +0100)]
Night of the typos III (amend prev 2 commits)
Robin Gareus [Sat, 1 Dec 2018 02:13:59 +0000 (03:13 +0100)]
Also use xjadeo 64bit windows version
Robin Gareus [Fri, 30 Nov 2018 23:56:20 +0000 (00:56 +0100)]
Harvid and xjadeo now feature 32/64bit window version(s)
Robin Gareus [Fri, 30 Nov 2018 17:10:35 +0000 (18:10 +0100)]
Freeze harvid/xjadeo PPC version
Paul Davis [Thu, 29 Nov 2018 22:36:19 +0000 (17:36 -0500)]
fix incorrect accumulation of export video options each time the dialog is used
Robin Gareus [Thu, 29 Nov 2018 13:25:52 +0000 (14:25 +0100)]
Fix a tiny memory leak, add_instant_xml() copies the node
Robin Gareus [Thu, 29 Nov 2018 13:25:22 +0000 (14:25 +0100)]
Delete temporary Window Proxy for dialogs
There are two cases:
(A) Proxy is created first, dialog is created later on demand
(B) Dialog is created and directly registers its window as proxy
In (B) the dialog is usually on the stack and destroyed when the
ArdourDialog instances leaves scope. In that case ~ArdourDialog()
is called and the proxy remained.
Destroying the proxy does destroy the registered window in ~WindowProxy()
If ArdourDialog's d'tor itself deletes the proxy it would recurse into
itself. Existing APIs e.g. drop_window() likewise delete the window and
cannot be safely called from ~ArdourDialog.
Robin Gareus [Thu, 29 Nov 2018 01:10:08 +0000 (02:10 +0100)]
Fix uninitialized variable
Robin Gareus [Thu, 29 Nov 2018 01:07:29 +0000 (02:07 +0100)]
NO-OP: whitespace
Robin Gareus [Thu, 29 Nov 2018 01:06:42 +0000 (02:06 +0100)]
Fix a tiny memory-leak when calling vfork
Robin Gareus [Thu, 29 Nov 2018 01:05:26 +0000 (02:05 +0100)]
Disk I/O: only allocate midi-buffer if needed
This fixes a memory-leak (_midi_buf was allocated in DiskIOProc
but only delete in DiskReader). Also skip midi-refill early on
Robin Gareus [Wed, 28 Nov 2018 20:41:08 +0000 (21:41 +0100)]
Fix a potential memory-corruption
Disk-writer run() can concurrently use the ringbuffer after it was
free()ed by the butler thread.
Robin Gareus [Wed, 28 Nov 2018 14:32:40 +0000 (15:32 +0100)]
Remove ambiguous API implementation
* PortEngine::available() implementation
* AudioEngine::connected() wrapper
Eventually we may re-introduce PortEngine::available along
with a libardour internal port-engine.
Robin Gareus [Wed, 28 Nov 2018 14:24:47 +0000 (15:24 +0100)]
Consolidate ambiguous engine API calls
available(), connected(), running() were ill-defined and
used interchangeably.
Robin Gareus [Wed, 28 Nov 2018 14:19:39 +0000 (15:19 +0100)]
Consolidate API, prefer ->running()
Robin Gareus [Wed, 28 Nov 2018 14:17:57 +0000 (15:17 +0100)]
Consolidate two more engine-checks
Robin Gareus [Wed, 28 Nov 2018 13:56:04 +0000 (14:56 +0100)]
NO-OP: Clarify function name
Robin Gareus [Tue, 27 Nov 2018 23:02:57 +0000 (00:02 +0100)]
Use central method to check for engine for processor operations
Robin Gareus [Tue, 27 Nov 2018 23:01:50 +0000 (00:01 +0100)]
Use central method to check for engine where required
These are generally places where tracks/busses are created or port
connections change.
Robin Gareus [Tue, 27 Nov 2018 22:57:53 +0000 (23:57 +0100)]
Prepare central engine check and user notification
Robin Gareus [Tue, 27 Nov 2018 12:19:34 +0000 (13:19 +0100)]
Catch potential exceptions when adding tracks/busses
Robin Gareus [Tue, 27 Nov 2018 12:18:39 +0000 (13:18 +0100)]
GUI limitation: Require engine to add/remove tracks/busses
Robin Gareus [Mon, 26 Nov 2018 20:45:06 +0000 (21:45 +0100)]
Fix stuck connection block when template load fails.
Session::new_route_from_template() unconditionally calls
IO::disable_connecting(), and needs to be reverted likewise
(no RAII here).
Robin Gareus [Mon, 26 Nov 2018 02:31:02 +0000 (03:31 +0100)]
Prevent deadlock when removing routes w/o engine
Robin Gareus [Mon, 26 Nov 2018 02:06:22 +0000 (03:06 +0100)]
Don't allow to add/remove monitor-section w/o engine
Adding/removing the Monitor section changes port-connections,
a port-engine is needed to establish connections.
Ideally we'd allow this and queue for connection changes. This
will however require deep changes.
Also toggling the monitor-section on/off/on w/o engine can later
result in failure to register ports. Due to lack of engine-signals
not all shared_ptr<> port references are dropped.
Robin Gareus [Mon, 26 Nov 2018 01:39:55 +0000 (02:39 +0100)]
Fix various issues when the engine disconnects:
Previously Port::PortDrop was never handled.
The signal was disconnected directly when the connection
is re-used by Port::PortSignalDrop.
Ports::drop() was not called when the engine was stopped
or disconnected, and port-handles were not invalidated.
This lead to crashes whenever a port-related operation was performed
while the engine was stopped. e.g. adding/removing tracks or plugins
(latency recompute, notify port-engine) and various other operations.
Robin Gareus [Sun, 25 Nov 2018 23:32:29 +0000 (00:32 +0100)]
Fix a double-free, introduced in
b06713bd8e57
~OptionEditor() already frees all components on every page.
Robin Gareus [Sun, 25 Nov 2018 16:22:46 +0000 (17:22 +0100)]
Do not allocate MIDI buffers for signal analysis
At this point in time MIDI buffers are vastly over-sized.
They include VST and LV2 event structure. This added about a MB per
plugin for no benefit.
Robin Gareus [Sun, 25 Nov 2018 15:57:51 +0000 (16:57 +0100)]
Fix Linux/PPC64 runtime
This fixes an error while loading shared libraries: libardour.so
R_PPC64_ADDR32 reloc at 0x... for symbol `' out of range
Treating a local as an immediate value in asm code makes the library
non-relocatable.
Robin Gareus [Sun, 25 Nov 2018 15:51:24 +0000 (16:51 +0100)]
Allow compilation with winpthreads -- closes #7691
Robin Gareus [Sun, 25 Nov 2018 15:40:28 +0000 (16:40 +0100)]
Bundle x42-limiter with binaries
Robin Gareus [Sat, 24 Nov 2018 01:01:16 +0000 (02:01 +0100)]
Auditioner: check if removing synth succeeds
remove_processor() also calls drop_references, when successful.
Robin Gareus [Fri, 23 Nov 2018 21:43:26 +0000 (22:43 +0100)]
Handle some midnam edge-cases
Whitespace between XML nodes can result in "text" children.
Those need to be skipped in the patch-name list.
Robin Gareus [Fri, 23 Nov 2018 21:09:13 +0000 (22:09 +0100)]
NO-OP: whitespace and re-organization
Robin Gareus [Fri, 23 Nov 2018 21:00:04 +0000 (22:00 +0100)]
Load audition synth on demand
This saves some memory (gmsynth loads a 30MB soundfont), and also
re-initializes the synth every time to gm defaults in case some
.mid changes patches or parameters.
Robin Gareus [Fri, 23 Nov 2018 13:36:52 +0000 (14:36 +0100)]
Update Fluidsynth to v2.0.2
John Emmas [Fri, 23 Nov 2018 07:28:17 +0000 (07:28 +0000)]
Add/remove source(s) in our MSVC project (gtk2_ardour)
John Emmas [Fri, 23 Nov 2018 07:27:32 +0000 (07:27 +0000)]
Add/remove source(s) in our MSVC project (audiographer)
John Emmas [Fri, 23 Nov 2018 07:25:54 +0000 (07:25 +0000)]
Add/remove source(s) in our MSVC project (libardour)
Robin Gareus [Thu, 22 Nov 2018 20:05:03 +0000 (21:05 +0100)]
Amend prev. commit, actually remove (1.0 - x) as was documented
Robin Gareus [Thu, 22 Nov 2018 19:36:41 +0000 (20:36 +0100)]
Backwards compatible sndfile support
SFC_SET_COMPRESSION_LEVEL was only added in 2012 and only available in
libsndfile 1.0.26 or later.
Robin Gareus [Thu, 22 Nov 2018 14:02:35 +0000 (15:02 +0100)]
Extend LV2UI-Request-Parameter File/Path GUI
This is a bit of a playground implementation, the various `#if 0`
code-blocks should be removed.
Robin Gareus [Thu, 22 Nov 2018 13:58:44 +0000 (14:58 +0100)]
Save LV2 Port Property values locally
This keeps track of lv2:Parameter properties modified with Port:Set,
currently file-paths.
Robin Gareus [Thu, 22 Nov 2018 05:12:54 +0000 (06:12 +0100)]
Fix LV2UI_Request_Parameter Feature URI
Robin Gareus [Wed, 21 Nov 2018 22:21:52 +0000 (23:21 +0100)]
Update codec-quality display when ExportFormat changes
Robin Gareus [Wed, 21 Nov 2018 22:21:13 +0000 (23:21 +0100)]
Properly revert FormatSpec changes on "cancel"
Previously the ExportFormatDialog saved changes to disk on "save" but
did nothing on "cancel". The format changed *remained* modified in
memory, just not saved (until the ExportProfileManager is re-instantiated)
Robin Gareus [Wed, 21 Nov 2018 22:14:52 +0000 (23:14 +0100)]
Allow to revert export-format from disk
This allows to restore ProfileManager's ExportFormatSpec without
re-instantiating the ProfileManager.
Robin Gareus [Wed, 21 Nov 2018 20:19:01 +0000 (21:19 +0100)]
Set encoder quality for existing ExportFormatSpecs
Robin Gareus [Wed, 21 Nov 2018 01:26:33 +0000 (02:26 +0100)]
Early prototype for _LV2UI_Request_Parameter extension
Olivier Humbert [Tue, 20 Nov 2018 22:13:17 +0000 (23:13 +0100)]
Fix a window size potential issue
Robin Gareus [Tue, 20 Nov 2018 23:05:13 +0000 (00:05 +0100)]
Update GUI, use/remove meta-data methods that have been migrated to the backend
Robin Gareus [Tue, 20 Nov 2018 23:03:36 +0000 (00:03 +0100)]
Include session-metadata in external/ffmpeg export
Robin Gareus [Tue, 20 Nov 2018 22:56:12 +0000 (23:56 +0100)]
Prepare session-metadata export to external command
Robin Gareus [Tue, 20 Nov 2018 02:35:25 +0000 (03:35 +0100)]
Vorbis Quality Config GUI
Robin Gareus [Tue, 20 Nov 2018 02:21:17 +0000 (03:21 +0100)]
Implement vorbis encoder quality
This also prepares for codec-quality defaults, but
ExportFormatSpecification does not yet set those for previously unset
or new formats/presets.
Robin Gareus [Mon, 19 Nov 2018 23:38:18 +0000 (00:38 +0100)]
Handle port-export report of unplayable files
Robin Gareus [Mon, 19 Nov 2018 23:21:51 +0000 (00:21 +0100)]
Add some mp3 export presets
Robin Gareus [Mon, 19 Nov 2018 22:45:26 +0000 (23:45 +0100)]
FFMPEG/MP3 encoder quality select GUI