Paul Davis [Tue, 3 Sep 2013 13:08:18 +0000 (09:08 -0400)]
bump to 3.4
Paul Davis [Tue, 3 Sep 2013 12:48:11 +0000 (08:48 -0400)]
fix error introduced during recent changes to Mackie control support, involving ambiguous enum usage
Paul Davis [Tue, 3 Sep 2013 12:00:58 +0000 (08:00 -0400)]
updated .po files from waf i18n, plus an updated gtk2_ardour/de.po from Edgar Aichinger
Paul Davis [Tue, 3 Sep 2013 11:59:59 +0000 (07:59 -0400)]
Revert "bump to 3.4"
This reverts commit
ad7ab8f09afe1eac025a6da87a45c83ada15544d.
Paul Davis [Tue, 3 Sep 2013 02:10:51 +0000 (22:10 -0400)]
revert to --backtrace enabled by default, since the original goal of this change was addressed in other ways
Paul Davis [Tue, 3 Sep 2013 01:57:30 +0000 (21:57 -0400)]
bump to 3.4
Paul Davis [Mon, 2 Sep 2013 21:43:55 +0000 (17:43 -0400)]
add std:: to clarify use of llabs on OS X
Robin Gareus [Mon, 2 Sep 2013 14:57:46 +0000 (16:57 +0200)]
LV2 extUI handling - amend to previous commit.
Robin Gareus [Mon, 2 Sep 2013 14:21:12 +0000 (16:21 +0200)]
LV2 external UI handling - revert to <= 3.3. behaviour
Don't ever clean up external UI plugins that use the LV2plug.in URI.
only free the memory of the last instance when the plugin is removed
or ardour closes.
Robin Gareus [Sun, 1 Sep 2013 01:19:13 +0000 (03:19 +0200)]
improve scroll and drag behaviour of volume-controller knob
Robin Gareus [Sat, 31 Aug 2013 18:37:02 +0000 (20:37 +0200)]
fix keyboard interaction with volume knobs (monitor section)
Robin Gareus [Thu, 29 Aug 2013 16:46:03 +0000 (18:46 +0200)]
fix typo in IEC-meter 'weird-float' protection.
Robin Gareus [Thu, 29 Aug 2013 15:36:52 +0000 (17:36 +0200)]
protect meters against weird float values
Robin Gareus [Thu, 29 Aug 2013 11:05:11 +0000 (13:05 +0200)]
update external plugin UI handling
amend to
4cdb018 and
1d972d0
override ui_closed() behavior for lv2ui:external
Keep UI around and do not re-instantiate, but simply show it again.
(this is against the original specs but was agreed upon by various
authors and the previous behavior or Ardour.)
kx:external-ui are cleaned up after ui_closed().
Robin Gareus [Tue, 27 Aug 2013 18:55:15 +0000 (20:55 +0200)]
fix vari-speed phase (when used for calculation only)
and clarify an old comment.
Robin Gareus [Sun, 25 Aug 2013 14:20:27 +0000 (16:20 +0200)]
add LV2 support for kx:external-ui#
the ABI of http://kxstudio.sf.net/ns/lv2ext/external-ui# is identical to
http://lv2plug.in/ns/extensions/ui#external
It just adds a distinction between #Host and #Widget for cosmetic reasons.
Sadly some newer plugins are released with only support for kxstudio URI :(
Robin Gareus [Sun, 25 Aug 2013 13:54:43 +0000 (15:54 +0200)]
free memory of external plugins on GUI close (major mem leak).
There is at least one known plugin that has a problem with this
(custom thread race condition) but it also crashes in other hosts:
http://www.drumgizmo.org/wiki/doku.php?id=bugs&do=showcaselink&showid=8&project=drumgizmo
tested to be working with various nedko, falktx and x42 plugins
Paul Davis [Sat, 24 Aug 2013 15:46:36 +0000 (11:46 -0400)]
pot/po file updates caused by waf i18n
Paul Davis [Sat, 24 Aug 2013 15:45:31 +0000 (11:45 -0400)]
fix confusion about whether flip_mode in the Mackie support code is a bool or an enum
Tim Blechmann [Sat, 24 Aug 2013 12:23:25 +0000 (14:23 +0200)]
export: add support for CAF
Robin Gareus [Fri, 23 Aug 2013 19:26:02 +0000 (21:26 +0200)]
don't run meter in import-dialog if the dialog is not visible
Paul Davis [Thu, 22 Aug 2013 21:46:19 +0000 (17:46 -0400)]
undo the hiding of SR-dependent LV2 ports
Paul Davis [Thu, 15 Aug 2013 18:55:57 +0000 (14:55 -0400)]
update czech translations from pavel fric, part 2
Paul Davis [Thu, 15 Aug 2013 18:55:10 +0000 (14:55 -0400)]
update czech translations from pavel fric
Paul Davis [Thu, 15 Aug 2013 15:44:47 +0000 (11:44 -0400)]
fix newly-appearing crash-at-close caused by muddled thinking in pbd/pthread_utils
threads created with this code can now just return a value as they normally would, and the
infrastructure will ensure cleanup. there is no longer any reason to call pthread_exit_pbd()
and so that has been removed.
Paul Davis [Thu, 15 Aug 2013 15:43:37 +0000 (11:43 -0400)]
check master sources when determining whether a region uses a source. should fix #5618
Tim Mayberry [Sat, 10 Aug 2013 02:08:45 +0000 (12:08 +1000)]
Move curve test file handling in main() until after ARDOUR::init is called
This means it doesn't need to call PBD::ID::init directly, which it now
shouldn't be doing
Tim Mayberry [Sat, 10 Aug 2013 02:07:39 +0000 (12:07 +1000)]
Remove call to PBD::ID::init as it is now done via ARDOUR::init
Tim Mayberry [Fri, 26 Jul 2013 02:04:40 +0000 (12:04 +1000)]
Call setup_libpbd_enums in PBD::init for portability
Tim Mayberry [Fri, 9 Aug 2013 12:13:50 +0000 (22:13 +1000)]
Call Gio::init from PBD::init instead of ARDOUR::init
PBD needs Gio for PBD::copy_file and perhaps others
Tim Mayberry [Fri, 9 Aug 2013 12:11:44 +0000 (22:11 +1000)]
Call PBD::init in ARDOUR::init and PBD::cleanup in ARDOUR::cleanup
Tim Mayberry [Fri, 9 Aug 2013 12:03:39 +0000 (22:03 +1000)]
Add PBD::init and PBD::cleanup
A bit of refactoring to move initialization of libpbd into libpbd
rather than rely on "client" code(ui,libardour,tests etc) to do it
Tim Mayberry [Fri, 9 Aug 2013 11:47:16 +0000 (21:47 +1000)]
Move initialization of libardour from ARDOUR_UI class into main()
Tim Mayberry [Thu, 25 Jul 2013 11:38:59 +0000 (21:38 +1000)]
Prevent libardour from being initialized more than once
This is not thread safe of course, it is not intended to be.
This was implemented as at one stage ARDOUR::init was being called multiple
times in the testsuite which was causing a subtle bug that took some
time to track down.
Tim Mayberry [Fri, 9 Aug 2013 10:41:58 +0000 (20:41 +1000)]
Change ARDOUR::init return type to bool type for success/failure
Robin Gareus [Sun, 11 Aug 2013 15:26:34 +0000 (17:26 +0200)]
Robin Gareus [Sun, 11 Aug 2013 15:19:04 +0000 (17:19 +0200)]
fix
5dee49e19 (32/64 bit unsigned int compatibility)
Robin Gareus [Sun, 11 Aug 2013 13:10:41 +0000 (15:10 +0200)]
make LV2 communication buffers independent from jack-midi buffer-size
fixes issues with plugin communication that are common with
jack1 use due to its very small midi-buffers.
Robin Gareus [Fri, 9 Aug 2013 17:35:27 +0000 (19:35 +0200)]
fix typos
Robin Gareus [Fri, 9 Aug 2013 17:34:32 +0000 (19:34 +0200)]
updated monitor modes doc (new version from Chris with IDs)
Robin Gareus [Thu, 8 Aug 2013 18:08:20 +0000 (20:08 +0200)]
remove --no-freesound option. fixes #5640
Paul Davis [Thu, 8 Aug 2013 03:06:25 +0000 (23:06 -0400)]
new Mackie Control device file for Qcon controller (from #5634)
Robin Gareus [Wed, 7 Aug 2013 13:57:29 +0000 (15:57 +0200)]
fix compiler warning
Robin Gareus [Sun, 4 Aug 2013 16:50:51 +0000 (18:50 +0200)]
fix meter-background highlight when peaking. (> vs >=)
Robin Gareus [Sun, 4 Aug 2013 16:49:28 +0000 (18:49 +0200)]
fix rounding issue when dragging video with fractional fps
Robin Gareus [Sun, 4 Aug 2013 15:23:58 +0000 (17:23 +0200)]
vtl: import audio at video-offset, forget offset on "Remove Video"
Robin Gareus [Sun, 4 Aug 2013 14:22:00 +0000 (16:22 +0200)]
Timecode: fix subframe rounding
if sub-frames are used, frames are rounded up for the later half of
a sub-frame. e.g. @48KSPS, 25fps, 100 subframes per frame
audio-samples >=1910 already yield 00:00:00:01
Robin Gareus [Sun, 4 Aug 2013 14:13:43 +0000 (16:13 +0200)]
fix no-roll LTC encoder, honor locates when transport is stopped
Robin Gareus [Sat, 3 Aug 2013 22:06:29 +0000 (00:06 +0200)]
make master-meter in toolbar optional
Robin Gareus [Sat, 3 Aug 2013 19:35:19 +0000 (21:35 +0200)]
advance track's play-position even if processing is locked
fixes
* http://tracker.ardour.org/view.php?id=5628
* http://tracker.ardour.org/view.php?id=5561
Robin Gareus [Sat, 3 Aug 2013 14:54:57 +0000 (16:54 +0200)]
dedicated namespace for video-utils
conflicting symbol prophylaxis
Robin Gareus [Sat, 3 Aug 2013 14:41:25 +0000 (16:41 +0200)]
remove strtok_r() from video_query_info()
for minGW compatibility
Robin Gareus [Sat, 3 Aug 2013 11:59:22 +0000 (13:59 +0200)]
add a peak reset button to the editor meter
see http://tracker.ardour.org/view.php?id=5601
Robin Gareus [Sat, 3 Aug 2013 11:45:27 +0000 (13:45 +0200)]
fix gtk "child->parent == NULL" asserts
Robin Gareus [Sat, 3 Aug 2013 01:44:51 +0000 (03:44 +0200)]
properly handle port removal in route.
bug:
- add midi track
- add additional midi port
- remove additional midi port
- press play
-> crash
because..
ARDOUR::MidiTrack::roll's route_buffer still has 2 midi-channels. This is
because processor_max_streams was not updated (no plugins added/removed)
fill_buffers_with_input() eventually asserts when trying to get the 2nd
(nonexistant) midi port via ARDOUR::PortSet::nth_midi_port() in
ARDOUR::PortSet::port().
Robin Gareus [Sat, 3 Aug 2013 00:46:08 +0000 (02:46 +0200)]
fix "other" port-group tab
Separate port-bundles for each jack client in the connection manager.
Previously, apps were only listed as separate bundles if the
ports were gathered at different times. ie one app shows up after
the other (and if no complete re-scan was triggered)
Fixes issue reported by Fons Adriaensen.
Robin Gareus [Fri, 2 Aug 2013 23:37:25 +0000 (01:37 +0200)]
Merge branch 'midiclock' of https://github.com/axetota/ardour
Michael Fisher [Fri, 2 Aug 2013 23:23:36 +0000 (18:23 -0500)]
Send and Read MIDI Positions the right way
Robin Gareus [Fri, 2 Aug 2013 22:50:09 +0000 (00:50 +0200)]
on session-load: skip output-change-handler until IOs are restored
fixes loading a session with tracks that have more input-ports
than output-ports.
the problem:
input -ports are added first, when added, IO::ensure_port() emits
IOChange::ConfigurationChanged which in turn triggers the route to
allocate corresponding output ports.
Due to this callback the output-ports were created before the actual
output-port-configuration and plugin-configuration from the
session-state was parsed and set.
Robin Gareus [Fri, 2 Aug 2013 21:02:13 +0000 (23:02 +0200)]
disallow invalid port-removal
do not allow port-removal if the port would be re-added immediately
after that again because the main-delivery actually needs it.
As a side effect this prevents this crash:
* create a stereo-track, then remove one output
-> unhandled exception "AudioEngine::PortRegistrationFailure&"
The problem:
- the port is removed from the RCU ports list,
but Port::drop() (which calls jack_port_unregister) is only called
from the Port's destructor at some later time.
(because a reference to the port still exists elsewhere)
- the jack-port is not yet removed.
- meanwhile Delivery::configure_io comes along and notices that
there are more audio-buffers than ports and tries to re-register the port.
- but the port still exists in jack, so it fails and throws an exception
...which is not handled.
Paul Davis [Fri, 2 Aug 2013 16:50:52 +0000 (12:50 -0400)]
fix typos in display of error message about an LV2 plugin preset
Michael Fisher [Fri, 2 Aug 2013 15:29:12 +0000 (10:29 -0500)]
Resolve duplicate symbol 'cocoa_open_uri' on OSX builds.
cocoa_open_uri.mm was being added to the source list
twice and also compiling twice. This patch enusres it is
only added once.
Robin Gareus [Fri, 2 Aug 2013 15:40:58 +0000 (17:40 +0200)]
keep port-matrix in sync when deleting ports. and fix segfault on session close with io-matrix visible
Michael Fisher [Thu, 1 Aug 2013 19:14:01 +0000 (14:14 -0500)]
Midi clock housekeeping
Michael Fisher [Thu, 1 Aug 2013 18:54:58 +0000 (13:54 -0500)]
Make Session::send_song_position_pointer a no-op
Michael Fisher [Thu, 1 Aug 2013 18:47:22 +0000 (13:47 -0500)]
Revamp clock processing so it uses an internal frame reference.
MidiClockTicker::Position managed by boost::scoped_ptr
Michael Fisher [Thu, 1 Aug 2013 15:07:18 +0000 (10:07 -0500)]
WIP - Experimenting with an alternative clock generating algo
- Transport debug output (tracing where transport_frame
is updated
Michael Fisher [Thu, 1 Aug 2013 05:55:58 +0000 (00:55 -0500)]
Human readable printing of MIDI Position messages
Michael Fisher [Thu, 1 Aug 2013 05:09:42 +0000 (00:09 -0500)]
- Send position data from internal position class
- Proper midi beat conversions for all time signatures
- Disable responding to Session::PositionChanged in place
of Session::Located.
Michael Fisher [Wed, 31 Jul 2013 12:15:52 +0000 (07:15 -0500)]
Test code removal...
Michael Fisher [Wed, 31 Jul 2013 12:02:28 +0000 (07:02 -0500)]
MIDI Clock - Shuffling locate code (not actually used yet)
- Subscribe to Session::Locate to detect seeks
- Shuffle Mclk locating computations into a separate private class
Michael Fisher [Mon, 29 Jul 2013 21:15:04 +0000 (16:15 -0500)]
Stop compiler warning about NSURL
Robin Gareus [Fri, 2 Aug 2013 01:39:00 +0000 (03:39 +0200)]
rework MIDI [processor|plugin] chain
* forward midi-data around plugins that have no MIDI-out
* allow to insert plugins with no MIDI-input at a point with one MIDI-channel
This works because excess ports (both plugin and route) remain
unconnected and use scratch-buffers.
Tested with LV2, LXVST and LADSPA.
(AU plugins with variable in/out retain the old behavior, no bypass)
fixes http://tracker.ardour.org/view.php?id=5630
Paul Davis [Thu, 1 Aug 2013 14:46:22 +0000 (10:46 -0400)]
remove an identical odd namespacing typo
Paul Davis [Thu, 1 Aug 2013 14:44:34 +0000 (10:44 -0400)]
remove odd namespacing typo
Paul Davis [Thu, 1 Aug 2013 14:10:21 +0000 (10:10 -0400)]
add _ISOC9X_SOURCE define to compiler command line to provide uniform access to llabs()
Robin Gareus [Thu, 1 Aug 2013 01:17:49 +0000 (03:17 +0200)]
re-check meterbridge metric-area on route deletion
fixes http://tracker.ardour.org/view.php?id=5616#c15204
Robin Gareus [Wed, 31 Jul 2013 22:35:24 +0000 (00:35 +0200)]
use zeroed scratch buffers for "silent" plugin runs
Plugins rewrite the buffer data in-place and some plugins
can produce output even when fed with silence.
Hence, during a PluginInsert::silence() run a plugin can
inject data into the "silent" buffers which causes side-effects.
Kudos to Chris 'oofus' Goddard for finding this issue.
Robin Gareus [Wed, 31 Jul 2013 18:19:57 +0000 (20:19 +0200)]
tiny detail.. GUI-callback may try to check vmonitor->is_started() or issue a periodic seek update while it's going away
Robin Gareus [Wed, 31 Jul 2013 17:24:26 +0000 (19:24 +0200)]
clean up some valgrid "Uninitialised value was created by a heap allocation" wanings
Robin Gareus [Wed, 31 Jul 2013 17:22:58 +0000 (19:22 +0200)]
correct error message
Robin Gareus [Wed, 31 Jul 2013 17:29:06 +0000 (19:29 +0200)]
fix close_allv() sentinel
Robin Gareus [Wed, 31 Jul 2013 16:30:09 +0000 (18:30 +0200)]
valgrind ignore glib UTF8 warnings
Robin Gareus [Wed, 31 Jul 2013 13:52:41 +0000 (15:52 +0200)]
initialize two more uninitialized vars..
Robin Gareus [Wed, 31 Jul 2013 13:24:46 +0000 (15:24 +0200)]
Robin Gareus [Wed, 31 Jul 2013 13:22:51 +0000 (15:22 +0200)]
initialize some uninitialized values
Robin Gareus [Wed, 31 Jul 2013 13:17:22 +0000 (15:17 +0200)]
catch assert()
Robin Gareus [Wed, 31 Jul 2013 12:45:02 +0000 (14:45 +0200)]
LV2 - use scratch buffers to scratch :)
Robin Gareus [Wed, 31 Jul 2013 12:21:40 +0000 (14:21 +0200)]
another amend to
00f26394a9
Robin Gareus [Wed, 31 Jul 2013 00:00:31 +0000 (02:00 +0200)]
fix stupid copy/paste error in
00f26394a9
Robin Gareus [Tue, 30 Jul 2013 23:59:50 +0000 (01:59 +0200)]
minimize meter-peak re-draw area
Robin Gareus [Tue, 30 Jul 2013 18:22:31 +0000 (20:22 +0200)]
RMS meter: remove unused peak-detection
Robin Gareus [Tue, 30 Jul 2013 18:21:02 +0000 (20:21 +0200)]
adjust meterbridge label-heigh options
Robin Gareus [Tue, 30 Jul 2013 16:28:06 +0000 (18:28 +0200)]
add name-tooltips to the meterbridge meters
Robin Gareus [Tue, 30 Jul 2013 15:54:52 +0000 (17:54 +0200)]
clean up
44fc92c3 (not a threading issue but sigc++ problem)
RouteUI is not sigc::trackable itself (only derived classes are)
RouteUI::~RouteUI() does not disconnect from signals on destruction.
Robin Gareus [Tue, 30 Jul 2013 14:55:33 +0000 (16:55 +0200)]
use dedicated buffers for route (and track)
"scratch buffers are by definition scratch and their contents are undefined at all times"
"silent buffers are by definition all-zero and should not be used for real data"
But track & route were using those for actual data; plugins (which may run
in the same thread and may get the same buffers) use them for scratch thereby
overwriting real data.
In particular get_silent_buffers() (used by LadspaPlugin::connect_and_run)
clears the buffer which can holds real data:
e.g. via Route::passthru_silence() -> plugin1 -> plugin2 (clears output of plugin1)
Robin Gareus [Tue, 30 Jul 2013 13:12:32 +0000 (15:12 +0200)]
disconnect AuxSend connection when deleting bus
fixes crash:
- add bus
- aux-send a signal to that bus
- delete bus
- add another bus
- aux-send a signal to "another bus"
- click "Aux Send" button on "another bus"
- crash
Robin Gareus [Tue, 30 Jul 2013 01:02:45 +0000 (03:02 +0200)]
Revert "fix issue with generator plugins and no-roll disk monitoring"
This reverts commit
bd34ab04cd43ed2f5bf6eebb8b6ea0e0e5cbb727.
Robin Gareus [Tue, 30 Jul 2013 00:27:06 +0000 (02:27 +0200)]
fix issue with generator plugins and no-roll disk monitoring
Paul Davis [Mon, 29 Jul 2013 20:03:50 +0000 (16:03 -0400)]
Merge branch 'clang-rebased' of https://github.com/axetota/ardour