X-Git-Url: https://git.carlh.net/gitweb/?p=dcpomatic.git;a=blobdiff_plain;f=src%2Ftools%2Fdcpomatic.cc;h=d6b6bc2b72aaba15126950ebdf4244c7e051d260;hp=e9302c6a0a4a461b4b793f849f37c5b52b3908fc;hb=9f125fddff88bf62d36381f9d3f09e5240b033d5;hpb=809bcfd85fad2ef7d4131c054be4cccd5bcc9d05 diff --git a/src/tools/dcpomatic.cc b/src/tools/dcpomatic.cc index e9302c6a0..d6b6bc2b7 100644 --- a/src/tools/dcpomatic.cc +++ b/src/tools/dcpomatic.cc @@ -56,10 +56,11 @@ #include "wx/wx_util.h" #include "lib/analytics.h" #include "lib/audio_content.h" -#include "lib/check_content_change_job.h" +#include "lib/check_content_job.h" #include "lib/cinema.h" #include "lib/compose.hpp" #include "lib/config.h" +#include "lib/constants.h" #include "lib/content.h" #include "lib/content_factory.h" #include "lib/cross.h" @@ -73,11 +74,13 @@ #include "lib/exceptions.h" #include "lib/ffmpeg_encoder.h" #include "lib/film.h" +#include "lib/font_config.h" #include "lib/hints.h" #include "lib/job_manager.h" #include "lib/kdm_with_metadata.h" #include "lib/log.h" #include "lib/make_dcp.h" +#include "lib/release_notes.h" #include "lib/screen.h" #include "lib/send_kdm_email_job.h" #include "lib/signal_manager.h" @@ -85,7 +88,6 @@ #include "lib/text_content.h" #include "lib/transcode_job.h" #include "lib/update_checker.h" -#include "lib/util.h" #include "lib/version.h" #include "lib/video_content.h" #include @@ -142,36 +144,27 @@ class FilmChangedClosingDialog { public: explicit FilmChangedClosingDialog (string name) - { - _dialog = new wxMessageDialog ( + : _dialog( nullptr, wxString::Format(_("Save changes to film \"%s\" before closing?"), std_to_wx (name).data()), /// TRANSLATORS: this is the heading for a dialog box, which tells the user that the current /// project (Film) has been changed since it was last saved. _("Film changed"), wxYES_NO | wxCANCEL | wxYES_DEFAULT | wxICON_QUESTION - ); - - _dialog->SetYesNoCancelLabels ( + ) + { + _dialog.SetYesNoCancelLabels( _("Save film and close"), _("Close without saving film"), _("Don't close") ); } - ~FilmChangedClosingDialog () - { - _dialog->Destroy (); - } - - FilmChangedClosingDialog (FilmChangedClosingDialog const&) = delete; - FilmChangedClosingDialog& operator= (FilmChangedClosingDialog const&) = delete; - int run () { - return _dialog->ShowModal (); + return _dialog.ShowModal(); } private: - wxMessageDialog* _dialog; + wxMessageDialog _dialog; }; @@ -179,36 +172,27 @@ class FilmChangedDuplicatingDialog { public: explicit FilmChangedDuplicatingDialog (string name) - { - _dialog = new wxMessageDialog ( + : _dialog( nullptr, wxString::Format(_("Save changes to film \"%s\" before duplicating?"), std_to_wx (name).data()), /// TRANSLATORS: this is the heading for a dialog box, which tells the user that the current /// project (Film) has been changed since it was last saved. _("Film changed"), wxYES_NO | wxCANCEL | wxYES_DEFAULT | wxICON_QUESTION - ); - - _dialog->SetYesNoCancelLabels ( + ) + { + _dialog.SetYesNoCancelLabels( _("Save film and duplicate"), _("Duplicate without saving film"), _("Don't duplicate") ); } - ~FilmChangedDuplicatingDialog () - { - _dialog->Destroy (); - } - - FilmChangedDuplicatingDialog (FilmChangedDuplicatingDialog const&) = delete; - FilmChangedDuplicatingDialog& operator= (FilmChangedDuplicatingDialog const&) = delete; - int run () { - return _dialog->ShowModal (); + return _dialog.ShowModal(); } private: - wxMessageDialog* _dialog; + wxMessageDialog _dialog; }; @@ -269,11 +253,58 @@ enum { }; +class LimitedFrameSplitter : public wxSplitterWindow +{ +public: + LimitedFrameSplitter(wxWindow* parent) + : wxSplitterWindow(parent, wxID_ANY, wxDefaultPosition, wxDefaultSize, wxSP_NOBORDER | wxSP_3DSASH | wxSP_LIVE_UPDATE) + { + /* This value doesn't really mean much but we just want to stop double-click on the + divider from shrinking the left panel. + */ + SetMinimumPaneSize(64); + + Bind(wxEVT_SIZE, boost::bind(&LimitedFrameSplitter::sized, this, _1)); + } + + bool OnSashPositionChange(int new_position) override + { + /* Try to stop the left bit of the splitter getting too small */ + auto const ok = new_position > _left_panel_minimum_size; + if (ok) { + Config::instance()->set_main_divider_sash_position(new_position); + } + return ok; + } + +private: + void sized(wxSizeEvent& ev) + { + if (GetSize().GetWidth() > _left_panel_minimum_size && GetSashPosition() < _left_panel_minimum_size) { + /* The window is now fairly big but the left panel is small; this happens when the DCP-o-matic window + * is shrunk and then made larger again. Try to set a sensible left panel size in this case. + */ + SetSashPosition(Config::instance()->main_divider_sash_position().get_value_or(_left_panel_minimum_size)); + } + + ev.Skip(); + } + + int const _left_panel_minimum_size = 200; +}; + + class DOMFrame : public wxFrame { public: explicit DOMFrame (wxString const& title) : wxFrame (nullptr, -1, title) + /* Use a panel as the only child of the Frame so that we avoid + the dark-grey background on Windows. + */ + , _splitter(new LimitedFrameSplitter(this)) + , _right_panel(new wxPanel(_splitter, wxID_ANY)) + , _film_viewer(_right_panel) { #if defined(DCPOMATIC_WINDOWS) if (Config::instance()->win32_console()) { @@ -347,33 +378,33 @@ public: Bind (wxEVT_CLOSE_WINDOW, boost::bind (&DOMFrame::close, this, _1)); Bind (wxEVT_SHOW, boost::bind (&DOMFrame::show, this, _1)); - /* Use a panel as the only child of the Frame so that we avoid - the dark-grey background on Windows. - */ - auto overall_panel = new wxPanel (this, wxID_ANY); + auto left_panel = new wxPanel(_splitter, wxID_ANY); + + _film_editor = new FilmEditor(left_panel, _film_viewer); + + auto left_sizer = new wxBoxSizer(wxHORIZONTAL); + left_sizer->Add(_film_editor, 1, wxEXPAND); + + left_panel->SetSizerAndFit(left_sizer); - _film_viewer.reset (new FilmViewer (overall_panel)); - _controls = new StandardControls (overall_panel, _film_viewer, true); - _film_editor = new FilmEditor (overall_panel, _film_viewer); - auto job_manager_view = new JobManagerView (overall_panel, false); + _controls = new StandardControls(_right_panel, _film_viewer, true); + auto job_manager_view = new JobManagerView(_right_panel, false); auto right_sizer = new wxBoxSizer (wxVERTICAL); - right_sizer->Add (_film_viewer->panel(), 2, wxEXPAND | wxALL, 6); + right_sizer->Add(_film_viewer.panel(), 2, wxEXPAND | wxALL, 6); right_sizer->Add (_controls, 0, wxEXPAND | wxALL, 6); right_sizer->Add (job_manager_view, 1, wxEXPAND | wxALL, 6); - wxBoxSizer* main_sizer = new wxBoxSizer (wxHORIZONTAL); - main_sizer->Add (_film_editor, 0, wxEXPAND | wxALL, 6); - main_sizer->Add (right_sizer, 1, wxEXPAND | wxALL, 6); + _right_panel->SetSizer(right_sizer); + + _splitter->SplitVertically(left_panel, _right_panel, Config::instance()->main_divider_sash_position().get_value_or(left_panel->GetSize().GetWidth() + 8)); set_menu_sensitivity (); _film_editor->content_panel()->SelectionChanged.connect (boost::bind (&DOMFrame::set_menu_sensitivity, this)); set_title (); - JobManager::instance()->ActiveJobsChanged.connect (boost::bind (&DOMFrame::set_menu_sensitivity, this)); - - overall_panel->SetSizer (main_sizer); + JobManager::instance()->ActiveJobsChanged.connect(boost::bind(&DOMFrame::active_jobs_changed, this)); UpdateChecker::instance()->StateChanged.connect(boost::bind(&DOMFrame::update_checker_state_changed, this)); @@ -458,7 +489,7 @@ public: set_film (film); - JobManager::instance()->add(shared_ptr(new CheckContentChangeJob(film))); + JobManager::instance()->add(make_shared(film)); } catch (FileNotFoundError& e) { auto const dir = e.file().parent_path(); @@ -480,13 +511,10 @@ public: void set_film (shared_ptr film) { _film = film; - _film_viewer->set_film (_film); - _film_editor->set_film (_film); + _film_viewer.set_film(_film); + _film_editor->set_film(_film); _controls->set_film (_film); - if (_video_waveform_dialog) { - _video_waveform_dialog->Destroy (); - _video_waveform_dialog = nullptr; - } + _video_waveform_dialog.reset(); set_menu_sensitivity (); if (_film && _film->directory()) { Config::instance()->add_to_history (_film->directory().get()); @@ -528,42 +556,42 @@ private: void file_new () { - auto d = new FilmNameLocationDialog (this, _("New Film"), true); - int const r = d->ShowModal (); + FilmNameLocationDialog dialog(this, _("New Film"), true); + int const r = dialog.ShowModal(); - if (r == wxID_OK && d->check_path() && maybe_save_then_delete_film()) { - try { - new_film (d->path(), d->template_name()); - } catch (boost::filesystem::filesystem_error& e) { + if (r != wxID_OK || !dialog.check_path() || !maybe_save_then_delete_film()) { + return; + } + + try { + new_film(dialog.path(), dialog.template_name()); + } catch (boost::filesystem::filesystem_error& e) { #ifdef DCPOMATIC_WINDOWS - string bad_chars = "<>:\"/|?*"; - string const filename = d->path().filename().string(); - string found_bad_chars; - for (size_t i = 0; i < bad_chars.length(); ++i) { - if (filename.find(bad_chars[i]) != string::npos && found_bad_chars.find(bad_chars[i]) == string::npos) { - found_bad_chars += bad_chars[i]; - } + string bad_chars = "<>:\"/|?*"; + string const filename = dialog.path().filename().string(); + string found_bad_chars; + for (size_t i = 0; i < bad_chars.length(); ++i) { + if (filename.find(bad_chars[i]) != string::npos && found_bad_chars.find(bad_chars[i]) == string::npos) { + found_bad_chars += bad_chars[i]; } - wxString message = _("Could not create folder to store film."); - message += " "; - if (!found_bad_chars.empty()) { - message += wxString::Format (_("Try removing the %s characters from your folder name."), std_to_wx(found_bad_chars).data()); - } else { - message += _("Please check that you do not have Windows controlled folder access enabled for DCP-o-matic."); - } - error_dialog (this, message, std_to_wx(e.what())); + } + wxString message = _("Could not create folder to store film."); + message += " "; + if (!found_bad_chars.empty()) { + message += wxString::Format (_("Try removing the %s characters from your folder name."), std_to_wx(found_bad_chars).data()); + } else { + message += _("Please check that you do not have Windows controlled folder access enabled for DCP-o-matic."); + } + error_dialog (this, message, std_to_wx(e.what())); #else - error_dialog (this, _("Could not create folder to store film."), std_to_wx(e.what())); + error_dialog (this, _("Could not create folder to store film."), std_to_wx(e.what())); #endif - } } - - d->Destroy (); } void file_open () { - auto c = new wxDirDialog ( + wxDirDialog dialog( this, _("Select film to open"), std_to_wx (Config::instance()->default_directory_or (wx_to_std (wxStandardPaths::Get().GetDocumentsDir())).string ()), @@ -572,8 +600,8 @@ private: int r; while (true) { - r = c->ShowModal (); - if (r == wxID_OK && c->GetPath() == wxStandardPaths::Get().GetDocumentsDir()) { + r = dialog.ShowModal(); + if (r == wxID_OK && dialog.GetPath() == wxStandardPaths::Get().GetDocumentsDir()) { error_dialog (this, _("You did not select a folder. Make sure that you select a folder before clicking Open.")); } else { break; @@ -581,67 +609,69 @@ private: } if (r == wxID_OK && maybe_save_then_delete_film()) { - load_film (wx_to_std (c->GetPath ())); + load_film(wx_to_std(dialog.GetPath())); } - - c->Destroy (); } void file_save () { - _film->write_metadata (); + try { + _film->write_metadata (); + } catch (exception& e) { + error_dialog(this, _("Could not save project."), std_to_wx(e.what())); + } } void file_save_as_template () { - auto d = new SaveTemplateDialog (this); - int const r = d->ShowModal (); - if (r == wxID_OK) { - Config::instance()->save_template (_film, d->name ()); + SaveTemplateDialog dialog(this); + if (dialog.ShowModal() == wxID_OK) { + try { + Config::instance()->save_template(_film, dialog.name()); + } catch (exception& e) { + error_dialog(this, _("Could not save template."), std_to_wx(e.what())); + } } - d->Destroy (); } void file_duplicate () { - auto d = new FilmNameLocationDialog (this, _("Duplicate Film"), false); - int const r = d->ShowModal (); + FilmNameLocationDialog dialog(this, _("Duplicate Film"), false); - if (r == wxID_OK && d->check_path() && maybe_save_film()) { - shared_ptr film (new Film (d->path())); + if (dialog.ShowModal() == wxID_OK && dialog.check_path() && maybe_save_film()) { + auto film = make_shared(dialog.path()); film->copy_from (_film); - film->set_name (d->path().filename().generic_string()); - film->write_metadata (); + film->set_name(dialog.path().filename().generic_string()); + try { + film->write_metadata(); + } catch (exception& e) { + error_dialog(this, _("Could not duplicate project."), std_to_wx(e.what())); + } } - - d->Destroy (); } void file_duplicate_and_open () { - auto d = new FilmNameLocationDialog (this, _("Duplicate Film"), false); - int const r = d->ShowModal (); + FilmNameLocationDialog dialog(this, _("Duplicate Film"), false); - if (r == wxID_OK && d->check_path() && maybe_save_film()) { - shared_ptr film (new Film (d->path())); + if (dialog.ShowModal() == wxID_OK && dialog.check_path() && maybe_save_film()) { + auto film = make_shared(dialog.path()); film->copy_from (_film); - film->set_name (d->path().filename().generic_string()); - film->write_metadata (); - set_film (film); + film->set_name(dialog.path().filename().generic_string()); + try { + film->write_metadata (); + set_film (film); + } catch (exception& e) { + error_dialog(this, _("Could not duplicate project."), std_to_wx(e.what())); + } } - - d->Destroy (); } void file_close () { if (_film && _film->dirty ()) { - - auto dialog = new FilmChangedClosingDialog (_film->name ()); - int const r = dialog->run (); - delete dialog; - - switch (r) { + FilmChangedClosingDialog dialog(_film->name()); + switch (dialog.run()) { case wxID_NO: /* Don't save and carry on to close */ break; @@ -684,30 +714,31 @@ private: { DCPOMATIC_ASSERT (_clipboard); - auto d = new PasteDialog (this, static_cast(_clipboard->video), static_cast(_clipboard->audio), !_clipboard->text.empty()); - if (d->ShowModal() == wxID_OK) { - for (auto i: _film_editor->content_panel()->selected()) { - if (d->video() && i->video) { - DCPOMATIC_ASSERT (_clipboard->video); - i->video->take_settings_from (_clipboard->video); - } - if (d->audio() && i->audio) { - DCPOMATIC_ASSERT (_clipboard->audio); - i->audio->take_settings_from (_clipboard->audio); - } + PasteDialog dialog(this, static_cast(_clipboard->video), static_cast(_clipboard->audio), !_clipboard->text.empty()); + if (dialog.ShowModal() != wxID_OK) { + return; + } - if (d->text()) { - auto j = i->text.begin (); - auto k = _clipboard->text.begin (); - while (j != i->text.end() && k != _clipboard->text.end()) { - (*j)->take_settings_from (*k); - ++j; - ++k; - } + for (auto i: _film_editor->content_panel()->selected()) { + if (dialog.video() && i->video) { + DCPOMATIC_ASSERT (_clipboard->video); + i->video->take_settings_from (_clipboard->video); + } + if (dialog.audio() && i->audio) { + DCPOMATIC_ASSERT (_clipboard->audio); + i->audio->take_settings_from (_clipboard->audio); + } + + if (dialog.text()) { + auto j = i->text.begin (); + auto k = _clipboard->text.begin (); + while (j != i->text.end() && k != _clipboard->text.end()) { + (*j)->take_settings_from (*k); + ++j; + ++k; } } } - d->Destroy (); } void edit_select_all () @@ -725,33 +756,27 @@ private: void tools_restore_default_preferences () { - auto d = new wxMessageDialog ( - 0, + wxMessageDialog dialog( + nullptr, _("Are you sure you want to restore preferences to their defaults? This cannot be undone."), _("Restore default preferences"), wxYES_NO | wxYES_DEFAULT | wxICON_QUESTION ); - int const r = d->ShowModal (); - d->Destroy (); - - if (r == wxID_YES) { + if (dialog.ShowModal() == wxID_YES) { Config::restore_defaults (); } } void tools_export_preferences () { - auto dialog = new wxFileDialog ( + wxFileDialog dialog( this, _("Specify ZIP file"), wxEmptyString, wxT("dcpomatic_config.zip"), wxT("ZIP files (*.zip)|*.zip"), wxFD_SAVE | wxFD_OVERWRITE_PROMPT ); - int const r = dialog->ShowModal (); - dialog->Destroy (); - - if (r == wxID_OK) { - save_all_config_as_zip (wx_to_std(dialog->GetPath())); + if (dialog.ShowModal() == wxID_OK) { + save_all_config_as_zip(wx_to_std(dialog.GetPath())); } } @@ -774,10 +799,8 @@ private: } if (Config::instance()->show_hints_before_make_dcp()) { - auto hints = new HintsDialog (this, _film, false); - int const r = hints->ShowModal(); - hints->Destroy (); - if (r == wxID_CANCEL) { + HintsDialog hints(this, _film, false); + if (hints.ShowModal() == wxID_CANCEL) { return; } } @@ -821,12 +844,7 @@ private: return; } - if (_kdm_dialog) { - _kdm_dialog->Destroy (); - _kdm_dialog = 0; - } - - _kdm_dialog = new KDMDialog (this, _film); + _kdm_dialog.reset(this, _film); _kdm_dialog->Show (); } @@ -836,12 +854,7 @@ private: return; } - if (_dkdm_dialog) { - _dkdm_dialog->Destroy (); - _dkdm_dialog = nullptr; - } - - _dkdm_dialog = new DKDMDialog (this, _film); + _dkdm_dialog.reset(this, _film); _dkdm_dialog->Show (); } @@ -888,10 +901,8 @@ private: } if (Config::instance()->show_hints_before_make_dcp()) { - auto hints = new HintsDialog (this, _film, false); - int const r = hints->ShowModal(); - hints->Destroy (); - if (r == wxID_CANCEL) { + HintsDialog hints(this, _film, false); + if (hints.ShowModal() == wxID_CANCEL) { return; } } @@ -928,9 +939,8 @@ private: return; } - auto d = new SelfDKDMDialog (this, _film); - if (d->ShowModal () != wxID_OK) { - d->Destroy (); + SelfDKDMDialog dialog(this, _film); + if (dialog.ShowModal() != wxID_OK) { return; } @@ -951,17 +961,24 @@ private: dcp::LocalTime to (Config::instance()->signer_chain()->leaf().not_after()); to.add_days (-1); + auto signer = Config::instance()->signer_chain(); + if (!signer->valid()) { + error_dialog(this, _("The certificate chain for signing is invalid")); + return; + } + optional kdm; try { - kdm = _film->make_kdm ( - Config::instance()->decryption_chain()->leaf(), - vector(), - d->cpl (), - from, to, - dcp::Formulation::MODIFIED_TRANSITIONAL_1, - true, - 0 - ); + auto const decrypted_kdm = _film->make_kdm(dialog.cpl(), from, to); + auto const kdm = decrypted_kdm.encrypt(signer, Config::instance()->decryption_chain()->leaf(), {}, dcp::Formulation::MODIFIED_TRANSITIONAL_1, true, 0); + if (dialog.internal()) { + auto dkdms = Config::instance()->dkdms(); + dkdms->add(make_shared(kdm)); + Config::instance()->changed (); + } else { + auto path = dialog.directory() / (_film->dcp_name(false) + "_DKDM.xml"); + kdm.as_xml(path); + } } catch (dcp::NotEncryptedError& e) { error_dialog (this, _("CPL's content is not encrypted.")); } catch (exception& e) { @@ -969,60 +986,47 @@ private: } catch (...) { error_dialog (this, _("An unknown exception occurred.")); } - - if (kdm) { - if (d->internal ()) { - auto dkdms = Config::instance()->dkdms(); - dkdms->add (make_shared(kdm.get())); - Config::instance()->changed (); - } else { - auto path = d->directory() / (_film->dcp_name(false) + "_DKDM.xml"); - kdm->as_xml (path); - } - } - - d->Destroy (); } void jobs_export_video_file () { - auto d = new ExportVideoFileDialog (this, _film->isdcf_name(true)); - if (d->ShowModal() == wxID_OK) { - if (boost::filesystem::exists(d->path())) { - bool ok = confirm_dialog( - this, - wxString::Format (_("File %s already exists. Do you want to overwrite it?"), std_to_wx(d->path().string()).data()) - ); - - if (!ok) { - d->Destroy (); - return; - } - } + ExportVideoFileDialog dialog(this, _film->isdcf_name(true)); + if (dialog.ShowModal() != wxID_OK) { + return; + } - auto job = make_shared(_film, TranscodeJob::ChangedBehaviour::EXAMINE_THEN_STOP); - job->set_encoder ( - make_shared ( - _film, job, d->path(), d->format(), d->mixdown_to_stereo(), d->split_reels(), d->split_streams(), d->x264_crf()) - ); - JobManager::instance()->add (job); + if (boost::filesystem::exists(dialog.path())) { + bool ok = confirm_dialog( + this, + wxString::Format(_("File %s already exists. Do you want to overwrite it?"), std_to_wx(dialog.path().string()).data()) + ); + + if (!ok) { + return; + } } - d->Destroy (); + + auto job = make_shared(_film, TranscodeJob::ChangedBehaviour::EXAMINE_THEN_STOP); + job->set_encoder ( + make_shared ( + _film, job, dialog.path(), dialog.format(), dialog.mixdown_to_stereo(), dialog.split_reels(), dialog.split_streams(), dialog.x264_crf()) + ); + JobManager::instance()->add (job); } void jobs_export_subtitles () { - auto d = new ExportSubtitlesDialog (this, _film->reels().size(), _film->interop()); - if (d->ShowModal() == wxID_OK) { - auto job = make_shared(_film, TranscodeJob::ChangedBehaviour::EXAMINE_THEN_STOP); - job->set_encoder ( - make_shared(_film, job, d->path(), _film->isdcf_name(true), d->split_reels(), d->include_font()) - ); - JobManager::instance()->add (job); + ExportSubtitlesDialog dialog(this, _film->reels().size(), _film->interop()); + if (dialog.ShowModal() != wxID_OK) { + return; } - d->Destroy (); + auto job = make_shared(_film, TranscodeJob::ChangedBehaviour::EXAMINE_THEN_STOP); + job->set_encoder( + make_shared(_film, job, dialog.path(), _film->isdcf_name(true), dialog.split_reels(), dialog.include_font()) + ); + JobManager::instance()->add(job); } @@ -1041,13 +1045,13 @@ private: void view_closed_captions () { - _film_viewer->show_closed_captions (); + _film_viewer.show_closed_captions (); } void view_video_waveform () { if (!_video_waveform_dialog) { - _video_waveform_dialog = new VideoWaveformDialog (this, _film, _film_viewer); + _video_waveform_dialog.reset(this, _film, _film_viewer); } _video_waveform_dialog->Show (); @@ -1083,7 +1087,7 @@ private: void tools_manage_templates () { if (!_templates_dialog) { - _templates_dialog = new TemplatesDialog (this); + _templates_dialog.reset(this); } _templates_dialog->Show (); @@ -1097,48 +1101,45 @@ private: void tools_send_translations () { - auto d = new SendI18NDialog (this); - if (d->ShowModal() == wxID_OK) { - string body; - body += d->name() + "\n"; - body += d->language() + "\n"; - body += string(dcpomatic_version) + " " + string(dcpomatic_git_commit) + "\n"; - body += "--\n"; - auto translations = I18NHook::translations (); - for (auto i: translations) { - body += i.first + "\n" + i.second + "\n\n"; - } - list to = { "carl@dcpomatic.com" }; - if (d->email().find("@") == string::npos) { - error_dialog (this, _("You must enter a valid email address when sending translations, " - "otherwise the DCP-o-matic maintainers cannot credit you or contact you with questions.")); - } else { - Emailer emailer (d->email(), to, "DCP-o-matic translations", body); - try { - emailer.send ("main.carlh.net", 2525, EmailProtocol::STARTTLS); - } catch (NetworkError& e) { - error_dialog (this, _("Could not send translations"), std_to_wx(e.what())); - } - } + SendI18NDialog dialog(this); + if (dialog.ShowModal() != wxID_OK) { + return; } - d->Destroy (); + string body; + body += dialog.name() + "\n"; + body += dialog.language() + "\n"; + body += string(dcpomatic_version) + " " + string(dcpomatic_git_commit) + "\n"; + body += "--\n"; + auto translations = I18NHook::translations (); + for (auto i: translations) { + body += i.first + "\n" + i.second + "\n\n"; + } + if (dialog.email().find("@") == string::npos) { + error_dialog (this, _("You must enter a valid email address when sending translations, " + "otherwise the DCP-o-matic maintainers cannot credit you or contact you with questions.")); + } else { + Emailer emailer(dialog.email(), { "carl@dcpomatic.com" }, "DCP-o-matic translations", body); + try { + emailer.send ("main.carlh.net", 2525, EmailProtocol::STARTTLS); + } catch (NetworkError& e) { + error_dialog (this, _("Could not send translations"), std_to_wx(e.what())); + } + } } void help_about () { - auto d = new AboutDialog (this); - d->ShowModal (); - d->Destroy (); + AboutDialog dialog(this); + dialog.ShowModal(); } void help_report_a_problem () { - auto d = new ReportProblemDialog (this, _film); - if (d->ShowModal () == wxID_OK) { - d->report (); + ReportProblemDialog dialog(this, _film); + if (dialog.ShowModal() == wxID_OK) { + dialog.report(); } - d->Destroy (); } bool should_close () @@ -1147,16 +1148,14 @@ private: return true; } - auto d = new wxMessageDialog ( - 0, + wxMessageDialog dialog( + nullptr, _("There are unfinished jobs; are you sure you want to quit?"), _("Unfinished jobs"), wxYES_NO | wxYES_DEFAULT | wxICON_QUESTION ); - bool const r = d->ShowModal() == wxID_YES; - d->Destroy (); - return r; + return dialog.ShowModal() == wxID_YES; } void close (wxCloseEvent& ev) @@ -1167,12 +1166,8 @@ private: } if (_film && _film->dirty ()) { - - auto dialog = new FilmChangedClosingDialog (_film->name ()); - int const r = dialog->run (); - delete dialog; - - switch (r) { + FilmChangedClosingDialog dialog(_film->name()); + switch (dialog.run()) { case wxID_NO: /* Don't save and carry on to close */ break; @@ -1196,9 +1191,20 @@ private: /* Also stop hearing about analytics-related stuff */ _analytics_message_connection.disconnect (); + FontConfig::drop(); + ev.Skip (); } + void active_jobs_changed() + { + /* ActiveJobsChanged can be called while JobManager holds a lock on its mutex, making + * the call to JobManager::get() in set_menu_sensitivity() deadlock unless we work around + * it by using an idle callback. This feels quite unpleasant. + */ + signal_manager->when_idle(boost::bind(&DOMFrame::set_menu_sensitivity, this)); + } + void set_menu_sensitivity () { auto jobs = JobManager::instance()->get (); @@ -1262,14 +1268,20 @@ private: return true; } - if (_film->dirty ()) { - T d (_film->name ()); - switch (d.run ()) { + while (_film->dirty()) { + T dialog(_film->name()); + switch (dialog.run()) { case wxID_NO: return true; case wxID_YES: - _film->write_metadata (); - return true; + try { + _film->write_metadata(); + return true; + } catch (exception& e) { + error_dialog(this, _("Could not save project."), std_to_wx(e.what())); + /* Go round again for another try */ + } + break; case wxID_CANCEL: return false; } @@ -1482,9 +1494,8 @@ private: } if (uc->state() == UpdateChecker::State::YES) { - auto dialog = new UpdateDialog (this, uc->stable(), uc->test()); - dialog->ShowModal (); - dialog->Destroy (); + UpdateDialog dialog(this, uc->stable(), uc->test()); + dialog.ShowModal(); } else if (uc->state() == UpdateChecker::State::FAILED) { error_dialog (this, _("The DCP-o-matic download server could not be contacted.")); } else { @@ -1496,10 +1507,10 @@ private: void start_stop_pressed () { - if (_film_viewer->playing()) { - _film_viewer->stop(); + if (_film_viewer.playing()) { + _film_viewer.stop(); } else { - _film_viewer->start(); + _film_viewer.start(); } } @@ -1510,19 +1521,18 @@ private: void back_frame () { - _film_viewer->seek_by (-_film_viewer->one_video_frame(), true); + _film_viewer.seek_by(-_film_viewer.one_video_frame(), true); } void forward_frame () { - _film_viewer->seek_by (_film_viewer->one_video_frame(), true); + _film_viewer.seek_by(_film_viewer.one_video_frame(), true); } void analytics_message (string title, string html) { - auto d = new HTMLDialog(this, std_to_wx(title), std_to_wx(html)); - d->ShowModal(); - d->Destroy(); + HTMLDialog dialog(this, std_to_wx(title), std_to_wx(html)); + dialog.ShowModal(); } void set_title () @@ -1541,16 +1551,18 @@ private: } FilmEditor* _film_editor; - std::shared_ptr _film_viewer; + LimitedFrameSplitter* _splitter; + wxPanel* _right_panel; + FilmViewer _film_viewer; StandardControls* _controls; - VideoWaveformDialog* _video_waveform_dialog = nullptr; + wx_ptr _video_waveform_dialog; SystemInformationDialog* _system_information_dialog = nullptr; HintsDialog* _hints_dialog = nullptr; ServersListDialog* _servers_list_dialog = nullptr; wxPreferencesEditor* _config_dialog = nullptr; - KDMDialog* _kdm_dialog = nullptr; - DKDMDialog* _dkdm_dialog = nullptr; - TemplatesDialog* _templates_dialog = nullptr; + wx_ptr _kdm_dialog; + wx_ptr _dkdm_dialog; + wx_ptr _templates_dialog; wxMenu* _file_menu = nullptr; shared_ptr _film; int _history_items = 0; @@ -1596,7 +1608,7 @@ private: try { wxInitAllImageHandlers (); - Config::FailedToLoad.connect (boost::bind (&App::config_failed_to_load, this)); + Config::FailedToLoad.connect(boost::bind(&App::config_failed_to_load, this, _1)); Config::Warning.connect (boost::bind (&App::config_warning, this, _1)); _splash = maybe_show_splash (); @@ -1686,13 +1698,17 @@ private: if (Config::instance()->check_for_updates ()) { UpdateChecker::instance()->run (); } + + auto release_notes = find_release_notes(gui_is_dark()); + if (release_notes) { + HTMLDialog notes(nullptr, _("Release notes"), std_to_wx(*release_notes), true); + notes.Centre(); + notes.ShowModal(); + } } catch (exception& e) { - if (_splash) { - _splash->Destroy (); - _splash = nullptr; - } + close_splash(); error_dialog (nullptr, wxString::Format ("DCP-o-matic could not start."), std_to_wx(e.what())); } @@ -1804,15 +1820,13 @@ private: void close_splash () { - if (_splash) { - _splash->Destroy (); - _splash = 0; - } + _splash->Destroy(); + _splash = nullptr; } - void config_failed_to_load () + void config_failed_to_load (Config::LoadFailure what) { - message_dialog (_frame, _("The existing configuration failed to load. Default values will be used instead. These may take a short time to create.")); + report_config_load_failure(_frame, what); } void config_warning (string m) @@ -1825,8 +1839,7 @@ private: /* Destroy the splash screen here, as otherwise bad things seem to happen (for reasons unknown) when we open our recreate dialog, close it, *then* try to Destroy the splash (the Destroy fails). */ - _splash->Destroy (); - _splash = nullptr; + close_splash(); auto config = Config::instance(); switch (reason) { @@ -1835,7 +1848,7 @@ private: if (config->nagged(Config::NAG_BAD_SIGNER_CHAIN_UTF8)) { return false; } - auto d = new RecreateChainDialog ( + RecreateChainDialog dialog( _frame, _("Recreate signing certificates"), _("The certificate chain that DCP-o-matic uses for signing DCPs and KDMs contains a small error\n" "which will prevent DCPs from being validated correctly on some systems. Do you want to re-create\n" @@ -1843,16 +1856,14 @@ private: _("Do nothing"), Config::NAG_BAD_SIGNER_CHAIN_UTF8 ); - int const r = d->ShowModal (); - d->Destroy (); - return r == wxID_OK; + return dialog.ShowModal() == wxID_OK; } case Config::BAD_SIGNER_VALIDITY_TOO_LONG: { if (config->nagged(Config::NAG_BAD_SIGNER_CHAIN_VALIDITY)) { return false; } - auto d = new RecreateChainDialog ( + RecreateChainDialog dialog( _frame, _("Recreate signing certificates"), _("The certificate chain that DCP-o-matic uses for signing DCPs and KDMs has a validity period\n" "that is too long. This will cause problems playing back DCPs on some systems.\n" @@ -1860,29 +1871,25 @@ private: _("Do nothing"), Config::NAG_BAD_SIGNER_CHAIN_VALIDITY ); - int const r = d->ShowModal (); - d->Destroy (); - return r == wxID_OK; + return dialog.ShowModal() == wxID_OK; } case Config::BAD_SIGNER_INCONSISTENT: { - auto d = new RecreateChainDialog ( + RecreateChainDialog dialog( _frame, _("Recreate signing certificates"), _("The certificate chain that DCP-o-matic uses for signing DCPs and KDMs is inconsistent and\n" "cannot be used. DCP-o-matic cannot start unless you re-create it. Do you want to re-create\n" "the certificate chain for signing DCPs and KDMs?"), _("Close DCP-o-matic") ); - int const r = d->ShowModal (); - d->Destroy (); - if (r != wxID_OK) { + if (dialog.ShowModal() != wxID_OK) { exit (EXIT_FAILURE); } return true; } case Config::BAD_DECRYPTION_INCONSISTENT: { - auto d = new RecreateChainDialog ( + RecreateChainDialog dialog( _frame, _("Recreate KDM decryption chain"), _("The certificate chain that DCP-o-matic uses for decrypting KDMs is inconsistent and\n" "cannot be used. DCP-o-matic cannot start unless you re-create it. Do you want to re-create\n" @@ -1890,9 +1897,7 @@ private: "configuration before continuing."), _("Close DCP-o-matic") ); - int const r = d->ShowModal (); - d->Destroy (); - if (r != wxID_OK) { + if (dialog.ShowModal() != wxID_OK) { exit (EXIT_FAILURE); } return true; @@ -1903,7 +1908,7 @@ private: } DOMFrame* _frame = nullptr; - wxSplashScreen* _splash = nullptr; + wxSplashScreen* _splash; shared_ptr _timer; string _film_to_load; string _film_to_create;