X-Git-Url: https://git.carlh.net/gitweb/?p=dcpomatic.git;a=blobdiff_plain;f=src%2Ftools%2Fdcpomatic_kdm.cc;h=b9d71d27338ddf6ee8cd39c93b5d01c1f36768b0;hp=c1239ff29f9ad94b616cf3cd405b0740cbe0b03f;hb=6ebec6b3ca11a7062ae19176096b1b157275d015;hpb=57cbdbed89e6432049fec50ecef28b5b57bcf301

diff --git a/src/tools/dcpomatic_kdm.cc b/src/tools/dcpomatic_kdm.cc
index c1239ff29..b9d71d273 100644
--- a/src/tools/dcpomatic_kdm.cc
+++ b/src/tools/dcpomatic_kdm.cc
@@ -46,6 +46,7 @@
 #include "lib/exceptions.h"
 #include "lib/file_log.h"
 #include "lib/job_manager.h"
+#include "lib/kdm_util.h"
 #include "lib/kdm_with_metadata.h"
 #include "lib/screen.h"
 #include "lib/send_kdm_email_job.h"
@@ -311,10 +312,17 @@ private:
 
 	bool confirm_overwrite (boost::filesystem::path path)
 	{
-		return confirm_dialog (
-			this,
-			wxString::Format (_("File %s already exists.  Do you want to overwrite it?"), std_to_wx(path.string()).data())
-			);
+		if (boost::filesystem::is_directory(path)) {
+			return confirm_dialog (
+				this,
+				wxString::Format(_("Folder %s already exists.  Do you want to overwrite it?"), std_to_wx(path.string()).data())
+				);
+		} else {
+			return confirm_dialog (
+				this,
+				wxString::Format(_("File %s already exists.  Do you want to overwrite it?"), std_to_wx(path.string()).data())
+				);
+		}
 	}
 
 	/** @id if not nullptr this is filled in with the wxTreeItemId of the selection */
@@ -367,50 +375,63 @@ private:
 				throw InvalidSignerError ();
 			}
 
-			for (auto i: _screens->screens()) {
-
-				if (!i->recipient) {
-					continue;
-				}
-
-				dcp::LocalTime begin(_timing->from(), dcp::UTCOffset(i->cinema->utc_offset_hour(), i->cinema->utc_offset_minute()));
-				dcp::LocalTime end(_timing->until(), dcp::UTCOffset(i->cinema->utc_offset_hour(), i->cinema->utc_offset_minute()));
+			vector<KDMCertificatePeriod> period_checks;
 
+			std::function<dcp::DecryptedKDM (dcp::LocalTime, dcp::LocalTime)> make_kdm = [decrypted, title](dcp::LocalTime begin, dcp::LocalTime end) {
 				/* Make an empty KDM */
 				dcp::DecryptedKDM kdm (
 					begin,
 					end,
-					decrypted.annotation_text().get_value_or (""),
+					decrypted.annotation_text().get_value_or(""),
 					title,
 					dcp::LocalTime().as_string()
 					);
 
 				/* Add keys from the DKDM */
 				for (auto const& j: decrypted.keys()) {
-					kdm.add_key (j);
+					kdm.add_key(j);
 				}
 
-				auto const encrypted = kdm.encrypt(
-						signer, i->recipient.get(), i->trusted_device_thumbprints(), _output->formulation(),
-						!_output->forensic_mark_video(), _output->forensic_mark_audio() ? boost::optional<int>() : 0
-						);
-
-				dcp::NameFormat::Map name_values;
-				name_values['c'] = i->cinema->name;
-				name_values['s'] = i->name;
-				name_values['f'] = title;
-				name_values['b'] = begin.date() + " " + begin.time_of_day(true, false);
-				name_values['e'] = end.date() + " " + end.time_of_day(true, false);
-				name_values['i'] = encrypted.cpl_id ();
-
-				/* Encrypt */
-				kdms.push_back (make_shared<KDMWithMetadata>(name_values, i->cinema.get(), i->cinema->emails, encrypted));
+				return kdm;
+			};
+
+			for (auto i: _screens->screens()) {
+
+				auto kdm = kdm_for_screen(
+					make_kdm,
+					i,
+					_timing->from(),
+					_timing->until(),
+					_output->formulation(),
+					!_output->forensic_mark_video(),
+					_output->forensic_mark_audio() ? boost::optional<int>() : 0,
+					period_checks
+					);
+
+				if (kdm) {
+					kdms.push_back(kdm);
+				}
 			}
 
 			if (kdms.empty()) {
 				return;
 			}
 
+			if (find(period_checks.begin(), period_checks.end(), KDMCertificatePeriod::KDM_OUTSIDE_CERTIFICATE) != period_checks.end()) {
+				error_dialog(
+					this,
+					_("Some KDMs would have validity periods which are completely outside the recipient certificate periods.  Such KDMs are very unlikely to work, so will not be created.")
+					);
+				return;
+			}
+
+			if (find(period_checks.begin(), period_checks.end(), KDMCertificatePeriod::KDM_OVERLAPS_CERTIFICATE) != period_checks.end()) {
+				message_dialog(
+					this,
+					_("For some of these KDMs the recipient certificate's validity period will not cover the whole of the KDM validity period.  This might cause problems with the KDMs.")
+					);
+			}
+
 			auto result = _output->make (
 				kdms, title, bind (&DOMFrame::confirm_overwrite, this, _1)
 				);
@@ -433,6 +454,13 @@ private:
 					wxString::Format (s, result.second, std_to_wx(_output->directory().string()).data())
 					);
 			}
+		} catch (dcp::BadKDMDateError& e) {
+			if (e.starts_too_early()) {
+				error_dialog(this, _("The KDM start period is before (or close to) the start of the signing certificate's validity period.  Use a later start time for this KDM."));
+			} else {
+				error_dialog(this, _("The KDM end period is after (or close to) the end of the signing certificates' validity period.  Either use an earlier end time for this KDM or re-create your signing certificates in the DCP-o-matic preferences window."));
+			}
+			return;
 		} catch (dcp::NotEncryptedError& e) {
 			error_dialog (this, _("CPL's content is not encrypted."));
 		} catch (exception& e) {
@@ -770,7 +798,7 @@ private:
 
 	bool OnInit () override
 	{
-		wx_ptr<wxSplashScreen> splash;
+		wxSplashScreen* splash;
 
 		try {
 			wxInitAllImageHandlers ();