X-Git-Url: https://git.carlh.net/gitweb/?p=dcpomatic.git;a=blobdiff_plain;f=src%2Fwx%2Fhints_dialog.cc;h=86a1602131fa9ab87b46c1aca4951cd991c4575b;hp=1c49a20684c8f94f576f391b0cc776a6f4396379;hb=ad5c8849fc3ef5aad88201f28db5474a60db4436;hpb=65b331d32c383f3a9049f29bf03ab3fe3193b31a diff --git a/src/wx/hints_dialog.cc b/src/wx/hints_dialog.cc index 1c49a2068..86a160213 100644 --- a/src/wx/hints_dialog.cc +++ b/src/wx/hints_dialog.cc @@ -1,38 +1,39 @@ /* Copyright (C) 2012-2016 Carl Hetherington - This program is free software; you can redistribute it and/or modify + This file is part of DCP-o-matic. + + DCP-o-matic is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. - This program is distributed in the hope that it will be useful, + DCP-o-matic is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; if not, write to the Free Software - Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. + along with DCP-o-matic. If not, see . */ #include "hints_dialog.h" +#include "wx_util.h" #include "lib/film.h" -#include "lib/ratio.h" -#include "lib/video_content.h" -#include "lib/subtitle_content.h" -#include "lib/font.h" -#include "lib/content.h" +#include "lib/hints.h" +#include "lib/config.h" #include -#include #include +using std::max; +using std::vector; +using std::string; using boost::shared_ptr; using boost::optional; using boost::dynamic_pointer_cast; -HintsDialog::HintsDialog (wxWindow* parent, boost::weak_ptr film) +HintsDialog::HintsDialog (wxWindow* parent, boost::weak_ptr film, bool ok) : wxDialog (parent, wxID_ANY, _("Hints")) , _film (film) { @@ -40,11 +41,23 @@ HintsDialog::HintsDialog (wxWindow* parent, boost::weak_ptr film) _text = new wxRichTextCtrl (this, wxID_ANY, wxEmptyString, wxDefaultPosition, wxSize (400, 300), wxRE_READONLY); sizer->Add (_text, 1, wxEXPAND | wxALL, 6); - wxSizer* buttons = CreateSeparatedButtonSizer (wxOK); - if (buttons) { - sizer->Add (buttons, wxSizerFlags().Expand().DoubleBorder()); + if (!ok) { + wxCheckBox* b = new wxCheckBox (this, wxID_ANY, _("Don't show hints again")); + sizer->Add (b, 0, wxALL, 6); + b->Bind (wxEVT_CHECKBOX, bind (&HintsDialog::shut_up, this, _1)); + } + + wxStdDialogButtonSizer* buttons = CreateStdDialogButtonSizer (0); + sizer->Add (CreateSeparatedSizer(buttons), wxSizerFlags().Expand().DoubleBorder()); + if (ok) { + buttons->SetAffirmativeButton (new wxButton (this, wxID_OK)); + } else { + buttons->SetAffirmativeButton (new wxButton (this, wxID_OK, _("Make DCP anyway"))); + buttons->SetNegativeButton (new wxButton (this, wxID_CANCEL, _("Go back"))); } + buttons->Realize (); + SetSizer (sizer); sizer->Layout (); sizer->SetSizeHints (this); @@ -64,116 +77,28 @@ void HintsDialog::film_changed () { _text->Clear (); - bool hint = false; boost::shared_ptr film = _film.lock (); if (!film) { return; } - ContentList content = film->content (); - - _text->BeginStandardBullet (N_("standard/circle"), 1, 50); - - bool big_font_files = false; - if (film->interop ()) { - BOOST_FOREACH (shared_ptr i, content) { - if (i->subtitle) { - BOOST_FOREACH (shared_ptr j, i->subtitle->fonts ()) { - for (int k = 0; k < FontFiles::VARIANTS; ++k) { - optional const p = j->file (static_cast (k)); - if (p && boost::filesystem::file_size (p.get()) >= (640 * 1024)) { - big_font_files = true; - } - } - } - } - } - } - - if (big_font_files) { - hint = true; - _text->WriteText (_("You have specified a font file which is larger than 640kB. This is very likely to cause problems on playback.")); - } - - if (film->audio_channels() < 6) { - hint = true; - _text->WriteText (_("Your DCP has fewer than 6 audio channels. This may cause problems on some projectors.")); - _text->Newline (); - } - - int flat_or_narrower = 0; - int scope = 0; - BOOST_FOREACH (shared_ptr i, content) { - if (i->video) { - Ratio const * r = i->video->scale().ratio (); - if (r && r->id() == "239") { - ++scope; - } else if (r && r->id() != "239" && r->id() != "full-frame") { - ++flat_or_narrower; - } - } - } - - if (scope && !flat_or_narrower && film->container()->id() == "185") { - hint = true; - _text->WriteText (_("All of your content is in Scope (2.39:1) but your DCP's container is Flat (1.85:1). This will letter-box your content inside a Flat (1.85:1) frame. You may prefer to set your DCP's container to Scope (2.39:1) in the \"DCP\" tab.")); - _text->Newline (); - } - - if (!scope && flat_or_narrower && film->container()->id() == "239") { - hint = true; - _text->WriteText (_("All of your content is at 1.85:1 or narrower but your DCP's container is Scope (2.39:1). This will pillar-box your content inside a Flat (1.85:1) frame. You may prefer to set your DCP's container to Flat (1.85:1) in the \"DCP\" tab.")); - _text->Newline (); - } - - if (film->video_frame_rate() != 24 && film->video_frame_rate() != 48) { - hint = true; - _text->WriteText (wxString::Format (_("Your DCP frame rate (%d fps) may cause problems in a few (mostly older) projectors. Use 24 or 48 frames per second to be on the safe side."), film->video_frame_rate())); - _text->Newline (); - } + vector hints = get_hints (film); - if (film->j2k_bandwidth() >= 245000000) { - hint = true; - _text->WriteText (_("A few projectors have problems playing back very high bit-rate DCPs. It is a good idea to drop the JPEG2000 bandwidth down to about 200Mbit/s; this is unlikely to have any visible effect on the image.")); - _text->Newline (); - } - - if (film->interop() && film->video_frame_rate() != 24 && film->video_frame_rate() != 48) { - hint = true; - _text->WriteText (_("You are set up for an Interop DCP at a frame rate which is not officially supported. You are advised to make a SMPTE DCP instead.")); - _text->Newline (); - } - - int vob = 0; - BOOST_FOREACH (shared_ptr i, content) { - if (boost::algorithm::starts_with (i->path(0).filename().string(), "VTS_")) { - ++vob; - } - } - - if (vob > 1) { - hint = true; - _text->WriteText (wxString::Format (_("You have %d files that look like they are VOB files from DVD. You should join them to ensure smooth joins between the files."), vob)); - _text->Newline (); - } - - int three_d = 0; - BOOST_FOREACH (shared_ptr i, content) { - if (i->video && i->video->video_frame_type() != VIDEO_FRAME_TYPE_2D) { - ++three_d; + if (hints.empty ()) { + _text->WriteText (_("There are no hints: everything looks good!")); + } else { + _text->BeginStandardBullet (N_("standard/circle"), 1, 50); + BOOST_FOREACH (string i, hints) { + _text->WriteText (std_to_wx (i)); + _text->Newline (); } + _text->EndSymbolBullet (); } +} - if (three_d > 0 && !film->three_d()) { - hint = true; - _text->WriteText (_("You are using 3D content but your DCP is set to 2D. Set the DCP to 3D if you want to play it back on a 3D system (e.g. Real-D, MasterImage etc.)")); - _text->Newline (); - } - - _text->EndSymbolBullet (); - - if (!hint) { - _text->WriteText (_("There are no hints: everything looks good!")); - } +void +HintsDialog::shut_up (wxCommandEvent& ev) +{ + Config::instance()->set_show_hints_before_make_dcp (!ev.IsChecked()); }